31231 2009-11-07 15:17:13 -0800 Closing brace in value breaks CSS parser 2010-01-13 22:05:07 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ap webkit-unassigned adele bdakin commit-queue webkit.review.bot yuzo oldest_to_newest 161380 0 42705 ap 2009-11-07 15:17:13 -0800 Created attachment 42705 test 1 From <http://habrahabr.ru/blogs/css/74565>. After e.g. '.myclass {height:{}}', nothing else gets parsed. See attached test cases. 161381 1 42706 ap 2009-11-07 15:17:33 -0800 Created attachment 42706 test 2 178545 2 46117 yuzo 2010-01-07 23:59:09 -0800 Created attachment 46117 Skip invalid blocks in CSS property declarations. 178546 3 webkit.review.bot 2010-01-07 23:59:51 -0800 style-queue ran check-webkit-style on attachment 46117 without any errors. 178547 4 yuzo 2010-01-08 00:00:43 -0800 The above patch should also fix 26619. Yuzo 178765 5 46117 commit-queue 2010-01-08 13:31:40 -0800 Comment on attachment 46117 Skip invalid blocks in CSS property declarations. Clearing flags on attachment: 46117 Committed r53004: <http://trac.webkit.org/changeset/53004> 178766 6 commit-queue 2010-01-08 13:31:45 -0800 All reviewed patches have been landed. Closing bug. 179662 7 yuzo 2010-01-11 20:11:28 -0800 *** Bug 26619 has been marked as a duplicate of this bug. *** 180541 8 adele 2010-01-13 22:05:07 -0800 This change introduced a serious bug at redfin.com - https://bugs.webkit.org/show_bug.cgi?id=33650 42705 2009-11-07 15:17:13 -0800 2009-11-07 15:17:13 -0800 test 1 brace1.html text/html 201 ap PHN0eWxlPgouY2xhc3MxIHsKICAgIGJlaGF2aW9yOmV4cHJlc3Npb24oKGZ1bmN0aW9uKCl7fSko KSk7CiAgICBjb2xvcjogZ3JlZW47Cn0KLmNsYXNzMiB7CiAgICBjb2xvcjogZ3JlZW47Cn0KCjwv c3R5bGU+CjxkaXYgY2xhc3M9Y2xhc3MxPlNob3VsZCBiZSBncmVlbjwvZGl2Pgo8ZGl2IGNsYXNz PWNsYXNzMj5TaG91bGQgYmUgZ3JlZW48L2Rpdj4K 42706 2009-11-07 15:17:33 -0800 2009-11-07 15:17:33 -0800 test 2 brace2.html text/html 110 ap PHN0eWxlPgoubXljbGFzcyB7aGVpZ2h0Ont9fQoKLmNsYXNzMiB7CiAgICBjb2xvcjogZ3JlZW47 Cn0KCjwvc3R5bGU+CjxkaXYgY2xhc3M9Y2xhc3MyPlNob3VsZCBiZSBncmVlbjwvZGl2Pgo= 46117 2010-01-07 23:59:09 -0800 2010-01-08 13:31:40 -0800 Skip invalid blocks in CSS property declarations. bug-31231-20100108165907.patch text/plain 3952 yuzo ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxOGFiNDM1Li5hZTc1NGIwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDEt MDcgIFl1em8gRnVqaXNoaW1hICA8eXV6b0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNraXAgaW52YWxpZCBibG9ja3MgaW4gQ1NT IHByb3BlcnR5IGRlY2xhcmF0aW9ucy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTMxMjMxCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yNjYxOQorCisgICAgICAgIFRoaXMgcGF0Y2ggbWFrZXMgdGhlIENTUyBw YXJzZXIgc2tpcCBwcm9wZXJ0eSBkZWNsYXJhdGlvbnMgY29udGFpbmluZyBpbnZhbGlkIGJsb2Nr cy4KKworICAgICAgICAqIGZhc3QvY3NzL3BhcnNpbmctZXJyb3ItcmVjb3ZlcnktZXhwZWN0ZWQu dHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Nzcy9wYXJzaW5nLWVycm9yLXJlY292ZXJ5Lmh0 bWw6IEFkZGVkLgorCiAyMDEwLTAxLTA1ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYWNpZWogU3RhY2hvd2lhay4KZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2Zhc3QvY3NzL3BhcnNpbmctZXJyb3ItcmVjb3ZlcnktZXhwZWN0ZWQudHh0 IGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvcGFyc2luZy1lcnJvci1yZWNvdmVyeS1leHBlY3RlZC50 eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uN2VmMjJlOQotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL3BhcnNpbmctZXJyb3ItcmVjb3ZlcnktZXhw ZWN0ZWQudHh0CkBAIC0wLDAgKzEgQEAKK1BBU1MKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zh c3QvY3NzL3BhcnNpbmctZXJyb3ItcmVjb3ZlcnkuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3Nz L3BhcnNpbmctZXJyb3ItcmVjb3ZlcnkuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwLi5kNzgxNDFhCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3Mv cGFyc2luZy1lcnJvci1yZWNvdmVyeS5odG1sCkBAIC0wLDAgKzEsNTMgQEAKKzxodG1sPgorPGhl YWQ+CisgICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgorICAgICAgICBpZiAod2lu ZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xs ZXIuZHVtcEFzVGV4dCgpOworICAgIDwvc2NyaXB0PgorICAgIDxzdHlsZT4KKyAgICAgICAgLnRv X2JlX3Nob3duIHsKKyAgICAgICAgICBkaXNwbGF5Om5vbmU7CisgICAgICAgICAgY29sb3I6Z3Jl ZW47CisgICAgICAgIH0KKyAgICAgICAgLnRvX2JlX2hpZGRlbiB7CisgICAgICAgICAgZGlzcGxh eTpibG9jazsKKyAgICAgICAgICBjb2xvcjpyZWQ7CisgICAgICAgIH0KKworICAgICAgICAvKiBF eHByZXNzaW9uIGNvbnRhaW5pbmcgYW4gaW52YWxpZCBibG9jayBzaG91bGQgYmUgc2tpcHBlZCAq LworICAgICAgICAjdGVzdDEgeworICAgICAgICAgICAgYmVoYXZpb3I6ZXhwcmVzc2lvbigoZnVu Y3Rpb24oKXt9KSgpKTsKKyAgICAgICAgICAgIGRpc3BsYXk6bm9uZTsKKyAgICAgICAgfQorCisg ICAgICAgIC8qIFZhbHVlIGNvbnRhaW5pbmcgYW4gaW52YWxpZCBibG9jayBzaG91bGQgYmUgc2tp cHBlZCAqLworICAgICAgICAubWFsZm9ybWVkMSB7CisgICAgICAgICAgaGVpZ2h0Ont9CisgICAg ICAgIH0KKyAgICAgICAgI3Rlc3QyIHsKKyAgICAgICAgICAgIGRpc3BsYXk6bm9uZTsKKyAgICAg ICAgfQorCisgICAgICAgIC8qIE1hbGZvcm1lZCBkZWNsYXJhdGlvbiBsaXN0IHNob3VsZCBiZSBz a2lwcGVkICovCisgICAgICAgIC5tYWxmb3JtZWQyIHsKKyAgICAgICAgICAgIGE6bGluayB7IGNv bG9yOiBibHVlO30KKyAgICAgICAgICAgIGE6YWN0aXZlIHsgY29sb3I6IHJlZDt9CisgICAgICAg IH0KKyAgICAgICAgI3Rlc3QzIHsKKyAgICAgICAgICAgIGRpc3BsYXk6bm9uZTsKKyAgICAgICAg fQorCisgICAgICAgIC8qIFN1Y2Nlc3NmdWxseSBwYXJzZWQgKi8KKyAgICAgICAgI2xhc3Qgewor ICAgICAgICAgICAgZGlzcGxheTpibG9jazsKKyAgICAgICAgfQorICAgIDwvc3R5bGU+Cis8L2hl YWQ+Cis8Ym9keT4KKyAgPGRpdiBjbGFzcz0idG9fYmVfaGlkZGVuIiBpZD0idGVzdDEiPkZBSUw6 IFRlc3QgMTwvZGl2PgorICA8ZGl2IGNsYXNzPSJ0b19iZV9oaWRkZW4iIGlkPSJ0ZXN0MiI+RkFJ TDogVGVzdCAyPC9kaXY+CisgIDxkaXYgY2xhc3M9InRvX2JlX2hpZGRlbiIgaWQ9InRlc3QzIj5G QUlMOiBUZXN0IDM8L2Rpdj4KKyAgPGRpdiBjbGFzcz0idG9fYmVfc2hvd24iIGlkPSJsYXN0Ij5Q QVNTPC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+CisKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdl TG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGQ1YThjMC4uMzQyMGY0NSAxMDA2NDQKLS0t IGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NyBAQAorMjAxMC0wMS0wNyAgWXV6byBGdWppc2hpbWEgIDx5dXpvQGdvb2dsZS5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2tpcCBpbnZhbGlk IGJsb2NrcyBpbiBDU1MgcHJvcGVydHkgZGVjbGFyYXRpb25zLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzEyMzEKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI2NjE5CisKKyAgICAgICAgVGhpcyBwYXRjaCBt YWtlcyB0aGUgQ1NTIHBhcnNlciBza2lwIHByb3BlcnR5IGRlY2xhcmF0aW9ucyBjb250YWluaW5n IGludmFsaWQgYmxvY2tzLgorCisgICAgICAgIFRlc3Q6IGZhc3QvY3NzL3BhcnNpbmctZXJyb3It cmVjb3ZlcnkuaHRtbAorCisgICAgICAgICogY3NzL0NTU0dyYW1tYXIueToKKwogMjAxMC0wMS0w NSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvY3NzL0NTU0dyYW1tYXIueSBi L1dlYkNvcmUvY3NzL0NTU0dyYW1tYXIueQppbmRleCBjZjg3MTA1Li4zN2YxMjVlIDEwMDY0NAot LS0gYS9XZWJDb3JlL2Nzcy9DU1NHcmFtbWFyLnkKKysrIGIvV2ViQ29yZS9jc3MvQ1NTR3JhbW1h ci55CkBAIC05Nyw3ICs5Nyw3IEBAIHN0YXRpYyBpbnQgY3NzeXlsZXgoWVlTVFlQRSogeXlsdmFs LCB2b2lkKiBwYXJzZXIpCiAKICV9CiAKLSVleHBlY3QgNDgKKyVleHBlY3QgNTMKIAogJW5vbmFz c29jIExPV0VTVF9QUkVDCiAKQEAgLTEyMDgsNiArMTIwOCw5IEBAIGRlY2xfbGlzdDoKICAgICBk ZWNsYXJhdGlvbiAnOycgbWF5YmVfc3BhY2UgewogICAgICAgICAkJCA9ICQxOwogICAgIH0KKyAg ICB8IGRlY2xhcmF0aW9uIGludmFsaWRfYmxvY2tfbGlzdCBtYXliZV9zcGFjZSB7CisgICAgICAg ICQkID0gZmFsc2U7CisgICAgfQogICAgIHwgZGVjbGFyYXRpb24gaW52YWxpZF9ibG9ja19saXN0 ICc7JyBtYXliZV9zcGFjZSB7CiAgICAgICAgICQkID0gZmFsc2U7CiAgICAgfQpAQCAtMTMyNSw2 ICsxMzI4LDkgQEAgZXhwcjoKICAgICAgICAgICAgICQkLT5hZGRWYWx1ZShwLT5zaW5rRmxvYXRp bmdWYWx1ZSgkMykpOwogICAgICAgICB9CiAgICAgfQorICAgIHwgZXhwciBpbnZhbGlkX2Jsb2Nr X2xpc3QgeworICAgICAgICAkJCA9IDA7CisgICAgfQogICAgIHwgZXhwciBlcnJvciB7CiAgICAg ICAgICQkID0gMDsKICAgICB9Cg==