<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>312300</bug_id>
          
          <creation_ts>2026-04-14 12:29:08 -0700</creation_ts>
          <short_desc>prepare-commit-msg: add unit test for git hook&apos;s get_bugs_string() to prevent future regressions</short_desc>
          <delta_ts>2026-04-15 13:33:50 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>309535</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="David Kilzer (:ddkilzer)">ddkilzer</reporter>
          <assigned_to name="Jonathan Bedard">jbedard</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2200311</commentid>
    <comment_count>0</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2026-04-14 12:29:08 -0700</bug_when>
    <thetext>The `get_bugs_string()` function in the `prepare-commit-msg` git hook directly references `radar.Tracker.RES` to detect radar URLs in commit messages. When 311151@main refactored `from_string()` to use `parse_id()`, it removed the `RES` attribute from `radar.Tracker`, breaking the hook with an `AttributeError`. This was fixed by 311158@main, but there is no unit test to prevent the regression from recurring.

Add a unit test that renders the real `prepare-commit-msg` hook template via `jinja2.Template` (same as `InstallHooks.main()`), loads the rendered script via `importlib.util`, and tests `get_bugs_string()` to verify `radar.Tracker.RES` is present and correctly matches radar URL formats.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2200312</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2026-04-14 12:29:15 -0700</bug_when>
    <thetext>&lt;rdar://problem/174765471&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2200329</commentid>
    <comment_count>2</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2026-04-14 12:53:11 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/62760</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2200333</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2026-04-14 13:19:11 -0700</bug_when>
    <thetext>Committed 311223@main (97f987bedded): &lt;https://commits.webkit.org/311223@main&gt;

Reviewed commits have been landed. Closing PR #62760 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2200749</commentid>
    <comment_count>4</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2026-04-15 11:56:58 -0700</bug_when>
    <thetext>Re-opening for pull request https://github.com/WebKit/WebKit/pull/62837</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2200794</commentid>
    <comment_count>5</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2026-04-15 13:33:48 -0700</bug_when>
    <thetext>Committed 311315@main (2625dd9448f9): &lt;https://commits.webkit.org/311315@main&gt;

Reviewed commits have been landed. Closing PR #62837 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>