31226 2009-11-07 10:06:28 -0800 V8 WorkerContextExecutionProxy does not handle SharedWorkers 2009-11-08 22:00:14 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 atwilson atwilson commit-queue dglazkov oldest_to_newest 161354 0 atwilson 2009-11-07 10:06:28 -0800 WorkerContextExecutionProxy does not currently handle SharedWorkers: * It always creates a DedicatedWorkerContext for the global context * It does not know how to convert an EventTarget to a SharedWorker or SharedWorkerContext 161356 1 42697 atwilson 2009-11-07 10:12:57 -0800 Created attachment 42697 proposed patch 161357 2 atwilson 2009-11-07 10:13:41 -0800 Adding dglazkov in case he has a chance to review this. 161494 3 42697 dglazkov 2009-11-08 21:43:29 -0800 Comment on attachment 42697 proposed patch r=me. 161500 4 42697 commit-queue 2009-11-08 22:00:10 -0800 Comment on attachment 42697 proposed patch Clearing flags on attachment: 42697 Committed r50638: <http://trac.webkit.org/changeset/50638> 161501 5 commit-queue 2009-11-08 22:00:14 -0800 All reviewed patches have been landed. Closing bug. 42697 2009-11-07 10:12:57 -0800 2009-11-08 22:00:10 -0800 proposed patch x text/plain 4122 atwilson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NGFlNzk4OS4uNDdiNTFiZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNSBAQAorMjAwOS0xMS0wNyAgRHJldyBXaWxzb24g IDxhdHdpbHNvbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVjggV29ya2VyQ29udGV4dEV4ZWN1dGlvblByb3h5IGRvZXMgbm90 IGhhbmRsZSBTaGFyZWRXb3JrZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zMTIyNgorCisgICAgICAgIE5vdyBjaGVja3MgdG8gc2VlIHdoYXQgdHlw ZSBvZiBjb250ZXh0IGlzIGFjdGl2ZSBhbmQgY3JlYXRlcyB0aGUKKyAgICAgICAgYXBwcm9wcmlh dGUgd3JhcHBlciAoREVESUNBVEVEV09SS0VSQ09OVEVYVCB2cyBTSEFSRURXT1JLRVJDT05URVhU KS4KKworICAgICAgICBBZGRlZCBzdXBwb3J0IGZvciBjb252ZXJ0aW5nIHRvIFNoYXJlZFdvcmtl cnMgYW5kIFNoYXJlZFdvcmtlckNvbnRleHRzLgorCisgICAgICAgIFRlc3Q6IEV4aXN0aW5nIGxh eW91dCB0ZXN0cyBjb3ZlciB0aGlzIGNhc2UgKHN0YXJ0IHBhc3NpbmcgaW4gQ2hyb21lKS4KKwor ICAgICAgICAqIGJpbmRpbmdzL3Y4L1dvcmtlckNvbnRleHRFeGVjdXRpb25Qcm94eS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpXb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHk6OmluaXRDb250ZXh0 SWZOZWVkZWQpOgorICAgICAgICBOb3cgZ2VuZXJhdGVzIHRoZSByaWdodCB0eXBlIG9mIERPTVdy YXBwZXIgZm9yIFNoYXJlZFdvcmtlckNvbnRleHRzLgorICAgICAgICAoV2ViQ29yZTo6V29ya2Vy Q29udGV4dEV4ZWN1dGlvblByb3h5Ojpjb252ZXJ0VG9WOE9iamVjdCk6CisgICAgICAgIEFkZGVk IHN1cHBvcnQgZm9yIFNIQVJFRFdPUktFUkNPTlRFWFQuCisgICAgICAgIChXZWJDb3JlOjpXb3Jr ZXJDb250ZXh0RXhlY3V0aW9uUHJveHk6OmNvbnZlcnRFdmVudFRhcmdldFRvVjhPYmplY3QpOgor ICAgICAgICBBZGRlZCBzdXBwb3J0IGZvciBTaGFyZWRXb3JrZXIgYW5kIFNoYXJlZFdvcmtlckNv bnRleHQuCisKIDIwMDktMTEtMDUgIEFscGhhIExhbSAgPGhjbGFtQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBSZXZlcnQgNTA1NjIgYmVjYXVzZSBpdCBicm9rZSBDaHJvbWl1bS4gTm90IHJldmll d2VkIHNpbmNlIHRoaXMgaXMgYSBidWlsZCBmaXggYW5kIHJldmVydC4KZGlmZiAtLWdpdCBhL1dl YkNvcmUvYmluZGluZ3MvdjgvV29ya2VyQ29udGV4dEV4ZWN1dGlvblByb3h5LmNwcCBiL1dlYkNv cmUvYmluZGluZ3MvdjgvV29ya2VyQ29udGV4dEV4ZWN1dGlvblByb3h5LmNwcAppbmRleCBhN2Fm YjM4Li5mMTc3NTVjIDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1dvcmtlckNvbnRl eHRFeGVjdXRpb25Qcm94eS5jcHAKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9Xb3JrZXJDb250 ZXh0RXhlY3V0aW9uUHJveHkuY3BwCkBAIC0xNTAsNyArMTUwLDggQEAgdm9pZCBXb3JrZXJDb250 ZXh0RXhlY3V0aW9uUHJveHk6OmluaXRDb250ZXh0SWZOZWVkZWQoKQogICAgIHY4OjpIYW5kbGU8 djg6OlN0cmluZz4gaW1wbGljaXRQcm90b1N0cmluZyA9IHY4OjpTdHJpbmc6Ok5ldygiX19wcm90 b19fIik7CiAKICAgICAvLyBDcmVhdGUgYSBuZXcgSlMgb2JqZWN0IGFuZCB1c2UgaXQgYXMgdGhl IHByb3RvdHlwZSBmb3IgdGhlIHNoYWRvdyBnbG9iYWwgb2JqZWN0LgotICAgIHY4OjpIYW5kbGU8 djg6OkZ1bmN0aW9uPiB3b3JrZXJDb250ZXh0Q29uc3RydWN0b3IgPSBWOERPTVdyYXBwZXI6Omdl dENvbnN0cnVjdG9yRm9yQ29udGV4dChWOENsYXNzSW5kZXg6OkRFRElDQVRFRFdPUktFUkNPTlRF WFQsIGNvbnRleHQpOworICAgIFY4Q2xhc3NJbmRleDo6VjhXcmFwcGVyVHlwZSBjb250ZXh0VHlw ZSA9IG1fd29ya2VyQ29udGV4dC0+aXNEZWRpY2F0ZWRXb3JrZXJDb250ZXh0KCkgPyBWOENsYXNz SW5kZXg6OkRFRElDQVRFRFdPUktFUkNPTlRFWFQgOiBWOENsYXNzSW5kZXg6OlNIQVJFRFdPUktF UkNPTlRFWFQ7CisgICAgdjg6OkhhbmRsZTx2ODo6RnVuY3Rpb24+IHdvcmtlckNvbnRleHRDb25z dHJ1Y3RvciA9IFY4RE9NV3JhcHBlcjo6Z2V0Q29uc3RydWN0b3JGb3JDb250ZXh0KGNvbnRleHRU eXBlLCBjb250ZXh0KTsKICAgICB2ODo6TG9jYWw8djg6Ok9iamVjdD4ganNXb3JrZXJDb250ZXh0 ID0gU2FmZUFsbG9jYXRpb246Om5ld0luc3RhbmNlKHdvcmtlckNvbnRleHRDb25zdHJ1Y3Rvcik7 CiAgICAgLy8gQmFpbCBvdXQgaWYgYWxsb2NhdGlvbiBmYWlsZWQuCiAgICAgaWYgKGpzV29ya2Vy Q29udGV4dC5Jc0VtcHR5KCkpIHsKQEAgLTE1OSw3ICsxNjAsNyBAQCB2b2lkIFdvcmtlckNvbnRl eHRFeGVjdXRpb25Qcm94eTo6aW5pdENvbnRleHRJZk5lZWRlZCgpCiAgICAgfQogCiAgICAgLy8g V3JhcCB0aGUgb2JqZWN0LgotICAgIFY4RE9NV3JhcHBlcjo6c2V0RE9NV3JhcHBlcihqc1dvcmtl ckNvbnRleHQsIFY4Q2xhc3NJbmRleDo6VG9JbnQoVjhDbGFzc0luZGV4OjpERURJQ0FURURXT1JL RVJDT05URVhUKSwgbV93b3JrZXJDb250ZXh0KTsKKyAgICBWOERPTVdyYXBwZXI6OnNldERPTVdy YXBwZXIoanNXb3JrZXJDb250ZXh0LCBWOENsYXNzSW5kZXg6OlRvSW50KGNvbnRleHRUeXBlKSwg bV93b3JrZXJDb250ZXh0KTsKIAogICAgIFY4RE9NV3JhcHBlcjo6c2V0SlNXcmFwcGVyRm9yRE9N T2JqZWN0KG1fd29ya2VyQ29udGV4dCwgdjg6OlBlcnNpc3RlbnQ8djg6Ok9iamVjdD46Ok5ldyhq c1dvcmtlckNvbnRleHQpKTsKICAgICBtX3dvcmtlckNvbnRleHQtPnJlZigpOwpAQCAtMTc0LDcg KzE3NSw3IEBAIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBXb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJv eHk6OmNvbnZlcnRUb1Y4T2JqZWN0KFY4Q2xhc3NJbmRlCiAgICAgaWYgKCFpbXBsKQogICAgICAg ICByZXR1cm4gdjg6Ok51bGwoKTsKIAotICAgIGlmICh0eXBlID09IFY4Q2xhc3NJbmRleDo6REVE SUNBVEVEV09SS0VSQ09OVEVYVCkKKyAgICBpZiAodHlwZSA9PSBWOENsYXNzSW5kZXg6OkRFRElD QVRFRFdPUktFUkNPTlRFWFQgfHwgdHlwZSA9PSBWOENsYXNzSW5kZXg6OlNIQVJFRFdPUktFUkNP TlRFWFQpCiAgICAgICAgIHJldHVybiBjb252ZXJ0V29ya2VyQ29udGV4dFRvVjhPYmplY3Qoc3Rh dGljX2Nhc3Q8V29ya2VyQ29udGV4dCo+KGltcGwpKTsKIAogICAgIGJvb2wgaXNBY3RpdmVEb21P YmplY3QgPSBmYWxzZTsKQEAgLTI4NiwxMCArMjg3LDE4IEBAIHY4OjpIYW5kbGU8djg6OlZhbHVl PiBXb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHk6OmNvbnZlcnRFdmVudFRhcmdldFRvVjhPYmpl Y3QoCiAgICAgaWYgKHdvcmtlckNvbnRleHQpCiAgICAgICAgIHJldHVybiBjb252ZXJ0V29ya2Vy Q29udGV4dFRvVjhPYmplY3Qod29ya2VyQ29udGV4dCk7CiAKKyAgICBTaGFyZWRXb3JrZXJDb250 ZXh0KiBzaGFyZWRXb3JrZXJDb250ZXh0ID0gdGFyZ2V0LT50b1NoYXJlZFdvcmtlckNvbnRleHQo KTsKKyAgICBpZiAoc2hhcmVkV29ya2VyQ29udGV4dCkKKyAgICAgICAgcmV0dXJuIGNvbnZlcnRX b3JrZXJDb250ZXh0VG9WOE9iamVjdChzaGFyZWRXb3JrZXJDb250ZXh0KTsKKwogICAgIFdvcmtl ciogd29ya2VyID0gdGFyZ2V0LT50b1dvcmtlcigpOwogICAgIGlmICh3b3JrZXIpCiAgICAgICAg IHJldHVybiBjb252ZXJ0VG9WOE9iamVjdChWOENsYXNzSW5kZXg6OldPUktFUiwgd29ya2VyKTsK IAorICAgIFNoYXJlZFdvcmtlciogc2hhcmVkV29ya2VyID0gdGFyZ2V0LT50b1NoYXJlZFdvcmtl cigpOworICAgIGlmIChzaGFyZWRXb3JrZXIpCisgICAgICAgIHJldHVybiBjb252ZXJ0VG9WOE9i amVjdChWOENsYXNzSW5kZXg6OlNIQVJFRFdPUktFUiwgc2hhcmVkV29ya2VyKTsKKwogICAgIFhN TEh0dHBSZXF1ZXN0KiB4aHIgPSB0YXJnZXQtPnRvWE1MSHR0cFJlcXVlc3QoKTsKICAgICBpZiAo eGhyKQogICAgICAgICByZXR1cm4gY29udmVydFRvVjhPYmplY3QoVjhDbGFzc0luZGV4OjpYTUxI VFRQUkVRVUVTVCwgeGhyKTsK