31224 2009-11-07 08:01:05 -0800 [V8] Return StyleSheet object instead of HTMLStyleElement w/document.styleSheets named property getter. 2009-11-08 21:52:52 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED http://soren.qzone.qq.com/cgi-bin/soren/cgi_userinfo_search?bSimple=0&ptlang=2052 P2 Normal --- 0 johnnyding.webkit webkit-unassigned commit-queue dglazkov oldest_to_newest 161347 0 johnnyding.webkit 2009-11-07 08:01:05 -0800 In page http://soren.qzone.qq.com/cgi-bin/soren/cgi_userinfo_search?bSimple=0&ptlang=2052, it uses document.styleSheets["CssId"].rules to get style css rule list. In safari, the page run well, but in Google Chrome, accessing document.styleSheets["CssId"].rules got "undefined". After investigation, Safari returns a [CSSStyleSheet] object when accessing document.styleSheets["CssId"], so the "rules" can be gotten. Chrome returns a [HTMLStyleElement] object when accessing document.styleSheets["CssId"], so the "rules" can not be gotten. I believe it's v8 binding's fault. See JS binding (JSStyleSheetListCustom.cpp, line 60), it returns stylesheet instead of returning style element. 161350 1 42694 johnnyding.webkit 2009-11-07 08:41:18 -0800 Created attachment 42694 patch to fix this issue. 161351 2 42694 dglazkov 2009-11-07 08:45:05 -0800 Comment on attachment 42694 patch to fix this issue. Thanks for tackling this! We just need a layout test and one small nit: > Index: WebCore/ChangeLog > =================================================================== > --- WebCore/ChangeLog (revision 50615) > +++ WebCore/ChangeLog (working copy) > @@ -1,3 +1,16 @@ > +2009-11-07 Johnny Ding <johnnyding.webkit@gmail.com> > + > + Reviewed by NOBODY (OOPS!). > + > + https://bugs.webkit.org/show_bug.cgi?id=31224 > + Returns a StyleSheet object instead of HTMLStyleElement when using Please update this to match the subject of the bug (including [V8] prefix). > + V8 engine to retrieve style sheet by a name from document.styleSheets . > + > + No new tests since it is only V8 binding issue.(JS binding is OK) Well, this is an easily testable case, so I would say a layout test is in order, regardless of whether it's a bindings issue for one engine and not another. 161353 3 dglazkov 2009-11-07 10:01:04 -0800 I wonder if there's already a layout test that we're failing that tests this. 161355 4 42696 johnnyding.webkit 2009-11-07 10:09:08 -0800 Created attachment 42696 patch v2 for fix Thanks, patch v2 is coming:) 161359 5 42698 johnnyding.webkit 2009-11-07 11:16:01 -0800 Created attachment 42698 patch v3 for fix 161360 6 42699 johnnyding.webkit 2009-11-07 11:18:09 -0800 Created attachment 42699 patch v3 for fix 161492 7 42699 dglazkov 2009-11-08 21:38:30 -0800 Comment on attachment 42699 patch v3 for fix Lovely. r=me. 161497 8 42699 commit-queue 2009-11-08 21:52:47 -0800 Comment on attachment 42699 patch v3 for fix Clearing flags on attachment: 42699 Committed r50637: <http://trac.webkit.org/changeset/50637> 161498 9 commit-queue 2009-11-08 21:52:52 -0800 All reviewed patches have been landed. Closing bug. 42694 2009-11-07 08:41:18 -0800 2009-11-07 10:09:08 -0800 patch to fix this issue. patch3.txt text/plain 1492 johnnyding.webkit SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDYxNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMTEtMDcgIEpvaG5ueSBEaW5nICA8am9obm55ZGluZy53ZWJr aXRAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTIyNAorICAg ICAgICBSZXR1cm5zIGEgU3R5bGVTaGVldCBvYmplY3QgaW5zdGVhZCBvZiBIVE1MU3R5bGVFbGVt ZW50IHdoZW4gdXNpbmcKKyAgICAgICAgVjggZW5naW5lIHRvIHJldHJpZXZlIHN0eWxlIHNoZWV0 IGJ5IGEgbmFtZSBmcm9tIGRvY3VtZW50LnN0eWxlU2hlZXRzLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cyBzaW5jZSBpdCBpcyBvbmx5IFY4IGJpbmRpbmcgaXNzdWUuKEpTIGJpbmRpbmcgaXMgT0sp CisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhTdHlsZVNoZWV0TGlzdEN1c3RvbS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpOQU1FRF9QUk9QRVJUWV9HRVRURVIpOgorCiAyMDA5LTEx LTA3ICBKb2FubWFyaWUgRGlnZ3MgIDxqb2FubWFyaWUuZGlnZ3NAZ21haWwuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IFhhbiBMb3Blei4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvY3Vz dG9tL1Y4U3R5bGVTaGVldExpc3RDdXN0b20uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmlu ZGluZ3MvdjgvY3VzdG9tL1Y4U3R5bGVTaGVldExpc3RDdXN0b20uY3BwCShyZXZpc2lvbiA1MDYx NSkKKysrIFdlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4U3R5bGVTaGVldExpc3RDdXN0b20u Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yOSw2ICsyOSw3IEBACiAgKi8KIAogI2luY2x1ZGUgImNv bmZpZy5oIgorI2luY2x1ZGUgIkhUTUxTdHlsZUVsZW1lbnQuaCIKICNpbmNsdWRlICJTdHlsZVNo ZWV0TGlzdC5oIgogCiAjaW5jbHVkZSAiVjhCaW5kaW5nLmgiCkBAIC01MCw3ICs1MSw3IEBAIE5B TUVEX1BST1BFUlRZX0dFVFRFUihTdHlsZVNoZWV0TGlzdCkKICAgICBpZiAoIWl0ZW0pCiAgICAg ICAgIHJldHVybiBub3RIYW5kbGVkQnlJbnRlcmNlcHRvcigpOwogCi0gICAgcmV0dXJuIFY4RE9N V3JhcHBlcjo6Y29udmVydFRvVjhPYmplY3QoVjhDbGFzc0luZGV4OjpIVE1MU1RZTEVFTEVNRU5U LCBpdGVtKTsKKyAgICByZXR1cm4gVjhET01XcmFwcGVyOjpjb252ZXJ0VG9WOE9iamVjdChWOENs YXNzSW5kZXg6OlNUWUxFU0hFRVQsIGl0ZW0tPnNoZWV0KCkpOwogfQogCiB9IC8vIG5hbWVzcGFj ZSBXZWJDb3JlCg== 42696 2009-11-07 10:09:08 -0800 2009-11-07 11:16:01 -0800 patch v2 for fix patch3.txt text/plain 3671 johnnyding.webkit SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDYxNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMTEtMDcgIEpvaG5ueSBEaW5nICA8am9obm55ZGluZy53ZWJr aXRAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTIyNAorICAg ICAgICBbVjhdIFJldHVybiBTdHlsZVNoZWV0IG9iamVjdCBpbnN0ZWFkIG9mIEhUTUxTdHlsZUVs ZW1lbnQgdy9kb2N1bWVudC5zdHlsZVNoZWV0cyBuYW1lZCBwcm9wZXJ0eSBnZXR0ZXIuCisKKyAg ICAgICAgVGVzdDogZmFzdC9kb20vU3R5bGVTaGVldC9nZXQtc3R5bGVzaGVldC1ieW5hbWUuaHRt bAorCisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4U3R5bGVTaGVldExpc3RDdXN0b20u Y3BwOgorICAgICAgICAoV2ViQ29yZTo6TkFNRURfUFJPUEVSVFlfR0VUVEVSKToKKwogMjAwOS0x MS0wNyAgSm9hbm1hcmllIERpZ2dzICA8am9hbm1hcmllLmRpZ2dzQGdtYWlsLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXouCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3Y4L2N1 c3RvbS9WOFN0eWxlU2hlZXRMaXN0Q3VzdG9tLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Jp bmRpbmdzL3Y4L2N1c3RvbS9WOFN0eWxlU2hlZXRMaXN0Q3VzdG9tLmNwcAkocmV2aXNpb24gNTA2 MTUpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFN0eWxlU2hlZXRMaXN0Q3VzdG9t LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjksNiArMjksNyBAQAogICovCiAKICNpbmNsdWRlICJj b25maWcuaCIKKyNpbmNsdWRlICJIVE1MU3R5bGVFbGVtZW50LmgiCiAjaW5jbHVkZSAiU3R5bGVT aGVldExpc3QuaCIKIAogI2luY2x1ZGUgIlY4QmluZGluZy5oIgpAQCAtNTAsNyArNTEsNyBAQCBO QU1FRF9QUk9QRVJUWV9HRVRURVIoU3R5bGVTaGVldExpc3QpCiAgICAgaWYgKCFpdGVtKQogICAg ICAgICByZXR1cm4gbm90SGFuZGxlZEJ5SW50ZXJjZXB0b3IoKTsKIAotICAgIHJldHVybiBWOERP TVdyYXBwZXI6OmNvbnZlcnRUb1Y4T2JqZWN0KFY4Q2xhc3NJbmRleDo6SFRNTFNUWUxFRUxFTUVO VCwgaXRlbSk7CisgICAgcmV0dXJuIFY4RE9NV3JhcHBlcjo6Y29udmVydFRvVjhPYmplY3QoVjhD bGFzc0luZGV4OjpTVFlMRVNIRUVULCBpdGVtLT5zaGVldCgpKTsKIH0KIAogfSAvLyBuYW1lc3Bh Y2UgV2ViQ29yZQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNTA2MTUpCisrKyBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0xMS0wNyAgSm9obm55 IERpbmcgIDxqb2hubnlkaW5nLndlYmtpdEBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTMxMjI0CisgICAgICAgIFtWOF0gUmV0dXJuIFN0eWxlU2hlZXQgb2JqZWN0 IGluc3RlYWQgb2YgSFRNTFN0eWxlRWxlbWVudCB3L2RvY3VtZW50LnN0eWxlU2hlZXRzIG5hbWVk IHByb3BlcnR5IGdldHRlci4KKworICAgICAgICAqIGZhc3QvZG9tL1N0eWxlU2hlZXQvZ2V0LXN0 eWxlc2hlZXQtYnluYW1lLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9kb20v U3R5bGVTaGVldC9nZXQtc3R5bGVzaGVldC1ieW5hbWUuaHRtbDogQWRkZWQuCisKIDIwMDktMTEt MDYgIEFuYW50YW5hcmF5YW5hbiBHIEl5ZW5nYXIgIDxhbmFudGFAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Rv bS9TdHlsZVNoZWV0L2dldC1zdHlsZXNoZWV0LWJ5bmFtZS1leHBlY3RlZC50eHQKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vU3R5bGVTaGVldC9nZXQtc3R5bGVzaGVldC1ieW5h bWUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vU3R5 bGVTaGVldC9nZXQtc3R5bGVzaGVldC1ieW5hbWUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpA QCAtMCwwICsxLDMgQEAKK1RoaXMgdGVzdCB2ZXJpZmllcyB0aGF0IGEgU3R5bGVTaGVldCBvYmpl Y3Qgd2lsbCBiZSByZXR1cm5lZCBpbnN0ZWFkIG9mIGEgSFRNTFN0eWxlRWxlbWVudCB3aGVuIGNh bGxpbmcgZG9jdW1lbnQuc3R5bGVTaGVldHMgbmFtZWQgcHJvcGVydHkgZ2V0dGVyLgorCitUZXN0 IHBhc3NlZC4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL1N0eWxlU2hlZXQvZ2V0LXN0eWxl c2hlZXQtYnluYW1lLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vU3R5 bGVTaGVldC9nZXQtc3R5bGVzaGVldC1ieW5hbWUuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91 dFRlc3RzL2Zhc3QvZG9tL1N0eWxlU2hlZXQvZ2V0LXN0eWxlc2hlZXQtYnluYW1lLmh0bWwJKHJl dmlzaW9uIDApCkBAIC0wLDAgKzEsMjYgQEAKKzxoZWFkPgorPGxpbmsgcmVsPSJzdHlsZXNoZWV0 IiBocmVmPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgorPHN0eWxlIGlk PSJ0ZXN0Ij4KK2RpdiB7IAorICAgIGJhY2tncm91bmQ6IHB1cnBsZTsKK30KKzwvc3R5bGU+Cis8 c2NyaXB0PgorZnVuY3Rpb24gcnVuVGVzdCgpCit7CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0 Q29udHJvbGxlcikKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOwor ICAgIHZhciByZXR1cm5lZE9iamVjdCA9IGRvY3VtZW50LnN0eWxlU2hlZXRzWyJ0ZXN0Il0udG9T dHJpbmcoKTsKKyAgICBpZiAocmV0dXJuZWRPYmplY3QgPT0gIltvYmplY3QgQ1NTU3R5bGVTaGVl dF0iKQorICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0IikuaW5uZXJIVE1M ID0gIlRlc3QgcGFzc2VkLiI7CisgICAgICAKK30KKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkg b25sb2FkPSJydW5UZXN0KCkiPgorPHA+CitUaGlzIHRlc3QgdmVyaWZpZXMgdGhhdCBhIFN0eWxl U2hlZXQgb2JqZWN0IHdpbGwgYmUgcmV0dXJuZWQgaW5zdGVhZCBvZgorYSBIVE1MU3R5bGVFbGVt ZW50IHdoZW4gY2FsbGluZyBkb2N1bWVudC5zdHlsZVNoZWV0cyBuYW1lZCBwcm9wZXJ0eSBnZXR0 ZXIuCis8L3A+Cis8cCBpZD0icmVzdWx0Ij5UZXN0IGZhaWxlZC48L3A+Cis8L2JvZHk+ClwgTm8g bmV3bGluZSBhdCBlbmQgb2YgZmlsZQo= 42698 2009-11-07 11:16:01 -0800 2009-11-07 11:18:09 -0800 patch v3 for fix patch3.txt text/plain 4494 johnnyding.webkit SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDYxNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMTEtMDcgIEpvaG5ueSBEaW5nICA8am9obm55ZGluZy53ZWJr aXRAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTIyNAorICAg ICAgICBbVjhdIFJldHVybiBTdHlsZVNoZWV0IG9iamVjdCBpbnN0ZWFkIG9mIEhUTUxTdHlsZUVs ZW1lbnQgdy9kb2N1bWVudC5zdHlsZVNoZWV0cyBuYW1lZCBwcm9wZXJ0eSBnZXR0ZXIuCisKKyAg ICAgICAgVGVzdDogZmFzdC9kb20vU3R5bGVTaGVldC9nZXQtc3R5bGVzaGVldC1ieW5hbWUuaHRt bAorCisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4U3R5bGVTaGVldExpc3RDdXN0b20u Y3BwOgorICAgICAgICAoV2ViQ29yZTo6TkFNRURfUFJPUEVSVFlfR0VUVEVSKToKKwogMjAwOS0x MS0wNyAgSm9hbm1hcmllIERpZ2dzICA8am9hbm1hcmllLmRpZ2dzQGdtYWlsLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXouCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3Y4L2N1 c3RvbS9WOFN0eWxlU2hlZXRMaXN0Q3VzdG9tLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Jp bmRpbmdzL3Y4L2N1c3RvbS9WOFN0eWxlU2hlZXRMaXN0Q3VzdG9tLmNwcAkocmV2aXNpb24gNTA2 MTUpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFN0eWxlU2hlZXRMaXN0Q3VzdG9t LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjksNiArMjksNyBAQAogICovCiAKICNpbmNsdWRlICJj b25maWcuaCIKKyNpbmNsdWRlICJIVE1MU3R5bGVFbGVtZW50LmgiCiAjaW5jbHVkZSAiU3R5bGVT aGVldExpc3QuaCIKIAogI2luY2x1ZGUgIlY4QmluZGluZy5oIgpAQCAtNTAsNyArNTEsNyBAQCBO QU1FRF9QUk9QRVJUWV9HRVRURVIoU3R5bGVTaGVldExpc3QpCiAgICAgaWYgKCFpdGVtKQogICAg ICAgICByZXR1cm4gbm90SGFuZGxlZEJ5SW50ZXJjZXB0b3IoKTsKIAotICAgIHJldHVybiBWOERP TVdyYXBwZXI6OmNvbnZlcnRUb1Y4T2JqZWN0KFY4Q2xhc3NJbmRleDo6SFRNTFNUWUxFRUxFTUVO VCwgaXRlbSk7CisgICAgcmV0dXJuIFY4RE9NV3JhcHBlcjo6Y29udmVydFRvVjhPYmplY3QoVjhD bGFzc0luZGV4OjpTVFlMRVNIRUVULCBpdGVtLT5zaGVldCgpKTsKIH0KIAogfSAvLyBuYW1lc3Bh Y2UgV2ViQ29yZQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNTA2MTUpCisrKyBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0xMS0wNyAgSm9obm55 IERpbmcgIDxqb2hubnlkaW5nLndlYmtpdEBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTMxMjI0CisgICAgICAgIFtWOF0gUmV0dXJuIFN0eWxlU2hlZXQgb2JqZWN0 IGluc3RlYWQgb2YgSFRNTFN0eWxlRWxlbWVudCB3L2RvY3VtZW50LnN0eWxlU2hlZXRzIG5hbWVk IHByb3BlcnR5IGdldHRlci4KKworICAgICAgICAqIGZhc3QvZG9tL1N0eWxlU2hlZXQvZ2V0LXN0 eWxlc2hlZXQtYnluYW1lLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9kb20v U3R5bGVTaGVldC9nZXQtc3R5bGVzaGVldC1ieW5hbWUuaHRtbDogQWRkZWQuCisgICAgICAgICog ZmFzdC9kb20vU3R5bGVTaGVldC9zY3JpcHQtdGVzdHM6IEFkZGVkLgorICAgICAgICAqIGZhc3Qv ZG9tL1N0eWxlU2hlZXQvc2NyaXB0LXRlc3RzL2dldC1zdHlsZXNoZWV0LWJ5bmFtZS5qczogQWRk ZWQuCisKIDIwMDktMTEtMDYgIEFuYW50YW5hcmF5YW5hbiBHIEl5ZW5nYXIgIDxhbmFudGFAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBMYXlv dXRUZXN0cy9mYXN0L2RvbS9TdHlsZVNoZWV0L2dldC1zdHlsZXNoZWV0LWJ5bmFtZS1leHBlY3Rl ZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vU3R5bGVTaGVldC9nZXQt c3R5bGVzaGVldC1ieW5hbWUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVz dHMvZmFzdC9kb20vU3R5bGVTaGVldC9nZXQtc3R5bGVzaGVldC1ieW5hbWUtZXhwZWN0ZWQudHh0 CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDEwIEBACitUaGlzIHRlc3QgdmVyaWZpZXMgdGhhdCBh IFN0eWxlU2hlZXQgb2JqZWN0IHdpbGwgYmUgcmV0dXJuZWQgaW5zdGVhZCBvZiBhIEhUTUxTdHls ZUVsZW1lbnQgd2hlbiBjYWxsaW5nIGRvY3VtZW50LnN0eWxlU2hlZXRzIG5hbWVkIHByb3BlcnR5 IGdldHRlci4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBt ZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgZG9jdW1lbnQu c3R5bGVTaGVldHNbInRlc3QiXS50b1N0cmluZygpIGlzIGRvY3VtZW50LnN0eWxlU2hlZXRzWzFd LnRvU3RyaW5nKCkKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01Q TEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9TdHlsZVNoZWV0L2dldC1zdHlsZXNo ZWV0LWJ5bmFtZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL1N0eWxl U2hlZXQvZ2V0LXN0eWxlc2hlZXQtYnluYW1lLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRU ZXN0cy9mYXN0L2RvbS9TdHlsZVNoZWV0L2dldC1zdHlsZXNoZWV0LWJ5bmFtZS5odG1sCShyZXZp c2lvbiAwKQpAQCAtMCwwICsxLDE4IEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYv L0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKzxoZWFkPgorPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBo cmVmPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgorPHN0eWxlIGlkPSJ0 ZXN0Ij4KKy51bmtub3duIHsgCisgICAgbGVmdDogMHB4OworfQorPC9zdHlsZT4KKzxzY3JpcHQg c3JjPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFk PgorPGJvZHk+Cis8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwv ZGl2PgorPHNjcmlwdCBzcmM9InNjcmlwdC10ZXN0cy9nZXQtc3R5bGVzaGVldC1ieW5hbWUuanMi Pjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3Qu anMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZp bGUKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL1N0eWxlU2hlZXQvc2NyaXB0LXRlc3RzL2dl dC1zdHlsZXNoZWV0LWJ5bmFtZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Rv bS9TdHlsZVNoZWV0L3NjcmlwdC10ZXN0cy9nZXQtc3R5bGVzaGVldC1ieW5hbWUuanMJKHJldmlz aW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9TdHlsZVNoZWV0L3NjcmlwdC10ZXN0cy9n ZXQtc3R5bGVzaGVldC1ieW5hbWUuanMJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNiBAQAorZGVz Y3JpcHRpb24oIlRoaXMgdGVzdCB2ZXJpZmllcyB0aGF0IGEgU3R5bGVTaGVldCBvYmplY3Qgd2ls bCBiZSByZXR1cm5lZCBpbnN0ZWFkIG9mIGEgSFRNTFN0eWxlRWxlbWVudCB3aGVuIGNhbGxpbmcg ZG9jdW1lbnQuc3R5bGVTaGVldHMgbmFtZWQgcHJvcGVydHkgZ2V0dGVyLiIpOworCisvLyBUaGUg dHlwZSBvZiByZXR1cm5lZCBvYmplY3QgYnkgbnVtYmVyIGdldHRlciBzaG91bGQgYmUgZXF1YWwg d2l0aCB0aGUgbmFtZWQgcHJvcGVydHkgZ2V0dGVyLgorc2hvdWxkQmUoJ2RvY3VtZW50LnN0eWxl U2hlZXRzWyJ0ZXN0Il0udG9TdHJpbmcoKScsICdkb2N1bWVudC5zdHlsZVNoZWV0c1sxXS50b1N0 cmluZygpJyk7CisgICAgCit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsK 42699 2009-11-07 11:18:09 -0800 2009-11-08 21:52:47 -0800 patch v3 for fix patch3.txt text/plain 4494 johnnyding.webkit SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDYxNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMTEtMDcgIEpvaG5ueSBEaW5nICA8am9obm55ZGluZy53ZWJr aXRAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTIyNAorICAg ICAgICBbVjhdIFJldHVybiBTdHlsZVNoZWV0IG9iamVjdCBpbnN0ZWFkIG9mIEhUTUxTdHlsZUVs ZW1lbnQgdy9kb2N1bWVudC5zdHlsZVNoZWV0cyBuYW1lZCBwcm9wZXJ0eSBnZXR0ZXIuCisKKyAg ICAgICAgVGVzdDogZmFzdC9kb20vU3R5bGVTaGVldC9nZXQtc3R5bGVzaGVldC1ieW5hbWUuaHRt bAorCisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4U3R5bGVTaGVldExpc3RDdXN0b20u Y3BwOgorICAgICAgICAoV2ViQ29yZTo6TkFNRURfUFJPUEVSVFlfR0VUVEVSKToKKwogMjAwOS0x MS0wNyAgSm9hbm1hcmllIERpZ2dzICA8am9hbm1hcmllLmRpZ2dzQGdtYWlsLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXouCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3Y4L2N1 c3RvbS9WOFN0eWxlU2hlZXRMaXN0Q3VzdG9tLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Jp bmRpbmdzL3Y4L2N1c3RvbS9WOFN0eWxlU2hlZXRMaXN0Q3VzdG9tLmNwcAkocmV2aXNpb24gNTA2 MTUpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFN0eWxlU2hlZXRMaXN0Q3VzdG9t LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjksNiArMjksNyBAQAogICovCiAKICNpbmNsdWRlICJj b25maWcuaCIKKyNpbmNsdWRlICJIVE1MU3R5bGVFbGVtZW50LmgiCiAjaW5jbHVkZSAiU3R5bGVT aGVldExpc3QuaCIKIAogI2luY2x1ZGUgIlY4QmluZGluZy5oIgpAQCAtNTAsNyArNTEsNyBAQCBO QU1FRF9QUk9QRVJUWV9HRVRURVIoU3R5bGVTaGVldExpc3QpCiAgICAgaWYgKCFpdGVtKQogICAg ICAgICByZXR1cm4gbm90SGFuZGxlZEJ5SW50ZXJjZXB0b3IoKTsKIAotICAgIHJldHVybiBWOERP TVdyYXBwZXI6OmNvbnZlcnRUb1Y4T2JqZWN0KFY4Q2xhc3NJbmRleDo6SFRNTFNUWUxFRUxFTUVO VCwgaXRlbSk7CisgICAgcmV0dXJuIFY4RE9NV3JhcHBlcjo6Y29udmVydFRvVjhPYmplY3QoVjhD bGFzc0luZGV4OjpTVFlMRVNIRUVULCBpdGVtLT5zaGVldCgpKTsKIH0KIAogfSAvLyBuYW1lc3Bh Y2UgV2ViQ29yZQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNTA2MTUpCisrKyBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0xMS0wNyAgSm9obm55 IERpbmcgIDxqb2hubnlkaW5nLndlYmtpdEBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTMxMjI0CisgICAgICAgIFtWOF0gUmV0dXJuIFN0eWxlU2hlZXQgb2JqZWN0 IGluc3RlYWQgb2YgSFRNTFN0eWxlRWxlbWVudCB3L2RvY3VtZW50LnN0eWxlU2hlZXRzIG5hbWVk IHByb3BlcnR5IGdldHRlci4KKworICAgICAgICAqIGZhc3QvZG9tL1N0eWxlU2hlZXQvZ2V0LXN0 eWxlc2hlZXQtYnluYW1lLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9kb20v U3R5bGVTaGVldC9nZXQtc3R5bGVzaGVldC1ieW5hbWUuaHRtbDogQWRkZWQuCisgICAgICAgICog ZmFzdC9kb20vU3R5bGVTaGVldC9zY3JpcHQtdGVzdHM6IEFkZGVkLgorICAgICAgICAqIGZhc3Qv ZG9tL1N0eWxlU2hlZXQvc2NyaXB0LXRlc3RzL2dldC1zdHlsZXNoZWV0LWJ5bmFtZS5qczogQWRk ZWQuCisKIDIwMDktMTEtMDYgIEFuYW50YW5hcmF5YW5hbiBHIEl5ZW5nYXIgIDxhbmFudGFAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBMYXlv dXRUZXN0cy9mYXN0L2RvbS9TdHlsZVNoZWV0L2dldC1zdHlsZXNoZWV0LWJ5bmFtZS1leHBlY3Rl ZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vU3R5bGVTaGVldC9nZXQt c3R5bGVzaGVldC1ieW5hbWUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVz dHMvZmFzdC9kb20vU3R5bGVTaGVldC9nZXQtc3R5bGVzaGVldC1ieW5hbWUtZXhwZWN0ZWQudHh0 CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDEwIEBACitUaGlzIHRlc3QgdmVyaWZpZXMgdGhhdCBh IFN0eWxlU2hlZXQgb2JqZWN0IHdpbGwgYmUgcmV0dXJuZWQgaW5zdGVhZCBvZiBhIEhUTUxTdHls ZUVsZW1lbnQgd2hlbiBjYWxsaW5nIGRvY3VtZW50LnN0eWxlU2hlZXRzIG5hbWVkIHByb3BlcnR5 IGdldHRlci4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBt ZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgZG9jdW1lbnQu c3R5bGVTaGVldHNbInRlc3QiXS50b1N0cmluZygpIGlzIGRvY3VtZW50LnN0eWxlU2hlZXRzWzFd LnRvU3RyaW5nKCkKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01Q TEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9TdHlsZVNoZWV0L2dldC1zdHlsZXNo ZWV0LWJ5bmFtZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL1N0eWxl U2hlZXQvZ2V0LXN0eWxlc2hlZXQtYnluYW1lLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRU ZXN0cy9mYXN0L2RvbS9TdHlsZVNoZWV0L2dldC1zdHlsZXNoZWV0LWJ5bmFtZS5odG1sCShyZXZp c2lvbiAwKQpAQCAtMCwwICsxLDE4IEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYv L0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKzxoZWFkPgorPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBo cmVmPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgorPHN0eWxlIGlkPSJ0 ZXN0Ij4KKy51bmtub3duIHsgCisgICAgbGVmdDogMHB4OworfQorPC9zdHlsZT4KKzxzY3JpcHQg c3JjPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFk PgorPGJvZHk+Cis8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwv ZGl2PgorPHNjcmlwdCBzcmM9InNjcmlwdC10ZXN0cy9nZXQtc3R5bGVzaGVldC1ieW5hbWUuanMi Pjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3Qu anMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZp bGUKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL1N0eWxlU2hlZXQvc2NyaXB0LXRlc3RzL2dl dC1zdHlsZXNoZWV0LWJ5bmFtZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Rv bS9TdHlsZVNoZWV0L3NjcmlwdC10ZXN0cy9nZXQtc3R5bGVzaGVldC1ieW5hbWUuanMJKHJldmlz aW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9TdHlsZVNoZWV0L3NjcmlwdC10ZXN0cy9n ZXQtc3R5bGVzaGVldC1ieW5hbWUuanMJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNiBAQAorZGVz Y3JpcHRpb24oIlRoaXMgdGVzdCB2ZXJpZmllcyB0aGF0IGEgU3R5bGVTaGVldCBvYmplY3Qgd2ls bCBiZSByZXR1cm5lZCBpbnN0ZWFkIG9mIGEgSFRNTFN0eWxlRWxlbWVudCB3aGVuIGNhbGxpbmcg ZG9jdW1lbnQuc3R5bGVTaGVldHMgbmFtZWQgcHJvcGVydHkgZ2V0dGVyLiIpOworCisvLyBUaGUg dHlwZSBvZiByZXR1cm5lZCBvYmplY3QgYnkgbnVtYmVyIGdldHRlciBzaG91bGQgYmUgZXF1YWwg d2l0aCB0aGUgbmFtZWQgcHJvcGVydHkgZ2V0dGVyLgorc2hvdWxkQmUoJ2RvY3VtZW50LnN0eWxl U2hlZXRzWyJ0ZXN0Il0udG9TdHJpbmcoKScsICdkb2N1bWVudC5zdHlsZVNoZWV0c1sxXS50b1N0 cmluZygpJyk7CisgICAgCit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsK