31209 2009-11-06 10:58:43 -0800 V8DOMWindowCustom.cpp is missing WEB_SOCKETS guard on include 2009-11-06 12:01:28 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 steveblock steveblock benm commit-queue eric steveblock oldest_to_newest 161175 0 steveblock 2009-11-06 10:58:43 -0800 V8DOMWindowCustom.cpp is missing WEB_SOCKETS feature guard on include of WebSockets.h. All other include sites of WebSockets.h from outside of websockets code use this guard. 161177 1 42660 steveblock 2009-11-06 11:05:25 -0800 Created attachment 42660 Patch 1 for Bug 31209 161188 2 42660 eric 2009-11-06 11:23:33 -0800 Comment on attachment 42660 Patch 1 for Bug 31209 LGTM. 161189 3 42660 eric 2009-11-06 11:23:57 -0800 Comment on attachment 42660 Patch 1 for Bug 31209 Build fixes don't require review, but review is always nice for any patch. :) 161205 4 42660 commit-queue 2009-11-06 11:38:35 -0800 Comment on attachment 42660 Patch 1 for Bug 31209 Rejecting patch 42660 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11573 test cases. transitions/transition-end-event-transform.html -> failed Exiting early after 1 failures. 11507 tests run. 484.99s total testing time 11506 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 6 test cases (<1%) had stderr output 161208 5 42660 eric 2009-11-06 11:43:31 -0800 Comment on attachment 42660 Patch 1 for Bug 31209 Must be a flakey test. I'll file a bug. 161210 6 eric 2009-11-06 11:44:49 -0800 Turns out this was a known issue. Updated bug 30029. 161219 7 42660 commit-queue 2009-11-06 12:01:24 -0800 Comment on attachment 42660 Patch 1 for Bug 31209 Clearing flags on attachment: 42660 Committed r50603: <http://trac.webkit.org/changeset/50603> 161220 8 commit-queue 2009-11-06 12:01:28 -0800 All reviewed patches have been landed. Closing bug. 42660 2009-11-06 11:05:25 -0800 2009-11-06 12:01:23 -0800 Patch 1 for Bug 31209 websocketsInclude.txt text/plain 1187 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDYwMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMTEtMDYgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFY4RE9NV2luZG93Q3VzdG9tLmNwcCBpcyBtaXNzaW5nIFdFQl9TT0NLRVRTIGd1YXJkIG9uIGlu Y2x1ZGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z MTIwOQorCisgICAgICAgIEJ1aWxkIGZpeCBvbmx5LiBObyBuZXcgdGVzdHMgcG9zc2libGUuCisK KyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhET01XaW5kb3dDdXN0b20uY3BwOiBNb2Rp ZmllZC4gQWRkZWQgV0VCX1NPQ0tFVFMgZ3VhcmQgb24gaW5jbHVlIG9mIFdlYlNvY2tldHMuaC4K KwogMjAwOS0xMS0wNiAgRHJldyBXaWxzb24gIDxhdHdpbHNvbkBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3Y4 L2N1c3RvbS9WOERPTVdpbmRvd0N1c3RvbS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5k aW5ncy92OC9jdXN0b20vVjhET01XaW5kb3dDdXN0b20uY3BwCShyZXZpc2lvbiA1MDU5MykKKysr IFdlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RE9NV2luZG93Q3VzdG9tLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNTUsNyArNTUsOSBAQAogI2luY2x1ZGUgIlNldHRpbmdzLmgiCiAjaW5jbHVk ZSAiU2hhcmVkV29ya2VyUmVwb3NpdG9yeS5oIgogI2luY2x1ZGUgIlN0b3JhZ2UuaCIKKyNpZiBF TkFCTEUoV0VCX1NPQ0tFVFMpCiAjaW5jbHVkZSAiV2ViU29ja2V0LmgiCisjZW5kaWYKICNpbmNs dWRlICJXaW5kb3dGZWF0dXJlcy5oIgogCiAvLyBIb3Jpem9udGFsIGFuZCB2ZXJ0aWNhbCBvZmZz ZXQsIGZyb20gdGhlIHBhcmVudCBjb250ZW50IGFyZWEsIGFyb3VuZCBuZXdseQo=