31202 2009-11-06 04:38:53 -0800 Web Inspector: Resource content search is broken 2009-11-06 05:41:48 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 apavlov webkit-unassigned bweinstein commit-queue joepeck keishi pfeldman pmuellr rik timothy oldest_to_newest 161118 0 apavlov 2009-11-06 04:38:53 -0800 1. Open Web Inspector window, Resources panel for any web page with textual resources (JS, CSS) 2. Select a textual resource and type any text in the Search box. An exception is thrown at ResourcesPanel.js:255 161121 1 42646 apavlov 2009-11-06 05:23:00 -0800 Created attachment 42646 patch 161127 2 42646 commit-queue 2009-11-06 05:41:42 -0800 Comment on attachment 42646 patch Clearing flags on attachment: 42646 Committed r50597: <http://trac.webkit.org/changeset/50597> 161128 3 commit-queue 2009-11-06 05:41:48 -0800 All reviewed patches have been landed. Closing bug. 42646 2009-11-06 05:23:00 -0800 2009-11-06 05:41:42 -0800 patch fixresourcesearch.patch text/plain 4445 apavlov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTZhMDg4NS4uMGFlNjZjYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0xMS0wNiAgQWxleGFuZGVyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEZpeCByZXNvdXJjZSBjb250ZW50IHNlYXJjaC4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxMjAyCisKKyAgICAg ICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0Fic3RyYWN0VGltZWxpbmVQYW5lbC5qczoKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5BYnN0cmFjdFRpbWVsaW5lUGFuZWwucHJvdG90eXBlLnJlZnJlc2gp OgorICAgICAgICAoV2ViSW5zcGVjdG9yLkFic3RyYWN0VGltZWxpbmVQYW5lbC5wcm90b3R5cGUu cmVtb3ZlSXRlbSk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZVBhbmVs LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lR3JhcGgucHJvdG90eXBlLnJlZnJl c2gpOgorCiAyMDA5LTExLTA1ICBZdXRhIEtpdGFtdXJhICA8eXV0YWtAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0Fic3RyYWN0VGltZWxpbmVQYW5lbC5qcyBiL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9BYnN0cmFjdFRpbWVsaW5lUGFuZWwuanMKaW5kZXggZDI4NWYzNi4u YjdhNzRmZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0Fic3RyYWN0 VGltZWxpbmVQYW5lbC5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQWJzdHJh Y3RUaW1lbGluZVBhbmVsLmpzCkBAIC0yODksMTcgKzI4OSwxNyBAQCBXZWJJbnNwZWN0b3IuQWJz dHJhY3RUaW1lbGluZVBhbmVsLnByb3RvdHlwZSA9IHsKIAogICAgICAgICBmb3IgKHZhciBpID0g MDsgaSA8IHN0YWxlSXRlbXNMZW5ndGg7ICsraSkgewogICAgICAgICAgICAgdmFyIGl0ZW0gPSB0 aGlzLl9zdGFsZUl0ZW1zW2ldOwotICAgICAgICAgICAgaWYgKCFpdGVtLl9pdGVtVHJlZUVsZW1l bnQpIHsKKyAgICAgICAgICAgIGlmICghaXRlbS5faXRlbXNUcmVlRWxlbWVudCkgewogICAgICAg ICAgICAgICAgIC8vIENyZWF0ZSB0aGUgdGltZWxpbmUgdHJlZSBlbGVtZW50IGFuZCBncmFwaC4K LSAgICAgICAgICAgICAgICBpdGVtLl9pdGVtVHJlZUVsZW1lbnQgPSB0aGlzLmNyZWF0ZUl0ZW1U cmVlRWxlbWVudChpdGVtKTsKLSAgICAgICAgICAgICAgICBpdGVtLl9pdGVtVHJlZUVsZW1lbnQu X2l0ZW1HcmFwaCA9IHRoaXMuY3JlYXRlSXRlbUdyYXBoKGl0ZW0pOworICAgICAgICAgICAgICAg IGl0ZW0uX2l0ZW1zVHJlZUVsZW1lbnQgPSB0aGlzLmNyZWF0ZUl0ZW1UcmVlRWxlbWVudChpdGVt KTsKKyAgICAgICAgICAgICAgICBpdGVtLl9pdGVtc1RyZWVFbGVtZW50Ll9pdGVtR3JhcGggPSB0 aGlzLmNyZWF0ZUl0ZW1HcmFwaChpdGVtKTsKIAotICAgICAgICAgICAgICAgIHRoaXMuaXRlbXNU cmVlRWxlbWVudC5hcHBlbmRDaGlsZChpdGVtLl9pdGVtVHJlZUVsZW1lbnQpOwotICAgICAgICAg ICAgICAgIHRoaXMuaXRlbXNHcmFwaHNFbGVtZW50LmFwcGVuZENoaWxkKGl0ZW0uX2l0ZW1UcmVl RWxlbWVudC5faXRlbUdyYXBoLmdyYXBoRWxlbWVudCk7CisgICAgICAgICAgICAgICAgdGhpcy5p dGVtc1RyZWVFbGVtZW50LmFwcGVuZENoaWxkKGl0ZW0uX2l0ZW1zVHJlZUVsZW1lbnQpOworICAg ICAgICAgICAgICAgIHRoaXMuaXRlbXNHcmFwaHNFbGVtZW50LmFwcGVuZENoaWxkKGl0ZW0uX2l0 ZW1zVHJlZUVsZW1lbnQuX2l0ZW1HcmFwaC5ncmFwaEVsZW1lbnQpOwogICAgICAgICAgICAgfQog Ci0gICAgICAgICAgICBpZiAoaXRlbS5faXRlbVRyZWVFbGVtZW50LnJlZnJlc2gpCi0gICAgICAg ICAgICAgICAgaXRlbS5faXRlbVRyZWVFbGVtZW50LnJlZnJlc2goKTsKKyAgICAgICAgICAgIGlm IChpdGVtLl9pdGVtc1RyZWVFbGVtZW50LnJlZnJlc2gpCisgICAgICAgICAgICAgICAgaXRlbS5f aXRlbXNUcmVlRWxlbWVudC5yZWZyZXNoKCk7CiAKICAgICAgICAgICAgIGlmICh0aGlzLmNhbGN1 bGF0b3IudXBkYXRlQm91bmRhcmllcyhpdGVtKSkKICAgICAgICAgICAgICAgICBib3VuZGFyaWVz Q2hhbmdlZCA9IHRydWU7CkBAIC0zMTIsNyArMzEyLDcgQEAgV2ViSW5zcGVjdG9yLkFic3RyYWN0 VGltZWxpbmVQYW5lbC5wcm90b3R5cGUgPSB7CiAgICAgICAgIH0KIAogICAgICAgICBmb3IgKHZh ciBpID0gMDsgaSA8IHN0YWxlSXRlbXNMZW5ndGg7ICsraSkKLSAgICAgICAgICAgIHRoaXMuX3N0 YWxlSXRlbXNbaV0uX2l0ZW1UcmVlRWxlbWVudC5faXRlbUdyYXBoLnJlZnJlc2godGhpcy5jYWxj dWxhdG9yKTsKKyAgICAgICAgICAgIHRoaXMuX3N0YWxlSXRlbXNbaV0uX2l0ZW1zVHJlZUVsZW1l bnQuX2l0ZW1HcmFwaC5yZWZyZXNoKHRoaXMuY2FsY3VsYXRvcik7CiAKICAgICAgICAgdGhpcy5f c3RhbGVJdGVtcyA9IFtdOwogCkBAIC0zNzAsMTIgKzM3MCwxMiBAQCBXZWJJbnNwZWN0b3IuQWJz dHJhY3RUaW1lbGluZVBhbmVsLnByb3RvdHlwZSA9IHsKICAgICB7CiAgICAgICAgIHRoaXMuX2l0 ZW1zLnJlbW92ZShpdGVtLCB0cnVlKTsKIAotICAgICAgICBpZiAoaXRlbS5faXRlbVRyZWVFbGVt ZW50KSB7Ci0gICAgICAgICAgICB0aGlzLml0ZW1zVHJlZUVsZW1lbnQucmVtb3ZlQ2hpbGQocmVz b3VyY2UuX2l0ZW1UcmVlRWxlbWVudCk7Ci0gICAgICAgICAgICB0aGlzLml0ZW1zR3JhcGhzRWxl bWVudC5yZW1vdmVDaGlsZChyZXNvdXJjZS5faXRlbVRyZWVFbGVtZW50Ll9pdGVtR3JhcGguZ3Jh cGhFbGVtZW50KTsKKyAgICAgICAgaWYgKGl0ZW0uX2l0ZW1zVHJlZUVsZW1lbnQpIHsKKyAgICAg ICAgICAgIHRoaXMuaXRlbXNUcmVlRWxlbWVudC5yZW1vdmVDaGlsZChyZXNvdXJjZS5faXRlbXNU cmVlRWxlbWVudCk7CisgICAgICAgICAgICB0aGlzLml0ZW1zR3JhcGhzRWxlbWVudC5yZW1vdmVD aGlsZChyZXNvdXJjZS5faXRlbXNUcmVlRWxlbWVudC5faXRlbUdyYXBoLmdyYXBoRWxlbWVudCk7 CiAgICAgICAgIH0KIAotICAgICAgICBkZWxldGUgaXRlbS5faXRlbVRyZWVFbGVtZW50OworICAg ICAgICBkZWxldGUgaXRlbS5faXRlbXNUcmVlRWxlbWVudDsKICAgICAgICAgdGhpcy5hZGp1c3RT Y3JvbGxQb3NpdGlvbigpOwogICAgIH0sCiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9UaW1lbGluZVBhbmVsLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L1RpbWVsaW5lUGFuZWwuanMKaW5kZXggNWYzZGNhOC4uNTI3Y2FjNiAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMKKysrIGIvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMKQEAgLTcxNiwxMiArNzE2LDEyIEBA IFdlYkluc3BlY3Rvci5UaW1lbGluZUdyYXBoLnByb3RvdHlwZSA9IHsKIAogICAgICAgICBpZiAo cGVyY2VudGFnZXMuc3RhcnQgPiAxMDAgfHwgcGVyY2VudGFnZXMuZW5kIDwgMCkgewogICAgICAg ICAgICAgdGhpcy5fZ3JhcGhFbGVtZW50LmFkZFN0eWxlQ2xhc3MoImhpZGRlbiIpOwotICAgICAg ICAgICAgdGhpcy5yZWNvcmQuX2l0ZW1UcmVlRWxlbWVudC5saXN0SXRlbUVsZW1lbnQuYWRkU3R5 bGVDbGFzcygiaGlkZGVuIik7CisgICAgICAgICAgICB0aGlzLnJlY29yZC5faXRlbXNUcmVlRWxl bWVudC5saXN0SXRlbUVsZW1lbnQuYWRkU3R5bGVDbGFzcygiaGlkZGVuIik7CiAgICAgICAgIH0g ZWxzZSB7CiAgICAgICAgICAgICB0aGlzLl9iYXJFbGVtZW50LnN0eWxlLnNldFByb3BlcnR5KCJs ZWZ0IiwgcGVyY2VudGFnZXMuc3RhcnQgKyAiJSIpOwogICAgICAgICAgICAgdGhpcy5fYmFyRWxl bWVudC5zdHlsZS5zZXRQcm9wZXJ0eSgicmlnaHQiLCAoMTAwIC0gcGVyY2VudGFnZXMuZW5kKSAr ICIlIik7CiAgICAgICAgICAgICB0aGlzLl9ncmFwaEVsZW1lbnQucmVtb3ZlU3R5bGVDbGFzcygi aGlkZGVuIik7Ci0gICAgICAgICAgICB0aGlzLnJlY29yZC5faXRlbVRyZWVFbGVtZW50Lmxpc3RJ dGVtRWxlbWVudC5yZW1vdmVTdHlsZUNsYXNzKCJoaWRkZW4iKTsKKyAgICAgICAgICAgIHRoaXMu cmVjb3JkLl9pdGVtc1RyZWVFbGVtZW50Lmxpc3RJdGVtRWxlbWVudC5yZW1vdmVTdHlsZUNsYXNz KCJoaWRkZW4iKTsKICAgICAgICAgfQogICAgICAgICB2YXIgdG9vbHRpcCA9IChsYWJlbHMudG9v bHRpcCB8fCAiIik7CiAgICAgICAgIHRoaXMuX2JhckVsZW1lbnQudGl0bGUgPSB0b29sdGlwOwo=