31199 2009-11-05 22:51:04 -0800 V8 bindings do not support SharedWorkers as event targets 2009-11-06 08:18:54 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 atwilson atwilson commit-queue oldest_to_newest 161080 0 atwilson 2009-11-05 22:51:04 -0800 V8DOMWrapper::convertEventTargetToV8Object() doesn't handle SharedWorkers currently, so we get a failed assertion if you ever try to send an event to a shared worker. 161083 1 42631 atwilson 2009-11-05 22:55:56 -0800 Created attachment 42631 proposed patch 161085 2 42632 atwilson 2009-11-05 22:58:46 -0800 Created attachment 42632 fixed bug (was passing "null" as the target) 161145 3 42632 commit-queue 2009-11-06 08:18:50 -0800 Comment on attachment 42632 fixed bug (was passing "null" as the target) Clearing flags on attachment: 42632 Committed r50600: <http://trac.webkit.org/changeset/50600> 161146 4 commit-queue 2009-11-06 08:18:54 -0800 All reviewed patches have been landed. Closing bug. 42631 2009-11-05 22:55:56 -0800 2009-11-05 22:58:46 -0800 proposed patch x text/plain 1436 atwilson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MWMwYmM1Ny4uOTE2ZGM0YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0xMS0wNSAgRHJldyBXaWxzb24g IDxhdHdpbHNvbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVjggYmluZGluZ3MgZG8gbm90IHN1cHBvcnQgU2hhcmVkV29ya2Vy cyBhcyBldmVudCB0YXJnZXRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zMTE5OQorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlIGV4aXN0aW5n IGxheW91dCB0ZXN0cyBzdWZmaWNlICh0aGV5IGN1cnJlbnRseQorICAgICAgICBjcmFzaCBvbiBD aHJvbWl1bSkKKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpWOERPTVdyYXBwZXI6OmNvbnZlcnRFdmVudFRhcmdldFRvVjhPYmplY3Qp OgorICAgICAgICBBZGRlZCBjbGF1c2UgdG8gY3JlYXRlIGEgRE9NIHdyYXBwZXIgZm9yIFNoYXJl ZFdvcmtlcnMuCisKIDIwMDktMTEtMDQgIEFscGhhIExhbSAgPGhjbGFtQGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIENhcmxzb24uCmRpZmYgLS1naXQgYS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9N V3JhcHBlci5jcHAKaW5kZXggMzllNThjNy4uMGM1OGM5MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9i aW5kaW5ncy92OC9WOERPTVdyYXBwZXIuY3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhE T01XcmFwcGVyLmNwcApAQCAtMTM0OCw2ICsxMzQ4LDEyIEBAIHY4OjpIYW5kbGU8djg6OlZhbHVl PiBWOERPTVdyYXBwZXI6OmNvbnZlcnRFdmVudFRhcmdldFRvVjhPYmplY3QoRXZlbnRUYXJnZXQq IHRhCiAgICAgICAgIHJldHVybiBjb252ZXJ0VG9WOE9iamVjdChWOENsYXNzSW5kZXg6OldPUktF Uiwgd29ya2VyKTsKICNlbmRpZiAvLyBXT1JLRVJTCiAKKyNpZiBFTkFCTEUoU0hBUkVEX1dPUktF UlMpCisgICAgU2hhcmVkV29ya2VyKiBzaGFyZWRXb3JrZXIgPSB0YXJnZXQtPnRvU2hhcmVkV29y a2VyKCk7CisgICAgaWYgKHNoYXJlZFdvcmtlcikKKyAgICAgICAgcmV0dXJuIGNvbnZlcnRUb1Y4 T2JqZWN0KFY4Q2xhc3NJbmRleDo6U0hBUkVEV09SS0VSLCB3b3JrZXIpOworI2VuZGlmIC8vIFNI QVJFRF9XT1JLRVJTCisKICNpZiBFTkFCTEUoTk9USUZJQ0FUSU9OUykKICAgICBOb3RpZmljYXRp b24qIG5vdGlmaWNhdGlvbiA9IHRhcmdldC0+dG9Ob3RpZmljYXRpb24oKTsKICAgICBpZiAobm90 aWZpY2F0aW9uKQo= 42632 2009-11-05 22:58:46 -0800 2009-11-06 08:18:50 -0800 fixed bug (was passing "null" as the target) x text/plain 1442 atwilson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MWMwYmM1Ny4uOTE2ZGM0YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0xMS0wNSAgRHJldyBXaWxzb24g IDxhdHdpbHNvbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVjggYmluZGluZ3MgZG8gbm90IHN1cHBvcnQgU2hhcmVkV29ya2Vy cyBhcyBldmVudCB0YXJnZXRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zMTE5OQorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlIGV4aXN0aW5n IGxheW91dCB0ZXN0cyBzdWZmaWNlICh0aGV5IGN1cnJlbnRseQorICAgICAgICBjcmFzaCBvbiBD aHJvbWl1bSkKKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpWOERPTVdyYXBwZXI6OmNvbnZlcnRFdmVudFRhcmdldFRvVjhPYmplY3Qp OgorICAgICAgICBBZGRlZCBjbGF1c2UgdG8gY3JlYXRlIGEgRE9NIHdyYXBwZXIgZm9yIFNoYXJl ZFdvcmtlcnMuCisKIDIwMDktMTEtMDQgIEFscGhhIExhbSAgPGhjbGFtQGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIENhcmxzb24uCmRpZmYgLS1naXQgYS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9N V3JhcHBlci5jcHAKaW5kZXggMzllNThjNy4uZWQxYTJiZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9i aW5kaW5ncy92OC9WOERPTVdyYXBwZXIuY3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhE T01XcmFwcGVyLmNwcApAQCAtMTM0OCw2ICsxMzQ4LDEyIEBAIHY4OjpIYW5kbGU8djg6OlZhbHVl PiBWOERPTVdyYXBwZXI6OmNvbnZlcnRFdmVudFRhcmdldFRvVjhPYmplY3QoRXZlbnRUYXJnZXQq IHRhCiAgICAgICAgIHJldHVybiBjb252ZXJ0VG9WOE9iamVjdChWOENsYXNzSW5kZXg6OldPUktF Uiwgd29ya2VyKTsKICNlbmRpZiAvLyBXT1JLRVJTCiAKKyNpZiBFTkFCTEUoU0hBUkVEX1dPUktF UlMpCisgICAgU2hhcmVkV29ya2VyKiBzaGFyZWRXb3JrZXIgPSB0YXJnZXQtPnRvU2hhcmVkV29y a2VyKCk7CisgICAgaWYgKHNoYXJlZFdvcmtlcikKKyAgICAgICAgcmV0dXJuIGNvbnZlcnRUb1Y4 T2JqZWN0KFY4Q2xhc3NJbmRleDo6U0hBUkVEV09SS0VSLCBzaGFyZWRXb3JrZXIpOworI2VuZGlm IC8vIFNIQVJFRF9XT1JLRVJTCisKICNpZiBFTkFCTEUoTk9USUZJQ0FUSU9OUykKICAgICBOb3Rp ZmljYXRpb24qIG5vdGlmaWNhdGlvbiA9IHRhcmdldC0+dG9Ob3RpZmljYXRpb24oKTsKICAgICBp ZiAobm90aWZpY2F0aW9uKQo=