31191 2009-11-05 15:23:41 -0800 [v8] get rid of unnecessary synchronization in weak reference callbacks 2009-11-06 05:49:19 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 antonm webkit-unassigned commit-queue jens oldest_to_newest 160984 0 antonm 2009-11-05 15:23:41 -0800 Currently browser and renderer execute V8-related code (including GC) in the main thread. So a lot of synchronization is actually unused and only makes us slower. I don't do the full cleanup (but would do on request) to make it easier to rollback this synchronization infrastructure if need be. On the other side that's exactly what version control should do. 160988 1 42604 antonm 2009-11-05 15:27:00 -0800 Created attachment 42604 First take 161057 2 42604 abarth 2009-11-05 20:19:02 -0800 Comment on attachment 42604 First take Ok. Isn't our plan to run workers in process at some point? I guess we can tackle that problem when we come to it. 161124 3 antonm 2009-11-06 05:30:04 -0800 (In reply to comment #2) > (From update of attachment 42604 [details]) > Ok. Isn't our plan to run workers in process at some point? I guess we can > tackle that problem when we come to it. Yep. That's exactly why I don't want to cleanup the stuff. 161125 4 antonm 2009-11-06 05:30:29 -0800 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 42604 [details] [details]) > > Ok. Isn't our plan to run workers in process at some point? I guess we can > > tackle that problem when we come to it. > > Yep. That's exactly why I don't want to cleanup the stuff. And thanks a lot for review. 161129 5 42604 commit-queue 2009-11-06 05:49:13 -0800 Comment on attachment 42604 First take Clearing flags on attachment: 42604 Committed r50598: <http://trac.webkit.org/changeset/50598> 161130 6 commit-queue 2009-11-06 05:49:19 -0800 All reviewed patches have been landed. Closing bug. 42604 2009-11-05 15:27:00 -0800 2009-11-06 05:49:13 -0800 First take WebCore.patch text/plain 2275 antonm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDU4MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMTEtMDUgIEFudG9uIE11aGluICA8YW50b25tQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBE byBub3QgdW5uZWNlc3Nhcmx5IHN5bmNocm9uemllIGluIHdlYWsgcmVmZXJlbmNlIGNhbGxiYWNr cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxMTkx CisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9ET01EYXRhLmg6CisgICAgICAgIChXZWJDb3JlOjpE T01EYXRhOjpoYW5kbGVXZWFrT2JqZWN0KToKKwogMjAwOS0xMS0wNSAgU2NvdHQgVmlvbGV0ICA8 c2t5QGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgpJ bmRleDogV2ViQ29yZS9iaW5kaW5ncy92OC9ET01EYXRhLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9iaW5kaW5ncy92OC9ET01EYXRhLmgJKHJldmlzaW9uIDUwNTM1KQorKysgV2ViQ29yZS9iaW5k aW5ncy92OC9ET01EYXRhLmgJKHdvcmtpbmcgY29weSkKQEAgLTg0LDIwICs4NCwxMCBAQAogICAg ICAgICBUaHJlYWRJZGVudGlmaWVyIG1fb3duaW5nVGhyZWFkOwogICAgIH07CiAKLSAgICAvLyBD YWxsZWQgd2hlbiB0aGUgZGVhZCBvYmplY3QgaXMgbm90IGluIEdDIHRocmVhZCdzIG1hcC4gR28g dGhyb3VnaCBhbGwKLSAgICAvLyB0aHJlYWQgbWFwcyB0byBmaW5kIHRoZSBvbmUgY29udGFpbmlu ZyBpdC4gIFRoZW4gY2xlYXIgdGhlIEpTIHJlZmVyZW5jZQotICAgIC8vIGFuZCBwdXNoIHRoZSBE T00gb2JqZWN0IGludG8gdGhlIGRlbGF5ZWQgcXVldWUgZm9yIGl0IHRvIGJlIGRlcmVmLWVkIGF0 Ci0gICAgLy8gbGF0ZXIgdGltZSBmcm9tIHRoZSBvd25pbmcgdGhyZWFkLgotICAgIC8vCi0gICAg Ly8gKiBUaGlzIGlzIGNhbGxlZCB3aGVuIHRoZSBHQyB0aHJlYWQgaXMgbm90IHRoZSBvd25pbmcg dGhyZWFkLgotICAgIC8vICogVGhpcyBjYW4gYmUgY2FsbGVkIG9uIGFueSB0aHJlYWQgdGhhdCBo YXMgR0MgcnVubmluZy4KLSAgICAvLyAqIE9ubHkgb25lIFY4IGluc3RhbmNlIGlzIHJ1bm5pbmcg YXQgYSB0aW1lIGR1ZSB0byBWODo6TG9ja2VyLiBTbyB3ZSBkb24ndCBuZWVkIHRvIHdvcnJ5IGFi b3V0IGNvbmN1cnJlbmN5LgotICAgIC8vCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4KICAgICB2 b2lkIERPTURhdGE6OmhhbmRsZVdlYWtPYmplY3QoRE9NRGF0YVN0b3JlOjpET01XcmFwcGVyTWFw VHlwZSBtYXBUeXBlLCB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IHY4T2JqZWN0LCBUKiBkb21PYmpl Y3QpCiAgICAgewotCi0gICAgICAgIFdURjo6TXV0ZXhMb2NrZXIgbG9ja2VyKERPTURhdGFTdG9y ZTo6YWxsU3RvcmVzTXV0ZXgoKSk7CisgICAgICAgIEFTU0VSVChXVEY6OmlzTWFpblRocmVhZCgp KTsKICAgICAgICAgRE9NRGF0YUxpc3QmIGxpc3QgPSBET01EYXRhU3RvcmU6OmFsbFN0b3Jlcygp OwogICAgICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IGxpc3Quc2l6ZSgpOyArK2kpIHsKICAg ICAgICAgICAgIERPTURhdGFTdG9yZSogc3RvcmUgPSBsaXN0W2ldOwpAQCAtMTA4LDcgKzk4LDgg QEAKICAgICAgICAgICAgIGlmICgqd3JhcHBlciA9PSAqdjhPYmplY3QpIHsKICAgICAgICAgICAg ICAgICAvLyBDbGVhciB0aGUgSlMgcmVmZXJlbmNlLgogICAgICAgICAgICAgICAgIGRvbU1hcC0+ Zm9yZ2V0T25seShkb21PYmplY3QpOwotICAgICAgICAgICAgICAgIHN0b3JlLT5kb21EYXRhKCkt PmVuc3VyZURlcmVmKFY4RE9NV3JhcHBlcjo6ZG9tV3JhcHBlclR5cGUodjhPYmplY3QpLCBkb21P YmplY3QpOworICAgICAgICAgICAgICAgIEFTU0VSVChzdG9yZS0+ZG9tRGF0YSgpLT5vd25pbmdU aHJlYWQoKSA9PSBXVEY6OmN1cnJlbnRUaHJlYWQoKSk7CisgICAgICAgICAgICAgICAgc3RvcmUt PmRvbURhdGEoKS0+ZGVyZWZPYmplY3QoVjhET01XcmFwcGVyOjpkb21XcmFwcGVyVHlwZSh2OE9i amVjdCksIGRvbU9iamVjdCk7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICB9Cg==