31185 2009-11-05 13:36:51 -0800 [Qt] Layout Test editing/undo/undo-deleteWord.html fails 2009-11-09 06:21:30 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 cshu cshu commit-queue laszlo.gombos oldest_to_newest 160933 0 cshu 2009-11-05 13:36:51 -0800 Build bot reports failure on the above test case: http://build.webkit.org/results/Qt%20Linux%20Release/r50408%20%283364%29/results.html 160938 1 42592 cshu 2009-11-05 13:44:12 -0800 Created attachment 42592 fix patch 160981 2 42592 eric 2009-11-05 15:21:10 -0800 Comment on attachment 42592 fix patch This change should really have a code comment to explain what 8 and 127 are. Using nicely named constants would be even better. 161132 3 42649 cshu 2009-11-06 06:32:00 -0800 Created attachment 42649 update after Eric's comment 161424 4 42649 eric 2009-11-08 10:36:09 -0800 Comment on attachment 42649 update after Eric's comment We generally use static variables instead of #defines, but we can always change that later. cq+ 161434 5 42649 commit-queue 2009-11-08 10:51:33 -0800 Comment on attachment 42649 update after Eric's comment Clearing flags on attachment: 42649 Committed r50624: <http://trac.webkit.org/changeset/50624> 161435 6 commit-queue 2009-11-08 10:51:37 -0800 All reviewed patches have been landed. Closing bug. 161554 7 cshu 2009-11-09 06:21:30 -0800 (In reply to comment #4) > (From update of attachment 42649 [details]) > We generally use static variables instead of #defines, but we can always change > that later. cq+ Will keep that in mind. 42592 2009-11-05 13:44:12 -0800 2009-11-06 06:32:00 -0800 fix patch bug31185_1.patch text/plain 1387 cshu SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUwNTc2KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTEtMDUgIFNodSBDaGFuZyAgPENoYW5n LlNodUBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgW1F0XSBBZGQgc3VwcG9ydCBmb3Iga2V5IGNvZGUgOCAoYmFja3NwYWNlKSBpbiBF dmVudFNlbmRlclF0LgorICAgICAgICBUaGlzIGhlbHBzIHRvIHBhc3MgdGhlIHRlc3QgY2FzZSBi ZWxvdy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMx MTg1CisgICAgICAgIAorICAgICAgICBUZXN0OiBlZGl0aW5nL3VuZG8vdW5kby1kZWxldGVXb3Jk Lmh0bWwKKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL3F0L0V2ZW50U2VuZGVyUXQuY3BwOgor ICAgICAgICAoRXZlbnRTZW5kZXI6OmtleURvd24pOgorCiAyMDA5LTExLTA0ICBFcmljIFNlaWRl bCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBObyByZXZpZXcsIGp1c3QgYWRkIGEgbGlu ZSB3aGljaCBnb3QgbGVmdCBvdXQgb2YgdGhlIHBhdGNoIHVwbG9hZGVkIGZvciBjb21taXQuCklu ZGV4OiBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9FdmVudFNlbmRlclF0LmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9FdmVudFNlbmRlclF0LmNw cAkocmV2aXNpb24gNTA1NjQpCisrKyBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9FdmVu dFNlbmRlclF0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTI5LDcgKzEyOSw3IEBAIHZvaWQgRXZl bnRTZW5kZXI6OmtleURvd24oY29uc3QgUVN0cmluZyYKICAgICAgICAgICAgIGlmIChtb2RpZnMg PT0gUXQ6OlNoaWZ0TW9kaWZpZXIpCiAgICAgICAgICAgICAgICAgY29kZSA9IFF0OjpLZXlfQmFj a3RhYjsKICAgICAgICAgICAgIHMgPSBRU3RyaW5nKCk7Ci0gICAgICAgIH0gZWxzZSBpZiAoY29k ZSA9PSAxMjcpIHsKKyAgICAgICAgfSBlbHNlIGlmIChjb2RlID09IDEyNyB8fCBjb2RlID09IDgp IHsKICAgICAgICAgICAgIGNvZGUgPSBRdDo6S2V5X0JhY2tzcGFjZTsKICAgICAgICAgICAgIGlm IChtb2RpZnMgPT0gUXQ6OkFsdE1vZGlmaWVyKQogICAgICAgICAgICAgICAgIG1vZGlmcyA9IFF0 OjpDb250cm9sTW9kaWZpZXI7Cg== 42649 2009-11-06 06:32:00 -0800 2009-11-08 10:51:32 -0800 update after Eric's comment bug31185_2.patch text/plain 3064 cshu SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUwNTc2KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMTEtMDUgIFNodSBDaGFuZyAgPENoYW5n LlNodUBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgW1F0XSBBZGRlZCBzdXBwb3J0IGZvciBrZXkgY29kZSA4IChiYWNrc3BhY2UpIGlu IEV2ZW50U2VuZGVyUXQuCisgICAgICAgIFRoaXMgaGVscHMgdG8gcGFzcyB0aGUgdGVzdCBjYXNl IGJlbG93LiBBbHNvIHJlcGxhY2VkIGhhcmRjb2RlZAorICAgICAgICBjb2RlIG51bWJlcnMgd2l0 aCBkZWZpbmVkIGNvbnN0YW50cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTMxMTg1CisgICAgICAgIAorICAgICAgICBUZXN0OiBlZGl0aW5nL3VuZG8v dW5kby1kZWxldGVXb3JkLmh0bWwKKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL3F0L0V2ZW50 U2VuZGVyUXQuY3BwOgorICAgICAgICAoRXZlbnRTZW5kZXI6OmtleURvd24pOgorCiAyMDA5LTEx LTA0ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBObyByZXZpZXcs IGp1c3QgYWRkIGEgbGluZSB3aGljaCBnb3QgbGVmdCBvdXQgb2YgdGhlIHBhdGNoIHVwbG9hZGVk IGZvciBjb21taXQuCkluZGV4OiBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9FdmVudFNl bmRlclF0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9F dmVudFNlbmRlclF0LmNwcAkocmV2aXNpb24gNTA1NjQpCisrKyBXZWJLaXRUb29scy9EdW1wUmVu ZGVyVHJlZS9xdC9FdmVudFNlbmRlclF0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzAsNiArMzAs MTUgQEAKICNpbmNsdWRlICJFdmVudFNlbmRlclF0LmgiCiAKIC8vI2luY2x1ZGUgPFF0RGVidWc+ CisKKyNkZWZpbmUgS0VZQ09ERV9ERUwgICAgICAgICAxMjcKKyNkZWZpbmUgS0VZQ09ERV9CQUNL U1BBQ0UgICA4CisjZGVmaW5lIEtFWUNPREVfTEVGVEFSUk9XICAgMHhmNzAyCisjZGVmaW5lIEtF WUNPREVfUklHSFRBUlJPVyAgMHhmNzAzCisjZGVmaW5lIEtFWUNPREVfVVBBUlJPVyAgICAgMHhm NzAwCisjZGVmaW5lIEtFWUNPREVfRE9XTkFSUk9XICAgMHhmNzAxCisKKwogRXZlbnRTZW5kZXI6 OkV2ZW50U2VuZGVyKFFXZWJQYWdlKiBwYXJlbnQpCiAgICAgOiBRT2JqZWN0KHBhcmVudCkKIHsK QEAgLTEyOSw3ICsxMzgsNyBAQCB2b2lkIEV2ZW50U2VuZGVyOjprZXlEb3duKGNvbnN0IFFTdHJp bmcmCiAgICAgICAgICAgICBpZiAobW9kaWZzID09IFF0OjpTaGlmdE1vZGlmaWVyKQogICAgICAg ICAgICAgICAgIGNvZGUgPSBRdDo6S2V5X0JhY2t0YWI7CiAgICAgICAgICAgICBzID0gUVN0cmlu ZygpOwotICAgICAgICB9IGVsc2UgaWYgKGNvZGUgPT0gMTI3KSB7CisgICAgICAgIH0gZWxzZSBp ZiAoY29kZSA9PSBLRVlDT0RFX0RFTCB8fCBjb2RlID09IEtFWUNPREVfQkFDS1NQQUNFKSB7CiAg ICAgICAgICAgICBjb2RlID0gUXQ6OktleV9CYWNrc3BhY2U7CiAgICAgICAgICAgICBpZiAobW9k aWZzID09IFF0OjpBbHRNb2RpZmllcikKICAgICAgICAgICAgICAgICBtb2RpZnMgPSBRdDo6Q29u dHJvbE1vZGlmaWVyOwpAQCAtMTQ4LDI4ICsxNTcsMjggQEAgdm9pZCBFdmVudFNlbmRlcjo6a2V5 RG93bihjb25zdCBRU3RyaW5nJgogICAgICAgICAgICAgcyA9IFFTdHJpbmcoKTsKICAgICAgICAg ICAgIGNvZGUgPSBRdDo6S2V5X0hvbWU7CiAgICAgICAgICAgICBtb2RpZnMgPSAwOwotICAgICAg ICB9IGVsc2UgaWYgKGNvZGUgPT0gMHhmNzAyKSB7CisgICAgICAgIH0gZWxzZSBpZiAoY29kZSA9 PSBLRVlDT0RFX0xFRlRBUlJPVykgewogICAgICAgICAgICAgcyA9IFFTdHJpbmcoKTsKICAgICAg ICAgICAgIGNvZGUgPSBRdDo6S2V5X0xlZnQ7CiAgICAgICAgICAgICBpZiAobW9kaWZzICYgUXQ6 Ok1ldGFNb2RpZmllcikgewogICAgICAgICAgICAgICAgIGNvZGUgPSBRdDo6S2V5X0hvbWU7CiAg ICAgICAgICAgICAgICAgbW9kaWZzICY9IH5RdDo6TWV0YU1vZGlmaWVyOwogICAgICAgICAgICAg fQotICAgICAgICB9IGVsc2UgaWYgKGNvZGUgPT0gMHhmNzAzKSB7CisgICAgICAgIH0gZWxzZSBp ZiAoY29kZSA9PSBLRVlDT0RFX1JJR0hUQVJST1cpIHsKICAgICAgICAgICAgIHMgPSBRU3RyaW5n KCk7CiAgICAgICAgICAgICBjb2RlID0gUXQ6OktleV9SaWdodDsKICAgICAgICAgICAgIGlmICht b2RpZnMgJiBRdDo6TWV0YU1vZGlmaWVyKSB7CiAgICAgICAgICAgICAgICAgY29kZSA9IFF0OjpL ZXlfRW5kOwogICAgICAgICAgICAgICAgIG1vZGlmcyAmPSB+UXQ6Ok1ldGFNb2RpZmllcjsKICAg ICAgICAgICAgIH0KLSAgICAgICAgfSBlbHNlIGlmIChjb2RlID09IDB4ZjcwMCkgeworICAgICAg ICB9IGVsc2UgaWYgKGNvZGUgPT0gS0VZQ09ERV9VUEFSUk9XKSB7CiAgICAgICAgICAgICBzID0g UVN0cmluZygpOwogICAgICAgICAgICAgY29kZSA9IFF0OjpLZXlfVXA7CiAgICAgICAgICAgICBp ZiAobW9kaWZzICYgUXQ6Ok1ldGFNb2RpZmllcikgewogICAgICAgICAgICAgICAgIGNvZGUgPSBR dDo6S2V5X1BhZ2VVcDsKICAgICAgICAgICAgICAgICBtb2RpZnMgJj0gflF0OjpNZXRhTW9kaWZp ZXI7CiAgICAgICAgICAgICB9Ci0gICAgICAgIH0gZWxzZSBpZiAoY29kZSA9PSAweGY3MDEpIHsK KyAgICAgICAgfSBlbHNlIGlmIChjb2RlID09IEtFWUNPREVfRE9XTkFSUk9XKSB7CiAgICAgICAg ICAgICBzID0gUVN0cmluZygpOwogICAgICAgICAgICAgY29kZSA9IFF0OjpLZXlfRG93bjsKICAg ICAgICAgICAgIGlmIChtb2RpZnMgJiBRdDo6TWV0YU1vZGlmaWVyKSB7Cg==