311707 2026-04-07 22:44:00 -0700 CredentialsContainer: performCommonChecks() should return RefPtr&lt;Document&gt; instead of bool 2026-04-08 08:09:34 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 marcosc marcosc webkit-bug-importer oldest_to_newest 2197877 0 marcosc 2026-04-07 22:44:00 -0700 In CredentialsContainer.cpp, `get()` and `isCreate()` both call `performCommonChecks()` which checks for a null document internally via RefPtr, then immediately re-acquire the document via `Ref document = *this->document()` — relying on an implicit contract that the document is still non-null. ```cpp void CredentialsContainer::get(CredentialRequestOptions&& options, CredentialPromise&& promise) { if (!performCommonChecks(options, promise)) return; Ref document = *this->document(); // unsafe: re-acquires WeakPtr without null check ... } ``` The fix is to change `performCommonChecks()` to return `RefPtr<Document>` (or null on failure), so callers receive the document directly without re-acquiring the WeakPtr: ```cpp void CredentialsContainer::get(CredentialRequestOptions&& options, CredentialPromise&& promise) { RefPtr document = performCommonChecks(options, promise); if (!document) return; ... } ``` This makes the null-safety contract explicit and eliminates the implicit assumption. Note: This is pre-existing code. In practice the implicit contract holds soundly under WebKit's single-threaded execution model, but it violates the spirit of WebKit's safer-cpp guidelines. 2197878 1 webkit-bug-importer 2026-04-07 22:44:07 -0700 <rdar://problem/174293959> 2197892 2 marcosc 2026-04-08 00:03:53 -0700 Pull request: https://github.com/WebKit/WebKit/pull/62256 2197987 3 ews-feeder 2026-04-08 08:09:32 -0700 Committed 310779@main (acecc70c2382): <https://commits.webkit.org/310779@main> Reviewed commits have been landed. Closing PR #62256 and removing active labels.