31166 2009-11-05 06:30:25 -0800 [Qt] Shift-PageUp and Shift-PageDown events not supported on Qt 2009-11-05 08:21:05 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED P3 Normal --- 1 cshu cshu abecsi commit-queue oldest_to_newest 160806 0 cshu 2009-11-05 06:30:25 -0800 Open the following page in QtLauncher: LayoutTests/editing/selection/shrink-selection-after-shift-pagedown.html Try to use Shift-PageUp and Shift-PageDown to select texts. Actual result: Shift-PageUp and Shift-PageDown behaves like PageUP and PageDown. Expected result: The selected text should change accordingly. 160808 1 42567 cshu 2009-11-05 06:37:54 -0800 Created attachment 42567 fix patch 160810 2 42568 cshu 2009-11-05 06:51:06 -0800 Created attachment 42568 fix patch with some coding style change 160821 3 42568 vestbo 2009-11-05 07:41:19 -0800 Comment on attachment 42568 fix patch with some coding style change Thanks 160822 4 42568 commit-queue 2009-11-05 07:48:51 -0800 Comment on attachment 42568 fix patch with some coding style change Clearing flags on attachment: 42568 Committed r50563: <http://trac.webkit.org/changeset/50563> 160823 5 commit-queue 2009-11-05 07:48:56 -0800 All reviewed patches have been landed. Closing bug. 160831 6 abecsi 2009-11-05 08:06:36 -0800 (In reply to comment #5) > All reviewed patches have been landed. Closing bug. There still seems to be a problem with Shift+Up: -SUCCESS: The selection shrunk correctly +SUCCESS: The selected text is "YES YES YES YES YES YES YES YES YES NO". 160834 7 cshu 2009-11-05 08:21:05 -0800 (In reply to comment #6) > (In reply to comment #5) > > All reviewed patches have been landed. Closing bug. > > There still seems to be a problem with Shift+Up: > > -SUCCESS: The selection shrunk correctly > +SUCCESS: The selected text is "YES YES YES YES YES YES YES YES YES NO". This patch does not fix the test case yet. The problem is addressed in bug 31122. please also check some comments I wrote for 31103. Thanks 42567 2009-11-05 06:37:54 -0800 2009-11-05 06:51:06 -0800 fix patch bug31166_1.patch text/plain 1819 cshu SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNTA1NjApCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTEtMDUgIFNodSBDaGFuZyAgPENoYW5nLlNodUBu b2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWRkIHN1cHBvcnQgZm9yIFNoaWZ0LVBhZ2VVcCBhbmQgU2hpZnQtUGFnZURvd24ga2V5IGV2 ZW50cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMx MTY2CisKKyAgICAgICAgVGVzdDogTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vc2hyaW5r LXNlbGVjdGlvbi1hZnRlci1zaGlmdC1wYWdlZG93bi5odG1sCisKKyAgICAgICAgKiBXZWJDb3Jl U3VwcG9ydC9FZGl0b3JDbGllbnRRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFZGl0b3JDbGll bnRRdDo6aGFuZGxlS2V5Ym9hcmRFdmVudCk6CisKIDIwMDktMTEtMDUgIFNpbW9uIEhhdXNtYW5u ICA8aGF1c21hbm5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBMYXN0IFF0IDQuNSBidWlsZCBmaXgg KCpzaWdoKikKSW5kZXg6IFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRRdC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudFF0 LmNwcAkocmV2aXNpb24gNTA0NzMpCisrKyBXZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRWRpdG9y Q2xpZW50UXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MjUsMTAgKzQyNSwxNCBAQCB2b2lkIEVk aXRvckNsaWVudFF0OjpoYW5kbGVLZXlib2FyZEV2ZW50CiAgICAgICAgICAgICAgICAgZWxzZSBm cmFtZS0+ZWRpdG9yKCktPmNvbW1hbmQoIk1vdmVEb3duIikuZXhlY3V0ZSgpOwogICAgICAgICAg ICAgICAgIGJyZWFrOwogICAgICAgICAgICAgY2FzZSBWS19QUklPUjogIC8vIFBhZ2VVcAotICAg ICAgICAgICAgICAgIGZyYW1lLT5lZGl0b3IoKS0+Y29tbWFuZCgiTW92ZVBhZ2VVcCIpLmV4ZWN1 dGUoKTsKKyAgICAgICAgICAgICAgICBpZiAoa2V2ZW50LT5zaGlmdEtleSgpKQorICAgICAgICAg ICAgICAgICAgICBmcmFtZS0+ZWRpdG9yKCktPmNvbW1hbmQoIk1vdmVQYWdlVXBBbmRNb2RpZnlT ZWxlY3Rpb24iKS5leGVjdXRlKCk7CisgICAgICAgICAgICAgICAgZWxzZSBmcmFtZS0+ZWRpdG9y KCktPmNvbW1hbmQoIk1vdmVQYWdlVXAiKS5leGVjdXRlKCk7CiAgICAgICAgICAgICAgICAgYnJl YWs7CiAgICAgICAgICAgICBjYXNlIFZLX05FWFQ6ICAvLyBQYWdlRG93bgotICAgICAgICAgICAg ICAgIGZyYW1lLT5lZGl0b3IoKS0+Y29tbWFuZCgiTW92ZVBhZ2VEb3duIikuZXhlY3V0ZSgpOwor ICAgICAgICAgICAgICAgIGlmIChrZXZlbnQtPnNoaWZ0S2V5KCkpCisgICAgICAgICAgICAgICAg ICAgIGZyYW1lLT5lZGl0b3IoKS0+Y29tbWFuZCgiTW92ZVBhZ2VEb3duQW5kTW9kaWZ5U2VsZWN0 aW9uIikuZXhlY3V0ZSgpOworICAgICAgICAgICAgICAgIGVsc2UgZnJhbWUtPmVkaXRvcigpLT5j b21tYW5kKCJNb3ZlUGFnZURvd24iKS5leGVjdXRlKCk7CiAgICAgICAgICAgICAgICAgYnJlYWs7 CiAgICAgICAgICAgICBjYXNlIFZLX1RBQjoKICAgICAgICAgICAgICAgICByZXR1cm47Cg== 42568 2009-11-05 06:51:06 -0800 2009-11-05 07:48:50 -0800 fix patch with some coding style change bug31166_2.patch text/plain 3123 cshu SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNTA1NjApCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTEtMDUgIFNodSBDaGFuZyAgPENoYW5nLlNodUBu b2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWRkIHN1cHBvcnQgZm9yIFNoaWZ0LVBhZ2VVcCBhbmQgU2hpZnQtUGFnZURvd24ga2V5IGV2 ZW50cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMx MTY2CisKKyAgICAgICAgVGVzdDogTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vc2hyaW5r LXNlbGVjdGlvbi1hZnRlci1zaGlmdC1wYWdlZG93bi5odG1sCisKKyAgICAgICAgKiBXZWJDb3Jl U3VwcG9ydC9FZGl0b3JDbGllbnRRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFZGl0b3JDbGll bnRRdDo6aGFuZGxlS2V5Ym9hcmRFdmVudCk6CisKIDIwMDktMTEtMDUgIFNpbW9uIEhhdXNtYW5u ICA8aGF1c21hbm5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBMYXN0IFF0IDQuNSBidWlsZCBmaXgg KCpzaWdoKikKSW5kZXg6IFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRRdC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudFF0 LmNwcAkocmV2aXNpb24gNTA0NzMpCisrKyBXZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRWRpdG9y Q2xpZW50UXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MDcsMjggKzQwNywzOCBAQCB2b2lkIEVk aXRvckNsaWVudFF0OjpoYW5kbGVLZXlib2FyZEV2ZW50CiAgICAgICAgICAgICBjYXNlIFZLX0xF RlQ6CiAgICAgICAgICAgICAgICAgaWYgKGtldmVudC0+c2hpZnRLZXkoKSkKICAgICAgICAgICAg ICAgICAgICAgZnJhbWUtPmVkaXRvcigpLT5jb21tYW5kKCJNb3ZlTGVmdEFuZE1vZGlmeVNlbGVj dGlvbiIpLmV4ZWN1dGUoKTsKLSAgICAgICAgICAgICAgICBlbHNlIGZyYW1lLT5lZGl0b3IoKS0+ Y29tbWFuZCgiTW92ZUxlZnQiKS5leGVjdXRlKCk7CisgICAgICAgICAgICAgICAgZWxzZQorICAg ICAgICAgICAgICAgICAgICBmcmFtZS0+ZWRpdG9yKCktPmNvbW1hbmQoIk1vdmVMZWZ0IikuZXhl Y3V0ZSgpOwogICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgY2FzZSBWS19SSUdI VDoKICAgICAgICAgICAgICAgICBpZiAoa2V2ZW50LT5zaGlmdEtleSgpKQogICAgICAgICAgICAg ICAgICAgICBmcmFtZS0+ZWRpdG9yKCktPmNvbW1hbmQoIk1vdmVSaWdodEFuZE1vZGlmeVNlbGVj dGlvbiIpLmV4ZWN1dGUoKTsKLSAgICAgICAgICAgICAgICBlbHNlIGZyYW1lLT5lZGl0b3IoKS0+ Y29tbWFuZCgiTW92ZVJpZ2h0IikuZXhlY3V0ZSgpOworICAgICAgICAgICAgICAgIGVsc2UKKyAg ICAgICAgICAgICAgICAgICAgZnJhbWUtPmVkaXRvcigpLT5jb21tYW5kKCJNb3ZlUmlnaHQiKS5l eGVjdXRlKCk7CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICBjYXNlIFZLX1VQ OgogICAgICAgICAgICAgICAgIGlmIChrZXZlbnQtPnNoaWZ0S2V5KCkpCiAgICAgICAgICAgICAg ICAgICAgIGZyYW1lLT5lZGl0b3IoKS0+Y29tbWFuZCgiTW92ZVVwQW5kTW9kaWZ5U2VsZWN0aW9u IikuZXhlY3V0ZSgpOwotICAgICAgICAgICAgICAgIGVsc2UgZnJhbWUtPmVkaXRvcigpLT5jb21t YW5kKCJNb3ZlVXAiKS5leGVjdXRlKCk7CisgICAgICAgICAgICAgICAgZWxzZQorICAgICAgICAg ICAgICAgICAgICBmcmFtZS0+ZWRpdG9yKCktPmNvbW1hbmQoIk1vdmVVcCIpLmV4ZWN1dGUoKTsK ICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIGNhc2UgVktfRE9XTjoKICAgICAg ICAgICAgICAgICBpZiAoa2V2ZW50LT5zaGlmdEtleSgpKQogICAgICAgICAgICAgICAgICAgICBm cmFtZS0+ZWRpdG9yKCktPmNvbW1hbmQoIk1vdmVEb3duQW5kTW9kaWZ5U2VsZWN0aW9uIikuZXhl Y3V0ZSgpOwotICAgICAgICAgICAgICAgIGVsc2UgZnJhbWUtPmVkaXRvcigpLT5jb21tYW5kKCJN b3ZlRG93biIpLmV4ZWN1dGUoKTsKKyAgICAgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAg ICAgICAgIGZyYW1lLT5lZGl0b3IoKS0+Y29tbWFuZCgiTW92ZURvd24iKS5leGVjdXRlKCk7CiAg ICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICBjYXNlIFZLX1BSSU9SOiAgLy8gUGFn ZVVwCi0gICAgICAgICAgICAgICAgZnJhbWUtPmVkaXRvcigpLT5jb21tYW5kKCJNb3ZlUGFnZVVw IikuZXhlY3V0ZSgpOworICAgICAgICAgICAgICAgIGlmIChrZXZlbnQtPnNoaWZ0S2V5KCkpCisg ICAgICAgICAgICAgICAgICAgIGZyYW1lLT5lZGl0b3IoKS0+Y29tbWFuZCgiTW92ZVBhZ2VVcEFu ZE1vZGlmeVNlbGVjdGlvbiIpLmV4ZWN1dGUoKTsKKyAgICAgICAgICAgICAgICBlbHNlCisgICAg ICAgICAgICAgICAgICAgIGZyYW1lLT5lZGl0b3IoKS0+Y29tbWFuZCgiTW92ZVBhZ2VVcCIpLmV4 ZWN1dGUoKTsKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIGNhc2UgVktfTkVY VDogIC8vIFBhZ2VEb3duCi0gICAgICAgICAgICAgICAgZnJhbWUtPmVkaXRvcigpLT5jb21tYW5k KCJNb3ZlUGFnZURvd24iKS5leGVjdXRlKCk7CisgICAgICAgICAgICAgICAgaWYgKGtldmVudC0+ c2hpZnRLZXkoKSkKKyAgICAgICAgICAgICAgICAgICAgZnJhbWUtPmVkaXRvcigpLT5jb21tYW5k KCJNb3ZlUGFnZURvd25BbmRNb2RpZnlTZWxlY3Rpb24iKS5leGVjdXRlKCk7CisgICAgICAgICAg ICAgICAgZWxzZQorICAgICAgICAgICAgICAgICAgICBmcmFtZS0+ZWRpdG9yKCktPmNvbW1hbmQo Ik1vdmVQYWdlRG93biIpLmV4ZWN1dGUoKTsKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAg ICAgICAgIGNhc2UgVktfVEFCOgogICAgICAgICAgICAgICAgIHJldHVybjsK