31164 2009-11-05 05:02:23 -0800 [Qt] [DRT] Fix wrong logic in LayoutTestController processWork 2009-11-08 19:13:04 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Qt P2 Normal --- 30573 1 tonikitoo tonikitoo oldest_to_newest 160793 0 tonikitoo 2009-11-05 05:02:23 -0800 Qt's DRT logic for processing the WorkQueue is working differently from other DRT ports (e.g. mac, gtk and win): void LayoutTestController::processWork() (..) if (!WorkQueue::shared()->processWork() && !shouldWaitUntilDone()) { emit done(); notice the first "!". It makes queue processing stop when if should proceed ('true' here means that queue is done and we are ok to finish). 160794 1 tonikitoo 2009-11-05 05:03:01 -0800 for reference: GTK: static gboolean processWork(void* data) { // if we finish all the commands, we're ready to dump state if (WorkQueue::shared()->processWork() && !gLayoutTestController->waitToDump()) dump(); WIN: void FrameLoadDelegate::processWork() { (...) // if we finish all the commands, we're ready to dump state if (WorkQueue::shared()->processWork() && !::gLayoutTestController->waitToDump()) dump(); MAC: - (void)processWork:(id)dummy { (...) // if we finish all the commands, we're ready to dump state if (WorkQueue::shared()->processWork() && !gLayoutTestController->waitToDump()) dump(); 160795 2 42560 tonikitoo 2009-11-05 05:09:53 -0800 Created attachment 42560 (committed in r50622) patch patch make LayoutTestController::proccessWork to dump whole if WorkQueue returns 'true' it makes qt compliant to other drt's (mac, win, gtk) 161318 3 42560 zecke 2009-11-07 00:32:56 -0800 Comment on attachment 42560 (committed in r50622) patch Seems plausible. 161416 4 tonikitoo 2009-11-08 09:27:46 -0800 r50622 42560 2009-11-05 05:09:53 -0800 2009-11-08 09:28:56 -0800 (committed in r50622) patch 0001--Qt-DRT-Fix-wrong-logic-in-LayoutTestController-p.patch text/plain 2159 tonikitoo RnJvbSA5ODZmOTBmNTU1MjE2ZTUxMDNhZThkOTFhZjE0Nzc0ZmJjMzEyNDdmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogVGh1LCA1IE5vdiAyMDA5IDA5OjA1OjIwIC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gW1F0 XSBbRFJUXSBGaXggd3JvbmcgbG9naWMgaW4gTGF5b3V0VGVzdENvbnRyb2xsZXIgcHJvY2Vzc1dv cmsKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTE2NAoKUGF0Y2gg YnkgQW50b25pbyBHb21lcyA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+IG9uIDIwMDktMTEtMDUKUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpGaXhlZCB3cm9uZyBsb2dpYyB0byBhc3N1bWUgV29y a1F1ZXVlIGlzIGRvbmUgaW4gUVQncyBEUlQuCgoqIER1bXBSZW5kZXJUcmVlL3F0L0xheW91dFRl c3RDb250cm9sbGVyUXQuY3BwOgooTGF5b3V0VGVzdENvbnRyb2xsZXI6OnByb2Nlc3NXb3JrKToK LS0tCiBXZWJLaXRUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8 ICAgMTIgKysrKysrKysrKysrCiAuLi4vRHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0VGVzdENvbnRy b2xsZXJRdC5jcHAgICB8ICAgIDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cgYi9X ZWJLaXRUb29scy9DaGFuZ2VMb2cKaW5kZXggOGFmYWQ0Yy4uNmVlYTc0OCAxMDA2NDQKLS0tIGEv V2ViS2l0VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwpAQCAtMiw2 ICsyLDE4IEBACiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCiAKKyAgICAg ICAgW1F0XSBbRFJUXSBGaXggd3JvbmcgbG9naWMgaW4gTGF5b3V0VGVzdENvbnRyb2xsZXIgcHJv Y2Vzc1dvcmsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTMxMTY0CisKKyAgICAgICAgRml4ZWQgd3JvbmcgbG9naWMgdG8gYXNzdW1lIFdvcmtRdWV1ZSBp cyBkb25lIGluIFFUJ3MgRFJULgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0 VGVzdENvbnRyb2xsZXJRdC5jcHA6CisgICAgICAgIChMYXlvdXRUZXN0Q29udHJvbGxlcjo6cHJv Y2Vzc1dvcmspOgorCisyMDA5LTExLTA1ICBBbnRvbmlvIEdvbWVzICA8dG9uaWtpdG9vQHdlYmtp dC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAgICAgICAg W1F0XVtEUlRdIFJlcGxhY2UgcXVldWVTY3JpcHQgYnkgcXVldWVOb25Mb2FkaW5nU2NyaXB0IGFu ZCBxdWV1ZUxvYWRpbmdTY3JpcHQgbWV0aG9kCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zMTE1OAogCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1w UmVuZGVyVHJlZS9xdC9MYXlvdXRUZXN0Q29udHJvbGxlclF0LmNwcCBiL1dlYktpdFRvb2xzL0R1 bXBSZW5kZXJUcmVlL3F0L0xheW91dFRlc3RDb250cm9sbGVyUXQuY3BwCmluZGV4IDAwYTYwODEu LjgzMTFkOTEgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0xheW91 dFRlc3RDb250cm9sbGVyUXQuY3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0 L0xheW91dFRlc3RDb250cm9sbGVyUXQuY3BwCkBAIC03Myw3ICs3Myw3IEBAIHZvaWQgTGF5b3V0 VGVzdENvbnRyb2xsZXI6OnByb2Nlc3NXb3JrKCkKICAgICAvLyBxRGVidWcoKSA8PCAiPj4+cHJv Y2Vzc1dvcmsiOwogCiAgICAgLy8gaWYgd2UgZGlkbid0IHN0YXJ0IGEgbmV3IGxvYWQsIHRoZW4g d2UgZmluaXNoZWQgYWxsIHRoZSBjb21tYW5kcywgc28gd2UncmUgcmVhZHkgdG8gZHVtcCBzdGF0 ZQotICAgIGlmICghV29ya1F1ZXVlOjpzaGFyZWQoKS0+cHJvY2Vzc1dvcmsoKSAmJiAhc2hvdWxk V2FpdFVudGlsRG9uZSgpKSB7CisgICAgaWYgKFdvcmtRdWV1ZTo6c2hhcmVkKCktPnByb2Nlc3NX b3JrKCkgJiYgIXNob3VsZFdhaXRVbnRpbERvbmUoKSkgewogICAgICAgICBlbWl0IGRvbmUoKTsK ICAgICAgICAgbV9pc0xvYWRpbmcgPSBmYWxzZTsKICAgICB9Ci0tIAoxLjYuMC40Cgo=