31159 2009-11-05 03:09:02 -0800 Fix branchDouble behaviour on ARM JIT. 2009-11-05 23:29:23 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 31050 0 zherczeg webkit-unassigned barraclough loki ossy oldest_to_newest 160778 0 zherczeg 2009-11-05 03:09:02 -0800 BranchDouble behaviour is reworked on x86, and all jit ports should follow the new, clean behaviour See bug 31104 and bug 31151 160802 1 42565 zherczeg 2009-11-05 05:59:25 -0800 Created attachment 42565 proposed patch 161001 2 42565 barraclough 2009-11-05 15:44:20 -0800 Comment on attachment 42565 proposed patch Huh, I guess I just don't think like an ARM programmer yet - hadn't thought of the predicated compare, that's neat, will be stealing that for ARMv7 too. ;-) r+. 161094 3 ossy 2009-11-05 23:29:23 -0800 (In reply to comment #2) Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/assembler/ARMAssembler.h Sending JavaScriptCore/assembler/MacroAssemblerARM.h Transmitting file data ... Committed revision 50593. 42565 2009-11-05 05:59:25 -0800 2009-11-05 15:44:19 -0800 proposed patch 0001-branchDouble-for-ARM.patch text/plain 6017 zherczeg RnJvbSAxYTFkNTM3MDdmNjZlMzE2MmQ4NjUwNzJkMWZjMjMyNDQ2ZjI2Y2FmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAaW5mLnUtc3plZ2Vk Lmh1PgpEYXRlOiBUaHUsIDUgTm92IDIwMDkgMTI6MTQ6MjEgKzAxMDAKU3ViamVjdDogW1BBVENI XSBicmFuY2hEb3VibGUgZm9yIEFSTQoKU2lnbmVkLW9mZi1ieTogWm9sdGFuIEhlcmN6ZWcgPHpo ZXJjemVnQGluZi51LXN6ZWdlZC5odT4KLS0tCiBKYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAg ICAgICAgICAgICAgICAgICB8ICAgMjEgKysrKysrKysrKysrKysrCiBKYXZhU2NyaXB0Q29yZS9h c3NlbWJsZXIvQVJNQXNzZW1ibGVyLmggICAgICB8ICAgMTIgKysrKysrKysrCiBKYXZhU2NyaXB0 Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaCB8ICAgMzUgKysrKysrKysrKysrKysr KysrKysrKysrLQogMyBmaWxlcyBjaGFuZ2VkLCA2NiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwppbmRleCAzZTBhYTE4Li4wZTQ4MTQzIDEwMDY0NAotLS0gYS9KYXZhU2Ny aXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMjQgQEAKKzIwMDktMTEtMDUgIFpvbHRhbiBIZXJjemVnICA8emhlcmN6ZWdAaW5mLnUtc3pl Z2VkLmh1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTE1OQorICAgICAgICBG aXggYnJhbmNoRG91YmxlIGJlaGF2aW91ciBvbiBBUk0gVEhVTUIyIEpJVC4KKworICAgICAgICBU aGUgeDg2IGJyYW5jaERvdWJsZSBiZWhhdmlvdXIgaXMgcmV3b3JrZWQsIGFuZCBhbGwgSklUCisg ICAgICAgIHBvcnRzIHNob3VsZCBmb2xsb3cgdGhlIHg4NiBwb3J0LiBTZWUgYnVnIDMxMTA0IGFu ZCAzMTE1MQorCisgICAgICAgIFRoaXMgcGF0Y2ggY29udGFpbnMgYSBmaXggZm9yIHRoZSB0cmFk aXRpb25hbCBBUk0gcG9ydAorCisgICAgICAgICogYXNzZW1ibGVyL0FSTUFzc2VtYmxlci5oOgor ICAgICAgICAoSlNDOjpBUk1Bc3NlbWJsZXI6Oik6CisgICAgICAgIChKU0M6OkFSTUFzc2VtYmxl cjo6Zm1yc19yKToKKyAgICAgICAgKEpTQzo6QVJNQXNzZW1ibGVyOjpmdG9zaWRfcik6CisgICAg ICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmg6CisgICAgICAgIChKU0M6Ok1hY3Jv QXNzZW1ibGVyQVJNOjopOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlckFSTTo6YnJhbmNo RG91YmxlKToKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJBUk06OmJyYW5jaENvbnZlcnRE b3VibGVUb0ludDMyKToKKwogMjAwOS0xMS0wNSAgR2Fib3IgTG9raSAgPGxva2lAaW5mLnUtc3pl Z2VkLmh1PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdhdmluIEJhcnJhY2xvdWdoLgpkaWZmIC0t Z2l0IGEvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTUFzc2VtYmxlci5oIGIvSmF2YVNjcmlw dENvcmUvYXNzZW1ibGVyL0FSTUFzc2VtYmxlci5oCmluZGV4IGY5ZTMwZGYuLjZhODY3MzQgMTAw NjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk1Bc3NlbWJsZXIuaAorKysgYi9K YXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJNQXNzZW1ibGVyLmgKQEAgLTEzMyw3ICsxMzMsOSBA QCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgICAgIEIgPSAweDBhMDAwMDAwLAogICAgICAgICAg ICAgQkwgPSAweDBiMDAwMDAwLAogICAgICAgICAgICAgRk1TUiA9IDB4MGUwMDBhMTAsCisgICAg ICAgICAgICBGTVJTID0gMHgwZTEwMGExMCwKICAgICAgICAgICAgIEZTSVRPRCA9IDB4MGViODBi YzAsCisgICAgICAgICAgICBGVE9TSUQgPSAweDBlYmQwYjQwLAogICAgICAgICAgICAgRk1TVEFU ID0gMHgwZWYxZmExMCwKICNpZiBBUk1fQVJDSF9WRVJTSU9OID49IDUKICAgICAgICAgICAgIENM WiA9IDB4MDE2ZjBmMTAsCkBAIC01MDIsMTEgKzUwNCwyMSBAQCBuYW1lc3BhY2UgSlNDIHsKICAg ICAgICAgICAgIGVtaXRJbnN0KHN0YXRpY19jYXN0PEFSTVdvcmQ+KGNjKSB8IEZNU1IsIHJuLCBk ZCwgMCk7CiAgICAgICAgIH0KIAorICAgICAgICB2b2lkIGZtcnNfcihpbnQgZGQsIGludCBybiwg Q29uZGl0aW9uIGNjID0gQUwpCisgICAgICAgIHsKKyAgICAgICAgICAgIGVtaXRJbnN0KHN0YXRp Y19jYXN0PEFSTVdvcmQ+KGNjKSB8IEZNUlMsIHJuLCBkZCwgMCk7CisgICAgICAgIH0KKwogICAg ICAgICB2b2lkIGZzaXRvZF9yKGludCBkZCwgaW50IGRtLCBDb25kaXRpb24gY2MgPSBBTCkKICAg ICAgICAgewogICAgICAgICAgICAgZW1pdEluc3Qoc3RhdGljX2Nhc3Q8QVJNV29yZD4oY2MpIHwg RlNJVE9ELCBkZCwgMCwgZG0pOwogICAgICAgICB9CiAKKyAgICAgICAgdm9pZCBmdG9zaWRfcihp bnQgZmQsIGludCBkbSwgQ29uZGl0aW9uIGNjID0gQUwpCisgICAgICAgIHsKKyAgICAgICAgICAg IGVtaXRJbnN0KHN0YXRpY19jYXN0PEFSTVdvcmQ+KGNjKSB8IEZUT1NJRCwgZmQsIDAsIGRtKTsK KyAgICAgICAgfQorCiAgICAgICAgIHZvaWQgZm1zdGF0KENvbmRpdGlvbiBjYyA9IEFMKQogICAg ICAgICB7CiAgICAgICAgICAgICBtX2J1ZmZlci5wdXRJbnQoc3RhdGljX2Nhc3Q8QVJNV29yZD4o Y2MpIHwgRk1TVEFUKTsKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNy b0Fzc2VtYmxlckFSTS5oIGIvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVy QVJNLmgKaW5kZXggYTA2Nzk3ZS4uMzRhZWEyMCAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUv YXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmgKKysrIGIvSmF2YVNjcmlwdENvcmUvYXNzZW1i bGVyL01hY3JvQXNzZW1ibGVyQVJNLmgKQEAgLTM4LDYgKzM4LDkgQEAKIG5hbWVzcGFjZSBKU0Mg ewogCiBjbGFzcyBNYWNyb0Fzc2VtYmxlckFSTSA6IHB1YmxpYyBBYnN0cmFjdE1hY3JvQXNzZW1i bGVyPEFSTUFzc2VtYmxlcj4geworICAgIHN0YXRpYyBjb25zdCBpbnQgRG91YmxlQ29uZGl0aW9u TWFzayA9IDB4MGY7CisgICAgc3RhdGljIGNvbnN0IGludCBEb3VibGVDb25kaXRpb25CaXRTcGVj aWFsID0gMHgxMDsKKyAgICBDT01QSUxFX0FTU0VSVCghKERvdWJsZUNvbmRpdGlvbkJpdFNwZWNp YWwgJiBEb3VibGVDb25kaXRpb25NYXNrKSwgRG91YmxlQ29uZGl0aW9uQml0U3BlY2lhbF9zaG91 bGRfbm90X2ludGVyZmVyZV93aXRoX0FSTUFzc2VtYmxlcl9Db25kaXRpb25fY29kZXMpOwogcHVi bGljOgogICAgIGVudW0gQ29uZGl0aW9uIHsKICAgICAgICAgRXF1YWwgPSBBUk1Bc3NlbWJsZXI6 OkVRLApAQCAtNTcsOSArNjAsMTggQEAgcHVibGljOgogICAgIH07CiAKICAgICBlbnVtIERvdWJs ZUNvbmRpdGlvbiB7Ci0gICAgICAgIERvdWJsZUVxdWFsT3JVbm9yZGVyZWQgPSBBUk1Bc3NlbWJs ZXI6OkVRLAorICAgICAgICAvLyBUaGVzZSBjb25kaXRpb25zIHdpbGwgb25seSBldmFsdWF0ZSB0 byB0cnVlIGlmIHRoZSBjb21wYXJpc29uIGlzIG9yZGVyZWQgLSBpLmUuIG5laXRoZXIgb3BlcmFu ZCBpcyBOYU4uCisgICAgICAgIERvdWJsZUVxdWFsID0gQVJNQXNzZW1ibGVyOjpFUSwKKyAgICAg ICAgRG91YmxlTm90RXF1YWwgPSBBUk1Bc3NlbWJsZXI6Ok5FIHwgRG91YmxlQ29uZGl0aW9uQml0 U3BlY2lhbCwKICAgICAgICAgRG91YmxlR3JlYXRlclRoYW4gPSBBUk1Bc3NlbWJsZXI6OkdULAog ICAgICAgICBEb3VibGVHcmVhdGVyVGhhbk9yRXF1YWwgPSBBUk1Bc3NlbWJsZXI6OkdFLAorICAg ICAgICBEb3VibGVMZXNzVGhhbiA9IEFSTUFzc2VtYmxlcjo6Q0MsCisgICAgICAgIERvdWJsZUxl c3NUaGFuT3JFcXVhbCA9IEFSTUFzc2VtYmxlcjo6TFMsCisgICAgICAgIC8vIElmIGVpdGhlciBv cGVyYW5kIGlzIE5hTiwgdGhlc2UgY29uZGl0aW9ucyBhbHdheXMgZXZhbHVhdGUgdG8gdHJ1ZS4K KyAgICAgICAgRG91YmxlRXF1YWxPclVub3JkZXJlZCA9IEFSTUFzc2VtYmxlcjo6RVEgfCBEb3Vi bGVDb25kaXRpb25CaXRTcGVjaWFsLAorICAgICAgICBEb3VibGVOb3RFcXVhbE9yVW5vcmRlcmVk ID0gQVJNQXNzZW1ibGVyOjpORSwKKyAgICAgICAgRG91YmxlR3JlYXRlclRoYW5PclVub3JkZXJl ZCA9IEFSTUFzc2VtYmxlcjo6SEksCisgICAgICAgIERvdWJsZUdyZWF0ZXJUaGFuT3JFcXVhbE9y VW5vcmRlcmVkID0gQVJNQXNzZW1ibGVyOjpDUywKICAgICAgICAgRG91YmxlTGVzc1RoYW5PclVu b3JkZXJlZCA9IEFSTUFzc2VtYmxlcjo6TFQsCiAgICAgICAgIERvdWJsZUxlc3NUaGFuT3JFcXVh bE9yVW5vcmRlcmVkID0gQVJNQXNzZW1ibGVyOjpMRSwKICAgICB9OwpAQCAtNzE0LDcgKzcyNiw5 IEBAIHB1YmxpYzoKICAgICB7CiAgICAgICAgIG1fYXNzZW1ibGVyLmZjbXBkX3IobGVmdCwgcmln aHQpOwogICAgICAgICBtX2Fzc2VtYmxlci5mbXN0YXQoKTsKLSAgICAgICAgcmV0dXJuIEp1bXAo bV9hc3NlbWJsZXIuam1wKHN0YXRpY19jYXN0PEFSTUFzc2VtYmxlcjo6Q29uZGl0aW9uPihjb25k KSkpOworICAgICAgICBpZiAoY29uZCAmIERvdWJsZUNvbmRpdGlvbkJpdFNwZWNpYWwpCisgICAg ICAgICAgICBtX2Fzc2VtYmxlci5jbXBfcihBUk1SZWdpc3RlcnM6OlMwLCBBUk1SZWdpc3RlcnM6 OlMwLCBBUk1Bc3NlbWJsZXI6OlZTKTsKKyAgICAgICAgcmV0dXJuIEp1bXAobV9hc3NlbWJsZXIu am1wKHN0YXRpY19jYXN0PEFSTUFzc2VtYmxlcjo6Q29uZGl0aW9uPihjb25kICYgfkRvdWJsZUNv bmRpdGlvbk1hc2spKSk7CiAgICAgfQogCiAgICAgLy8gVHJ1bmNhdGVzICdzcmMnIHRvIGFuIGlu dGVnZXIsIGFuZCBwbGFjZXMgdGhlIHJlc3VsdGluZyAnZGVzdCcuCkBAIC03MjksNiArNzQzLDIz IEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuIGp1bXAoKTsKICAgICB9CiAKKyAgICAvLyBDb252 ZXJ0ICdzcmMnIHRvIGFuIGludGVnZXIsIGFuZCBwbGFjZXMgdGhlIHJlc3VsdGluZyAnZGVzdCcu CisgICAgLy8gSWYgdGhlIHJlc3VsdCBpcyBub3QgcmVwcmVzZW50YWJsZSBhcyBhIDMyIGJpdCB2 YWx1ZSwgYnJhbmNoLgorICAgIC8vIE1heSBhbHNvIGJyYW5jaCBmb3Igc29tZSB2YWx1ZXMgdGhh dCBhcmUgcmVwcmVzZW50YWJsZSBpbiAzMiBiaXRzCisgICAgLy8gKHNwZWNpZmljYWxseSwgaW4g dGhpcyBjYXNlLCAwKS4KKyAgICB2b2lkIGJyYW5jaENvbnZlcnREb3VibGVUb0ludDMyKEZQUmVn aXN0ZXJJRCBzcmMsIFJlZ2lzdGVySUQgZGVzdCwgSnVtcExpc3QmIGZhaWx1cmVDYXNlcywgRlBS ZWdpc3RlcklEIGZwVGVtcCkKKyAgICB7CisgICAgICAgIG1fYXNzZW1ibGVyLmZ0b3NpZF9yKHNy YywgQVJNUmVnaXN0ZXJzOjpTRDApOworICAgICAgICBtX2Fzc2VtYmxlci5mbXJzX3IoQVJNUmVn aXN0ZXJzOjpTRDAsIGRlc3QpOworCisgICAgICAgIC8vIENvbnZlcnQgdGhlIGludGVnZXIgcmVz dWx0IGJhY2sgdG8gZmxvYXQgJiBjb21wYXJlIHRvIHRoZSBvcmlnaW5hbCB2YWx1ZSAtIGlmIG5v dCBlcXVhbCBvciB1bm9yZGVyZWQgKE5hTikgdGhlbiBqdW1wLgorICAgICAgICBtX2Fzc2VtYmxl ci5mc2l0b2RfcihBUk1SZWdpc3RlcnM6OlNEMCwgQVJNUmVnaXN0ZXJzOjpTRDApOworICAgICAg ICBmYWlsdXJlQ2FzZXMuYXBwZW5kKGJyYW5jaERvdWJsZShEb3VibGVOb3RFcXVhbCwgc3JjLCBB Uk1SZWdpc3RlcnM6OlNEMCkpOworCisgICAgICAgIC8vIElmIHRoZSByZXN1bHQgaXMgemVybywg aXQgbWlnaHQgaGF2ZSBiZWVuIC0wLjAsIGFuZCAwLjAgZXF1YWxzIHRvIC0wLjAKKyAgICAgICAg ZmFpbHVyZUNhc2VzLmFwcGVuZChicmFuY2hUZXN0MzIoWmVybywgZGVzdCkpOworICAgIH0KKwog cHJvdGVjdGVkOgogICAgIEFSTUFzc2VtYmxlcjo6Q29uZGl0aW9uIEFSTUNvbmRpdGlvbihDb25k aXRpb24gY29uZCkKICAgICB7Ci0tIAoxLjYuMC40Cgo=