31152 2009-11-04 21:25:16 -0800 Fix ASSERT(currentStyle = renderStyle()) 2009-11-05 23:26:27 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 yutak webkit-unassigned commit-queue eric oldest_to_newest 160717 0 yutak 2009-11-04 21:25:16 -0800 In WebCore/dom/Element.cpp, line 762: ASSERT(currentStyle = renderStyle()); Clearly this doesn't do what we expected it to do... 160718 1 42545 yutak 2009-11-04 21:32:20 -0800 Created attachment 42545 Fix ASSERT(currentStyle = renderStyle()). 160861 2 42545 ap 2009-11-05 10:20:27 -0800 Comment on attachment 42545 Fix ASSERT(currentStyle = renderStyle()). Wow. r=me The ChangeLog is not in great shape - why repeat the same line twice, for example? Also, the line saying 'We should have used "==" instead of "=". should go after the automatically inserted function name (pseudoStyleCacheIsInvalid), because it describes what was changed in that particular function. 161015 3 yutak 2009-11-05 16:40:38 -0800 Thanks for your comment! I'll be more careful in writing Changelog. 161019 4 42545 eric 2009-11-05 16:45:17 -0800 Comment on attachment 42545 Fix ASSERT(currentStyle = renderStyle()). Actually, cq-. I really think we should fix the ChangeLog before landing this. 161020 5 yutak 2009-11-05 16:48:24 -0800 (In reply to comment #4) > (From update of attachment 42545 [details]) > Actually, cq-. I really think we should fix the ChangeLog before landing this. Thanks. I'll do it. 161069 6 42628 yutak 2009-11-05 21:34:34 -0800 Created attachment 42628 Fix ASSERT(currentStyle = renderStyle()). (v2: Fixed Changelog) 161089 7 42628 eric 2009-11-05 23:04:45 -0800 Comment on attachment 42628 Fix ASSERT(currentStyle = renderStyle()). (v2: Fixed Changelog) Looks great! Thanks for fixing the ChangeLog nit. 161091 8 42628 commit-queue 2009-11-05 23:26:23 -0800 Comment on attachment 42628 Fix ASSERT(currentStyle = renderStyle()). (v2: Fixed Changelog) Clearing flags on attachment: 42628 Committed r50592: <http://trac.webkit.org/changeset/50592> 161092 9 commit-queue 2009-11-05 23:26:27 -0800 All reviewed patches have been landed. Closing bug. 42545 2009-11-04 21:32:20 -0800 2009-11-05 21:34:29 -0800 Fix ASSERT(currentStyle = renderStyle()). bug-31152-20091105143218.patch text/plain 1077 yutak ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MjQ0YzA0NS4uMzE5N2NlYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0xMS0wNCAgWXV0YSBLaXRhbXVy YSAgPHl1dGFrQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGaXggQVNTRVJUKGN1cnJlbnRTdHlsZSA9IHJlbmRlclN0eWxlKCkp LgorICAgICAgICAKKyAgICAgICAgV2Ugc2hvdWxkIGhhdmUgdXNlZCAiPT0iIGluc3RlYWQgb2Yg Ij0iLgorCisgICAgICAgIEZpeCBBU1NFUlQoY3VycmVudFN0eWxlID0gcmVuZGVyU3R5bGUoKSkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxMTUyCisK KyAgICAgICAgKiBkb20vRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50Ojpw c2V1ZG9TdHlsZUNhY2hlSXNJbnZhbGlkKToKKwogMjAwOS0xMS0wNCAgRW5yaWNhIENhc3VjY2kg IDxlbnJpY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkZWxlIFBldGVyc29u LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAgYi9XZWJDb3JlL2RvbS9FbGVt ZW50LmNwcAppbmRleCAyZTdjNDRmLi44NTEzYjI2IDEwMDY0NAotLS0gYS9XZWJDb3JlL2RvbS9F bGVtZW50LmNwcAorKysgYi9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcApAQCAtNzU5LDcgKzc1OSw3 IEBAIHZvaWQgRWxlbWVudDo6ZGV0YWNoKCkKIAogYm9vbCBFbGVtZW50Ojpwc2V1ZG9TdHlsZUNh Y2hlSXNJbnZhbGlkKGNvbnN0IFJlbmRlclN0eWxlKiBjdXJyZW50U3R5bGUsIFJlbmRlclN0eWxl KiBuZXdTdHlsZSkKIHsKLSAgICBBU1NFUlQoY3VycmVudFN0eWxlID0gcmVuZGVyU3R5bGUoKSk7 CisgICAgQVNTRVJUKGN1cnJlbnRTdHlsZSA9PSByZW5kZXJTdHlsZSgpKTsKIAogICAgIGlmICgh cmVuZGVyZXIoKSB8fCAhY3VycmVudFN0eWxlKQogICAgICAgICByZXR1cm4gZmFsc2U7 42628 2009-11-05 21:34:34 -0800 2009-11-05 23:26:23 -0800 Fix ASSERT(currentStyle = renderStyle()). (v2: Fixed Changelog) bug-31152-20091106143433.patch text/plain 1005 yutak ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDQxMWEyMy4uMmVjNzRiZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0xMS0wNSAgWXV0YSBLaXRhbXVy YSAgPHl1dGFrQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGaXggQVNTRVJUKGN1cnJlbnRTdHlsZSA9IHJlbmRlclN0eWxlKCkp LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzExNTIK KworICAgICAgICAqIGRvbS9FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnQ6 OnBzZXVkb1N0eWxlQ2FjaGVJc0ludmFsaWQpOiBXZSBzaG91bGQgaGF2ZSB1c2VkICI9PSIgaW5z dGVhZCBvZiAiPSIuCisKIDIwMDktMTEtMDUgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9kb20vRWxlbWVudC5jcHAgYi9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAppbmRleCAy ZTdjNDRmLi44NTEzYjI2IDEwMDY0NAotLS0gYS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAorKysg Yi9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcApAQCAtNzU5LDcgKzc1OSw3IEBAIHZvaWQgRWxlbWVu dDo6ZGV0YWNoKCkKIAogYm9vbCBFbGVtZW50Ojpwc2V1ZG9TdHlsZUNhY2hlSXNJbnZhbGlkKGNv bnN0IFJlbmRlclN0eWxlKiBjdXJyZW50U3R5bGUsIFJlbmRlclN0eWxlKiBuZXdTdHlsZSkKIHsK LSAgICBBU1NFUlQoY3VycmVudFN0eWxlID0gcmVuZGVyU3R5bGUoKSk7CisgICAgQVNTRVJUKGN1 cnJlbnRTdHlsZSA9PSByZW5kZXJTdHlsZSgpKTsKIAogICAgIGlmICghcmVuZGVyZXIoKSB8fCAh Y3VycmVudFN0eWxlKQogICAgICAgICByZXR1cm4gZmFsc2U7