31145 2009-11-04 16:45:15 -0800 Need notification of scrolling frame 2009-11-05 15:09:01 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sky webkit-unassigned commit-queue fishd mitz sam oldest_to_newest 160660 0 sky 2009-11-04 16:45:15 -0800 The notification will be used to know when history state is out of date. 160661 1 42532 sky 2009-11-04 16:47:08 -0800 Created attachment 42532 Adds FrameLoaderClient::didChangeScrollOffset 160677 2 sam 2009-11-04 17:59:58 -0800 Can you please explain what you mean by the "history state is out of date"? 160745 3 fishd 2009-11-04 23:21:46 -0800 The frame's current scroll offset is a property of HistoryItem. However that field is only updated when HistoryController::saveDocumentAndScrollState() is called, which does not ordinarily happen when a frame scrolls. Chromium needs a way to know when the scroll offset for any frame has changed, so that it can schedule a call to saveDocumentAndScrollState(). Our objective is to use this as a signal to save session information for Chromium's session restore feature. 160746 4 42532 fishd 2009-11-04 23:22:55 -0800 Comment on attachment 42532 Adds FrameLoaderClient::didChangeScrollOffset > Index: WebCore/ChangeLog .. > + Reviewed by NOBODY (OOPS!). > + > + Adds FrameLoaderClient::didChangeScrollOffset that is called when > + the frame scrolls. This will be used to know when history state > + needs to be updated. ^^^ fix the indentation please include a link to this bug. delete the line below: > + No new tests. LGTM otherwise 160828 5 42571 sky 2009-11-05 07:56:14 -0800 Created attachment 42571 Revised patch 160829 6 sky 2009-11-05 07:57:08 -0800 Sam, sorry for not being clear on why I want to add this. Darin, thanks for clarifying! 160940 7 42571 dglazkov 2009-11-05 13:46:20 -0800 Comment on attachment 42571 Revised patch r=me per Darin's comments. 160968 8 42571 commit-queue 2009-11-05 15:08:55 -0800 Comment on attachment 42571 Revised patch Clearing flags on attachment: 42571 Committed r50580: <http://trac.webkit.org/changeset/50580> 160969 9 commit-queue 2009-11-05 15:09:01 -0800 All reviewed patches have been landed. Closing bug. 42532 2009-11-04 16:47:08 -0800 2009-11-05 07:56:14 -0800 Adds FrameLoaderClient::didChangeScrollOffset patch text/plain 1860 sky SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDUzNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMTEtMDQgIFNjb3R0IFZpb2xldCAgPHNreUBnb29nbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZHMg RnJhbWVMb2FkZXJDbGllbnQ6OmRpZENoYW5nZVNjcm9sbE9mZnNldCB0aGF0IGlzIGNhbGxlZCB3 aGVuCisJdGhlIGZyYW1lIHNjcm9sbHMuIFRoaXMgd2lsbCBiZSB1c2VkIHRvIGtub3cgd2hlbiBo aXN0b3J5IHN0YXRlCisJbmVlZHMgdG8gYmUgdXBkYXRlZC4KKworICAgICAgICBObyBuZXcgdGVz dHMuCisKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXJDbGllbnQuaDoKKyAgICAgICAgKFdl YkNvcmU6OkZyYW1lTG9hZGVyQ2xpZW50OjpkaWRDaGFuZ2VTY3JvbGxPZmZzZXQpOgorICAgICAg ICAqIHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6dmFs dWVDaGFuZ2VkKToKKwogMjAwOS0xMS0wNCAgSmVubiBCcmFpdGh3YWl0ZSAgPGplbm5iQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBMZXZpbi4KSW5kZXg6IFdlYkNv cmUvbG9hZGVyL0ZyYW1lTG9hZGVyQ2xpZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9sb2Fk ZXIvRnJhbWVMb2FkZXJDbGllbnQuaAkocmV2aXNpb24gNTA1MzIpCisrKyBXZWJDb3JlL2xvYWRl ci9GcmFtZUxvYWRlckNsaWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNDcsNiArMjQ3LDggQEAg bmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICB2aXJ0dWFsIGJvb2wgc2hvdWxkVXNlUGx1Z2lu RG9jdW1lbnQoY29uc3QgU3RyaW5nJiAvKm1pbWVUeXBlKi8pIGNvbnN0IHsgcmV0dXJuIGZhbHNl OyB9CiAgICAgICAgIHZpcnR1YWwgYm9vbCBzaG91bGRMb2FkTWVkaWFFbGVtZW50VVJMKGNvbnN0 IEtVUkwmKSBjb25zdCB7IHJldHVybiB0cnVlOyB9CiAKKyAgICAgICAgdmlydHVhbCB2b2lkIGRp ZENoYW5nZVNjcm9sbE9mZnNldCgpIHsgfQorCiAgICAgICAgIHZpcnR1YWwgYm9vbCBhbGxvd0ph dmFTY3JpcHQoYm9vbCBlbmFibGVkUGVyU2V0dGluZ3MpIHsgcmV0dXJuIGVuYWJsZWRQZXJTZXR0 aW5nczsgfQogICAgIH07CiAKSW5kZXg6IFdlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCShyZXZpc2lvbiA1MDUzMikKKysr IFdlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDUwLDYgKzE0 NTAsNyBAQCB2b2lkIEZyYW1lVmlldzo6dmFsdWVDaGFuZ2VkKFNjcm9sbGJhciogCiAgICAgU2Ny b2xsVmlldzo6dmFsdWVDaGFuZ2VkKGJhcik7CiAgICAgaWYgKG9mZnNldCAhPSBzY3JvbGxPZmZz ZXQoKSkKICAgICAgICAgZnJhbWUoKS0+ZXZlbnRIYW5kbGVyKCktPnNlbmRTY3JvbGxFdmVudCgp OworICAgIGZyYW1lKCktPmxvYWRlcigpLT5jbGllbnQoKS0+ZGlkQ2hhbmdlU2Nyb2xsT2Zmc2V0 KCk7CiB9CiAKIHZvaWQgRnJhbWVWaWV3OjppbnZhbGlkYXRlU2Nyb2xsYmFyUmVjdChTY3JvbGxi YXIqIHNjcm9sbGJhciwgY29uc3QgSW50UmVjdCYgcmVjdCkK 42571 2009-11-05 07:56:14 -0800 2009-11-05 15:08:55 -0800 Revised patch patch text/plain 1952 sky SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDUzNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDktMTEtMDQgIFNjb3R0IFZpb2xldCAgPHNreUBnb29nbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5lZWQg bm90aWZpY2F0aW9uIG9mIHNjcm9sbGluZyBmcmFtZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzExNDUKKworICAgICAgICBBZGRzIEZyYW1lTG9hZGVy Q2xpZW50OjpkaWRDaGFuZ2VTY3JvbGxPZmZzZXQgdGhhdCBpcyBjYWxsZWQgd2hlbgorICAgICAg ICB0aGUgZnJhbWUgc2Nyb2xscy4gVGhpcyB3aWxsIGJlIHVzZWQgdG8ga25vdyB3aGVuIGhpc3Rv cnkgc3RhdGUKKyAgICAgICAgbmVlZHMgdG8gYmUgdXBkYXRlZC4KKworICAgICAgICAqIGxvYWRl ci9GcmFtZUxvYWRlckNsaWVudC5oOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXJDbGll bnQ6OmRpZENoYW5nZVNjcm9sbE9mZnNldCk6CisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3Ojp2YWx1ZUNoYW5nZWQpOgorCiAyMDA5LTEx LTA0ICBKZW5uIEJyYWl0aHdhaXRlICA8amVubmJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IERhdmlkIExldmluLgpJbmRleDogV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXJD bGllbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlckNsaWVudC5o CShyZXZpc2lvbiA1MDUzMikKKysrIFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyQ2xpZW50LmgJ KHdvcmtpbmcgY29weSkKQEAgLTI0Nyw2ICsyNDcsOCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAg ICAgICAgIHZpcnR1YWwgYm9vbCBzaG91bGRVc2VQbHVnaW5Eb2N1bWVudChjb25zdCBTdHJpbmcm IC8qbWltZVR5cGUqLykgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KICAgICAgICAgdmlydHVhbCBi b29sIHNob3VsZExvYWRNZWRpYUVsZW1lbnRVUkwoY29uc3QgS1VSTCYpIGNvbnN0IHsgcmV0dXJu IHRydWU7IH0KIAorICAgICAgICB2aXJ0dWFsIHZvaWQgZGlkQ2hhbmdlU2Nyb2xsT2Zmc2V0KCkg eyB9CisKICAgICAgICAgdmlydHVhbCBib29sIGFsbG93SmF2YVNjcmlwdChib29sIGVuYWJsZWRQ ZXJTZXR0aW5ncykgeyByZXR1cm4gZW5hYmxlZFBlclNldHRpbmdzOyB9CiAgICAgfTsKIApJbmRl eDogV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdl L0ZyYW1lVmlldy5jcHAJKHJldmlzaW9uIDUwNTMyKQorKysgV2ViQ29yZS9wYWdlL0ZyYW1lVmll dy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0NTAsNiArMTQ1MCw3IEBAIHZvaWQgRnJhbWVWaWV3 Ojp2YWx1ZUNoYW5nZWQoU2Nyb2xsYmFyKiAKICAgICBTY3JvbGxWaWV3Ojp2YWx1ZUNoYW5nZWQo YmFyKTsKICAgICBpZiAob2Zmc2V0ICE9IHNjcm9sbE9mZnNldCgpKQogICAgICAgICBmcmFtZSgp LT5ldmVudEhhbmRsZXIoKS0+c2VuZFNjcm9sbEV2ZW50KCk7CisgICAgZnJhbWUoKS0+bG9hZGVy KCktPmNsaWVudCgpLT5kaWRDaGFuZ2VTY3JvbGxPZmZzZXQoKTsKIH0KIAogdm9pZCBGcmFtZVZp ZXc6OmludmFsaWRhdGVTY3JvbGxiYXJSZWN0KFNjcm9sbGJhciogc2Nyb2xsYmFyLCBjb25zdCBJ bnRSZWN0JiByZWN0KQo=