31143 2009-11-04 15:13:44 -0800 Assertion failure in CredentialStorage::set() when proxy credentials are being set 2009-11-04 15:49:00 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All RESOLVED FIXED P4 Normal --- 1 ap ap oldest_to_newest 160626 0 ap 2009-11-04 15:13:44 -0800 These fail when url is null, and url is null for proxy credentials. ASSERT(url.protocolInHTTPFamily()); ASSERT(url.isValid()); 160631 1 42529 ap 2009-11-04 15:23:56 -0800 Created attachment 42529 proposed fix 160637 2 ap 2009-11-04 15:49:00 -0800 Committed <http://trac.webkit.org/changeset/50530>. 42529 2009-11-04 15:23:56 -0800 2009-11-04 15:42:37 -0800 proposed fix ProxyCredential.txt text/plain 2588 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDUyOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMTEtMDQgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxMTQzCisgICAgICAgIEFz c2VydGlvbiBmYWlsdXJlIGluIENyZWRlbnRpYWxTdG9yYWdlOjpzZXQoKSB3aGVuIHByb3h5IGNy ZWRlbnRpYWxzIGFyZSBiZWluZyBzZXQKKworICAgICAgICBObyB0ZXN0LCBjYW5ub3QgdGVzdCBw cm94eSBiZWhhdmlvci4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvQ3JlZGVudGlhbFN0 b3JhZ2UuY3BwOiAoV2ViQ29yZTo6Q3JlZGVudGlhbFN0b3JhZ2U6OnNldCk6IEFjY291bnQgZm9y IHRoZQorICAgICAgICBwb3NzaWJpbGl0eSBvZiBudWxsIHVybC4gUmVsZWFzZSBtb2RlIGNoYW5n ZXMgYXJlIGxpa2VseSBpbmNvbnNlcXVlbnRpYWwgLSBlLmcuIHdlIHVzZWQgdG8KKyAgICAgICAg YWRkICI6Ly8iIHRvIG9yaWdpbiBzZXQsIHdoaWNoIGlzIHdlaXJkLCBidXQgc2FmZS4KKwogMjAw OS0xMS0wNCAgUGF0cmljayBNdWVsbGVyICA8UGF0cmlja19NdWVsbGVyQHVzLmlibS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgVGltb3RoeSBIYXRjaGVyLgpJbmRleDogV2ViQ29yZS9wbGF0 Zm9ybS9uZXR3b3JrL0NyZWRlbnRpYWxTdG9yYWdlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvQ3JlZGVudGlhbFN0b3JhZ2UuY3BwCShyZXZpc2lvbiA1MDUxNSkK KysrIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9DcmVkZW50aWFsU3RvcmFnZS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTg1LDE2ICs4NSwxOCBAQCBzdGF0aWMgU3RyaW5nIHByb3RlY3Rpb25TcGFj ZU1hcEtleUZyb21VCiAKIHZvaWQgQ3JlZGVudGlhbFN0b3JhZ2U6OnNldChjb25zdCBDcmVkZW50 aWFsJiBjcmVkZW50aWFsLCBjb25zdCBQcm90ZWN0aW9uU3BhY2UmIHByb3RlY3Rpb25TcGFjZSwg Y29uc3QgS1VSTCYgdXJsKQogewotICAgIEFTU0VSVCh1cmwucHJvdG9jb2xJbkhUVFBGYW1pbHko KSk7Ci0gICAgQVNTRVJUKHVybC5pc1ZhbGlkKCkpOworICAgIEFTU0VSVChwcm90ZWN0aW9uU3Bh Y2UuaXNQcm94eSgpIHx8IHVybC5wcm90b2NvbEluSFRUUEZhbWlseSgpKTsKKyAgICBBU1NFUlQo cHJvdGVjdGlvblNwYWNlLmlzUHJveHkoKSB8fCB1cmwuaXNWYWxpZCgpKTsKIAogICAgIHByb3Rl Y3Rpb25TcGFjZVRvQ3JlZGVudGlhbE1hcCgpLnNldChwcm90ZWN0aW9uU3BhY2UsIGNyZWRlbnRp YWwpOwotICAgIG9yaWdpbnNXaXRoQ3JlZGVudGlhbHMoKS5hZGQob3JpZ2luU3RyaW5nRnJvbVVS TCh1cmwpKTsKKyAgICBpZiAoIXByb3RlY3Rpb25TcGFjZS5pc1Byb3h5KCkpIHsKKyAgICAgICAg b3JpZ2luc1dpdGhDcmVkZW50aWFscygpLmFkZChvcmlnaW5TdHJpbmdGcm9tVVJMKHVybCkpOwog Ci0gICAgUHJvdGVjdGlvblNwYWNlQXV0aGVudGljYXRpb25TY2hlbWUgc2NoZW1lID0gcHJvdGVj dGlvblNwYWNlLmF1dGhlbnRpY2F0aW9uU2NoZW1lKCk7Ci0gICAgaWYgKHNjaGVtZSA9PSBQcm90 ZWN0aW9uU3BhY2VBdXRoZW50aWNhdGlvblNjaGVtZUhUVFBCYXNpYyB8fCBzY2hlbWUgPT0gUHJv dGVjdGlvblNwYWNlQXV0aGVudGljYXRpb25TY2hlbWVEZWZhdWx0KSB7Ci0gICAgICAgIC8vIFRo ZSBtYXAgY2FuIGNvbnRhaW4gYm90aCBhIHBhdGggYW5kIGl0cyBzdWJwYXRoIC0gd2hpbGUgcmVk dW5kYW50LCB0aGlzIG1ha2VzIGxvb2t1cHMgZmFzdGVyLgotICAgICAgICBwYXRoVG9EZWZhdWx0 UHJvdGVjdGlvblNwYWNlTWFwKCkuc2V0KHByb3RlY3Rpb25TcGFjZU1hcEtleUZyb21VUkwodXJs KSwgcHJvdGVjdGlvblNwYWNlKTsKKyAgICAgICAgUHJvdGVjdGlvblNwYWNlQXV0aGVudGljYXRp b25TY2hlbWUgc2NoZW1lID0gcHJvdGVjdGlvblNwYWNlLmF1dGhlbnRpY2F0aW9uU2NoZW1lKCk7 CisgICAgICAgIGlmIChzY2hlbWUgPT0gUHJvdGVjdGlvblNwYWNlQXV0aGVudGljYXRpb25TY2hl bWVIVFRQQmFzaWMgfHwgc2NoZW1lID09IFByb3RlY3Rpb25TcGFjZUF1dGhlbnRpY2F0aW9uU2No ZW1lRGVmYXVsdCkgeworICAgICAgICAgICAgLy8gVGhlIG1hcCBjYW4gY29udGFpbiBib3RoIGEg cGF0aCBhbmQgaXRzIHN1YnBhdGggLSB3aGlsZSByZWR1bmRhbnQsIHRoaXMgbWFrZXMgbG9va3Vw cyBmYXN0ZXIuCisgICAgICAgICAgICBwYXRoVG9EZWZhdWx0UHJvdGVjdGlvblNwYWNlTWFwKCku c2V0KHByb3RlY3Rpb25TcGFjZU1hcEtleUZyb21VUkwodXJsKSwgcHJvdGVjdGlvblNwYWNlKTsK KyAgICAgICAgfQogICAgIH0KIH0KIAo=