31131 2009-11-04 10:57:46 -0800 wxport mouse events crashes and assertions 2009-11-04 12:38:13 -0800 1 1 1 Unclassified WebKit WebKit wx 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 kevinwatters webkit-unassigned kevino oldest_to_newest 160513 0 kevinwatters 2009-11-04 10:57:46 -0800 To avoid some asserts, wxWebView should use Connect and Disconnect to register for popup menu events only when a context menu is visible. It also needs to release any mouse capture it has on destruction. 160515 1 42496 kevinwatters 2009-11-04 11:01:10 -0800 Created attachment 42496 fixes mouse event problems 160570 2 kevino 2009-11-04 12:38:13 -0800 Landed in r50522, thanks! 42496 2009-11-04 11:01:10 -0800 2009-11-04 11:42:10 -0800 fixes mouse event problems menu_mouse_fix.patch text/plain 2396 kevinwatters SW5kZXg6IFdlYktpdC93eC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3d4L0NoYW5n ZUxvZwkocmV2aXNpb24gNTA0OTcpCisrKyBXZWJLaXQvd3gvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTEtMDQgIEtldmluIFdhdHRlcnMgIDxrZXZpbndh dHRlcnNAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEZpeCBhbiBhc3NlcnQgb24gc2h1dGRvd24gd2hlbiB3eFdlYlZpZXcgaGFzIGNh cHR1cmVkIHRoZSBtb3VzZSwKKyAgICAgICAgYW5kIG1ha2Ugc3VyZSB3eFdlYlZpZXcncyByaWdo dCBjbGljayBoYW5kbGluZyBpcyBvbmx5IGFjdGl2ZSB3aGVuIAorICAgICAgICB0aGUgV2ViQ29y ZSBwb3B1cCBtZW51IGlzIHVzZWQuCisKKyAgICAgICAgKiBXZWJWaWV3LmNwcDoKKyAgICAgICAg KHd4V2ViVmlldzo6fnd4V2ViVmlldyk6CisgICAgICAgICh3eFdlYlZpZXc6Ok9uQ29udGV4dE1l bnVFdmVudHMpOgorICAgICAgICAod3hXZWJWaWV3OjpPbk1lbnVTZWxlY3RFdmVudHMpOgorCiAy MDA5LTEwLTMwICBFdmFuIFN0YWRlICA8ZXN0YWRlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBEYXZpZCBMZXZpbi4KSW5kZXg6IFdlYktpdC93eC9XZWJWaWV3LmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJLaXQvd3gvV2ViVmlldy5jcHAJKHJldmlzaW9uIDUwNDk2KQorKysgV2Vi S2l0L3d4L1dlYlZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNTcsNyArMjU3LDYgQEAKICAg ICBFVlRfU0laRSh3eFdlYlZpZXc6Ok9uU2l6ZSkKICAgICBFVlRfTU9VU0VfRVZFTlRTKHd4V2Vi Vmlldzo6T25Nb3VzZUV2ZW50cykKICAgICBFVlRfQ09OVEVYVF9NRU5VKHd4V2ViVmlldzo6T25D b250ZXh0TWVudUV2ZW50cykKLSAgICBFVlRfTUVOVSh3eElEX0FOWSwgd3hXZWJWaWV3OjpPbk1l bnVTZWxlY3RFdmVudHMpCiAgICAgRVZUX0tFWV9ET1dOKHd4V2ViVmlldzo6T25LZXlFdmVudHMp CiAgICAgRVZUX0tFWV9VUCh3eFdlYlZpZXc6Ok9uS2V5RXZlbnRzKQogICAgIEVWVF9DSEFSKHd4 V2ViVmlldzo6T25LZXlFdmVudHMpCkBAIC0zNDgsNiArMzQ3LDkgQEAKIHsKICAgICBtX2JlaW5n RGVzdHJveWVkID0gdHJ1ZTsKICAgICAKKyAgICB3aGlsZSAoSGFzQ2FwdHVyZSgpKQorICAgICAg ICBSZWxlYXNlTW91c2UoKTsKKyAgICAKICAgICBpZiAobV9tYWluRnJhbWUgJiYgbV9tYWluRnJh bWUtPkdldEZyYW1lKCkpCiAgICAgICAgIG1fbWFpbkZyYW1lLT5HZXRGcmFtZSgpLT5sb2FkZXIo KS0+ZGV0YWNoRnJvbVBhcmVudCgpOwogICAgIApAQCAtNjQ2LDYgKzY0OCw3IEBACiAKIHZvaWQg d3hXZWJWaWV3OjpPbkNvbnRleHRNZW51RXZlbnRzKHd4Q29udGV4dE1lbnVFdmVudCYgZXZlbnQp CiB7CisgICAgQ29ubmVjdCh3eEVWVF9DT01NQU5EX01FTlVfU0VMRUNURUQsIHd4Q29tbWFuZEV2 ZW50SGFuZGxlcih3eFdlYlZpZXc6Ok9uTWVudVNlbGVjdEV2ZW50cyksIE5VTEwsIHRoaXMpOwog ICAgIG1faW1wbC0+cGFnZS0+Y29udGV4dE1lbnVDb250cm9sbGVyKCktPmNsZWFyQ29udGV4dE1l bnUoKTsKICAgICB3eFBvaW50IGxvY2FsRXZlbnRQb2ludCA9IFNjcmVlblRvQ2xpZW50KGV2ZW50 LkdldFBvc2l0aW9uKCkpOwogCkBAIC02NzUsMTAgKzY3OCwxOCBAQAogICAgICAgICByZXR1cm47 CiAKICAgICBQb3B1cE1lbnUobWVudVd4LCBsb2NhbEV2ZW50UG9pbnQpOworICAgIAorICAgIERp c2Nvbm5lY3Qod3hFVlRfQ09NTUFORF9NRU5VX1NFTEVDVEVELCB3eENvbW1hbmRFdmVudEhhbmRs ZXIod3hXZWJWaWV3OjpPbk1lbnVTZWxlY3RFdmVudHMpLCBOVUxMLCB0aGlzKTsKIH0KIAogdm9p ZCB3eFdlYlZpZXc6Ok9uTWVudVNlbGVjdEV2ZW50cyh3eENvbW1hbmRFdmVudCYgZXZlbnQpCiB7 CisgICAgLy8gd2Ugc2hvdWxkbid0IGhpdCB0aGlzIHVubGVzcyB0aGVyZSdzIGEgY29udGV4dCBt ZW51IHNob3dpbmcKKyAgICBXZWJDb3JlOjpDb250ZXh0TWVudSogY29yZU1lbnUgPSBtX2ltcGwt PnBhZ2UtPmNvbnRleHRNZW51Q29udHJvbGxlcigpLT5jb250ZXh0TWVudSgpOworICAgIEFTU0VS VChjb3JlTWVudSk7CisgICAgaWYgKCFjb3JlTWVudSkKKyAgICAgICAgcmV0dXJuOworCiAgICAg V2ViQ29yZTo6Q29udGV4dE1lbnVJdGVtKiBpdGVtID0gV2ViQ29yZTo6Q29udGV4dE1lbnU6Oml0 ZW1XaXRoSWQgKGV2ZW50LkdldElkKCkpOwogICAgIGlmICghaXRlbSkKICAgICAgICAgcmV0dXJu Owo=