31126 2009-11-04 09:53:14 -0800 bugzilla-tool's reviewer/committer rejection message should be clearer 2009-11-19 12:28:17 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned mark oldest_to_newest 160477 0 eric 2009-11-04 09:53:14 -0800 bugzilla-tool's reviewer/committer rejection message should be clearer The message should give action steps like. 1. If you believe this message is in error, please add yourself as a Committer or Reviewer to committers.py and reset the flag. 2. If you are not a committer/reviewer please set review=? or commit-queue=? instead and a reviewer/committer will set review+ commit-queue+ for you. The prose should be briefer than that, and should include a link to the contributing docs. 164388 1 43389 eric 2009-11-17 16:38:53 -0800 Created attachment 43389 Patch 164390 2 eric 2009-11-17 16:40:21 -0800 As an example, I'll ask someone without review access to r+ this patch. 164391 3 43389 commit-queue 2009-11-17 16:44:39 -0800 Comment on attachment 43389 Patch Rejecting patch 43389 from review queue. evan@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. If you have reviewer rights please correct the error in WebKitTools/Scripts/modules/committers.py by adding yourself to the file (no review needed) and then set the reviewer flag again. If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. 164392 4 43391 eric 2009-11-17 16:47:26 -0800 Created attachment 43391 Add some extra newlines in the message to make it more readable 164402 5 43391 eric 2009-11-17 17:08:21 -0800 Comment on attachment 43391 Add some extra newlines in the message to make it more readable Evan was just trying to be helpful. :) But I'd like a real review on this one. 164476 6 43391 dimich 2009-11-17 23:53:43 -0800 Comment on attachment 43391 Add some extra newlines in the message to make it more readable > diff --git a/WebKitTools/Scripts/modules/bugzilla.py b/WebKitTools/Scripts/modules/bugzilla.py > + if True: > + rejection_function(patch['id'], self._flag_permission_rejection_message(setter_email, result_key)) > else: Is this supposed to be "if True"? When the subsequent "else:" will be taken? 164632 7 43391 darin 2009-11-18 10:57:48 -0800 Comment on attachment 43391 Add some extra newlines in the message to make it more readable rs=me 164757 8 43391 eric 2009-11-18 15:21:03 -0800 Comment on attachment 43391 Add some extra newlines in the message to make it more readable This needs to be landed by hand due to my error in this diff. 165055 9 eric 2009-11-19 12:28:17 -0800 Committed r51202: <http://trac.webkit.org/changeset/51202> 43389 2009-11-17 16:38:53 -0800 2009-11-17 16:47:21 -0800 Patch bug-31126-20091117163852.patch text/plain 2705 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBiMDcxODY5Li43YmI5OGNiIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMDktMTEt MTcgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGJ1Z3ppbGxhLXRvb2wncyByZXZpZXdlci9jb21t aXR0ZXIgcmVqZWN0aW9uIG1lc3NhZ2Ugc2hvdWxkIGJlIGNsZWFyZXIKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxMTI2CisKKyAgICAgICAgQWRkIG1v cmUgZXhwbGFuYXRvcnkgcHJvc2UgdG8gYnVnemlsbGEtdG9vbCdzIGZsYWcgcGVybWlzc2lvbiBy ZWplY3Rpb24gbWVzc2FnZS4KKworICAgICAgICAqIFNjcmlwdHMvbW9kdWxlcy9idWd6aWxsYS5w eToKKworMjAwOS0xMS0xNyAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKICAgICAg ICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCiAKICAgICAgICAgY29tbWl0LXF1ZXVlIGlzIGZh aWxpbmcgdG8gc2V0IHJldmlld2VyIGluIENoYW5nZUxvZ3MKZGlmZiAtLWdpdCBhL1dlYktpdFRv b2xzL1NjcmlwdHMvbW9kdWxlcy9idWd6aWxsYS5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9k dWxlcy9idWd6aWxsYS5weQppbmRleCAzYTljYTY4Li5jZjFiODM2IDEwMDY0NAotLS0gYS9XZWJL aXRUb29scy9TY3JpcHRzL21vZHVsZXMvYnVnemlsbGEucHkKKysrIGIvV2ViS2l0VG9vbHMvU2Ny aXB0cy9tb2R1bGVzL2J1Z3ppbGxhLnB5CkBAIC0yMzksNiArMjM5LDE0IEBAIGNsYXNzIEJ1Z3pp bGxhOgogICAgIGRlZiBfdmlld19zb3VyY2VfbGluayhzZWxmLCBsb2NhbF9wYXRoKToKICAgICAg ICAgcmV0dXJuICJodHRwOi8vdHJhYy53ZWJraXQub3JnL2Jyb3dzZXIvdHJ1bmsvJXMiICUgbG9j YWxfcGF0aAogCisgICAgZGVmIF9mbGFnX3Blcm1pc3Npb25fcmVqZWN0aW9uX21lc3NhZ2Uoc2V0 dGVyX2VtYWlsLCBmbGFnX25hbWUpOgorICAgICAgICBjb21taXR0ZXJfbGlzdCA9ICJXZWJLaXRU b29scy9TY3JpcHRzL21vZHVsZXMvY29tbWl0dGVycy5weSIKKyAgICAgICAgY29udHJpYnV0aW9u X2d1aWRsaW5lc191cmwgPSAiaHR0cDovL3dlYmtpdC5vcmcvY29kaW5nL2NvbnRyaWJ1dGluZy5o dG1sIgorICAgICAgICByZWplY3Rpb25fbWVzc2FnZSA9ICIlcyBkb2VzIG5vdCBoYXZlICVzIHBl cm1pc3Npb25zIGFjY29yZGluZyB0byAlcy4iICUgKHNldHRlcl9lbWFpbCwgZmxhZ19uYW1lLCBz ZWxmLl92aWV3X3NvdXJjZV9saW5rKGNvbW1pdHRlcl9saXN0KSkKKyAgICAgICAgcmVqZWN0aW9u X21lc3NhZ2UgKz0gIlxuSWYgeW91IGhhdmUgJXMgcmlnaHRzIHBsZWFzZSBjb3JyZWN0IHRoZSBl cnJvciBpbiAlcyBieSBhZGRpbmcgeW91cnNlbGYgdG8gdGhlIGZpbGUgKG5vIHJldmlldyBuZWVk ZWQpIGFuZCB0aGVuIHNldCB0aGUgJXMgZmxhZyBhZ2Fpbi4iICUgKGZsYWdfbmFtZSwgY29tbWl0 dGVyX2xpc3QsIGZsYWdfbmFtZSkKKyAgICAgICAgcmVqZWN0aW9uX21lc3NhZ2UgKz0gIlxuSWYg eW91IGRvIG5vdCBoYXZlICVzIHJpZ2h0cyBwbGVhc2UgcmVhZCAlcyBmb3IgaW5zdHJ1Y3Rpb25z IG9uIGhvdyB0byB1c2UgYnVnemlsbGEgZmxhZ3MuIiAlIChmbGFnX25hbWUsIGNvbnRyaWJ1dGlv bl9ndWlkbGluZXNfdXJsKQorICAgICAgICByZXR1cm4gcmVqZWN0aW9uX21lc3NhZ2UKKwogICAg IGRlZiBfdmFsaWRhdGVfc2V0dGVyX2VtYWlsKHNlbGYsIHBhdGNoLCByZXN1bHRfa2V5LCBsb29r dXBfZnVuY3Rpb24sIHJlamVjdGlvbl9mdW5jdGlvbiwgcmVqZWN0X2ludmFsaWRfcGF0Y2hlcyk6 CiAgICAgICAgIHNldHRlcl9lbWFpbCA9IHBhdGNoLmdldChyZXN1bHRfa2V5ICsgJ19lbWFpbCcp CiAgICAgICAgIGlmIG5vdCBzZXR0ZXJfZW1haWw6CkBAIC0yNTAsOSArMjU4LDcgQEAgY2xhc3Mg QnVnemlsbGE6CiAgICAgICAgICAgICByZXR1cm4gcGF0Y2hbcmVzdWx0X2tleV0KIAogICAgICAg ICBpZiByZWplY3RfaW52YWxpZF9wYXRjaGVzOgotICAgICAgICAgICAgY29tbWl0dGVyX2xpc3Qg PSAiV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NvbW1pdHRlcnMucHkiCi0gICAgICAgICAg ICBmYWlsdXJlX21lc3NhZ2UgPSAiJXMgZG9lcyBub3QgaGF2ZSAlcyBwZXJtaXNzaW9ucyBhY2Nv cmRpbmcgdG8gJXMuIiAlIChzZXR0ZXJfZW1haWwsIHJlc3VsdF9rZXksIHNlbGYuX3ZpZXdfc291 cmNlX2xpbmsoY29tbWl0dGVyX2xpc3QpKQotICAgICAgICAgICAgcmVqZWN0aW9uX2Z1bmN0aW9u KHBhdGNoWydpZCddLCBmYWlsdXJlX21lc3NhZ2UpCisgICAgICAgICAgICByZWplY3Rpb25fZnVu Y3Rpb24ocGF0Y2hbJ2lkJ10sIHNlbGYuX2ZsYWdfcGVybWlzc2lvbl9yZWplY3Rpb25fbWVzc2Fn ZShzZXR0ZXJfZW1haWwsIHJlc3VsdF9rZXkpKQogICAgICAgICBlbHNlOgogICAgICAgICAgICAg bG9nKCJXYXJuaW5nLCBhdHRhY2htZW50ICVzIG9uIGJ1ZyAlcyBoYXMgaW52YWxpZCAlcyAoJXMp IiAlIChwYXRjaFsnaWQnXSwgcGF0Y2hbJ2J1Z19pZCddLCByZXN1bHRfa2V5LCBzZXR0ZXJfZW1h aWwpKQogICAgICAgICByZXR1cm4gTm9uZQo= 43391 2009-11-17 16:47:26 -0800 2009-11-18 15:21:03 -0800 Add some extra newlines in the message to make it more readable bug-31126-20091117164725.patch text/plain 2791 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBiMDcxODY5Li43YmI5OGNiIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMDktMTEt MTcgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGJ1Z3ppbGxhLXRvb2wncyByZXZpZXdlci9jb21t aXR0ZXIgcmVqZWN0aW9uIG1lc3NhZ2Ugc2hvdWxkIGJlIGNsZWFyZXIKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxMTI2CisKKyAgICAgICAgQWRkIG1v cmUgZXhwbGFuYXRvcnkgcHJvc2UgdG8gYnVnemlsbGEtdG9vbCdzIGZsYWcgcGVybWlzc2lvbiBy ZWplY3Rpb24gbWVzc2FnZS4KKworICAgICAgICAqIFNjcmlwdHMvbW9kdWxlcy9idWd6aWxsYS5w eToKKworMjAwOS0xMS0xNyAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKICAgICAg ICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCiAKICAgICAgICAgY29tbWl0LXF1ZXVlIGlzIGZh aWxpbmcgdG8gc2V0IHJldmlld2VyIGluIENoYW5nZUxvZ3MKZGlmZiAtLWdpdCBhL1dlYktpdFRv b2xzL1NjcmlwdHMvbW9kdWxlcy9idWd6aWxsYS5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9k dWxlcy9idWd6aWxsYS5weQppbmRleCAzYTljYTY4Li4wNzZmMmRlIDEwMDY0NAotLS0gYS9XZWJL aXRUb29scy9TY3JpcHRzL21vZHVsZXMvYnVnemlsbGEucHkKKysrIGIvV2ViS2l0VG9vbHMvU2Ny aXB0cy9tb2R1bGVzL2J1Z3ppbGxhLnB5CkBAIC0yMzksNiArMjM5LDE0IEBAIGNsYXNzIEJ1Z3pp bGxhOgogICAgIGRlZiBfdmlld19zb3VyY2VfbGluayhzZWxmLCBsb2NhbF9wYXRoKToKICAgICAg ICAgcmV0dXJuICJodHRwOi8vdHJhYy53ZWJraXQub3JnL2Jyb3dzZXIvdHJ1bmsvJXMiICUgbG9j YWxfcGF0aAogCisgICAgZGVmIF9mbGFnX3Blcm1pc3Npb25fcmVqZWN0aW9uX21lc3NhZ2Uoc2Vs Ziwgc2V0dGVyX2VtYWlsLCBmbGFnX25hbWUpOgorICAgICAgICBjb21taXR0ZXJfbGlzdCA9ICJX ZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY29tbWl0dGVycy5weSIKKyAgICAgICAgY29udHJp YnV0aW9uX2d1aWRsaW5lc191cmwgPSAiaHR0cDovL3dlYmtpdC5vcmcvY29kaW5nL2NvbnRyaWJ1 dGluZy5odG1sIgorICAgICAgICByZWplY3Rpb25fbWVzc2FnZSA9ICIlcyBkb2VzIG5vdCBoYXZl ICVzIHBlcm1pc3Npb25zIGFjY29yZGluZyB0byAlcy4iICUgKHNldHRlcl9lbWFpbCwgZmxhZ19u YW1lLCBzZWxmLl92aWV3X3NvdXJjZV9saW5rKGNvbW1pdHRlcl9saXN0KSkKKyAgICAgICAgcmVq ZWN0aW9uX21lc3NhZ2UgKz0gIlxuXG4tIElmIHlvdSBoYXZlICVzIHJpZ2h0cyBwbGVhc2UgY29y cmVjdCB0aGUgZXJyb3IgaW4gJXMgYnkgYWRkaW5nIHlvdXJzZWxmIHRvIHRoZSBmaWxlIChubyBy ZXZpZXcgbmVlZGVkKSBhbmQgdGhlbiBzZXQgdGhlICVzIGZsYWcgYWdhaW4uIiAlIChmbGFnX25h bWUsIGNvbW1pdHRlcl9saXN0LCBmbGFnX25hbWUpCisgICAgICAgIHJlamVjdGlvbl9tZXNzYWdl ICs9ICJcblxuLSBJZiB5b3UgZG8gbm90IGhhdmUgJXMgcmlnaHRzIHBsZWFzZSByZWFkICVzIGZv ciBpbnN0cnVjdGlvbnMgb24gaG93IHRvIHVzZSBidWd6aWxsYSBmbGFncy4iICUgKGZsYWdfbmFt ZSwgY29udHJpYnV0aW9uX2d1aWRsaW5lc191cmwpCisgICAgICAgIHJldHVybiByZWplY3Rpb25f bWVzc2FnZQorCiAgICAgZGVmIF92YWxpZGF0ZV9zZXR0ZXJfZW1haWwoc2VsZiwgcGF0Y2gsIHJl c3VsdF9rZXksIGxvb2t1cF9mdW5jdGlvbiwgcmVqZWN0aW9uX2Z1bmN0aW9uLCByZWplY3RfaW52 YWxpZF9wYXRjaGVzKToKICAgICAgICAgc2V0dGVyX2VtYWlsID0gcGF0Y2guZ2V0KHJlc3VsdF9r ZXkgKyAnX2VtYWlsJykKICAgICAgICAgaWYgbm90IHNldHRlcl9lbWFpbDoKQEAgLTI0OSwxMCAr MjU3LDggQEAgY2xhc3MgQnVnemlsbGE6CiAgICAgICAgICAgICBwYXRjaFtyZXN1bHRfa2V5XSA9 IGNvbW1pdHRlci5mdWxsX25hbWUKICAgICAgICAgICAgIHJldHVybiBwYXRjaFtyZXN1bHRfa2V5 XQogCi0gICAgICAgIGlmIHJlamVjdF9pbnZhbGlkX3BhdGNoZXM6Ci0gICAgICAgICAgICBjb21t aXR0ZXJfbGlzdCA9ICJXZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY29tbWl0dGVycy5weSIK LSAgICAgICAgICAgIGZhaWx1cmVfbWVzc2FnZSA9ICIlcyBkb2VzIG5vdCBoYXZlICVzIHBlcm1p c3Npb25zIGFjY29yZGluZyB0byAlcy4iICUgKHNldHRlcl9lbWFpbCwgcmVzdWx0X2tleSwgc2Vs Zi5fdmlld19zb3VyY2VfbGluayhjb21taXR0ZXJfbGlzdCkpCi0gICAgICAgICAgICByZWplY3Rp b25fZnVuY3Rpb24ocGF0Y2hbJ2lkJ10sIGZhaWx1cmVfbWVzc2FnZSkKKyAgICAgICAgaWYgVHJ1 ZToKKyAgICAgICAgICAgIHJlamVjdGlvbl9mdW5jdGlvbihwYXRjaFsnaWQnXSwgc2VsZi5fZmxh Z19wZXJtaXNzaW9uX3JlamVjdGlvbl9tZXNzYWdlKHNldHRlcl9lbWFpbCwgcmVzdWx0X2tleSkp CiAgICAgICAgIGVsc2U6CiAgICAgICAgICAgICBsb2coIldhcm5pbmcsIGF0dGFjaG1lbnQgJXMg b24gYnVnICVzIGhhcyBpbnZhbGlkICVzICglcykiICUgKHBhdGNoWydpZCddLCBwYXRjaFsnYnVn X2lkJ10sIHJlc3VsdF9rZXksIHNldHRlcl9lbWFpbCkpCiAgICAgICAgIHJldHVybiBOb25lCg==