31122 2009-11-04 08:27:31 -0800 [Qt] editing/selection/shrink-selection-after-shift-pagedown.html failing 2009-11-08 11:09:53 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 cshu cshu adele commit-queue darin enrica eric laszlo.gombos oldest_to_newest 160445 0 cshu 2009-11-04 08:27:31 -0800 QtLauncher failed to pass this newly added test case. It's also reported by build bot: http://build.webkit.org/results/Qt%20Linux%20Release/r50408%20%283364%29/results.html 160530 1 42502 cshu 2009-11-04 11:29:31 -0800 Created attachment 42502 this patch implements the support for shift-pageup and shift-pagedown. This patch does not make the test case pass yet. But this is the 1st step and better to be in a separate patch. 160809 2 42502 vestbo 2009-11-05 06:44:42 -0800 Comment on attachment 42502 this patch implements the support for shift-pageup and shift-pagedown. LGTM, but please wrap the else before submitting, ie: if (kevent->shiftKey()) frame->editor()->command("MovePageDownAndModifySelection").execute(); else frame->editor()->command("MovePageDown").execute(); 160841 3 cshu 2009-11-05 08:41:31 -0800 I think the original test case has a flaw: it issues a shift-pagedown and expects exactly 7 more links are selected. This is true for Safari. However, on other WebKit browsers like QtLauncher or GTK browsers (bug 31103), or Firefox, or IE, the amount of selected lines caused by shift-pagedown event is NOT deterministic. This makes the test case fail on other platforms. The intention of the test case is to check if selection would shrink as expected after a shift-arrowup following a "shift-down". I guess this "shift-down" can either be shift-arrowdown or shift-pagedown. While shift-arrowdown generates deterministic behavior, I suggest we change the test to replace shift-pagedown with multiple shift-arrowdown. This should resolve both failures on Qt and GTK. Btw, Qt did not support shift-pageup and shift-pagedown before and this has been addressed in bug 31166 and fixed already. 160898 4 42582 cshu 2009-11-05 11:43:56 -0800 Created attachment 42582 fix test case The original writer of the test case, Enrica Casucci [enrica@apple.com], pointed out that shift-PageDown is required for the test case. So my previous proposal of replacing it using multiple shift-arrowdown is not an option. Then I came up with this patch. This patch fixes the test case so that it no longer depends on the exact number of lines selected. On Qt, shift-pagedown has been implemented for bug 31166 and landed. I tested both Qt and Mac and this patch worked. I also think it should fix bug 31103, a GTK regression on this test case. 160902 5 enrica 2009-11-05 11:51:13 -0800 The patch looks good to me. 160957 6 42582 commit-queue 2009-11-05 14:47:08 -0800 Comment on attachment 42582 fix test case Clearing flags on attachment: 42582 Committed r50579: <http://trac.webkit.org/changeset/50579> 160958 7 commit-queue 2009-11-05 14:47:15 -0800 All reviewed patches have been landed. Closing bug. 161162 8 darin 2009-11-06 09:42:14 -0800 This change leaves the test case in an inconsistent state. The text telling how to run the test case says: The selection should only include the lines with "YES". But that's no longer what the test looks like. 161163 9 cshu 2009-11-06 09:58:11 -0800 (In reply to comment #8) > This change leaves the test case in an inconsistent state. The text telling how > to run the test case says: > > The selection should only include the lines with "YES". > > But that's no longer what the test looks like. I guess I should update this text. However, the reason for inconsistent result is because of the behavior of shift-pagedown. 161181 10 42662 cshu 2009-11-06 11:14:49 -0800 Created attachment 42662 update test description 161184 11 eric 2009-11-06 11:21:54 -0800 I think Chang meant to re-open the bug before posting a new patch. 161187 12 cshu 2009-11-06 11:23:16 -0800 (In reply to comment #11) > I think Chang meant to re-open the bug before posting a new patch. Thanks for doing this for me. 161323 13 42662 zecke 2009-11-07 00:49:44 -0800 Comment on attachment 42662 update test description Sounds sensible. 161439 14 42662 commit-queue 2009-11-08 11:09:48 -0800 Comment on attachment 42662 update test description Clearing flags on attachment: 42662 Committed r50626: <http://trac.webkit.org/changeset/50626> 161440 15 commit-queue 2009-11-08 11:09:53 -0800 All reviewed patches have been landed. Closing bug. 42502 2009-11-04 11:29:31 -0800 2009-11-05 11:43:56 -0800 this patch implements the support for shift-pageup and shift-pagedown. bug31122_1.patch text/plain 1815 cshu SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNTA1MTgpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTEtMDQgIFNodSBDaGFuZyAgPENoYW5nLlNodUBu b2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWRkIHN1cHBvcnQgZm9yIFNoaWZ0LVBhZ2VVcCBhbmQgU2hpZnQtUGFnZURvd24ga2V5IGV2 ZW50cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMx MTIyCisKKyAgICAgICAgVGVzdDogTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vc2hyaW5r LXNlbGVjdGlvbi1hZnRlci1zaGlmdC1wYWdlZG93bi5odG1sCisKKyAgICAgICAgKiBXZWJDb3Jl U3VwcG9ydC9FZGl0b3JDbGllbnRRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFZGl0b3JDbGll bnRRdDo6aGFuZGxlS2V5Ym9hcmRFdmVudCk6CisKIDIwMDktMTEtMDQgIFlhZWwgQWhhcm9uICA8 eWFlbC5haGFyb25Abm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNt YW5uLgpJbmRleDogV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudFF0LmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50UXQuY3Bw CShyZXZpc2lvbiA1MDQ3MykKKysrIFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGll bnRRdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQyNSwxMCArNDI1LDE0IEBAIHZvaWQgRWRpdG9y Q2xpZW50UXQ6OmhhbmRsZUtleWJvYXJkRXZlbnQKICAgICAgICAgICAgICAgICBlbHNlIGZyYW1l LT5lZGl0b3IoKS0+Y29tbWFuZCgiTW92ZURvd24iKS5leGVjdXRlKCk7CiAgICAgICAgICAgICAg ICAgYnJlYWs7CiAgICAgICAgICAgICBjYXNlIFZLX1BSSU9SOiAgLy8gUGFnZVVwCi0gICAgICAg ICAgICAgICAgZnJhbWUtPmVkaXRvcigpLT5jb21tYW5kKCJNb3ZlUGFnZVVwIikuZXhlY3V0ZSgp OworICAgICAgICAgICAgICAgIGlmIChrZXZlbnQtPnNoaWZ0S2V5KCkpCisgICAgICAgICAgICAg ICAgICAgIGZyYW1lLT5lZGl0b3IoKS0+Y29tbWFuZCgiTW92ZVBhZ2VVcEFuZE1vZGlmeVNlbGVj dGlvbiIpLmV4ZWN1dGUoKTsKKyAgICAgICAgICAgICAgICBlbHNlIGZyYW1lLT5lZGl0b3IoKS0+ Y29tbWFuZCgiTW92ZVBhZ2VVcCIpLmV4ZWN1dGUoKTsKICAgICAgICAgICAgICAgICBicmVhazsK ICAgICAgICAgICAgIGNhc2UgVktfTkVYVDogIC8vIFBhZ2VEb3duCi0gICAgICAgICAgICAgICAg ZnJhbWUtPmVkaXRvcigpLT5jb21tYW5kKCJNb3ZlUGFnZURvd24iKS5leGVjdXRlKCk7CisgICAg ICAgICAgICAgICAgaWYgKGtldmVudC0+c2hpZnRLZXkoKSkKKyAgICAgICAgICAgICAgICAgICAg ZnJhbWUtPmVkaXRvcigpLT5jb21tYW5kKCJNb3ZlUGFnZURvd25BbmRNb2RpZnlTZWxlY3Rpb24i KS5leGVjdXRlKCk7CisgICAgICAgICAgICAgICAgZWxzZSBmcmFtZS0+ZWRpdG9yKCktPmNvbW1h bmQoIk1vdmVQYWdlRG93biIpLmV4ZWN1dGUoKTsKICAgICAgICAgICAgICAgICBicmVhazsKICAg ICAgICAgICAgIGNhc2UgVktfVEFCOgogICAgICAgICAgICAgICAgIHJldHVybjsK 42582 2009-11-05 11:43:56 -0800 2009-11-05 14:47:07 -0800 fix test case bug31122_2.patch text/plain 2351 cshu SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUwNTY5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTEtMDUgIFNodSBDaGFuZyAgPENoYW5n LlNodUBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhlIG51bWJlciBvZiBzZWxlY3RlZCBsaW5lcyBpbiB0ZXh0YXJlYSBhZnRlciBh IHNoaWZ0LVBhZ2VEb3duCisgICAgICAgIG1heSBkaWZmZXIuIFRoZSB0ZXN0IGNhc2UgaXMgbW9k aWZpZWQgc28gdGhhdCBpdCB3aWxsIG5vdCBkZXBlbmQKKyAgICAgICAgb24gdGhlIGV4YWN0IG51 bWJlciBvZiBsaW5lcyBzZWxlY3RlZC4gVGhpcyBzaG91bGQgcmVzb2x2ZSByZWdyZXNzaW9uCisg ICAgICAgIG9uIHBsYXRmb3JtcyBsaWtlIFF0IGFuZCBHVEsuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTEyMgorCisgICAgICAgICogZWRpdGluZy9z ZWxlY3Rpb24vc2hyaW5rLXNlbGVjdGlvbi1hZnRlci1zaGlmdC1wYWdlZG93bi5odG1sOgorCiAy MDA5LTExLTA1ICBKaWFuIExpICA8amlhbmxpQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBEbWl0cmkgVGl0b3YuCkluZGV4OiBMYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlv bi9zaHJpbmstc2VsZWN0aW9uLWFmdGVyLXNoaWZ0LXBhZ2Vkb3duLmh0bWwKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vc2hyaW5rLXNlbGVjdGlvbi1hZnRlci1z aGlmdC1wYWdlZG93bi5odG1sCShyZXZpc2lvbiA1MDU2NCkKKysrIExheW91dFRlc3RzL2VkaXRp bmcvc2VsZWN0aW9uL3Nocmluay1zZWxlY3Rpb24tYWZ0ZXItc2hpZnQtcGFnZWRvd24uaHRtbAko d29ya2luZyBjb3B5KQpAQCAtNywxNiArNywxOCBAQAogICAgICAgICAgICAgbGF5b3V0VGVzdENv bnRyb2xsZXIuZHVtcEFzVGV4dCgpOwogICAgICAgICAKICAgICAgICAgdmFyIHRhID0gZG9jdW1l bnQuZ2V0RWxlbWVudEJ5SWQoJ3RhJyk7Ci0gICAgICAgIHRhLnNldFNlbGVjdGlvblJhbmdlKDMs IDE0KTsKLSAgICAgICAgCisgICAgICAgIHRhLnNldFNlbGVjdGlvblJhbmdlKDQsIDE2KTsKKwor ICAgICAgICB2YXIgbGFzdFNlbGVjdGVkTGluZTsKICAgICAgICAgaWYgKHdpbmRvdy5ldmVudFNl bmRlcikgewogICAgICAgICAgICAgZXZlbnRTZW5kZXIua2V5RG93bigicGFnZURvd24iLFsic2hp ZnRLZXkiXSk7CisgICAgICAgICAgICBsYXN0U2VsZWN0ZWRMaW5lID0gKHRhLnZhbHVlKS5zdWJz dHJpbmcodGEuc2VsZWN0aW9uRW5kIC0gNCwgdGEuc2VsZWN0aW9uRW5kKTsKICAgICAgICAgICAg IGV2ZW50U2VuZGVyLmtleURvd24oInVwQXJyb3ciLFsic2hpZnRLZXkiXSk7CiAgICAgICAgIH0K ICAgICAgICAgCiAgICAgICAgIHZhciByZXN1bHQ7CiAgICAgICAgIHZhciBzZWxlY3RlZFRleHQg PSAodGEudmFsdWUpLnN1YnN0cmluZyh0YS5zZWxlY3Rpb25TdGFydCwgdGEuc2VsZWN0aW9uRW5k KTsKLSAgICAgICAgaWYgKHNlbGVjdGVkVGV4dC5pbmRleE9mKCdOTycpID09IC0xKQorICAgICAg ICBpZiAoKHNlbGVjdGVkVGV4dC5pbmRleE9mKGxhc3RTZWxlY3RlZExpbmUpID09IC0xKSAmJiAo c2VsZWN0ZWRUZXh0LmluZGV4T2YoJ0wwMScpID09IC0xKSkKICAgICAgICAgICAgIHJlc3VsdCA9 ICJTVUNDRVNTOiBUaGUgc2VsZWN0aW9uIHNocnVuayBjb3JyZWN0bHkiOwogICAgICAgICBlbHNl CiAgICAgICAgICAgICByZXN1bHQgPSAiU1VDQ0VTUzogVGhlIHNlbGVjdGVkIHRleHQgaXMgXCIi ICsgc2VsZWN0ZWRUZXh0ICsgIlwiLiI7CkBAIC0zMywyMyArMzUsMjIgQEAKICAgICBUaGUgc2Vs ZWN0aW9uIHNob3VsZCBvbmx5IGluY2x1ZGUgdGhlIGxpbmVzIHdpdGggIllFUyIuCiA8L3A+CiA8 dGV4dGFyZWEgcm93cz0xMCBpZD0idGEiPgotTk8KLVlFUwotWUVTCi1ZRVMKLVlFUwotWUVTCi1Z RVMKLVlFUwotWUVTCi1ZRVMKLU5PCi1OTwotTk8KLU5PCi1OTwotTk8KLU5PCitMMDEKK0wwMgor TDAzCitMMDQKK0wwNQorTDA2CitMMDcKK0wwOAorTDA5CitMMTAKK0wxMQorTDEyCitMMTMKK0wx NAorTDE1CitMMTYKIDwvdGV4dGFyZWE+CiA8cCBpZD0icmVzdWx0Ij5URVNUIEhBUyBOT1QgUlVO PC9wPgogPC9ib2R5Pgo= 42662 2009-11-06 11:14:49 -0800 2009-11-08 11:09:48 -0800 update test description bug31122_3.patch text/plain 2283 cshu SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUwNjAxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTEtMDYgIFNodSBDaGFuZyAgPENoYW5n LlNodUBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVXBkYXRlIHRleHRzIGluIHRlc3QgZGVzY3JpcHRpb24gYWZ0ZXIgdGVzdCBjYXNl IGNoYW5nZSBpbiByNTA1NzkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zMTEyMgorCisgICAgICAgICogZWRpdGluZy9zZWxlY3Rpb24vc2hyaW5rLXNl bGVjdGlvbi1hZnRlci1zaGlmdC1wYWdlZG93bi1leHBlY3RlZC50eHQ6CisgICAgICAgICogZWRp dGluZy9zZWxlY3Rpb24vc2hyaW5rLXNlbGVjdGlvbi1hZnRlci1zaGlmdC1wYWdlZG93bi5odG1s OgorCiAyMDA5LTExLTA0ICBTaGluaWNoaXJvIEhhbWFqaSAgPGhhbWFqaUBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBMYXlvdXRUZXN0cy9l ZGl0aW5nL3NlbGVjdGlvbi9zaHJpbmstc2VsZWN0aW9uLWFmdGVyLXNoaWZ0LXBhZ2Vkb3duLWV4 cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9z aHJpbmstc2VsZWN0aW9uLWFmdGVyLXNoaWZ0LXBhZ2Vkb3duLWV4cGVjdGVkLnR4dAkocmV2aXNp b24gNTA2MDEpCisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9zaHJpbmstc2VsZWN0 aW9uLWFmdGVyLXNoaWZ0LXBhZ2Vkb3duLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAt MSw2ICsxLDYgQEAKIFRoaXMgdGVzdHMgc2hyaW5raW5nIGEgc2VsZWN0aW9uIHdpdGggc2hpZnQt dXAgYWZ0ZXIgZXh0ZW5kaW5nIGl0IHdpdGggc2hpZnQtUGFnZURvd24uCiAKLVRoaXMgdGVzdCBk b2VzIG5vdCBydW4gaW50ZXJhY3RpdmVseS4gSXQgdXNlcyB0aGUgZXZlbnQgc2VuZGVyIHRvIGRv IG1vdXNlIGNsaWNrcy4gVG8gcnVuIGl0IG1hbnVhbGx5LCBwcmVzcyBzaGlmdC1QYWdEb3duLiBU aGVuIHByZXNzIHNoaWZ0LXVwLiBUaGUgc2VsZWN0aW9uIHNob3VsZCBvbmx5IGluY2x1ZGUgdGhl IGxpbmVzIHdpdGggIllFUyIuCitUaGlzIHRlc3QgZG9lcyBub3QgcnVuIGludGVyYWN0aXZlbHku IEl0IHVzZXMgdGhlIGV2ZW50IHNlbmRlciB0byBkbyBtb3VzZSBjbGlja3MuIFRvIHJ1biBpdCBt YW51YWxseSwgcHJlc3Mgc2hpZnQtUGFnRG93bi4gVGhlbiBwcmVzcyBzaGlmdC11cC4gVGhlIHNl bGVjdGlvbiBzaG91bGQgc2hyaW5rIGJ5IG9uZSBsaW5lIGZyb20gdGhlIGJvdHRvbSBhZnRlciBz aGlmdC11cC4KIAogCiBTVUNDRVNTOiBUaGUgc2VsZWN0aW9uIHNocnVuayBjb3JyZWN0bHkKSW5k ZXg6IExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL3Nocmluay1zZWxlY3Rpb24tYWZ0ZXIt c2hpZnQtcGFnZWRvd24uaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL3Nl bGVjdGlvbi9zaHJpbmstc2VsZWN0aW9uLWFmdGVyLXNoaWZ0LXBhZ2Vkb3duLmh0bWwJKHJldmlz aW9uIDUwNjAxKQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vc2hyaW5rLXNlbGVj dGlvbi1hZnRlci1zaGlmdC1wYWdlZG93bi5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0zMiw3ICsz Miw3IEBACiAgICAgVGhpcyB0ZXN0IGRvZXMgbm90IHJ1biBpbnRlcmFjdGl2ZWx5LgogICAgIEl0 IHVzZXMgdGhlIGV2ZW50IHNlbmRlciB0byBkbyBtb3VzZSBjbGlja3MuCiAgICAgVG8gcnVuIGl0 IG1hbnVhbGx5LCBwcmVzcyBzaGlmdC1QYWdEb3duLiAgVGhlbiBwcmVzcyBzaGlmdC11cC4KLSAg ICBUaGUgc2VsZWN0aW9uIHNob3VsZCBvbmx5IGluY2x1ZGUgdGhlIGxpbmVzIHdpdGggIllFUyIu CisgICAgVGhlIHNlbGVjdGlvbiBzaG91bGQgc2hyaW5rIGJ5IG9uZSBsaW5lIGZyb20gdGhlIGJv dHRvbSBhZnRlciBzaGlmdC11cC4KIDwvcD4KIDx0ZXh0YXJlYSByb3dzPTEwIGlkPSJ0YSI+CiBM MDEK