31091 2009-11-03 15:53:59 -0800 commit-queue is crashing when trying to reject patches after unknown failures 2009-11-04 10:28:52 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth commit-queue oldest_to_newest 160251 0 eric 2009-11-03 15:53:59 -0800 commit-queue is crashing when trying to reject patches after unknown failures Traceback (most recent call last): File "WebKitTools/Scripts/bugzilla-tool", line 917, in <module> main() File "WebKitTools/Scripts/bugzilla-tool", line 914, in main return tool.main() File "WebKitTools/Scripts/bugzilla-tool", line 909, in main return command_object.execute(command_options, command_args, self) File "WebKitTools/Scripts/bugzilla-tool", line 762, in execute tool.bugs.reject_patch_from_commit_queue(patch['id'], "Unexpected failure when landing patch! Please file a bug against bugzilla-tool.\n%s" % e.message_with_output()) NameError: global name 'patch' is not defined This is a really bad place to crash, because we never learn what's actually wrong. :) I've fixed this. I also noticed we're leaking file descriptors in this case, so I've fixed that as well. 160253 1 42434 eric 2009-11-03 15:57:11 -0800 Created attachment 42434 Patch 160324 2 42434 abarth 2009-11-03 22:57:49 -0800 Comment on attachment 42434 Patch Ok. I'd prefer to keep the master process as simple as possible to avoid these kinds of bugs in the future. It should be bullet-proof. 160500 3 42434 commit-queue 2009-11-04 10:28:47 -0800 Comment on attachment 42434 Patch Clearing flags on attachment: 42434 Committed r50518: <http://trac.webkit.org/changeset/50518> 160501 4 commit-queue 2009-11-04 10:28:52 -0800 All reviewed patches have been landed. Closing bug. 42434 2009-11-03 15:57:11 -0800 2009-11-04 10:28:47 -0800 Patch bug-31091-20091103155710.patch text/plain 3344 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA5YjViNWY5Li44MjAwZjk1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMDktMTEt MDMgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNvbW1pdC1xdWV1ZSBpcyBjcmFzaGluZyB3aGVu IHRyeWluZyB0byByZWplY3QgcGF0Y2hlcyBhZnRlciB1bmtub3duIGZhaWx1cmVzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTA5MQorCisgICAgICAg ICogU2NyaXB0cy9idWd6aWxsYS10b29sOgorICAgICAgICAgLSBwYXRjaFsnaWQnXSB3YXMgYSBj b3B5L3Bhc3RlIG1pc3Rha2UuICBUaGlzIGNvZGUgaGFzIG5vICdwYXRjaCcgdmFyaWFibGUKKyAg ICAgICAgICAgc28gd2UgaGF2ZSB0byBmaW5kIG91dCB3aGF0IHRoZSBjdXJyZW50IHBhdGNoIGlz IGJ5IGFza2luZyBidWd6aWxsYSBhZ2Fpbi4KKyAgICAgICAgIC0gRGlzY292ZXJlZCB0aGF0IHRo aXMgY29kZSB3YXMgYWxzbyBsZWFraW5nIGZpbGUgZGVzY3JpcHRvcnMsIHNvIGZpeGVkIHRoYXQu CisKKzIwMDktMTEtMDMgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCiAgICAgICAg IE5vIHJldmlldywganVzdCBjaGFuZ2luZyB3b3JkaW5nIG9mIGxvZyBtZXNzYWdlLgogCiAgICAg ICAgIENoYW5nZSBsb2cgc3RyaW5nIHRvIHNheSAiZmFpbGVkIiBpbnN0ZWFkIG9mICJyZWplY3Rl ZCIKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVnemlsbGEtdG9vbCBiL1dlYktp dFRvb2xzL1NjcmlwdHMvYnVnemlsbGEtdG9vbAppbmRleCBmNzNkNzZkLi5lMTdhYmJlIDEwMDc1 NQotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL2J1Z3ppbGxhLXRvb2wKKysrIGIvV2ViS2l0VG9v bHMvU2NyaXB0cy9idWd6aWxsYS10b29sCkBAIC03MjMsNyArNzIzLDExIEBAIGNsYXNzIExhbmRQ YXRjaGVzRnJvbUNvbW1pdFF1ZXVlKENvbW1hbmQpOgogCiAgICAgICAgIHNlbGYuc3RhdHVzX2Jv dCA9IFN0YXR1c0JvdChob3N0PW9wdGlvbnMuc3RhdHVzX2hvc3QpCiAKKyAgICAgICAgYnVnX2xv ZyA9IE5vbmUKICAgICAgICAgd2hpbGUgKFRydWUpOgorICAgICAgICAgICAgIyBJZiB3ZSBzdGls bCBoYXZlIGEgYnVnIGxvZyBvcGVuIGZyb20gdGhlIGxhc3QgbG9vcCwgY2xvc2UgaXQuCisgICAg ICAgICAgICBpZiBidWdfbG9nOgorICAgICAgICAgICAgICAgIHNlbGYuX3JlbW92ZV9sb2dfZnJv bV9vdXRwdXRfdGVlKGJ1Z19sb2cpCiAgICAgICAgICAgICAjIEVpdGhlciBvZiB0aGVzZSBjYWxs cyBjb3VsZCB0aHJvdyBVUkxFcnJvciB3aGljaCBzaG91bGRuJ3Qgc3RvcCB0aGUgcXVldWUuCiAg ICAgICAgICAgICAjIFdlIGNhdGNoIGFsbCBleGNlcHRpb25zIGp1c3QgaW4gY2FzZS4KICAgICAg ICAgICAgIHRyeToKQEAgLTc1OCwxMSArNzYyLDIyIEBAIGNsYXNzIExhbmRQYXRjaGVzRnJvbUNv bW1pdFF1ZXVlKENvbW1hbmQpOgogICAgICAgICAgICAgZXhjZXB0IFNjcmlwdEVycm9yLCBlOgog ICAgICAgICAgICAgICAgICMgVW5leHBlY3RlZCBmYWlsdXJlISAgTWFyayB0aGUgcGF0Y2ggYXMg Y29tbWl0LXF1ZXVlLSBhbmQgY29tbWVudCBpbiB0aGUgYnVnLgogICAgICAgICAgICAgICAgICMg ZXhpdCgyKSBpcyBhIHNwZWNpYWwgZXhpdCBjb2RlIHdlIHVzZSB0byBpbmRpY2F0ZSB0aGF0IHRo ZSBlcnJvciB3YXMgYWxyZWFkeSBoYW5kbGVkIGJ5IGxhbmQtcGF0Y2hlcyBhbmQgd2Ugc2hvdWxk IGtlZXAgbG9vcGluZyBhbnl3YXkuCi0gICAgICAgICAgICAgICAgaWYgZS5leGl0X2NvZGUgIT0g MjoKLSAgICAgICAgICAgICAgICAgICAgdG9vbC5idWdzLnJlamVjdF9wYXRjaF9mcm9tX2NvbW1p dF9xdWV1ZShwYXRjaFsnaWQnXSwgIlVuZXhwZWN0ZWQgZmFpbHVyZSB3aGVuIGxhbmRpbmcgcGF0 Y2ghICBQbGVhc2UgZmlsZSBhIGJ1ZyBhZ2FpbnN0IGJ1Z3ppbGxhLXRvb2wuXG4lcyIgJSBlLm1l c3NhZ2Vfd2l0aF9vdXRwdXQoKSkKLSAgICAgICAgICAgIHNlbGYuX3JlbW92ZV9sb2dfZnJvbV9v dXRwdXRfdGVlKGJ1Z19sb2cpCisgICAgICAgICAgICAgICAgaWYgZS5leGl0X2NvZGUgPT0gMjoK KyAgICAgICAgICAgICAgICAgICAgY29udGludWUKKyAgICAgICAgICAgICAgICBtZXNzYWdlID0g IlVuZXhwZWN0ZWQgZmFpbHVyZSB3aGVuIGxhbmRpbmcgcGF0Y2ghICBQbGVhc2UgZmlsZSBhIGJ1 ZyBhZ2FpbnN0IGJ1Z3ppbGxhLXRvb2wuXG4lcyIgJSBlLm1lc3NhZ2Vfd2l0aF9vdXRwdXQoKQor ICAgICAgICAgICAgICAgICMgV2UgZG9uJ3QgaGF2ZSBhIHBhdGNoIGlkIGF0IHRoaXMgcG9pbnQs IHNvIHRyeSB0byBncmFiIHRoZSBmaXJzdCBwYXRjaCBvZmYgb2YgdGhlIGJ1ZyBpbiBxdWVzdGlv bi4KKyAgICAgICAgICAgICAgICBwYXRjaGVzID0gdG9vbC5idWdzLmZldGNoX2NvbW1pdF9xdWV1 ZV9wYXRjaGVzX2Zyb21fYnVnKGZpcnN0X2J1Z19pZCkKKyAgICAgICAgICAgICAgICBub25fb2Jz b2xldGVfcGF0Y2hlcyA9IGZpbHRlcihsYW1iZGEgcGF0Y2g6IG5vdCBwYXRjaFsnaXNfb2Jzb2xl dGUnXSwgcGF0Y2hlcykKKyAgICAgICAgICAgICAgICBpZiBub3QgbGVuKG5vbl9vYnNvbGV0ZV9w YXRjaGVzKToKKyAgICAgICAgICAgICAgICAgICAgIyBJZiB0aGVyZSBhcmUgbm8gcGF0Y2hlcyBs ZWZ0IG9uIHRoZSBidWcsIGFzc3VtZSBsYW5kLXBhdGNoZXMgYWxyZWFkeSBjbG9zZWQgaXQgYmVm b3JlIGR5aW5nLCBhbmQganVzdCBjb250aW51ZS4KKyAgICAgICAgICAgICAgICAgICAgbG9nKG1l c3NhZ2UpCisgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlCisgICAgICAgICAgICAgICAgZmly c3RfcGF0Y2hfaWQgPSBub25fb2Jzb2xldGVfcGF0Y2hlc1swXVsnaWQnXQorICAgICAgICAgICAg ICAgIHRvb2wuYnVncy5yZWplY3RfcGF0Y2hfZnJvbV9jb21taXRfcXVldWUoZmlyc3RfcGF0Y2hf aWQsIG1lc3NhZ2UpCiAKLSAgICAgICAgbG9nKCJGaW5pc2hlZCBXZWJLaXQgQ29tbWl0IFF1ZXVl LiAlcyIgJSBkYXRldGltZS5ub3coKS5zdHJmdGltZShzZWxmLmxvZ19kYXRlX2Zvcm1hdCkpCisg ICAgICAgICMgTmV2ZXIgcmVhY2hlZC4KKyAgICAgICAgaWYgYnVnX2xvZzoKKyAgICAgICAgICAg IHNlbGYuX3JlbW92ZV9sb2dfZnJvbV9vdXRwdXRfdGVlKGJ1Z19sb2cpCiAgICAgICAgIHNlbGYu X3JlbW92ZV9sb2dfZnJvbV9vdXRwdXRfdGVlKHF1ZXVlX2xvZyk=