31089 2009-11-03 15:19:18 -0800 Uninitialized member m_createdByParser in WebCore::ProcessingInstruction 2019-02-06 09:02:32 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dank webkit-unassigned cdumez commit-queue oldest_to_newest 160237 0 dank 2009-11-03 15:19:18 -0800 Caught by the chromium valgrind layout bot. Valgrind complains Warning: set address range perms: large range [0x3901d000, 0x5901d000) (defined) Conditional jump or move depends on uninitialised value(s) at WebCore::Document::addStyleSheetCandidateNode(WebCore::Node*, bool) (Document.cpp:2411) by WebCore::ProcessingInstruction::insertedIntoDocument() (ProcessingInstruction.cpp:262) by WebCore::dispatchChildInsertionEvents(WebCore::Node*) (ContainerNode.cpp:876) ... Uninitialised value was created by a heap allocation at 0x4C2312C: malloc (vg_replace_malloc.c:195) by 0x13B3CDA: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:233) by 0x8B6AEE: WTF::FastAllocBase::operator new(unsigned long) (FastAllocBase.h:96) by 0xC1528A: WebCore::ProcessingInstruction::create(WebCore::Document*, WebCore::String const&, WebCore::String const&) (ProcessingInstruction.cpp:53) Looks like somebody forgot to initialize m_createdByParser. The following patch seems to resolve the problem: --- WebCore/dom/ProcessingInstruction.cpp (revision 50454) +++ WebCore/dom/ProcessingInstruction.cpp (working copy) @@ -42,6 +42,7 @@ , m_cachedSheet(0) , m_loading(false) , m_alternate(false) + , m_createdByParser(false) #if ENABLE(XSLT) , m_isXSL(false) #endif 160300 1 ap 2009-11-03 20:26:53 -0800 The fix looks right to me. Would you be willing to submit it for review, as described in <http://webkit.org/coding/contributing.html>? 160316 2 dank 2009-11-03 22:07:38 -0800 Sure, I'll do that in the morning, thanks. 160448 3 42484 dank 2009-11-04 08:38:09 -0800 Created attachment 42484 Add mising initializer Here y'go! 160481 4 42484 eric 2009-11-04 10:09:25 -0800 Comment on attachment 42484 Add mising initializer You can leave the "Reviewed by NOBODY (OOPS!)." line alone and our scripts will fill it in automatically with Alexey's full name when landing. It would be better for you to paste an un-altered NOBODY line, or to correct that to say "Alexey Proskuryakov." (with a period), before we land this. LGTM, and someone could land this manually with that fix, but we should get the ChangeLog completely right (either left as NOBODY (OOPS!) or changed to Alexey's full name with a period) if we want the commit-queue to land this. Thanks for the patch! 160566 5 42511 dank 2009-11-04 12:26:59 -0800 Created attachment 42511 2nd draft, with right 'reviewed by' In case it's useful, here is the patch with the suggested change. 160899 6 42511 dimich 2009-11-05 11:44:22 -0800 Comment on attachment 42511 2nd draft, with right 'reviewed by' r+, cq+, commit bot to substitute the right reviewer. 160910 7 42511 commit-queue 2009-11-05 11:57:17 -0800 Comment on attachment 42511 2nd draft, with right 'reviewed by' Clearing flags on attachment: 42511 Committed r50571: <http://trac.webkit.org/changeset/50571> 160911 8 commit-queue 2009-11-05 11:57:23 -0800 All reviewed patches have been landed. Closing bug. 1502789 9 lforschler 2019-02-06 09:02:32 -0800 Mass moving XML DOM bugs to the "DOM" Component. 42484 2009-11-04 08:38:09 -0800 2009-11-04 12:26:59 -0800 Add mising initializer webkit31089.patch text/plain 1092 dank SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDUxMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMTEtMDQgIERhbiBLZWdlbCAgPGRhbmtAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IGFwQHdlYmtpdC5vcmcKKworICAgICAgICBBZGQgbWlz c2luZyBpbml0aWFsaXphdGlvbiBmb3IgbV9jcmVhdGVkQnlQYXJzZXIuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTA4OQorCisgICAgICAgIFRlc3Q6 IGZhc3QvZG9tL2JlZm9yZWxvYWQvcGktYmVmb3JlLWxvYWQueGh0bWwgdW5kZXIgdmFsZ3JpbmQK KworICAgICAgICAqIGRvbS9Qcm9jZXNzaW5nSW5zdHJ1Y3Rpb24uY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UHJvY2Vzc2luZ0luc3RydWN0aW9uOjpQcm9jZXNzaW5nSW5zdHJ1Y3Rpb24pOgorCiAy MDA5LTExLTA0ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAg ICAgVW5yZXZpZXdlZCByb2xsb3V0LgpJbmRleDogV2ViQ29yZS9kb20vUHJvY2Vzc2luZ0luc3Ry dWN0aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9Qcm9jZXNzaW5nSW5zdHJ1Y3Rp b24uY3BwCShyZXZpc2lvbiA1MDUxMSkKKysrIFdlYkNvcmUvZG9tL1Byb2Nlc3NpbmdJbnN0cnVj dGlvbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQyLDYgKzQyLDcgQEAgaW5saW5lIFByb2Nlc3Np bmdJbnN0cnVjdGlvbjo6UHJvY2Vzc2luZwogICAgICwgbV9jYWNoZWRTaGVldCgwKQogICAgICwg bV9sb2FkaW5nKGZhbHNlKQogICAgICwgbV9hbHRlcm5hdGUoZmFsc2UpCisgICAgLCBtX2NyZWF0 ZWRCeVBhcnNlcihmYWxzZSkKICNpZiBFTkFCTEUoWFNMVCkKICAgICAsIG1faXNYU0woZmFsc2Up CiAjZW5kaWYK 42511 2009-11-04 12:26:59 -0800 2009-11-05 11:57:17 -0800 2nd draft, with right 'reviewed by' webkit31089.patch text/plain 1091 dank SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDUxMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMTEtMDQgIERhbiBLZWdlbCAgPGRhbmtAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBt aXNzaW5nIGluaXRpYWxpemF0aW9uIGZvciBtX2NyZWF0ZWRCeVBhcnNlci4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxMDg5CisKKyAgICAgICAgVGVz dDogZmFzdC9kb20vYmVmb3JlbG9hZC9waS1iZWZvcmUtbG9hZC54aHRtbCBpbiBWYWxncmluZAor CisgICAgICAgICogZG9tL1Byb2Nlc3NpbmdJbnN0cnVjdGlvbi5jcHA6CisgICAgICAgIChXZWJD b3JlOjpQcm9jZXNzaW5nSW5zdHJ1Y3Rpb246OlByb2Nlc3NpbmdJbnN0cnVjdGlvbik6CisKIDIw MDktMTEtMDQgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAg ICBVbnJldmlld2VkIHJvbGxvdXQuCkluZGV4OiBXZWJDb3JlL2RvbS9Qcm9jZXNzaW5nSW5zdHJ1 Y3Rpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZG9tL1Byb2Nlc3NpbmdJbnN0cnVjdGlv bi5jcHAJKHJldmlzaW9uIDUwNTExKQorKysgV2ViQ29yZS9kb20vUHJvY2Vzc2luZ0luc3RydWN0 aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDIsNiArNDIsNyBAQCBpbmxpbmUgUHJvY2Vzc2lu Z0luc3RydWN0aW9uOjpQcm9jZXNzaW5nCiAgICAgLCBtX2NhY2hlZFNoZWV0KDApCiAgICAgLCBt X2xvYWRpbmcoZmFsc2UpCiAgICAgLCBtX2FsdGVybmF0ZShmYWxzZSkKKyAgICAsIG1fY3JlYXRl ZEJ5UGFyc2VyKGZhbHNlKQogI2lmIEVOQUJMRShYU0xUKQogICAgICwgbV9pc1hTTChmYWxzZSkK ICNlbmRpZgo=