31064 2009-11-03 09:21:40 -0800 Web Inspector: Implement timeline summary panel. 2009-11-03 10:00:24 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman bweinstein joepeck rik timothy oldest_to_newest 160084 0 pfeldman 2009-11-03 09:21:40 -0800 Patch will follow. 160088 1 42389 pfeldman 2009-11-03 09:28:20 -0800 Created attachment 42389 [PATCH] Proposed patch. 160094 2 42389 timothy 2009-11-03 09:46:59 -0800 Comment on attachment 42389 [PATCH] Proposed patch. > + // Create sparse arrays 101 cell each to fill with chunks for a given category. Should be: "Create sparse arrays with 101 cells each…" > + // Convert sparse arrays to continues segments, render graphs for each. Should be "Convert sparse arrays to continuous segments…" > + while (this._barAreaElement.firstChild) > + this._barAreaElement.removeChild(this._barAreaElement.firstChild); Just do this._barAreaElement.removeChildren() (from utilities.js) 160104 3 pfeldman 2009-11-03 09:57:26 -0800 (In reply to comment #2) > (From update of attachment 42389 [details]) > > > + // Create sparse arrays 101 cell each to fill with chunks for a given category. > > Should be: "Create sparse arrays with 101 cells each…" > Done. > > + // Convert sparse arrays to continues segments, render graphs for each. > > Should be "Convert sparse arrays to continuous segments…" > Done. > > + while (this._barAreaElement.firstChild) > > + this._barAreaElement.removeChild(this._barAreaElement.firstChild); > > Just do this._barAreaElement.removeChildren() (from utilities.js) Done. 160106 4 pfeldman 2009-11-03 10:00:24 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/TimelinePanel.js M WebCore/inspector/front-end/inspector.css Committed r50463 42389 2009-11-03 09:28:20 -0800 2009-11-03 09:46:59 -0800 [PATCH] Proposed patch. timeline_summary text/plain 7353 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OWI2MWMxNC4uYWY5YzYwNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMyBAQAogMjAwOS0xMS0wMyAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbXBsZW1lbnQgdGltZWxpbmUgc3Vt bWFyeSBwYW5lbC4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MzEwNjQKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVQYW5l bC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZVBhbmVsLnByb3RvdHlwZS5fY3Jl YXRlT3ZlcnZpZXcpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUGFuZWwucHJvdG90 eXBlLnJlZnJlc2gpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lQ2F0ZWdvcnlHcmFw aCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVDYXRlZ29yeUdyYXBoLnByb3RvdHlw ZS5nZXQgZ3JhcGhFbGVtZW50KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZUNhdGVn b3J5R3JhcGgucHJvdG90eXBlLmFkZENodW5rKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1l bGluZUNhdGVnb3J5R3JhcGgucHJvdG90eXBlLmNsZWFyQ2h1bmtzKToKKyAgICAgICAgKFdlYklu c3BlY3Rvci5UaW1lbGluZUdyYXBoLnByb3RvdHlwZS5yZWZyZXNoKToKKyAgICAgICAgKiBpbnNw ZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5jc3M6CisKKzIwMDktMTEtMDMgIFBhdmVsIEZlbGRt YW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgVGltb3Ro eSBIYXRjaGVyLgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEltcGxlbWVudCBUaW1lbGluZSBX aW5kb3csIHdpcmUgaXQgdG8gdGhlIGJvdHRvbSB0aW1lbGluZS4KZGlmZiAtLWdpdCBhL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZVBhbmVsLmpzIGIvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMKaW5kZXggMWQ5ODRiYS4uZDljNDA1NiAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMKKysr IGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMKQEAgLTIyMyw2 ICsyMjMsMTQgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUGFuZWwucHJvdG90eXBlID0gewogICAg ICAgICB0aGlzLl9vdmVydmlld0dyaWRFbGVtZW50LmlkID0gInRpbWVsaW5lLW92ZXJ2aWV3LWdy aWQiOwogICAgICAgICBvdmVydmlld1BhbmVsRWxlbWVudC5hcHBlbmRDaGlsZCh0aGlzLl9vdmVy dmlld0dyaWRFbGVtZW50KTsKICAgICAgICAgdGhpcy5fb3ZlcnZpZXdHcmlkID0gbmV3IFdlYklu c3BlY3Rvci5UaW1lbGluZUdyaWQodGhpcy5fb3ZlcnZpZXdHcmlkRWxlbWVudCk7CisgICAgICAg IHRoaXMuX292ZXJ2aWV3R3JpZC5pdGVtc0dyYXBoc0VsZW1lbnQuaWQgPSAidGltZWxpbmUtb3Zl cnZpZXctZ3JhcGhzIjsKKworICAgICAgICB0aGlzLl9jYXRlZ29yeUdyYXBocyA9IHt9OworICAg ICAgICBmb3IgKHZhciBjYXRlZ29yeSBpbiB0aGlzLmNhdGVnb3JpZXMpIHsKKyAgICAgICAgICAg IHZhciBjYXRlZ29yeUdyYXBoID0gbmV3IFdlYkluc3BlY3Rvci5UaW1lbGluZUNhdGVnb3J5R3Jh cGgodGhpcy5jYXRlZ29yaWVzW2NhdGVnb3J5XSk7CisgICAgICAgICAgICB0aGlzLl9jYXRlZ29y eUdyYXBoc1tjYXRlZ29yeV0gPSBjYXRlZ29yeUdyYXBoOworICAgICAgICAgICAgdGhpcy5fb3Zl cnZpZXdHcmlkLml0ZW1zR3JhcGhzRWxlbWVudC5hcHBlbmRDaGlsZChjYXRlZ29yeUdyYXBoLmdy YXBoRWxlbWVudCk7CisgICAgICAgIH0KICAgICAgICAgdGhpcy5fb3ZlcnZpZXdHcmlkLnNldFNj cm9sbEFuZERpdmlkZXJUb3AoMCwgMCk7CiAKICAgICAgICAgdGhpcy5fb3ZlcnZpZXdXaW5kb3dF bGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CkBAIC0yNzEsNiArMjc5LDQ2 IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZVBhbmVsLnByb3RvdHlwZSA9IHsKICAgICB7CiAgICAg ICAgIFdlYkluc3BlY3Rvci5BYnN0cmFjdFRpbWVsaW5lUGFuZWwucHJvdG90eXBlLnJlZnJlc2gu Y2FsbCh0aGlzKTsKICAgICAgICAgdGhpcy5fb3ZlcnZpZXdHcmlkLnVwZGF0ZURpdmlkZXJzKHRy dWUsIHRoaXMuX292ZXJ2aWV3Q2FsY3VsYXRvcik7CisKKyAgICAgICAgLy8gQ2xlYXIgc3VtbWFy eSBiYXJzLgorICAgICAgICB2YXIgdGltZWxpbmVzID0ge307CisgICAgICAgIGZvciAodmFyIGNh dGVnb3J5IGluIHRoaXMuY2F0ZWdvcmllcykgeworICAgICAgICAgICAgdGltZWxpbmVzW2NhdGVn b3J5XSA9IFtdOworICAgICAgICAgICAgdGhpcy5fY2F0ZWdvcnlHcmFwaHNbY2F0ZWdvcnldLmNs ZWFyQ2h1bmtzKCk7CisgICAgICAgIH0KKworICAgICAgICAvLyBDcmVhdGUgc3BhcnNlIGFycmF5 cyAxMDEgY2VsbCBlYWNoIHRvIGZpbGwgd2l0aCBjaHVua3MgZm9yIGEgZ2l2ZW4gY2F0ZWdvcnku CisgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgdGhpcy5pdGVtcy5sZW5ndGg7ICsraSkgewor ICAgICAgICAgICAgdmFyIHJlY29yZCA9IHRoaXMuaXRlbXNbaV07CisgICAgICAgICAgICB0aGlz Ll9vdmVydmlld0NhbGN1bGF0b3IudXBkYXRlQm91bmRhcmllcyhyZWNvcmQpOworICAgICAgICAg ICAgdmFyIHBlcmNlbnRhZ2VzID0gdGhpcy5fb3ZlcnZpZXdDYWxjdWxhdG9yLmNvbXB1dGVCYXJH cmFwaFBlcmNlbnRhZ2VzKHJlY29yZCk7CisgICAgICAgICAgICB2YXIgZW5kID0gTWF0aC5yb3Vu ZChwZXJjZW50YWdlcy5lbmQpOworICAgICAgICAgICAgdmFyIGNhdGVnb3J5TmFtZSA9IHJlY29y ZC5jYXRlZ29yeS5uYW1lOworICAgICAgICAgICAgZm9yICh2YXIgaiA9IE1hdGgucm91bmQocGVy Y2VudGFnZXMuc3RhcnQpOyBqIDw9IGVuZDsgKytqKQorICAgICAgICAgICAgICAgIHRpbWVsaW5l c1tjYXRlZ29yeU5hbWVdW2pdID0gdHJ1ZTsKKyAgICAgICAgfQorCisgICAgICAgIC8vIENvbnZl cnQgc3BhcnNlIGFycmF5cyB0byBjb250aW51ZXMgc2VnbWVudHMsIHJlbmRlciBncmFwaHMgZm9y IGVhY2guCisgICAgICAgIGZvciAodmFyIGNhdGVnb3J5IGluIHRoaXMuY2F0ZWdvcmllcykgewor ICAgICAgICAgICAgdmFyIHRpbWVsaW5lID0gdGltZWxpbmVzW2NhdGVnb3J5XTsKKyAgICAgICAg ICAgIHdpbmRvdy50aW1lbGluZVNhdmVkID0gdGltZWxpbmU7CisgICAgICAgICAgICB2YXIgY2h1 bmtTdGFydCA9IC0xOworICAgICAgICAgICAgZm9yICh2YXIgaiA9IDA7IGogPCAxMDE7ICsraikg eworICAgICAgICAgICAgICAgIGlmICh0aW1lbGluZVtqXSkgeworICAgICAgICAgICAgICAgICAg ICBpZiAoY2h1bmtTdGFydCA9PT0gLTEpCisgICAgICAgICAgICAgICAgICAgICAgICBjaHVua1N0 YXJ0ID0gajsKKyAgICAgICAgICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgICAgICAgICBp ZiAoY2h1bmtTdGFydCAhPT0gLTEpIHsKKyAgICAgICAgICAgICAgICAgICAgICAgIHRoaXMuX2Nh dGVnb3J5R3JhcGhzW2NhdGVnb3J5XS5hZGRDaHVuayhjaHVua1N0YXJ0LCBqKTsKKyAgICAgICAg ICAgICAgICAgICAgICAgIGNodW5rU3RhcnQgPSAtMTsKKyAgICAgICAgICAgICAgICAgICAgfQor ICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIGlmIChjaHVua1N0 YXJ0ICE9PSAtMSkgeworICAgICAgICAgICAgICAgIHRoaXMuX2NhdGVnb3J5R3JhcGhzW2NhdGVn b3J5XS5hZGRDaHVuayhjaHVua1N0YXJ0LCAxMDApOworICAgICAgICAgICAgICAgIGNodW5rU3Rh cnQgPSAtMTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQogICAgIH0sCiAKICAgICBfcmVzaXpl V2luZG93OiBmdW5jdGlvbihyZXNpemVFbGVtZW50LCBldmVudCkKQEAgLTUxOCw2ICs1NjYsNDEg QEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lQ2FsY3VsYXRvci5wcm90b3R5cGUgPSB7CiBXZWJJbnNw ZWN0b3IuVGltZWxpbmVDYWxjdWxhdG9yLnByb3RvdHlwZS5fX3Byb3RvX18gPSBXZWJJbnNwZWN0 b3IuQWJzdHJhY3RUaW1lbGluZUNhbGN1bGF0b3IucHJvdG90eXBlOwogCiAKK1dlYkluc3BlY3Rv ci5UaW1lbGluZUNhdGVnb3J5R3JhcGggPSBmdW5jdGlvbihjYXRlZ29yeSkKK3sKKyAgICB0aGlz Ll9jYXRlZ29yeSA9IGNhdGVnb3J5OworCisgICAgdGhpcy5fZ3JhcGhFbGVtZW50ID0gZG9jdW1l bnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CisgICAgdGhpcy5fZ3JhcGhFbGVtZW50LmNsYXNzTmFt ZSA9ICJ0aW1lbGluZS1ncmFwaC1zaWRlIHRpbWVsaW5lLW92ZXJ2aWV3LWdyYXBoLXNpZGUgZmls dGVyLWFsbCI7CisKKyAgICB0aGlzLl9iYXJBcmVhRWxlbWVudCA9IGRvY3VtZW50LmNyZWF0ZUVs ZW1lbnQoImRpdiIpOworICAgIHRoaXMuX2JhckFyZWFFbGVtZW50LmNsYXNzTmFtZSA9ICJ0aW1l bGluZS1ncmFwaC1iYXItYXJlYSB0aW1lbGluZS1jYXRlZ29yeS0iICsgY2F0ZWdvcnkubmFtZTsK KyAgICB0aGlzLl9ncmFwaEVsZW1lbnQuYXBwZW5kQ2hpbGQodGhpcy5fYmFyQXJlYUVsZW1lbnQp OworfQorCitXZWJJbnNwZWN0b3IuVGltZWxpbmVDYXRlZ29yeUdyYXBoLnByb3RvdHlwZSA9IHsK KyAgICBnZXQgZ3JhcGhFbGVtZW50KCkKKyAgICB7CisgICAgICAgIHJldHVybiB0aGlzLl9ncmFw aEVsZW1lbnQ7CisgICAgfSwKKworICAgIGFkZENodW5rOiBmdW5jdGlvbihzdGFydCwgZW5kKQor ICAgIHsKKyAgICAgICAgdmFyIGNodW5rID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7 CisgICAgICAgIGNodW5rLmNsYXNzTmFtZSA9ICJ0aW1lbGluZS1ncmFwaC1iYXIiOworICAgICAg ICB0aGlzLl9iYXJBcmVhRWxlbWVudC5hcHBlbmRDaGlsZChjaHVuayk7CisgICAgICAgIGNodW5r LnN0eWxlLnNldFByb3BlcnR5KCJsZWZ0Iiwgc3RhcnQgKyAiJSIpOworICAgICAgICBjaHVuay5z dHlsZS5zZXRQcm9wZXJ0eSgid2lkdGgiLCAoZW5kIC0gc3RhcnQpICsgIiUiKTsKKyAgICB9LAor CisgICAgY2xlYXJDaHVua3M6IGZ1bmN0aW9uKCkKKyAgICB7CisgICAgICAgIHdoaWxlICh0aGlz Ll9iYXJBcmVhRWxlbWVudC5maXJzdENoaWxkKQorICAgICAgICAgICAgdGhpcy5fYmFyQXJlYUVs ZW1lbnQucmVtb3ZlQ2hpbGQodGhpcy5fYmFyQXJlYUVsZW1lbnQuZmlyc3RDaGlsZCk7CisgICAg fQorfQorCisKIFdlYkluc3BlY3Rvci5UaW1lbGluZUdyYXBoID0gZnVuY3Rpb24ocmVjb3JkKQog ewogICAgIHRoaXMucmVjb3JkID0gcmVjb3JkOwpAQCAtNTU1LDExICs2MzgsNiBAQCBXZWJJbnNw ZWN0b3IuVGltZWxpbmVHcmFwaC5wcm90b3R5cGUgPSB7CiAKICAgICAgICAgdGhpcy5fYmFyQXJl YUVsZW1lbnQucmVtb3ZlU3R5bGVDbGFzcygiaGlkZGVuIik7CiAKLSAgICAgICAgaWYgKCF0aGlz Ll9ncmFwaEVsZW1lbnQuaGFzU3R5bGVDbGFzcygidGltZWxpbmUtY2F0ZWdvcnktIiArIHRoaXMu cmVjb3JkLmNhdGVnb3J5Lm5hbWUpKSB7Ci0gICAgICAgICAgICB0aGlzLl9ncmFwaEVsZW1lbnQu cmVtb3ZlTWF0Y2hpbmdTdHlsZUNsYXNzZXMoInRpbWVsaW5lLWNhdGVnb3J5LVxcdysiKTsKLSAg ICAgICAgICAgIHRoaXMuX2dyYXBoRWxlbWVudC5hZGRTdHlsZUNsYXNzKCJ0aW1lbGluZS1jYXRl Z29yeS0iICsgdGhpcy5yZWNvcmQuY2F0ZWdvcnkubmFtZSk7Ci0gICAgICAgIH0KLQogICAgICAg ICB0aGlzLl9iYXJFbGVtZW50LnN0eWxlLnNldFByb3BlcnR5KCJsZWZ0IiwgcGVyY2VudGFnZXMu c3RhcnQgKyAiJSIpOwogICAgICAgICB0aGlzLl9iYXJFbGVtZW50LnN0eWxlLnNldFByb3BlcnR5 KCJyaWdodCIsICgxMDAgLSBwZXJjZW50YWdlcy5lbmQpICsgIiUiKTsKIApkaWZmIC0tZ2l0IGEv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5jc3MgYi9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmNzcwppbmRleCBkMGYxZTlmLi44ZDhmMGUzIDEwMDY0 NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmNzcworKysgYi9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmNzcwpAQCAtMzQxNiw2ICszNDE2 LDE0IEBAIGJvZHkuaW5hY3RpdmUgLnNpZGViYXItdHJlZS1pdGVtLnNlbGVjdGVkIC5idWJibGUu c2VhcmNoLW1hdGNoZXMgewogICAgIGRpc3BsYXk6IGxpc3QtaXRlbTsKIH0KIAorI3RpbWVsaW5l LW92ZXJ2aWV3LWdyYXBocyB7CisgICAgcG9zaXRpb246IGFic29sdXRlOworICAgIGxlZnQ6IDA7 CisgICAgcmlnaHQ6IDA7CisgICAgYm90dG9tOiAwOworICAgIHRvcDogMjBweDsKK30KKwogI3Rp bWVsaW5lLWdyYXBocyB7CiAgICAgcG9zaXRpb246IGFic29sdXRlOwogICAgIGxlZnQ6IDA7CkBA IC0zNDMyLDYgKzM0NDAsMTMgQEAgYm9keS5pbmFjdGl2ZSAuc2lkZWJhci10cmVlLWl0ZW0uc2Vs ZWN0ZWQgLmJ1YmJsZS5zZWFyY2gtbWF0Y2hlcyB7CiAgICAgbWFyZ2luLXRvcDogMHB4OwogICAg IGJvcmRlci10b3A6IDFweCBzb2xpZCB0cmFuc3BhcmVudDsKICAgICBvdmVyZmxvdzogaGlkZGVu OworICAgIHBvaW50ZXItZXZlbnRzOiBub25lOworfQorCisudGltZWxpbmUtb3ZlcnZpZXctZ3Jh cGgtc2lkZSB7CisgICAgaGVpZ2h0OiAyMHB4OworICAgIHotaW5kZXg6IDE3MDsKKyAgICBwb2lu dGVyLWV2ZW50czogbm9uZTsKIH0KIAogLnRpbWVsaW5lLWdyYXBoLWJhci1hcmVhIHsKQEAgLTM0 NDAsNiArMzQ1NSw3IEBAIGJvZHkuaW5hY3RpdmUgLnNpZGViYXItdHJlZS1pdGVtLnNlbGVjdGVk IC5idWJibGUuc2VhcmNoLW1hdGNoZXMgewogICAgIGJvdHRvbTogMDsKICAgICByaWdodDogOHB4 OwogICAgIGxlZnQ6IDlweDsKKyAgICBwb2ludGVyLWV2ZW50czogbm9uZTsKIH0KIAogLnRpbWVs aW5lLWdyYXBoLWJhciB7CkBAIC0zNDUyLDYgKzM0NjgsNyBAQCBib2R5LmluYWN0aXZlIC5zaWRl YmFyLXRyZWUtaXRlbS5zZWxlY3RlZCAuYnViYmxlLnNlYXJjaC1tYXRjaGVzIHsKICAgICBtaW4t d2lkdGg6IDdweDsKICAgICBvcGFjaXR5OiAwLjg7CiAgICAgLXdlYmtpdC1ib3JkZXItaW1hZ2U6 IHVybChJbWFnZXMvdGltZWxpbmVCYXJHcmF5LnBuZykgNCA0IDUgNDsKKyAgICBwb2ludGVyLWV2 ZW50czogbm9uZTsKIH0KIAogLnRpbWVsaW5lLWdyYXBoLXNpZGU6bnRoLW9mLXR5cGUoMm4pIHsK