31058 2009-11-03 06:52:59 -0800 [Qt] QWebSettings using unitialized values 2009-11-16 05:55:31 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Other All RESOLVED INVALID P3 Normal --- 0 daniel.teske webkit-unassigned hausmann jturcotte oldest_to_newest 160055 0 daniel.teske 2009-11-03 06:52:59 -0800 The QWebSettings(WebCore::Settings* settings) ctor does access unitialized values. The current code: QWebSettings::QWebSettings(WebCore::Settings* settings) : d(new QWebSettingsPrivate(settings)) { d->settings = settings; d->apply(); allSettings()->append(d); } does not correctly initialize d->printingMinimumShrinkFactor d->printingMaximumShrinkFactor and d->offlineStorageDefaultQuota, since the QWebSettingsPrivate ctor also does not set those values. But the inside QWebSettignsPrivate::apply() d->printingMinimumShrinkFactor and d->printingMaximumShrinkFactor are accessed. This generates the following valgrind warnings: 40: ==10098== Conditional jump or move depends on uninitialised value(s) 41: ==10098== at 0x9D04BB9: QWebSettingsPrivate::apply() (in /home/apoenitz/dev/qt-4.6/lib/libQtWebKitMyns.so.4.6.0) 42: ==10098== by 0x9D0591A: QWebSettings::QWebSettings(WebCore::Settings*) (in /home/apoenitz/dev/qt-4.6/lib/libQtWebKitMyns.so.4.6.0) 43: ==10098== by 0x9CF16AF: QWebPagePrivate::QWebPagePrivate(QWebPage*) (in /home/apoenitz/dev/qt-4.6/lib/libQtWebKitMyns.so.4.6.0) 44: ==10098== by 0x9CF19FE: QWebPage::QWebPage(myns::QObject*) (in /home/apoenitz/dev/qt-4.6/lib/libQtWebKitMyns.so.4.6.0) 45: ==10098== by 0x93E6B65: HelpPage::HelpPage(Help::Internal::CentralWidget*, myns::QHelpEngine*, myns::QObject*) (helpviewer.cpp:171) 46: ==10098== by 0x93E6D0D: HelpViewer::HelpViewer(myns::QHelpEngine*, Help::Internal::CentralWidget*) (helpviewer.cpp:240) 47: ==10098== by 0x93C03E4: Help::Internal::HelpPlugin::createRightPaneSideBar() (helpplugin.cpp:494) 48: ==10098== by 0x93C60E1: Help::Internal::HelpPlugin::initialize(myns::QStringList const&, myns::QString*) (helpplugin.cpp:408) 49: ==10098== by 0x40469F6: ExtensionSystem::Internal::PluginSpecPrivate::initializePlugin() (pluginspec.cpp:827) 50: ==10098== by 0x403EF99: ExtensionSystem::Internal::PluginManagerPrivate::loadPlugin(ExtensionSystem::PluginSpec*, ExtensionSystem::PluginSpec::State) (pluginmanager.cpp:677) 51: ==10098== by 0x403FE8E: ExtensionSystem::Internal::PluginManagerPrivate::loadPlugins() (pluginmanager.cpp:582) 52: ==10098== by 0x404000F: ExtensionSystem::PluginManager::loadPlugins() (pluginmanager.cpp:246) 53: ==10098== Uninitialised value was created by a heap allocation 54: ==10098== at 0x40269EE: operator new(unsigned int) (vg_replace_malloc.c:224) 55: ==10098== by 0x9D058E5: QWebSettings::QWebSettings(WebCore::Settings*) (in /home/apoenitz/dev/qt-4.6/lib/libQtWebKitMyns.so.4.6.0) 56: ==10098== by 0x9CF16AF: QWebPagePrivate::QWebPagePrivate(QWebPage*) (in /home/apoenitz/dev/qt-4.6/lib/libQtWebKitMyns.so.4.6.0) 57: ==10098== by 0x9CF19FE: QWebPage::QWebPage(myns::QObject*) (in /home/apoenitz/dev/qt-4.6/lib/libQtWebKitMyns.so.4.6.0) 58: ==10098== by 0x93E6B65: HelpPage::HelpPage(Help::Internal::CentralWidget*, myns::QHelpEngine*, myns::QObject*) (helpviewer.cpp:171) 59: ==10098== by 0x93E6D0D: HelpViewer::HelpViewer(myns::QHelpEngine*, Help::Internal::CentralWidget*) (helpviewer.cpp:240) 60: ==10098== by 0x93C03E4: Help::Internal::HelpPlugin::createRightPaneSideBar() (helpplugin.cpp:494) 61: ==10098== by 0x93C60E1: Help::Internal::HelpPlugin::initialize(myns::QStringList const&, myns::QString*) (helpplugin.cpp:408) 62: ==10098== by 0x40469F6: ExtensionSystem::Internal::PluginSpecPrivate::initializePlugin() (pluginspec.cpp:827) 63: ==10098== by 0x403EF99: ExtensionSystem::Internal::PluginManagerPrivate::loadPlugin(ExtensionSystem::PluginSpec*, ExtensionSystem::PluginSpec::State) (pluginmanager.cpp:677) 64: ==10098== by 0x403FE8E: ExtensionSystem::Internal::PluginManagerPrivate::loadPlugins() (pluginmanager.cpp:582) 65: ==10098== by 0x404000F: ExtensionSystem::PluginManager::loadPlugins() (pluginmanager.cpp:246) 161628 1 42763 manish.5.gupta 2009-11-09 10:04:39 -0800 Created attachment 42763 Providing Initialization of variables in constructor 161874 2 42763 eric 2009-11-09 17:50:03 -0800 Comment on attachment 42763 Providing Initialization of variables in constructor This does not comply with teh webkit style guide. http://webkit.org/coding/coding-style.html Please run check-webkit-style against the file or the patch. 162059 3 42868 manish.5.gupta 2009-11-10 08:30:29 -0800 Created attachment 42868 initialization of variables in constructor, webkit compliant code style 162639 4 42868 hausmann 2009-11-11 13:08:07 -0800 Comment on attachment 42868 initialization of variables in constructor, webkit compliant code style Good catch! 162890 5 jturcotte 2009-11-12 06:09:39 -0800 This is a duplicate of bug #30755. Both bugs have proposed patches so I'm not in position of knowing which one should be closed as duplicate. Also note that both submitted patches depends on changes of bug #29042 which have been reverted to be postponed to 4.7. Please consider it before committing. 162893 6 42868 kenneth 2009-11-12 06:37:16 -0800 Comment on attachment 42868 initialization of variables in constructor, webkit compliant code style The code was been reverted, so marking r-. I also noticed these issues yesterday due to crashes in the DRT, but didn't review this patch as Benjamin and me decided to revert the patch introducing the change instead, 163971 7 hausmann 2009-11-16 05:55:31 -0800 Closing this bug as rolling out the original patch also fixed this UMR. 42763 2009-11-09 10:04:39 -0800 2009-11-10 08:30:29 -0800 Providing Initialization of variables in constructor bug31058.patch text/plain 1054 manish.5.gupta SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNTA2NjApCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTEtMDkgIEd1cHRhIE1hbmlzaCAgPE1hbmlzaC41 Lmd1cHRhQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBbUXRdIFFXZWJTZXR0aW5ncyB1c2luZyB1bmluaXRpYWxpemVkIHZhbHVlcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzEwNTgKKwor ICAgICAgICAqIEFwaS9xd2Vic2V0dGluZ3MuY3BwOgorICAgICAgICAoUVdlYlNldHRpbmdzUHJp dmF0ZTo6UVdlYlNldHRpbmdzUHJpdmF0ZSk6CisKIDIwMDktMTEtMDkgIExhc3psbyBHb21ib3Mg IDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5l dGggQ2hyaXN0aWFuc2VuLgpJbmRleDogV2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmNwcAkocmV2aXNpb24gNTA2 NTUpCisrKyBXZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTUyLDYgKzUyLDggQEAgcHVibGljOgogICAgIFFXZWJTZXR0aW5nc1ByaXZhdGUoV2ViQ29yZTo6 U2V0dGluZ3MqIHdjU2V0dGluZ3MgPSAwKQogICAgICAgICA6IHNldHRpbmdzKHdjU2V0dGluZ3Mp CiAgICAgeworICAgICAgICBwcmludGluZ01pbmltdW1TaHJpbmtGYWN0b3I9MC4wZjsKKyAgICAg ICAgcHJpbnRpbmdNYXhpbXVtU2hyaW5rRmFjdG9yPTAuMGY7CiAgICAgfQogCiAgICAgUUhhc2g8 aW50LCBRU3RyaW5nPiBmb250RmFtaWxpZXM7Cg== 42868 2009-11-10 08:30:29 -0800 2009-11-12 06:37:15 -0800 initialization of variables in constructor, webkit compliant code style bug31058.patch text/plain 1054 manish.5.gupta SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNTA3MzcpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTEtMTAgIEd1cHRhIE1hbmlzaCAgPE1hbmlzaC41 Lmd1cHRhQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBbUXRdIFFXZWJTZXR0aW5ncyB1c2luZyB1bmluaXRpYWxpemVkIHZhbHVlcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzEwNTgKKwor ICAgICAgICAqIEFwaS9xd2Vic2V0dGluZ3MuY3BwOgorICAgICAgICAoUVdlYlNldHRpbmdzUHJp dmF0ZTo6UVdlYlNldHRpbmdzUHJpdmF0ZSk6CisKIDIwMDktMTEtMDkgIExhc3psbyBHb21ib3Mg IDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5l dGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpJbmRleDogV2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3Mu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmNwcAkocmV2aXNp b24gNTA3MzcpCisrKyBXZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTUxLDYgKzUxLDggQEAgY2xhc3MgUVdlYlNldHRpbmdzUHJpdmF0ZSB7CiBwdWJsaWM6 CiAgICAgUVdlYlNldHRpbmdzUHJpdmF0ZShXZWJDb3JlOjpTZXR0aW5ncyogd2NTZXR0aW5ncyA9 IDApCiAgICAgICAgIDogc2V0dGluZ3Mod2NTZXR0aW5ncykKKyAgICAgICAgLCBwcmludGluZ01p bmltdW1TaHJpbmtGYWN0b3IoMC4wZikKKyAgICAgICAgLCBwcmludGluZ01heGltdW1TaHJpbmtG YWN0b3IoMC4wZikKICAgICB7CiAgICAgfQogCg==