31041 2009-11-02 20:33:14 -0800 Improve SecurityOrigin::toString comment 2009-11-12 19:05:55 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned commit-queue fishd oldest_to_newest 159976 0 abarth 2009-11-02 20:33:14 -0800 This comment confused fishd today. Let's make it better. Patch forthcoming. 159977 1 42357 abarth 2009-11-02 20:49:09 -0800 Created attachment 42357 Patch 159983 2 42357 fishd 2009-11-02 21:28:21 -0800 Comment on attachment 42357 Patch r=me, thanks!! > Index: WebCore/page/SecurityOrigin.h ... > + // shouldTreatURLSchemeAsNoAccess). nit: no trailing ')' 159984 3 abarth 2009-11-02 21:30:04 -0800 (In reply to comment #2) > (From update of attachment 42357 [details]) > r=me, thanks!! > > > Index: WebCore/page/SecurityOrigin.h > ... > > + // shouldTreatURLSchemeAsNoAccess). > > nit: no trailing ')' Ah. Left over editing crud. 163145 4 43123 abarth 2009-11-12 18:27:44 -0800 Created attachment 43123 remove ) 163173 5 43123 commit-queue 2009-11-12 19:05:50 -0800 Comment on attachment 43123 remove ) Clearing flags on attachment: 43123 Committed r50924: <http://trac.webkit.org/changeset/50924> 163174 6 commit-queue 2009-11-12 19:05:55 -0800 All reviewed patches have been landed. Closing bug. 42357 2009-11-02 20:49:09 -0800 2009-11-12 18:27:44 -0800 Patch bug-31041-20091102204907.patch text/plain 1986 abarth PyAgICAgICBodWJidWIucGF0Y2gKPyAgICAgICB0dHQKPyAgICAgICBXZWJLaXQvd2luL1dlYlZp ZXcuY3BwLm9yaWcKPyAgICAgICBXZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbS5vcmlnCj8g ICAgICAgV2ViQ29yZS9XZWJDb3JlLmd5cGkub3JpZwo/ICAgICAgIFdlYkNvcmUvR05VbWFrZWZp bGUuYW0ub3JpZwo/ICAgICAgIFdlYkNvcmUvcGFnZS9QYWdlLmNwcC5vcmlnCj8gICAgICAgV2Vi Q29yZS9XZWJDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oub3JpZwpJbmRleDogV2ViQ29y ZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUw NDM5KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBA QAorMjAwOS0xMS0wMiAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltcHJvdmUgU2VjdXJpdHlP cmlnaW46OnRvU3RyaW5nIGNvbW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTMxMDQxCisKKyAgICAgICAgKiBwYWdlL1NlY3VyaXR5T3JpZ2luLmg6 CisKIDIwMDktMTEtMDIgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBS dWJiZXItc3RhbXBlZCBieSBCcmFkeSBFaWRzb24uCkluZGV4OiBXZWJDb3JlL3BhZ2UvU2VjdXJp dHlPcmlnaW4uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvU2VjdXJpdHlPcmlnaW4uaAko cmV2aXNpb24gNTA0MzYpCisrKyBXZWJDb3JlL3BhZ2UvU2VjdXJpdHlPcmlnaW4uaAkod29ya2lu ZyBjb3B5KQpAQCAtMTIzLDggKzEyMywxNCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAg IC8vIENvbnZlcnQgdGhpcyBTZWN1cml0eU9yaWdpbiBpbnRvIGEgc3RyaW5nLiAgVGhlIHN0cmlu ZwogICAgICAgICAvLyByZXByZXNlbnRhdGlvbiBvZiBhIFNlY3VyaXR5T3JpZ2luIGlzIHNpbWls YXIgdG8gYSBVUkwsIGV4Y2VwdCBpdAogICAgICAgICAvLyBsYWNrcyBhIHBhdGggY29tcG9uZW50 LiAgVGhlIHN0cmluZyByZXByZXNlbnRhdGlvbiBkb2VzIG5vdCBlbmNvZGUKLSAgICAgICAgLy8g dGhlIHZhbHVlIG9mIHRoZSBTZWN1cml0eU9yaWdpbidzIGRvbWFpbiBwcm9wZXJ0eS4gIFRoZSBl bXB0eQotICAgICAgICAvLyBTZWN1cml0eU9yaWdpbiBpcyByZXByZXNlbnRlZCB3aXRoIHRoZSBz dHJpbmcgIm51bGwiLgorICAgICAgICAvLyB0aGUgdmFsdWUgb2YgdGhlIFNlY3VyaXR5T3JpZ2lu J3MgZG9tYWluIHByb3BlcnR5LgorICAgICAgICAvLworICAgICAgICAvLyBXaGVuIHVzaW5nIHRo ZSBzdHJpbmcgdmFsdWUsIGl0J3MgaW1wb3J0YW50IHRvIHJlbWVtYmVyIHRoYXQgaXQKKyAgICAg ICAgLy8gbWlnaHQgYmUgIm51bGwiLiAgVGhpcyBoYXBwZW5zIHdoZW4gdGhpcyBTZWN1cml0eU9y aWdpbiBoYXMKKyAgICAgICAgLy8gbm9BY2Nlc3MgdG8gb3RoZXIgU2VjdXJpdHlPcmlnaW5zLiAg Rm9yIGV4YW1wbGUsIHRoaXMgU2VjdXJpdHlPcmlnaW4KKyAgICAgICAgLy8gbWlnaHQgaGF2ZSBj b21lIGZyb20gYSBkYXRhIFVSTCwgdGhlIFNlY3VyaXR5T3JpZ2luIG1pZ2h0IGJlIGVtcHR5LAor ICAgICAgICAvLyBvciB3ZSBtaWdodCBoYXZlIGV4cGxpY2l0bHkgZGVjaWRlZCB0aGF0IHdlCisg ICAgICAgIC8vIHNob3VsZFRyZWF0VVJMU2NoZW1lQXNOb0FjY2VzcykuCiAgICAgICAgIFN0cmlu ZyB0b1N0cmluZygpIGNvbnN0OwogCiAgICAgICAgIC8vIFNlcmlhbGl6ZSB0aGUgc2VjdXJpdHkg b3JpZ2luIHRvIGEgc3RyaW5nIHRoYXQgY291bGQgYmUgdXNlZCBhcyBwYXJ0IG9m 43123 2009-11-12 18:27:44 -0800 2009-11-12 19:05:49 -0800 remove ) ttt text/plain 1720 abarth SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n ICAgKHJldmlzaW9uIDUwNDM5KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cgICAod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDEyIEBACisyMDA5LTExLTAyICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtp dC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgorCisgICAgICAgIElt cHJvdmUgU2VjdXJpdHlPcmlnaW46OnRvU3RyaW5nIGNvbW1lbnQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxMDQxCisKKyAgICAgICAgKiBwYWdlL1Nl Y3VyaXR5T3JpZ2luLmg6CisKIDIwMDktMTEtMDIgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNv bT4KIAogICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBCcmFkeSBFaWRzb24uCkluZGV4OiBXZWJD b3JlL3BhZ2UvU2VjdXJpdHlPcmlnaW4uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvU2Vj dXJpdHlPcmlnaW4uaCAgIChyZXZpc2lvbiA1MDQzNikKKysrIFdlYkNvcmUvcGFnZS9TZWN1cml0 eU9yaWdpbi5oICAgKHdvcmtpbmcgY29weSkKQEAgLTEyMyw4ICsxMjMsMTQgQEAgbmFtZXNwYWNl IFdlYkNvcmUgewogICAgICAgICAvLyBDb252ZXJ0IHRoaXMgU2VjdXJpdHlPcmlnaW4gaW50byBh IHN0cmluZy4gIFRoZSBzdHJpbmcKICAgICAgICAgLy8gcmVwcmVzZW50YXRpb24gb2YgYSBTZWN1 cml0eU9yaWdpbiBpcyBzaW1pbGFyIHRvIGEgVVJMLCBleGNlcHQgaXQKICAgICAgICAgLy8gbGFj a3MgYSBwYXRoIGNvbXBvbmVudC4gIFRoZSBzdHJpbmcgcmVwcmVzZW50YXRpb24gZG9lcyBub3Qg ZW5jb2RlCi0gICAgICAgIC8vIHRoZSB2YWx1ZSBvZiB0aGUgU2VjdXJpdHlPcmlnaW4ncyBkb21h aW4gcHJvcGVydHkuICBUaGUgZW1wdHkKLSAgICAgICAgLy8gU2VjdXJpdHlPcmlnaW4gaXMgcmVw cmVzZW50ZWQgd2l0aCB0aGUgc3RyaW5nICJudWxsIi4KKyAgICAgICAgLy8gdGhlIHZhbHVlIG9m IHRoZSBTZWN1cml0eU9yaWdpbidzIGRvbWFpbiBwcm9wZXJ0eS4KKyAgICAgICAgLy8KKyAgICAg ICAgLy8gV2hlbiB1c2luZyB0aGUgc3RyaW5nIHZhbHVlLCBpdCdzIGltcG9ydGFudCB0byByZW1l bWJlciB0aGF0IGl0CisgICAgICAgIC8vIG1pZ2h0IGJlICJudWxsIi4gIFRoaXMgaGFwcGVucyB3 aGVuIHRoaXMgU2VjdXJpdHlPcmlnaW4gaGFzCisgICAgICAgIC8vIG5vQWNjZXNzIHRvIG90aGVy IFNlY3VyaXR5T3JpZ2lucy4gIEZvciBleGFtcGxlLCB0aGlzIFNlY3VyaXR5T3JpZ2luCisgICAg ICAgIC8vIG1pZ2h0IGhhdmUgY29tZSBmcm9tIGEgZGF0YSBVUkwsIHRoZSBTZWN1cml0eU9yaWdp biBtaWdodCBiZSBlbXB0eSwKKyAgICAgICAgLy8gb3Igd2UgbWlnaHQgaGF2ZSBleHBsaWNpdGx5 IGRlY2lkZWQgdGhhdCB3ZQorICAgICAgICAvLyBzaG91bGRUcmVhdFVSTFNjaGVtZUFzTm9BY2Nl c3MuCiAgICAgICAgIFN0cmluZyB0b1N0cmluZygpIGNvbnN0OwogCiAgICAgICAgIC8vIFNlcmlh bGl6ZSB0aGUgc2VjdXJpdHkgb3JpZ2luIHRvIGEgc3RyaW5nIHRoYXQgY291bGQgYmUgdXNlZCBh cyBwYXJ0IG9mCg==