31036 2009-11-02 17:16:16 -0800 need a height equivalent of RenderBox::minPrefWidth() 2009-11-18 18:04:24 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Enhancement --- 1 erikkay aa aa arv eric hyatt oldest_to_newest 159952 0 erikkay 2009-11-02 17:16:16 -0800 (apologies if an API like this already exists, but I haven't been able to find it) For Chrome's extension system, we let the extension create a popup widget using HTML. This popup widget's size is (mostly) unconstrained externally. The idea is to let the developer take advantage of some dynamic layout so that they don't have to worry about issues like system font sizes and localization. Obviously, the developer needs to put some constraints in (whitespace: nowrap,  , an explicit width or height on an element, etc.). I can get pretty close to my goal by using RenderBox::minPrefWidth() (on RenderView) and using contentHeight() for the height and resizing the RenderView to match. Unfortunately, with this technique, the height will never shrink. There doesn't seem to be a way to ask for the "intrinsic height" of the view at its current width. I'm assuming this must be known somewhere in order to calculate the overflow if any, but it looks like this value isn't saved or exposed. 160675 1 hyatt 2009-11-04 17:53:01 -0800 Just size the height of the view to 0 and then get the lowestPosition. 160824 2 erikkay 2009-11-05 07:49:21 -0800 Thanks for replying Dave. I'm not sure if your suggestion will work for me. There are two issues. The first issue is that since there's no real way to know when layout is "done", there's not a good point for me to know when size it back to the correct height so that it can draw. When I have the view sized to a zero height, I can't draw it, so this affects the responsiveness of the UI (how long it takes for me to be able to display the widget initially). The second (related) issue is that given that I want to display the widget as quickly as possible, I really need to be able to respond to size changes dynamically and resize the view accordingly. This would put me in a position of having to toggle back and forth between a zero height and the desired height after each layout, just to be able to see if the height changed. I'm concerned that it may be difficult to do that without introducing some serious flicker. 161263 3 aa 2009-11-06 15:46:32 -0800 Dave, do you know where the correct state might live in WebCore so that we could add plumbing to make it more accessible to a WebKit host? 163574 4 43209 aa 2009-11-13 16:09:45 -0800 Created attachment 43209 patch This isn't a complete solution because it doesn't work in quirks mode. I will create a separate bug to fix that, harder problem. 163576 5 43210 aa 2009-11-13 16:11:27 -0800 Created attachment 43210 tabs to spaces 163584 6 eric 2009-11-13 16:26:25 -0800 I do not know if this is the height value you want. The patch is certainly non-harmful however, so I'm happy to r+ it. But, I think you should seek confirmation from other web experts as to if document.scrolleHeight will be sufficient. 163590 7 aa 2009-11-13 16:40:17 -0800 Thanks. Erik Kay requested that I add to this bug what I found with fixing quirks mode in case someone else wants to pick it up: The important routine is RenderBox::calcHeight(). At the end of that method, if the document is in quirks mode, the calculated height is overwritten with a different one that is computed a different way (look for the comment that starts with "WinIE"). I think that in order to get what we want in quirks mode, we would need to store that first, unquriked value from calcHeight(), and then add a new method like scrollHeightWithoutQuirks() or some such that uses the non-quirked height. (It could probably be factored nicer). 163599 8 43210 aa 2009-11-13 17:03:28 -0800 Comment on attachment 43210 tabs to spaces Rejecting patch 43210 from commit-queue. Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html 163600 9 43210 aa 2009-11-13 17:04:41 -0800 Comment on attachment 43210 tabs to spaces Rejecting patch 43210 from commit-queue. Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html 164851 10 eric 2009-11-18 17:53:33 -0800 Aaron, looks like this never quite made it in. Would you like me to cq+ it? The commit-queue is back up and running fine now. 164855 11 aa 2009-11-18 17:58:52 -0800 It did make it, I'm afraid: http://trac.webkit.org/changeset/50983 When I was trying to repeat the steps you showed me to workaround the problem we encountered with bugzilla-tool, I accidentally submitted this with my git change description, which was not very informative. 164860 12 eric 2009-11-18 18:04:24 -0800 Thanks for the update! Doing your first commit on a new machine is always a bit tricky. Sorry our process isn't simpler. :( 43209 2009-11-13 16:09:45 -0800 2009-11-13 16:11:27 -0800 patch patch.txt text/plain 2755 aa ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDRiNjljMDQuLmJkNjIyZTYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE4IEBACisyMDA5LTExLTEzICBBYXJvbiBCb29kbWFuICA8YWFAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIEFkZHMgYSB3YXkgdG8gZ2V0IHRoZSBkb2N1bWVudCBlbGVtZW50J3Mgc2Nyb2xsSGVp Z2h0LAorICAgICAgICB3aGljaCBpcyBzb3J0IG9mIHRoZSBtb3JhbCBlcXVpdmFsZW50IHRvCisg ICAgICAgIFJlbmRlckJveDo6bWluUHJlZldpZHRoKCkuCisKKwlodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzEwMzYKKworICAgICAgICAqIHB1YmxpYy9XZWJGcmFtZS5o OiBEZWNsYXJlIGRvY3VtZW50RWxlbWVudFNjcm9sbEhlaWdodCgpCisgICAgICAgICogc3JjL1dl YkZyYW1lSW1wbC5oOiBEaXR0bworICAgICAgICAqIHNyYy9XZWJGcmFtZUltcGwuY3BwOiBJbXBs ZW1lbnQgZG9jdW1lbnRFbGVtZW50U2Nyb2xsSGVpZ2h0KCkKKyAgICAgICAgKFdlYktpdDo6V2Vi RnJhbWVJbXBsOjpkb2N1bWVudEVsZW1lbnRTY3JvbGxIZWlnaHQpOiBSZXR1cm4gdGhlCisgICAg ICAgIHNjcm9sbCBoZWlnaHQgb2YgdGhlIGRvY3VtZW50IGVsZW1lbnQsIG9yIHplcm8gaWYgdGhl cmUncyBubworICAgICAgICBkb2N1bWVudEVsZW1lbnQuCisKIDIwMDktMTEtMTIgIER1bWl0cnUg RGFuaWxpdWMgIDxkdW1pQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1p dHJpIEdsYXprb3YuCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1l LmggYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lLmgKaW5kZXggMGEzZWQwMC4uNDRi NTdhYSAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZS5oCisrKyBi L1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWUuaApAQCAtMTE5LDYgKzExOSwxMSBAQCBw dWJsaWM6CiAgICAgLy8gY3VycmVudCBkb2N1bWVudC4KICAgICB2aXJ0dWFsIGludCBjb250ZW50 c1ByZWZlcnJlZFdpZHRoKCkgY29uc3QgPSAwOwogCisgICAgLy8gUmV0dXJucyB0aGUgc2Nyb2xs IGhlaWdodCBvZiB0aGUgZG9jdW1lbnQgZWxlbWVudC4gVGhpcyBpcworICAgIC8vIGVxdWl2YWxl bnQgdG8gdGhlIERPTSBwcm9wZXJ0eSBvZiB0aGUgc2FtZSBuYW1lLCBhbmQgaXMgdGhlIG1pbmlt dW0KKyAgICAvLyBoZWlnaHQgcmVxdWlyZWQgdG8gZGlzcGxheSB0aGUgZG9jdW1lbnQgd2l0aG91 dCBzY3JvbGxiYXJzLgorICAgIHZpcnR1YWwgaW50IGRvY3VtZW50RWxlbWVudFNjcm9sbEhlaWdo dCgpIGNvbnN0ID0gMDsKKwogICAgIC8vIFJldHVybnMgdHJ1ZSBpZiB0aGUgY29udGVudHMgKG1p bnVzIHNjcm9sbGJhcnMpIGhhcyBub24temVybyBhcmVhLgogICAgIHZpcnR1YWwgYm9vbCBoYXNW aXNpYmxlQ29udGVudCgpIGNvbnN0ID0gMDsKIApkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJGcmFtZUltcGwuY3BwIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwu Y3BwCmluZGV4IDZkNTEyMzUuLjA2ZDM5NGYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViRnJhbWVJbXBsLmNwcAorKysgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1w bC5jcHAKQEAgLTQxMiw2ICs0MTIsMTMgQEAgaW50IFdlYkZyYW1lSW1wbDo6Y29udGVudHNQcmVm ZXJyZWRXaWR0aCgpIGNvbnN0CiAgICAgcmV0dXJuIDA7CiB9CiAKK2ludCBXZWJGcmFtZUltcGw6 OmRvY3VtZW50RWxlbWVudFNjcm9sbEhlaWdodCgpIGNvbnN0Cit7CisgICAgaWYgKG1fZnJhbWUt PmRvY3VtZW50KCkgJiYgbV9mcmFtZS0+ZG9jdW1lbnQoKS0+ZG9jdW1lbnRFbGVtZW50KCkpCisg ICAgICAgIHJldHVybiBtX2ZyYW1lLT5kb2N1bWVudCgpLT5kb2N1bWVudEVsZW1lbnQoKS0+c2Ny b2xsSGVpZ2h0KCk7CisgICAgcmV0dXJuIDA7Cit9CisKIGJvb2wgV2ViRnJhbWVJbXBsOjpoYXNW aXNpYmxlQ29udGVudCgpIGNvbnN0CiB7CiAgICAgcmV0dXJuIGZyYW1lKCktPnZpZXcoKS0+dmlz aWJsZVdpZHRoKCkgPiAwICYmIGZyYW1lKCktPnZpZXcoKS0+dmlzaWJsZUhlaWdodCgpID4gMDsK ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmggYi9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5oCmluZGV4IDZjMDdlZTguLjA1MDY3NWIgMTAwNjQ0 Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmgKKysrIGIvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJGcmFtZUltcGwuaApAQCAtNjgsNiArNjgsNyBAQCBwdWJsaWM6CiAgICAg dmlydHVhbCBXZWJTaXplIHNjcm9sbE9mZnNldCgpIGNvbnN0OwogICAgIHZpcnR1YWwgV2ViU2l6 ZSBjb250ZW50c1NpemUoKSBjb25zdDsKICAgICB2aXJ0dWFsIGludCBjb250ZW50c1ByZWZlcnJl ZFdpZHRoKCkgY29uc3Q7CisgICAgdmlydHVhbCBpbnQgZG9jdW1lbnRFbGVtZW50U2Nyb2xsSGVp Z2h0KCkgY29uc3Q7CiAgICAgdmlydHVhbCBib29sIGhhc1Zpc2libGVDb250ZW50KCkgY29uc3Q7 CiAgICAgdmlydHVhbCBXZWJWaWV3KiB2aWV3KCkgY29uc3Q7CiAgICAgdmlydHVhbCBXZWJGcmFt ZSogb3BlbmVyKCkgY29uc3Q7Cg== 43210 2009-11-13 16:11:27 -0800 2009-11-13 17:04:41 -0800 tabs to spaces patch.txt text/plain 2762 aa ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDRiNjljMDQuLjFiN2YzZTUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE4IEBACisyMDA5LTExLTEzICBBYXJvbiBCb29kbWFuICA8YWFAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIEFkZHMgYSB3YXkgdG8gZ2V0IHRoZSBkb2N1bWVudCBlbGVtZW50J3Mgc2Nyb2xsSGVp Z2h0LAorICAgICAgICB3aGljaCBpcyBzb3J0IG9mIHRoZSBtb3JhbCBlcXVpdmFsZW50IHRvCisg ICAgICAgIFJlbmRlckJveDo6bWluUHJlZldpZHRoKCkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxMDM2CisKKyAgICAgICAgKiBwdWJsaWMvV2Vi RnJhbWUuaDogRGVjbGFyZSBkb2N1bWVudEVsZW1lbnRTY3JvbGxIZWlnaHQoKQorICAgICAgICAq IHNyYy9XZWJGcmFtZUltcGwuaDogRGl0dG8KKyAgICAgICAgKiBzcmMvV2ViRnJhbWVJbXBsLmNw cDogSW1wbGVtZW50IGRvY3VtZW50RWxlbWVudFNjcm9sbEhlaWdodCgpCisgICAgICAgIChXZWJL aXQ6OldlYkZyYW1lSW1wbDo6ZG9jdW1lbnRFbGVtZW50U2Nyb2xsSGVpZ2h0KTogUmV0dXJuIHRo ZQorICAgICAgICBzY3JvbGwgaGVpZ2h0IG9mIHRoZSBkb2N1bWVudCBlbGVtZW50LCBvciB6ZXJv IGlmIHRoZXJlJ3Mgbm8KKyAgICAgICAgZG9jdW1lbnRFbGVtZW50LgorCiAyMDA5LTExLTEyICBE dW1pdHJ1IERhbmlsaXVjICA8ZHVtaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRGltaXRyaSBHbGF6a292LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJGcmFtZS5oIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZS5oCmluZGV4IDBhM2Vk MDAuLjQ0YjU3YWEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWUu aAorKysgYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lLmgKQEAgLTExOSw2ICsxMTks MTEgQEAgcHVibGljOgogICAgIC8vIGN1cnJlbnQgZG9jdW1lbnQuCiAgICAgdmlydHVhbCBpbnQg Y29udGVudHNQcmVmZXJyZWRXaWR0aCgpIGNvbnN0ID0gMDsKIAorICAgIC8vIFJldHVybnMgdGhl IHNjcm9sbCBoZWlnaHQgb2YgdGhlIGRvY3VtZW50IGVsZW1lbnQuIFRoaXMgaXMKKyAgICAvLyBl cXVpdmFsZW50IHRvIHRoZSBET00gcHJvcGVydHkgb2YgdGhlIHNhbWUgbmFtZSwgYW5kIGlzIHRo ZSBtaW5pbXVtCisgICAgLy8gaGVpZ2h0IHJlcXVpcmVkIHRvIGRpc3BsYXkgdGhlIGRvY3VtZW50 IHdpdGhvdXQgc2Nyb2xsYmFycy4KKyAgICB2aXJ0dWFsIGludCBkb2N1bWVudEVsZW1lbnRTY3Jv bGxIZWlnaHQoKSBjb25zdCA9IDA7CisKICAgICAvLyBSZXR1cm5zIHRydWUgaWYgdGhlIGNvbnRl bnRzIChtaW51cyBzY3JvbGxiYXJzKSBoYXMgbm9uLXplcm8gYXJlYS4KICAgICB2aXJ0dWFsIGJv b2wgaGFzVmlzaWJsZUNvbnRlbnQoKSBjb25zdCA9IDA7CiAKZGlmZiAtLWdpdCBhL1dlYktpdC9j aHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcCBiL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJh bWVJbXBsLmNwcAppbmRleCA2ZDUxMjM1Li4wNmQzOTRmIDEwMDY0NAotLS0gYS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAKKysrIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJG cmFtZUltcGwuY3BwCkBAIC00MTIsNiArNDEyLDEzIEBAIGludCBXZWJGcmFtZUltcGw6OmNvbnRl bnRzUHJlZmVycmVkV2lkdGgoKSBjb25zdAogICAgIHJldHVybiAwOwogfQogCitpbnQgV2ViRnJh bWVJbXBsOjpkb2N1bWVudEVsZW1lbnRTY3JvbGxIZWlnaHQoKSBjb25zdAoreworICAgIGlmICht X2ZyYW1lLT5kb2N1bWVudCgpICYmIG1fZnJhbWUtPmRvY3VtZW50KCktPmRvY3VtZW50RWxlbWVu dCgpKQorICAgICAgICByZXR1cm4gbV9mcmFtZS0+ZG9jdW1lbnQoKS0+ZG9jdW1lbnRFbGVtZW50 KCktPnNjcm9sbEhlaWdodCgpOworICAgIHJldHVybiAwOworfQorCiBib29sIFdlYkZyYW1lSW1w bDo6aGFzVmlzaWJsZUNvbnRlbnQoKSBjb25zdAogewogICAgIHJldHVybiBmcmFtZSgpLT52aWV3 KCktPnZpc2libGVXaWR0aCgpID4gMCAmJiBmcmFtZSgpLT52aWV3KCktPnZpc2libGVIZWlnaHQo KSA+IDA7CmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5oIGIv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuaAppbmRleCA2YzA3ZWU4Li4wNTA2NzVi IDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5oCisrKyBiL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmgKQEAgLTY4LDYgKzY4LDcgQEAgcHVibGlj OgogICAgIHZpcnR1YWwgV2ViU2l6ZSBzY3JvbGxPZmZzZXQoKSBjb25zdDsKICAgICB2aXJ0dWFs IFdlYlNpemUgY29udGVudHNTaXplKCkgY29uc3Q7CiAgICAgdmlydHVhbCBpbnQgY29udGVudHNQ cmVmZXJyZWRXaWR0aCgpIGNvbnN0OworICAgIHZpcnR1YWwgaW50IGRvY3VtZW50RWxlbWVudFNj cm9sbEhlaWdodCgpIGNvbnN0OwogICAgIHZpcnR1YWwgYm9vbCBoYXNWaXNpYmxlQ29udGVudCgp IGNvbnN0OwogICAgIHZpcnR1YWwgV2ViVmlldyogdmlldygpIGNvbnN0OwogICAgIHZpcnR1YWwg V2ViRnJhbWUqIG9wZW5lcigpIGNvbnN0Owo=