31030 2009-11-02 13:35:17 -0800 Web Inspector: Timeline instrumentation for Node::dispatchGenericEvent missed a case. 2009-11-02 14:02:44 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 knorton webkit-unassigned bweinstein commit-queue joepeck keishi pfeldman pmuellr rik timothy oldest_to_newest 159908 0 knorton 2009-11-02 13:35:17 -0800 This one is my bad. When I filtered out events with no listeners, I forgot to add support for DOMWindow dispatch. This only effects DOM events that are delivered to window (like 'click'). So we current miss this case: window.addEventListener('click', function(e) { }, false); Patch is ready, I'm about to upload. 159910 1 42340 knorton 2009-11-02 13:42:50 -0800 Created attachment 42340 Proposed fix. 159914 2 42340 commit-queue 2009-11-02 14:02:40 -0800 Comment on attachment 42340 Proposed fix. Clearing flags on attachment: 42340 Committed r50428: <http://trac.webkit.org/changeset/50428> 159915 3 commit-queue 2009-11-02 14:02:44 -0800 All reviewed patches have been landed. Closing bug. 42340 2009-11-02 13:42:50 -0800 2009-11-02 14:02:40 -0800 Proposed fix. Timeline-missedcase.diff text/plain 2696 knorton ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NzkyNTMxMy4uMzZhODdiNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0xMS0wMiAgS2VsbHkgTm9ydG9u ICA8a25vcnRvbkBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFkZHMgYSBtaXNzZWQgY2FzZSBmb3IgSW5zcGVjdG9yVGltZWxpbmUs IERPTVdpbmRvdyBkaXNwYXRjaCBvZiBET00gZXZlbnRzLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzEwMzAKKworICAgICAgICAqIGRvbS9Ob2RlLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OmV2ZW50SGFzTGlzdGVuZXJzKTogQ2hlY2tzIERPTVdpbmRv dyBmb3IgbGlzdGVuZXJzLgorICAgICAgICAoV2ViQ29yZTo6Tm9kZTo6ZGlzcGF0Y2hHZW5lcmlj RXZlbnQpOgorCiAyMDA5LTExLTAyICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlh LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBKYW4gQWxvbnpvLgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9kb20vTm9kZS5jcHAgYi9XZWJDb3JlL2RvbS9Ob2RlLmNwcAppbmRleCBjYmZkZTMwLi4z ZDM1NDZhIDEwMDY0NAotLS0gYS9XZWJDb3JlL2RvbS9Ob2RlLmNwcAorKysgYi9XZWJDb3JlL2Rv bS9Ob2RlLmNwcApAQCAtMjQ0Niw4ICsyNDQ2LDExIEBAIGJvb2wgTm9kZTo6ZGlzcGF0Y2hFdmVu dChQYXNzUmVmUHRyPEV2ZW50PiBwcnBFdmVudCkKICAgICByZXR1cm4gZGlzcGF0Y2hHZW5lcmlj RXZlbnQoZXZlbnQucmVsZWFzZSgpKTsKIH0KIAotc3RhdGljIGJvb2wgZXZlbnRIYXNMaXN0ZW5l cnMoY29uc3QgQXRvbWljU3RyaW5nJiBldmVudFR5cGUsIE5vZGUqIG5vZGUsIFZlY3RvcjxSZWZQ dHI8Q29udGFpbmVyTm9kZT4gPiYgYW5jZXN0b3JzKQorc3RhdGljIGJvb2wgZXZlbnRIYXNMaXN0 ZW5lcnMoY29uc3QgQXRvbWljU3RyaW5nJiBldmVudFR5cGUsIERPTVdpbmRvdyogd2luZG93LCBO b2RlKiBub2RlLCBWZWN0b3I8UmVmUHRyPENvbnRhaW5lck5vZGU+ID4mIGFuY2VzdG9ycykKIHsK KyAgICBpZiAod2luZG93ICYmIHdpbmRvdy0+aGFzRXZlbnRMaXN0ZW5lcnMoZXZlbnRUeXBlKSkK KyAgICAgICAgcmV0dXJuIHRydWU7CisKICAgICBpZiAobm9kZS0+aGFzRXZlbnRMaXN0ZW5lcnMo ZXZlbnRUeXBlKSkKICAgICAgICAgcmV0dXJuIHRydWU7CiAKQEAgLTI0NzUsMTMgKzI0NzgsNiBA QCBib29sIE5vZGU6OmRpc3BhdGNoR2VuZXJpY0V2ZW50KFBhc3NSZWZQdHI8RXZlbnQ+IHBycEV2 ZW50KQogICAgIFZlY3RvcjxSZWZQdHI8Q29udGFpbmVyTm9kZT4gPiBhbmNlc3RvcnM7CiAgICAg ZXZlbnRBbmNlc3RvcnMoYW5jZXN0b3JzKTsKIAotI2lmIEVOQUJMRShJTlNQRUNUT1IpCi0gICAg SW5zcGVjdG9yVGltZWxpbmVBZ2VudCogdGltZWxpbmVBZ2VudCA9IGRvY3VtZW50KCktPmluc3Bl Y3RvclRpbWVsaW5lQWdlbnQoKTsKLSAgICBib29sIHRpbWVsaW5lQWdlbnRJc0FjdGl2ZSA9IHRp bWVsaW5lQWdlbnQgJiYgZXZlbnRIYXNMaXN0ZW5lcnMoZXZlbnQtPnR5cGUoKSwgdGhpcywgYW5j ZXN0b3JzKTsgICAgCi0gICAgaWYgKHRpbWVsaW5lQWdlbnRJc0FjdGl2ZSkKLSAgICAgICAgdGlt ZWxpbmVBZ2VudC0+d2lsbERpc3BhdGNoRXZlbnQoKmV2ZW50KTsKLSNlbmRpZgotCiAgICAgLy8g U2V0IHVwIGEgcG9pbnRlciB0byBpbmRpY2F0ZSB3aGV0aGVyIC8gd2hlcmUgdG8gZGlzcGF0Y2gg d2luZG93IGV2ZW50cy4KICAgICAvLyBXZSBkb24ndCBkaXNwYXRjaCBsb2FkIGV2ZW50cyB0byB0 aGUgd2luZG93LiBUaGF0IHF1aXJrIHdhcyBvcmlnaW5hbGx5CiAgICAgLy8gYWRkZWQgYmVjYXVz ZSBNb3ppbGxhIGRvZXNuJ3QgcHJvcGFnYXRlIGxvYWQgZXZlbnRzIHRvIHRoZSB3aW5kb3cgb2Jq ZWN0LgpAQCAtMjQ5Miw2ICsyNDg4LDEzIEBAIGJvb2wgTm9kZTo6ZGlzcGF0Y2hHZW5lcmljRXZl bnQoUGFzc1JlZlB0cjxFdmVudD4gcHJwRXZlbnQpCiAgICAgICAgICAgICB0YXJnZXRGb3JXaW5k b3dFdmVudHMgPSBzdGF0aWNfY2FzdDxEb2N1bWVudCo+KHRvcExldmVsQ29udGFpbmVyKS0+ZG9t V2luZG93KCk7CiAgICAgfQogCisjaWYgRU5BQkxFKElOU1BFQ1RPUikKKyAgICBJbnNwZWN0b3JU aW1lbGluZUFnZW50KiB0aW1lbGluZUFnZW50ID0gZG9jdW1lbnQoKS0+aW5zcGVjdG9yVGltZWxp bmVBZ2VudCgpOworICAgIGJvb2wgdGltZWxpbmVBZ2VudElzQWN0aXZlID0gdGltZWxpbmVBZ2Vu dCAmJiBldmVudEhhc0xpc3RlbmVycyhldmVudC0+dHlwZSgpLCB0YXJnZXRGb3JXaW5kb3dFdmVu dHMsIHRoaXMsIGFuY2VzdG9ycyk7CisgICAgaWYgKHRpbWVsaW5lQWdlbnRJc0FjdGl2ZSkKKyAg ICAgICAgdGltZWxpbmVBZ2VudC0+d2lsbERpc3BhdGNoRXZlbnQoKmV2ZW50KTsKKyNlbmRpZgor CiAgICAgLy8gR2l2ZSB0aGUgdGFyZ2V0IG5vZGUgYSBjaGFuY2UgdG8gZG8gc29tZSB3b3JrIGJl Zm9yZSBET00gZXZlbnQgaGFuZGxlcnMgZ2V0IGEgY3JhY2suCiAgICAgdm9pZCogZGF0YSA9IHBy ZURpc3BhdGNoRXZlbnRIYW5kbGVyKGV2ZW50LmdldCgpKTsKICAgICBpZiAoZXZlbnQtPnByb3Bh Z2F0aW9uU3RvcHBlZCgpKQo=