31023 2009-11-02 11:52:07 -0800 Safari crashes when calling execCommand on formatted html in special case 2009-11-02 17:07:50 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC All RESOLVED FIXED InRadar P2 Normal --- 1 enrica enrica oldest_to_newest 159875 0 enrica 2009-11-02 11:52:07 -0800 Imagine to use your WebMail allowing to compose a message in HTML format. You obtain a new message and wants to reply, so: 1. have specially crafted HTML text, e.g.: <span> Line 1. <br> <b>Select all text in this line and use justify command. Actual result: Safari crashes.</b> <br> Line 3. </span> 2. select all text in the 2nd line 3. try to center the line: document.execCommand('JustifyCenter', false, null) is called Actual result: unexpected crash 159879 1 42332 enrica 2009-11-02 11:58:23 -0800 Created attachment 42332 Patch 159880 2 42332 adele 2009-11-02 12:01:16 -0800 Comment on attachment 42332 Patch You should add a newline at the end of your test to prevent that warning. r=me! 159881 3 42332 mitz 2009-11-02 12:01:54 -0800 Comment on attachment 42332 Patch > + RenderObject* cb = containingBlock(); > + if (cb) > + cb->setSelectionState(state); We usually combine such cases into if (RenderObject* cb = containingBlock()) cb->setSelectionState(state); I think you can also use a RenderBlock* because that’s the return type of containingBlock(). > +</html> > \ No newline at end of file Please add a newline. 159949 4 enrica 2009-11-02 17:07:50 -0800 Committed revision 50433. 42332 2009-11-02 11:58:23 -0800 2009-11-02 12:01:54 -0800 Patch bug7318656.txt text/plain 4297 enrica SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDQyNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDktMTEtMDIgIEVucmljYSBDYXN1Y2NpICA8ZW5yaWNhQGFwcGxl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBT YWZhcmkgY3Jhc2hlcyB3aGVuIGNhbGxpbmcgZXhlY0NvbW1hbmQgb24gZm9ybWF0dGVkIGh0bWwg aW4gc3BlY2lhbCBjYXNlCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83MzE4NjU2PgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzEwMjMKKworICAgICAg ICBUZXN0OiBlZGl0aW5nL2V4ZWNDb21tYW5kL2FsaWduLWluLXNwYW4uaHRtbAorCisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJP YmplY3Q6OmNvbnRhaW5pbmdCbG9jayk6IE1vZGlmaWVkIGNvbW1lbnQgb24gY29udGFpbmluZ0Js b2NrIHJldHVybmluZyBOVUxMLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUZXh0LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRleHQ6OnNldFNlbGVjdGlvblN0YXRlKTogQWRkZWQg Y2hlY2sgZm9yIE5VTEwgcmV0dXJuIGZyb20gY29udGFpbmluZ0Jsb2NrLAorICAgICAgICBzaW5j ZSBpdCBpcyBwb3NzaWJsZSB3aGVuIGRlYWxpbmcgd2l0aCBvcnBoYW5lZCB0cmVlcy4KKwogMjAw OS0xMS0wMiAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgSmFuIEFsb256by4KSW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ck9iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0 LmNwcAkocmV2aXNpb24gNTAzNjkpCisrKyBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3Qu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NDMsNyArNjQzLDcgQEAgUmVuZGVyQmxvY2sqIFJlbmRl ck9iamVjdDo6Y29udGFpbmluZ0JsbwogICAgIH0KIAogICAgIGlmICghbyB8fCAhby0+aXNSZW5k ZXJCbG9jaygpKQotICAgICAgICByZXR1cm4gMDsgLy8gUHJvYmFibHkgZG9lc24ndCBoYXBwZW4g YW55IG1vcmUsIGJ1dCBsZWF2ZSBqdXN0IGluIGNhc2UuIC1kd2gKKyAgICAgICAgcmV0dXJuIDA7 IC8vIFRoaXMgY2FuIHN0aWxsIGhhcHBlbiBpbiBjYXNlIG9mIGFuIG9ycGhhbmVkIHRyZWUKIAog ICAgIHJldHVybiB0b1JlbmRlckJsb2NrKG8pOwogfQpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyVGV4dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4 dC5jcHAJKHJldmlzaW9uIDUwMzY5KQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dC5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTgxMyw3ICs4MTMsMTAgQEAgdm9pZCBSZW5kZXJUZXh0Ojpz ZXRTZWxlY3Rpb25TdGF0ZShTZWxlYwogICAgICAgICB9CiAgICAgfQogCi0gICAgY29udGFpbmlu Z0Jsb2NrKCktPnNldFNlbGVjdGlvblN0YXRlKHN0YXRlKTsKKyAgICAvLyBUaGUgcmV0dXJuZWQg dmFsdWUgY2FuIGJlIG51bGwgaW4gY2FzZSBvZiBhbiBvcnBoYW5lZCB0cmVlLgorICAgIFJlbmRl ck9iamVjdCogY2IgPSBjb250YWluaW5nQmxvY2soKTsKKyAgICBpZiAoY2IpCisgICAgICAgIGNi LT5zZXRTZWxlY3Rpb25TdGF0ZShzdGF0ZSk7CiB9CiAKIHZvaWQgUmVuZGVyVGV4dDo6c2V0VGV4 dFdpdGhPZmZzZXQoUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiB0ZXh0LCB1bnNpZ25lZCBvZmZzZXQs IHVuc2lnbmVkIGxlbiwgYm9vbCBmb3JjZSkKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDUwNDI0KQorKysg TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIw MDktMTEtMDIgIEVucmljYSBDYXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTYWZhcmkgY3Jhc2hlcyB3aGVu IGNhbGxpbmcgZXhlY0NvbW1hbmQgb24gZm9ybWF0dGVkIGh0bWwgaW4gc3BlY2lhbCBjYXNlCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS83MzE4NjU2PgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzEwMjMKKworICAgICAgICAqIGVkaXRpbmcvZXhlY0Nv bW1hbmQvYWxpZ24taW4tc3Bhbi1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRp bmcvZXhlY0NvbW1hbmQvYWxpZ24taW4tc3Bhbi5odG1sOiBBZGRlZC4KKwogMjAwOS0xMS0wMiAg QW5kcmV3IFNjaGVya3VzICA8c2NoZXJrdXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEVyaWMgQ2FybHNvbi4KSW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1h bmQvYWxpZ24taW4tc3Bhbi1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv ZWRpdGluZy9leGVjQ29tbWFuZC9hbGlnbi1pbi1zcGFuLWV4cGVjdGVkLnR4dAkocmV2aXNpb24g MCkKKysrIExheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvYWxpZ24taW4tc3Bhbi1leHBl Y3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNCBAQAorTGluZSAxLiAKK1NlbGVjdCBh bGwgdGV4dCBpbiB0aGlzIGxpbmUgYW5kIHVzZSBqdXN0aWZ5IGNvbW1hbmQuCitMaW5lIDMuCisK SW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvYWxpZ24taW4tc3Bhbi5odG1s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvYWxpZ24taW4t c3Bhbi5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFu ZC9hbGlnbi1pbi1zcGFuLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMzEgQEAKKzxodG1s Pg0KKzxoZWFkPg0KKzxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4NCisNCitmdW5jdGlv biBzZWxlY3RBbmRKdXN0aWZ5KCkNCit7DQorICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRy b2xsZXIpDQorICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7DQorDQor ICAgIHZhciBlbGVtID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3QiKTsNCisgICAgdmFy IHNlbGVjdGlvbiA9IHdpbmRvdy5nZXRTZWxlY3Rpb24oKTsNCisgICAgc2VsZWN0aW9uLnNldEJh c2VBbmRFeHRlbnQoZWxlbSwgMiwgZWxlbSwgNik7DQorICAgIGRvY3VtZW50LmV4ZWNDb21tYW5k KCdKdXN0aWZ5Q2VudGVyJywgZmFsc2UsIG51bGwpOw0KK30NCisNCis8L3NjcmlwdD4NCis8L2hl YWQ+DQorDQorPGJvZHk+DQorICAgIDxzcGFuIGlkPSJ0ZXN0IiBjb250ZW50ZWRpdGFibGU9InRy dWUiID4NCisgICAgICAgIExpbmUgMS4NCisgICAgICAgIDxicj4NCisgICAgICAgIDxiPlNlbGVj dCBhbGwgdGV4dCBpbiB0aGlzIGxpbmUgYW5kIHVzZSBqdXN0aWZ5IGNvbW1hbmQuPC9iPg0KKyAg ICAgICAgPGJyPg0KKyAgICAgICAgTGluZSAzLg0KKyAgICA8L3NwYW4+DQorPC9ib2R5Pg0KKzxz Y3JpcHQ+DQorc2VsZWN0QW5kSnVzdGlmeSgpOw0KKzwvc2NyaXB0Pg0KKzwvaHRtbD4KXCBObyBu ZXdsaW5lIGF0IGVuZCBvZiBmaWxlCgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBMYXlvdXRUZXN0cy9l ZGl0aW5nL2V4ZWNDb21tYW5kL2FsaWduLWluLXNwYW4uaHRtbApfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkFkZGVkOiBz dm46ZXhlY3V0YWJsZQogICArICoKCg==