31018 2009-11-02 10:31:00 -0800 Accessibility: Implement isSelected in DRT for GTK 2010-05-15 04:09:26 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 38648 25531 1 cfleizach jdiggs abarth commit-queue eric jmalonzo mario webkit.review.bot xan.lopez oldest_to_newest 159837 0 cfleizach 2009-11-02 10:31:00 -0800 This will allow the aria-tab-controls.html layout test to pass 221743 1 mario 2010-05-06 09:45:07 -0700 (In reply to comment #0) > This will allow the aria-tab-controls.html layout test to pass Hmmm... do you mean accessibility/aria-controls-with-tabs.html? Can't find aria-tab-controls.html anywhere 221769 2 cfleizach 2010-05-06 10:05:39 -0700 yes that is what i meant 221813 3 55266 mario 2010-05-06 10:48:46 -0700 Created attachment 55266 Patch to fix this bug (In reply to comment #2) > yes that is what i meant Ok, attaching then a patch that would fix the issue. Please notice that fixing blocker bug 38648 first is mandatory for this to work (otherwise, the isSelected implementation would be always returning false, as m_element wouldn't be a valid AtkObject) 221815 4 webkit.review.bot 2010-05-06 10:49:40 -0700 Attachment 55266 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKitTools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:367: Declaration has space between type name and * in AtkStateSet *stateSet [whitespace/declaration] [3] WebKitTools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:373: Extra space before ( in function call [whitespace/parens] [4] WebKitTools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:374: Extra space before ( in function call [whitespace/parens] [4] WebKitTools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:375: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 4 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 221817 5 55268 mario 2010-05-06 10:57:57 -0700 Created attachment 55268 Patch to fix this bug (In reply to comment #4) > Attachment 55266 [details] did not pass style-queue: > Sorry, forgot to check style. Uploading new patch 223096 6 55268 eric 2010-05-09 15:08:59 -0700 Comment on attachment 55268 Patch to fix this bug LGTM. Don't we have some sort of GRefPtr so we don't have to manually call g_object_unref? 223097 7 55268 eric 2010-05-09 15:09:37 -0700 Comment on attachment 55268 Patch to fix this bug Actually, we don't do c-style forward declarations of variables. Please declare them inline. 223187 8 55526 mario 2010-05-10 01:12:59 -0700 Created attachment 55526 Patch to fix this bug (In reply to comment #7) > (From update of attachment 55268 [details]) > Actually, we don't do c-style forward declarations of variables. Please declare them inline. Done. (In reply to comment #6) > (From update of attachment 55268 [details]) > LGTM. > > Don't we have some sort of GRefPtr so we don't have to manually call g_object_unref? I'm not sure that would be aplicable on here, since the extra ref comes from ATK lib, but not a strong opinion anyway. Glad to hear suggestions :-) 223374 9 55526 xan.lopez 2010-05-10 10:08:41 -0700 Comment on attachment 55526 Patch to fix this bug re GRefPtr, it does not really matter that you are not adding the ref yourself, what GRefPtr does is get rid of the reference when the object goes out of scope. You'd use it like: GRefPtr<AtkStateSet> stateSet = atk_object_ref_state_set() ... and then you can get rid of the g_object_unref. I think it makes sense to use it, so r- because of that. Also, you can probably add the bug URL and title to the ChangeLog in the layout tests. 223425 10 55581 mario 2010-05-10 11:38:25 -0700 Created attachment 55581 Patch to fix this bug (In reply to comment #9) > (From update of attachment 55526 [details]) > re GRefPtr, it does not really matter that you are not adding the ref yourself, what GRefPtr does is get rid of the reference when the object goes out of scope. You'd use it like: > > GRefPtr<AtkStateSet> stateSet = atk_object_ref_state_set() ... > > and then you can get rid of the g_object_unref. > > I think it makes sense to use it, so r- because of that. Also, you can probably add the bug URL and title to the ChangeLog in the layout tests. Done. 223427 11 55581 xan.lopez 2010-05-10 11:48:27 -0700 Comment on attachment 55581 Patch to fix this bug Looks good to me. 224532 12 55581 commit-queue 2010-05-12 05:08:53 -0700 Comment on attachment 55581 Patch to fix this bug Rejecting patch 55581 from commit-queue. Unexpected failure when landing patch! Please file a bug against webkit-patch. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 55581, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1 Last 500 characters of output: 5581&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=31018&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Processing patch 55581 from bug 31018. NOBODY (OOPS!) found in /Users/eseidel/Projects/CommitQueue/LayoutTests/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /Users/eseidel/Projects/CommitQueue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). 225927 13 55581 xan.lopez 2010-05-14 11:44:36 -0700 Comment on attachment 55581 Patch to fix this bug I believe this should work now. 226205 14 55581 commit-queue 2010-05-15 02:44:34 -0700 Comment on attachment 55581 Patch to fix this bug Clearing flags on attachment: 55581 Committed r59531: <http://trac.webkit.org/changeset/59531> 226206 15 commit-queue 2010-05-15 02:44:40 -0700 All reviewed patches have been landed. Closing bug. 226220 16 webkit.review.bot 2010-05-15 04:09:26 -0700 http://trac.webkit.org/changeset/59531 might have broken GTK Linux 32-bit Release The following changes are on the blame list: http://trac.webkit.org/changeset/59530 http://trac.webkit.org/changeset/59531 http://trac.webkit.org/changeset/59532 http://trac.webkit.org/changeset/59533 55266 2010-05-06 10:48:46 -0700 2010-05-06 10:57:57 -0700 Patch to fix this bug 0001-2010-05-06-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 3302 mario RnJvbSA2M2Y2NmM4NDExM2EzMGM4MjUyY2IxODBiMzFlZWExZmExM2Y0OTFiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBUaHUsIDYgTWF5IDIwMTAgMTk6MTE6NTcgKzAyMDAKU3ViamVjdDogW1BBVENI XSAyMDEwLTA1LTA2ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4K CiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIEFjY2Vzc2liaWxp dHk6IEltcGxlbWVudCBpc1NlbGVjdGVkIGluIERSVCBmb3IgR1RLCiAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxMDE4CgogICAgICAgIEltcGxlbWVudCBB Y2Nlc3NpYmlsaXR5VUlFbGVtZW50Ojppc1NlbGVjdGVkKCkgZm9yIEd0awoKICAgICAgICAqIER1 bXBSZW5kZXJUcmVlL2d0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50R3RrLmNwcDoKICAgICAgICAo QWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6aXNTZWxlY3RlZCk6Ci0tLQogTGF5b3V0VGVzdHMvQ2hh bmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgICA4ICsrKysrKysrCiBMYXlv dXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZCAgICAgICAgICAgICAgICAgICB8ICAgIDEgLQog V2ViS2l0VG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDEy ICsrKysrKysrKysrKwogLi4uL2d0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50R3RrLmNwcCAgICAg ICAgICAgICAgfCAgIDEzICsrKysrKysrKysrLS0KIDQgZmlsZXMgY2hhbmdlZCwgMzEgaW5zZXJ0 aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZTc1ZDhiNS4uNDdjMGE4MSAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpA QCAtMSwzICsxLDExIEBACisyMDEwLTA1LTA2ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNo ZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBEbyBub3Qgc2tpcCBhcmlhLWNvbnRyb2xzLXdpdGgtdGFicy5odG1sIGFueW1vcmUK KworICAgICAgICAqIHBsYXRmb3JtL2d0ay9Ta2lwcGVkOgorCiAyMDEwLTA1LTA1ICBKZXJlbXkg TW9za292aWNoICA8amVyZW15QGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCBl eHBlY3RhdGlvbnMgY2hhbmdlLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3Rr L1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAppbmRleCBiMDg0NzY0 Li4zNzEwMmEzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAor KysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZApAQCAtNTU4Miw3ICs1NTgyLDYg QEAgZmFzdC9jc3MvY29sb3ItY29ycmVjdGlvbi5odG1sCiBmYXN0L211bHRpY29sL3NpbmdsZS1s aW5lLmh0bWwKIAogIyBOZXcgdGVzdHMgZmFpbGluZwotYWNjZXNzaWJpbGl0eS9hcmlhLWNvbnRy b2xzLXdpdGgtdGFicy5odG1sCiBhY2Nlc3NpYmlsaXR5L2FyaWEtbGlzdC1hbmQtbGlzdGl0ZW0u aHRtbAogYWNjZXNzaWJpbGl0eS9hcmlhLXByZXNlbnRhdGlvbmFsLXJvbGUuaHRtbAogYWNjZXNz aWJpbGl0eS9hcmlhLWNoZWNrYm94LWNoZWNrZWQuaHRtbApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9v bHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IDBjZTI1MzUuLjJjNjc4 ZTkgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJLaXRUb29scy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNS0wNiAgTWFyaW8gU2FuY2hleiBQcmFk YSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQWNjZXNzaWJpbGl0eTogSW1wbGVtZW50IGlzU2VsZWN0ZWQgaW4g RFJUIGZvciBHVEsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTMxMDE4CisKKyAgICAgICAgSW1wbGVtZW50IEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6Omlz U2VsZWN0ZWQoKSBmb3IgR3RrCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9ndGsvQWNjZXNz aWJpbGl0eVVJRWxlbWVudEd0ay5jcHA6CisgICAgICAgIChBY2Nlc3NpYmlsaXR5VUlFbGVtZW50 Ojppc1NlbGVjdGVkKToKKwogMjAxMC0wNS0wNCAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2hpbmljaGlybyBIYW1hamkuCmRpZmYgLS1naXQg YS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEd0 ay5jcHAgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvQWNjZXNzaWJpbGl0eVVJRWxl bWVudEd0ay5jcHAKaW5kZXggZmFiYWRhMy4uMGYxNTNhYSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9v bHMvRHVtcFJlbmRlclRyZWUvZ3RrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRHdGsuY3BwCisrKyBi L1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50R3Rr LmNwcApAQCAtMzY0LDggKzM2NCwxNyBAQCBib29sIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6Omlz UmVxdWlyZWQoKSBjb25zdAogCiBib29sIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmlzU2VsZWN0 ZWQoKSBjb25zdAogewotICAgIC8vIEZJWE1FOiBpbXBsZW1lbnQKLSAgICByZXR1cm4gZmFsc2U7 CisgICAgQXRrU3RhdGVTZXQgKnN0YXRlU2V0OworICAgIGdib29sZWFuIGlzU2VsZWN0ZWQ7CisK KyAgICBpZiAoIUFUS19JU19PQkpFQ1QobV9lbGVtZW50KSkKKyAgICAgICAgcmV0dXJuIGZhbHNl OworCisgICAgc3RhdGVTZXQgPSBhdGtfb2JqZWN0X3JlZl9zdGF0ZV9zZXQgKEFUS19PQkpFQ1Qg KG1fZWxlbWVudCkpOworICAgIGlzU2VsZWN0ZWQgPSBhdGtfc3RhdGVfc2V0X2NvbnRhaW5zX3N0 YXRlIChzdGF0ZVNldCwgQVRLX1NUQVRFX1NFTEVDVEVEKTsKKyAgICBnX29iamVjdF91bnJlZiAo c3RhdGVTZXQpOworCisgICAgcmV0dXJuIGlzU2VsZWN0ZWQ7CiB9CiAKIGludCBBY2Nlc3NpYmls aXR5VUlFbGVtZW50OjpoaWVyYXJjaGljYWxMZXZlbCgpIGNvbnN0Ci0tIAoxLjcuMC40Cgo= 55268 2010-05-06 10:57:57 -0700 2010-05-10 01:12:59 -0700 Patch to fix this bug 0001-2010-05-06-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 3298 mario RnJvbSAzOGQ1NTJiN2JkMDQ5YzdkNzdlODQwZTk2ZmY5MDE4ZjliYTVkY2UxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBUaHUsIDYgTWF5IDIwMTAgMTk6MTE6NTcgKzAyMDAKU3ViamVjdDogW1BBVENI XSAyMDEwLTA1LTA2ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4K CiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIEFjY2Vzc2liaWxp dHk6IEltcGxlbWVudCBpc1NlbGVjdGVkIGluIERSVCBmb3IgR1RLCiAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxMDE4CgogICAgICAgIEltcGxlbWVudCBB Y2Nlc3NpYmlsaXR5VUlFbGVtZW50Ojppc1NlbGVjdGVkKCkgZm9yIEd0awoKICAgICAgICAqIER1 bXBSZW5kZXJUcmVlL2d0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50R3RrLmNwcDoKICAgICAgICAo QWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6aXNTZWxlY3RlZCk6Ci0tLQogTGF5b3V0VGVzdHMvQ2hh bmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgICA4ICsrKysrKysrCiBMYXlv dXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZCAgICAgICAgICAgICAgICAgICB8ICAgIDEgLQog V2ViS2l0VG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDEy ICsrKysrKysrKysrKwogLi4uL2d0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50R3RrLmNwcCAgICAg ICAgICAgICAgfCAgIDEzICsrKysrKysrKysrLS0KIDQgZmlsZXMgY2hhbmdlZCwgMzEgaW5zZXJ0 aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZTc1ZDhiNS4uNDdjMGE4MSAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpA QCAtMSwzICsxLDExIEBACisyMDEwLTA1LTA2ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNo ZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBEbyBub3Qgc2tpcCBhcmlhLWNvbnRyb2xzLXdpdGgtdGFicy5odG1sIGFueW1vcmUK KworICAgICAgICAqIHBsYXRmb3JtL2d0ay9Ta2lwcGVkOgorCiAyMDEwLTA1LTA1ICBKZXJlbXkg TW9za292aWNoICA8amVyZW15QGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCBl eHBlY3RhdGlvbnMgY2hhbmdlLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3Rr L1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAppbmRleCBiMDg0NzY0 Li4zNzEwMmEzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAor KysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZApAQCAtNTU4Miw3ICs1NTgyLDYg QEAgZmFzdC9jc3MvY29sb3ItY29ycmVjdGlvbi5odG1sCiBmYXN0L211bHRpY29sL3NpbmdsZS1s aW5lLmh0bWwKIAogIyBOZXcgdGVzdHMgZmFpbGluZwotYWNjZXNzaWJpbGl0eS9hcmlhLWNvbnRy b2xzLXdpdGgtdGFicy5odG1sCiBhY2Nlc3NpYmlsaXR5L2FyaWEtbGlzdC1hbmQtbGlzdGl0ZW0u aHRtbAogYWNjZXNzaWJpbGl0eS9hcmlhLXByZXNlbnRhdGlvbmFsLXJvbGUuaHRtbAogYWNjZXNz aWJpbGl0eS9hcmlhLWNoZWNrYm94LWNoZWNrZWQuaHRtbApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9v bHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IDBjZTI1MzUuLjJjNjc4 ZTkgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJLaXRUb29scy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNS0wNiAgTWFyaW8gU2FuY2hleiBQcmFk YSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQWNjZXNzaWJpbGl0eTogSW1wbGVtZW50IGlzU2VsZWN0ZWQgaW4g RFJUIGZvciBHVEsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTMxMDE4CisKKyAgICAgICAgSW1wbGVtZW50IEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6Omlz U2VsZWN0ZWQoKSBmb3IgR3RrCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9ndGsvQWNjZXNz aWJpbGl0eVVJRWxlbWVudEd0ay5jcHA6CisgICAgICAgIChBY2Nlc3NpYmlsaXR5VUlFbGVtZW50 Ojppc1NlbGVjdGVkKToKKwogMjAxMC0wNS0wNCAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2hpbmljaGlybyBIYW1hamkuCmRpZmYgLS1naXQg YS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEd0 ay5jcHAgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvQWNjZXNzaWJpbGl0eVVJRWxl bWVudEd0ay5jcHAKaW5kZXggZmFiYWRhMy4uYTBhNTUwMCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9v bHMvRHVtcFJlbmRlclRyZWUvZ3RrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRHdGsuY3BwCisrKyBi L1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50R3Rr LmNwcApAQCAtMzY0LDggKzM2NCwxNyBAQCBib29sIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6Omlz UmVxdWlyZWQoKSBjb25zdAogCiBib29sIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmlzU2VsZWN0 ZWQoKSBjb25zdAogewotICAgIC8vIEZJWE1FOiBpbXBsZW1lbnQKLSAgICByZXR1cm4gZmFsc2U7 CisgICAgQXRrU3RhdGVTZXQqIHN0YXRlU2V0OworICAgIGdib29sZWFuIGlzU2VsZWN0ZWQ7CisK KyAgICBpZiAoIUFUS19JU19PQkpFQ1QobV9lbGVtZW50KSkKKyAgICAgICAgcmV0dXJuIGZhbHNl OworCisgICAgc3RhdGVTZXQgPSBhdGtfb2JqZWN0X3JlZl9zdGF0ZV9zZXQoQVRLX09CSkVDVCht X2VsZW1lbnQpKTsKKyAgICBpc1NlbGVjdGVkID0gYXRrX3N0YXRlX3NldF9jb250YWluc19zdGF0 ZShzdGF0ZVNldCwgQVRLX1NUQVRFX1NFTEVDVEVEKTsKKyAgICBnX29iamVjdF91bnJlZihzdGF0 ZVNldCk7CisKKyAgICByZXR1cm4gaXNTZWxlY3RlZDsKIH0KIAogaW50IEFjY2Vzc2liaWxpdHlV SUVsZW1lbnQ6OmhpZXJhcmNoaWNhbExldmVsKCkgY29uc3QKLS0gCjEuNy4wLjQKCg== 55526 2010-05-10 01:12:59 -0700 2010-05-10 11:38:25 -0700 Patch to fix this bug 0001-2010-05-06-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 3261 mario RnJvbSAwNTU4ZDE2NmJjZmJkNDZmN2NhY2NmM2U1MmIwY2FmMTMwZDQ3OGU3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBUaHUsIDYgTWF5IDIwMTAgMTk6MTE6NTcgKzAyMDAKU3ViamVjdDogW1BBVENI XSAyMDEwLTA1LTA2ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4K CiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIEFjY2Vzc2liaWxp dHk6IEltcGxlbWVudCBpc1NlbGVjdGVkIGluIERSVCBmb3IgR1RLCiAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxMDE4CgogICAgICAgIEltcGxlbWVudCBB Y2Nlc3NpYmlsaXR5VUlFbGVtZW50Ojppc1NlbGVjdGVkKCkgZm9yIEd0awoKICAgICAgICAqIER1 bXBSZW5kZXJUcmVlL2d0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50R3RrLmNwcDoKICAgICAgICAo QWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6aXNTZWxlY3RlZCk6Ci0tLQogTGF5b3V0VGVzdHMvQ2hh bmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgICA4ICsrKysrKysrCiBMYXlv dXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZCAgICAgICAgICAgICAgICAgICB8ICAgIDEgLQog V2ViS2l0VG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDEy ICsrKysrKysrKysrKwogLi4uL2d0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50R3RrLmNwcCAgICAg ICAgICAgICAgfCAgIDEwICsrKysrKysrLS0KIDQgZmlsZXMgY2hhbmdlZCwgMjggaW5zZXJ0aW9u cygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZTc1ZDhiNS4uNDdjMGE4MSAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAt MSwzICsxLDExIEBACisyMDEwLTA1LTA2ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpA aWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBEbyBub3Qgc2tpcCBhcmlhLWNvbnRyb2xzLXdpdGgtdGFicy5odG1sIGFueW1vcmUKKwor ICAgICAgICAqIHBsYXRmb3JtL2d0ay9Ta2lwcGVkOgorCiAyMDEwLTA1LTA1ICBKZXJlbXkgTW9z a292aWNoICA8amVyZW15QGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCBleHBl Y3RhdGlvbnMgY2hhbmdlLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Nr aXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAppbmRleCBiMDg0NzY0Li4z NzEwMmEzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAorKysg Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZApAQCAtNTU4Miw3ICs1NTgyLDYgQEAg ZmFzdC9jc3MvY29sb3ItY29ycmVjdGlvbi5odG1sCiBmYXN0L211bHRpY29sL3NpbmdsZS1saW5l Lmh0bWwKIAogIyBOZXcgdGVzdHMgZmFpbGluZwotYWNjZXNzaWJpbGl0eS9hcmlhLWNvbnRyb2xz LXdpdGgtdGFicy5odG1sCiBhY2Nlc3NpYmlsaXR5L2FyaWEtbGlzdC1hbmQtbGlzdGl0ZW0uaHRt bAogYWNjZXNzaWJpbGl0eS9hcmlhLXByZXNlbnRhdGlvbmFsLXJvbGUuaHRtbAogYWNjZXNzaWJp bGl0eS9hcmlhLWNoZWNrYm94LWNoZWNrZWQuaHRtbApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMv Q2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IDBjZTI1MzUuLjJjNjc4ZTkg MTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJLaXRUb29scy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNS0wNiAgTWFyaW8gU2FuY2hleiBQcmFkYSAg PG1zYW5jaGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQWNjZXNzaWJpbGl0eTogSW1wbGVtZW50IGlzU2VsZWN0ZWQgaW4gRFJU IGZvciBHVEsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTMxMDE4CisKKyAgICAgICAgSW1wbGVtZW50IEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmlzU2Vs ZWN0ZWQoKSBmb3IgR3RrCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9ndGsvQWNjZXNzaWJp bGl0eVVJRWxlbWVudEd0ay5jcHA6CisgICAgICAgIChBY2Nlc3NpYmlsaXR5VUlFbGVtZW50Ojpp c1NlbGVjdGVkKToKKwogMjAxMC0wNS0wNCAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2hpbmljaGlybyBIYW1hamkuCmRpZmYgLS1naXQgYS9X ZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEd0ay5j cHAgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVu dEd0ay5jcHAKaW5kZXggZmFiYWRhMy4uNDM2OThlMyAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMv RHVtcFJlbmRlclRyZWUvZ3RrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRHdGsuY3BwCisrKyBiL1dl YktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50R3RrLmNw cApAQCAtMzY0LDggKzM2NCwxNCBAQCBib29sIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmlzUmVx dWlyZWQoKSBjb25zdAogCiBib29sIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmlzU2VsZWN0ZWQo KSBjb25zdAogewotICAgIC8vIEZJWE1FOiBpbXBsZW1lbnQKLSAgICByZXR1cm4gZmFsc2U7Cisg ICAgaWYgKCFBVEtfSVNfT0JKRUNUKG1fZWxlbWVudCkpCisgICAgICAgIHJldHVybiBmYWxzZTsK KworICAgIEF0a1N0YXRlU2V0KiBzdGF0ZVNldCA9IGF0a19vYmplY3RfcmVmX3N0YXRlX3NldChB VEtfT0JKRUNUKG1fZWxlbWVudCkpOworICAgIGdib29sZWFuIGlzU2VsZWN0ZWQgPSBhdGtfc3Rh dGVfc2V0X2NvbnRhaW5zX3N0YXRlKHN0YXRlU2V0LCBBVEtfU1RBVEVfU0VMRUNURUQpOworICAg IGdfb2JqZWN0X3VucmVmKHN0YXRlU2V0KTsKKworICAgIHJldHVybiBpc1NlbGVjdGVkOwogfQog CiBpbnQgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6aGllcmFyY2hpY2FsTGV2ZWwoKSBjb25zdAot LSAKMS43LjAuNAoK 55581 2010-05-10 11:38:25 -0700 2010-05-15 02:44:34 -0700 Patch to fix this bug 0001-2010-05-10-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 3542 mario RnJvbSAxOGE2Y2I4Nzg0ZjQzZmIxOTk4YjRkYTE0NWJhZGI5YmExZmU3MDE1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBUaHUsIDYgTWF5IDIwMTAgMTk6MTE6NTcgKzAyMDAKU3ViamVjdDogW1BBVENI XSAyMDEwLTA1LTEwICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4K CiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIEFjY2Vzc2liaWxp dHk6IEltcGxlbWVudCBpc1NlbGVjdGVkIGluIERSVCBmb3IgR1RLCiAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxMDE4CgogICAgICAgIEltcGxlbWVudCBB Y2Nlc3NpYmlsaXR5VUlFbGVtZW50Ojppc1NlbGVjdGVkKCkgZm9yIEd0awoKICAgICAgICAqIER1 bXBSZW5kZXJUcmVlL2d0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50R3RrLmNwcDoKICAgICAgICAo QWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6aXNTZWxlY3RlZCk6Ci0tLQogTGF5b3V0VGVzdHMvQ2hh bmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDExICsrKysrKysrKysrCiBM YXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZCAgICAgICAgICAgICAgICAgICB8ICAgIDEg LQogV2ViS2l0VG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAg IDEyICsrKysrKysrKysrKwogLi4uL2d0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50R3RrLmNwcCAg ICAgICAgICAgICAgfCAgIDEwICsrKysrKysrLS0KIDQgZmlsZXMgY2hhbmdlZCwgMzEgaW5zZXJ0 aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMWE0MjdjMy4uMjdhYzQxMCAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE0IEBACisyMDEwLTA1LTEwICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNo ZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBY2Nlc3NpYmlsaXR5OiBJbXBsZW1lbnQgaXNTZWxlY3RlZCBpbiBEUlQgZm9yIEdU SworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzEwMTgK KworICAgICAgICBEbyBub3Qgc2tpcCBhcmlhLWNvbnRyb2xzLXdpdGgtdGFicy5odG1sIGFueW1v cmUKKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9Ta2lwcGVkOgorCiAyMDEwLTA1LTA5ICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCB0ZXN0 IGV4cGVjdGF0aW9uIHVwZGF0ZS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0 ay9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKaW5kZXggNWIwMGI3 MS4uY2QyODc1NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQK KysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKQEAgLTU1ODIsNyArNTU4Miw2 IEBAIGZhc3QvY3NzL2NvbG9yLWNvcnJlY3Rpb24uaHRtbAogZmFzdC9tdWx0aWNvbC9zaW5nbGUt bGluZS5odG1sCiAKICMgTmV3IHRlc3RzIGZhaWxpbmcKLWFjY2Vzc2liaWxpdHkvYXJpYS1jb250 cm9scy13aXRoLXRhYnMuaHRtbAogYWNjZXNzaWJpbGl0eS9hcmlhLWxpc3QtYW5kLWxpc3RpdGVt Lmh0bWwKIGFjY2Vzc2liaWxpdHkvYXJpYS1wcmVzZW50YXRpb25hbC1yb2xlLmh0bWwKIGFjY2Vz c2liaWxpdHkvYXJpYS1jaGVja2JveC1jaGVja2VkLmh0bWwKZGlmZiAtLWdpdCBhL1dlYktpdFRv b2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwppbmRleCA0ZTQ4YjM2Li4xZDli NzlkIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDUtMTAgIE1hcmlvIFNhbmNoZXogUHJh ZGEgIDxtc2FuY2hlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFjY2Vzc2liaWxpdHk6IEltcGxlbWVudCBpc1NlbGVjdGVkIGlu IERSVCBmb3IgR1RLCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zMTAxOAorCisgICAgICAgIEltcGxlbWVudCBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50Ojpp c1NlbGVjdGVkKCkgZm9yIEd0aworCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZ3RrL0FjY2Vz c2liaWxpdHlVSUVsZW1lbnRHdGsuY3BwOgorICAgICAgICAoQWNjZXNzaWJpbGl0eVVJRWxlbWVu dDo6aXNTZWxlY3RlZCk6CisKIDIwMTAtMDUtMDkgIERhbmllbCBCYXRlcyAgPGRiYXRlc0ByaW0u Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IENocmlzIEplcmRvbmVrLgpkaWZmIC0tZ2l0IGEv V2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRHdGsu Y3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0FjY2Vzc2liaWxpdHlVSUVsZW1l bnRHdGsuY3BwCmluZGV4IGZhYmFkYTMuLjNjMzE5M2IgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xz L0R1bXBSZW5kZXJUcmVlL2d0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50R3RrLmNwcAorKysgYi9X ZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEd0ay5j cHAKQEAgLTI2LDYgKzI2LDcgQEAKIAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkFj Y2Vzc2liaWxpdHlVSUVsZW1lbnQuaCIKKyNpbmNsdWRlICJHUmVmUHRyLmgiCiAKICNpbmNsdWRl IDxKYXZhU2NyaXB0Q29yZS9KU1N0cmluZ1JlZi5oPgogI2luY2x1ZGUgPHd0Zi9Bc3NlcnRpb25z Lmg+CkBAIC0zNjQsOCArMzY1LDEzIEBAIGJvb2wgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6aXNS ZXF1aXJlZCgpIGNvbnN0CiAKIGJvb2wgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6aXNTZWxlY3Rl ZCgpIGNvbnN0CiB7Ci0gICAgLy8gRklYTUU6IGltcGxlbWVudAotICAgIHJldHVybiBmYWxzZTsK KyAgICBpZiAoIUFUS19JU19PQkpFQ1QobV9lbGVtZW50KSkKKyAgICAgICAgcmV0dXJuIGZhbHNl OworCisgICAgR1JlZlB0cjxBdGtTdGF0ZVNldD4gc3RhdGVTZXQgPSBhZG9wdEdSZWYoYXRrX29i amVjdF9yZWZfc3RhdGVfc2V0KEFUS19PQkpFQ1QobV9lbGVtZW50KSkpOworICAgIGdib29sZWFu IGlzU2VsZWN0ZWQgPSBhdGtfc3RhdGVfc2V0X2NvbnRhaW5zX3N0YXRlKHN0YXRlU2V0LmdldCgp LCBBVEtfU1RBVEVfU0VMRUNURUQpOworCisgICAgcmV0dXJuIGlzU2VsZWN0ZWQ7CiB9CiAKIGlu dCBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50OjpoaWVyYXJjaGljYWxMZXZlbCgpIGNvbnN0Ci0tIAox LjcuMC40Cgo=