31017 2009-11-02 10:15:48 -0800 media/video-currentTime-set.html uses too short of a timeout 2009-11-02 10:53:11 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 scherkus webkit-unassigned commit-queue eric.carlson oldest_to_newest 159829 0 scherkus 2009-11-02 10:15:48 -0800 Eric and I discussed in #webkit a while back that some tests use too short of a timeout and end the test too early. This would be one of them :) I'm sure there are more, but verifying that the cause of flaky test failures is indeed a timeout and not some other bug is a tricky and time consuming process. 159830 1 42323 scherkus 2009-11-02 10:17:14 -0800 Created attachment 42323 Round 1 159833 2 42324 scherkus 2009-11-02 10:19:23 -0800 Created attachment 42324 Round 1 + Better ChangeLog Forgot to mention the call to logResult() was fixed. 159842 3 42324 eric.carlson 2009-11-02 10:34:34 -0800 Comment on attachment 42324 Round 1 + Better ChangeLog r=me 159850 4 42324 commit-queue 2009-11-02 10:53:06 -0800 Comment on attachment 42324 Round 1 + Better ChangeLog Clearing flags on attachment: 42324 Committed r50420: <http://trac.webkit.org/changeset/50420> 159851 5 commit-queue 2009-11-02 10:53:11 -0800 All reviewed patches have been landed. Closing bug. 42323 2009-11-02 10:17:14 -0800 2009-11-02 10:19:23 -0800 Round 1 less_flake.patch text/plain 1265 scherkus ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmODBkZmY4Li4yZDZjNjA3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTEt MDIgIEFuZHJldyBTY2hlcmt1cyAgPHNjaGVya3VzQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbmNyZWFzZSB0aGUgdGltZW91 dCBvZiBtZWRpYS92aWRlby1jdXJyZW50VGltZS1zZXQuaHRtbCBmcm9tIDgwMG1zIHRvIDIwMDBt cy4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzEw MTcKKworICAgICAgICAqIG1lZGlhL3ZpZGVvLWN1cnJlbnRUaW1lLXNldC5odG1sOiBUaW1lb3V0 IGluY3JlYXNlZCB0byAyMDAwbXMuCisKIDIwMDktMTEtMDIgIFJvbGFuZCBTdGVpbmVyICA8cm9s YW5kc3RlaW5lckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2ZSBIeWF0 dC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLWN1cnJlbnRUaW1lLXNldC5o dG1sIGIvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tY3VycmVudFRpbWUtc2V0Lmh0bWwKaW5kZXgg OTJmZTk2YS4uOWI2MTgzNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tY3Vy cmVudFRpbWUtc2V0Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tY3VycmVudFRp bWUtc2V0Lmh0bWwKQEAgLTE4LDggKzE4LDggQEAKICAgICAgICAgcnVuKCJ2aWRlby5wbGF5KCki KTsgCiAgICAgICAgIGNvbnNvbGVXcml0ZSgiIik7CiAgICAgCi0gICAgICAgIHZhciB0aW1lb3V0 ID0gODAwOwotICAgICAgICBzZXRUaW1lb3V0KGZ1bmN0aW9uICgpIHsgbG9nUmVzdWx0KCJObyAn ZW5kZWQnIGV2ZW50IGluICIgKyB0aW1lb3V0LzEwMDAgICsgInNlY29uZHMiLCBmYWxzZSk7IH0s IHRpbWVvdXQpOworICAgICAgICB2YXIgdGltZW91dCA9IDIwMDA7CisgICAgICAgIHNldFRpbWVv dXQoZnVuY3Rpb24gKCkgeyBsb2dSZXN1bHQoZmFsc2UsICJObyAnZW5kZWQnIGV2ZW50IGluICIg KyB0aW1lb3V0LzEwMDAgICsgIiBzZWNvbmRzIik7IH0sIHRpbWVvdXQpOwogICAgIH0pOwogICAg IHZpZGVvLnNyYyA9IGZpbmRNZWRpYUZpbGUoInZpZGVvIiwgImNvbnRlbnQvdGVzdCIpOwogICAg IDwvc2NyaXB0Pgo= 42324 2009-11-02 10:19:23 -0800 2009-11-02 10:53:06 -0800 Round 1 + Better ChangeLog less_flake.patch text/plain 1394 scherkus ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmODBkZmY4Li5iMDM5N2IxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTEt MDIgIEFuZHJldyBTY2hlcmt1cyAgPHNjaGVya3VzQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbmNyZWFzZSB0aGUgdGltZW91 dCBvZiBtZWRpYS92aWRlby1jdXJyZW50VGltZS1zZXQuaHRtbCBmcm9tIDgwMG1zIHRvIDIwMDBt cy4KKworICAgICAgICBBbHNvIGZpeCBjYWxsIHRvIGxvZ1Jlc3VsdCgpIGFzIHBhcmFtZXRlcnMg d2VyZSByZXZlcnNlZCwgcmVzdWx0aW5nIGluCisgICAgICAgIHByaW50aW5nIGFuIGVycm9yIG1l c3NhZ2Ugb2YgImZhbHNlIi4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MzEwMTcKKworICAgICAgICAqIG1lZGlhL3ZpZGVvLWN1cnJlbnRUaW1lLXNl dC5odG1sOiBUaW1lb3V0IGluY3JlYXNlZCB0byAyMDAwbXMuCisKIDIwMDktMTEtMDIgIFJvbGFu ZCBTdGVpbmVyICA8cm9sYW5kc3RlaW5lckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRGF2ZSBIeWF0dC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLWN1 cnJlbnRUaW1lLXNldC5odG1sIGIvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tY3VycmVudFRpbWUt c2V0Lmh0bWwKaW5kZXggOTJmZTk2YS4uOWI2MTgzNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv bWVkaWEvdmlkZW8tY3VycmVudFRpbWUtc2V0Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEv dmlkZW8tY3VycmVudFRpbWUtc2V0Lmh0bWwKQEAgLTE4LDggKzE4LDggQEAKICAgICAgICAgcnVu KCJ2aWRlby5wbGF5KCkiKTsgCiAgICAgICAgIGNvbnNvbGVXcml0ZSgiIik7CiAgICAgCi0gICAg ICAgIHZhciB0aW1lb3V0ID0gODAwOwotICAgICAgICBzZXRUaW1lb3V0KGZ1bmN0aW9uICgpIHsg bG9nUmVzdWx0KCJObyAnZW5kZWQnIGV2ZW50IGluICIgKyB0aW1lb3V0LzEwMDAgICsgInNlY29u ZHMiLCBmYWxzZSk7IH0sIHRpbWVvdXQpOworICAgICAgICB2YXIgdGltZW91dCA9IDIwMDA7Cisg ICAgICAgIHNldFRpbWVvdXQoZnVuY3Rpb24gKCkgeyBsb2dSZXN1bHQoZmFsc2UsICJObyAnZW5k ZWQnIGV2ZW50IGluICIgKyB0aW1lb3V0LzEwMDAgICsgIiBzZWNvbmRzIik7IH0sIHRpbWVvdXQp OwogICAgIH0pOwogICAgIHZpZGVvLnNyYyA9IGZpbmRNZWRpYUZpbGUoInZpZGVvIiwgImNvbnRl bnQvdGVzdCIpOwogICAgIDwvc2NyaXB0Pgo=