31014 2009-11-02 08:08:10 -0800 [Gtk] Build fails with gtk+-2.10 (no tested with older releases) 2009-12-13 03:40:18 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 c.nicolas webkit-unassigned christian jmalonzo webkit.review.bot oldest_to_newest 159800 0 c.nicolas 2009-11-02 08:08:10 -0800 Hello guys, I tried to build WebKit-Gtk, both 1.1.15.3 and 1.1.6, downloaded today from the webkitgtk.org website, and the build fails. Here is my configure command, which exits normally: ./configure --prefix=${HOME}/local/`hostname` --enable-web-sockets (BTW, ./configure --help says: "--enable-web-sockets enable support for Web Sockets default=yes", but it seems to default to no, that should be another bug report) Here is the error: CXX WebKit/gtk/WebCoreSupport/libwebkit_1_0_la-ChromeClientGtk.lo WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp: In member function ‘virtual void WebKit::ChromeClient::mouseDidMoveOverElement(const WebCore::HitTestResult&, unsigned int)’: WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:453: error: ‘gtk_tooltip_trigger_tooltip_query’ was not declared in this scope make[1]: *** [WebKit/gtk/WebCoreSupport/libwebkit_1_0_la-ChromeClientGtk.lo] Error 1 make[1]: Leaving directory `/auto/sop-nas2a/u/sop-nas2a/vol/home_indes/cnicolas/NOSAVE/webkit/WebKitGTK/webkit-1.1.16' make: *** [all] Error 2 pkg-config tells me I have gtk+ 2.10 $ pkg-config --modversion gtk+-2.0 2.10.14 I checked for the GTK+ API, and `gtk_tooltip_trigger_tooltip_query' comes with the new GtkTooltip API, which is available since Gtk+-2.12, source: http://library.gnome.org/devel/gtk/unstable/GtkTooltip.html So I think the autoconf/configure should be updated to fail if the gtk+ lib is too old for webkit-gtk... 159801 1 christian 2009-11-02 08:13:05 -0800 The requirement of 2.10 is actually correct. The call to the new function should be guarded by #ifdefs instead. 169500 2 44437 christian 2009-12-07 15:32:59 -0800 Created attachment 44437 Guard GTK+ 2.12 specific tooltip code with #ifdef. 169501 3 webkit.review.bot 2009-12-07 15:35:38 -0800 Attachment 44437 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:445: Missing space after , [whitespace/comma] [3] Total errors found: 1 171161 4 44437 zecke 2009-12-12 22:09:28 -0800 Comment on attachment 44437 Guard GTK+ 2.12 specific tooltip code with #ifdef. > + [Gtk] Build fails with gtk+-2.10 (no tested with older releases) s/no/not/ ? and I have no idea what the style check script is aiming at... 171192 5 christian 2009-12-13 03:40:18 -0800 2009-12-13 Christian Dywan <christian@twotoasts.de> Reviewed by Holger Freyther. http://bugs.webkit.org/show_bug.cgi?id=31014 [Gtk] Build fails with gtk+-2.10 (no tested with older releases) Guard GTK+ 2.12 specific tooltip code with #ifdef. * WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::mouseDidMoveOverElement): 44437 2009-12-07 15:32:59 -0800 2009-12-12 22:09:28 -0800 Guard GTK+ 2.12 specific tooltip code with #ifdef. tooltip-2.12.diff text/plain 1565 christian ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggNWExNDJiNS4uMDRiMzY0MiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0xMi0wNyAg Q2hyaXN0aWFuIER5d2FuICA8Y2hyaXN0aWFuQHR3b3RvYXN0cy5kZT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zMTAxNAorICAgICAgICBbR3RrXSBCdWlsZCBmYWlscyB3aXRoIGd0 aystMi4xMCAobm8gdGVzdGVkIHdpdGggb2xkZXIgcmVsZWFzZXMpCisKKyAgICAgICAgR3VhcmQg R1RLKyAyLjEyIHNwZWNpZmljIHRvb2x0aXAgY29kZSB3aXRoICNpZmRlZi4KKworICAgICAgICAq IFdlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEd0ay5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNo cm9tZUNsaWVudDo6bW91c2VEaWRNb3ZlT3ZlckVsZW1lbnQpOgorCiAyMDA5LTEyLTA3ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZ0BnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJp YyBTZWlkZWwuCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNs aWVudEd0ay5jcHAgYi9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEd0ay5j cHAKaW5kZXggZDlhMDQzYi4uMGY0NmI5MiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9XZWJDb3Jl U3VwcG9ydC9DaHJvbWVDbGllbnRHdGsuY3BwCisrKyBiL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBv cnQvQ2hyb21lQ2xpZW50R3RrLmNwcApAQCAtNDQyLDYgKzQ0Miw3IEBAIHZvaWQgQ2hyb21lQ2xp ZW50OjpzY3JvbGxiYXJzTW9kZURpZENoYW5nZSgpIGNvbnN0CiAKIHZvaWQgQ2hyb21lQ2xpZW50 Ojptb3VzZURpZE1vdmVPdmVyRWxlbWVudChjb25zdCBIaXRUZXN0UmVzdWx0JiBoaXQsIHVuc2ln bmVkIG1vZGlmaWVyRmxhZ3MpCiB7CisjaWYgR1RLX0NIRUNLX1ZFUlNJT04oMiwxMiwwKQogICAg IC8vIElmIGEgdG9vbHRpcCBtdXN0IGJlIGRpc3BsYXllZCBpdCB3aWxsIGJlLCBhZnRlcndhcmRz LCB3aGVuCiAgICAgLy8gc2V0VG9vbFRpcCBpcyBjYWxsZWQ7IHRoaXMgaXMganVzdCBhIHdvcmst YXJvdW5kIHRvIG1ha2Ugc3VyZQogICAgIC8vIGl0IHVwZGF0ZXMgaXRzIGxvY2F0aW9uIGNvcnJl Y3RseTsgc2VlCkBAIC00NTUsNiArNDU2LDcgQEAgdm9pZCBDaHJvbWVDbGllbnQ6Om1vdXNlRGlk TW92ZU92ZXJFbGVtZW50KGNvbnN0IEhpdFRlc3RSZXN1bHQmIGhpdCwgdW5zaWduZWQgbW8KICAg ICBlbHNlCiAgICAgICAgIGdka0Rpc3BsYXkgPSBnZGtfZGlzcGxheV9nZXRfZGVmYXVsdCgpOwog ICAgIGd0a190b29sdGlwX3RyaWdnZXJfdG9vbHRpcF9xdWVyeShnZGtEaXNwbGF5KTsKKyNlbmRp ZgogCiAgICAgLy8gY2hlY2sgaWYgdGhlIGVsZW1lbnQgaXMgYSBsaW5rLi4uCiAgICAgYm9vbCBp c0xpbmsgPSBoaXQuaXNMaXZlTGluaygpOwo=