30998 2009-11-01 13:42:59 -0800 [Gtk] Implement AtkDocument's locale support 2009-11-02 09:35:48 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 25531 0 jdiggs webkit-unassigned commit-queue xan.lopez oldest_to_newest 159666 0 42281 jdiggs 2009-11-01 13:42:59 -0800 Created attachment 42281 proposed fix +++ This bug was initially created as a clone of Bug #30964 +++ We need to implement the AtkDocument interface. http://library.gnome.org/devel/atk/unstable/AtkDocument.html 159771 1 42281 jmalonzo 2009-11-02 03:31:25 -0800 Comment on attachment 42281 proposed fix > static const gchar* webkit_accessible_document_get_locale(AtkDocument* document) > { > - // FIXME: This needs to be implemented. > - notImplemented(); > + > + // TODO: Should we fall back on lang xml:lang when the following comes up empty? > + String language = static_cast<AccessibilityRenderObject*>(core(document))->language(); > + if (!language.isEmpty()) > + return returnString(language); Should this return NULL if empty? 159772 2 jdiggs 2009-11-02 03:37:17 -0800 (In reply to comment #1) > (From update of attachment 42281 [details]) > > static const gchar* webkit_accessible_document_get_locale(AtkDocument* document) > > { > > - // FIXME: This needs to be implemented. > > - notImplemented(); > > + > > + // TODO: Should we fall back on lang xml:lang when the following comes up empty? > > + String language = static_cast<AccessibilityRenderObject*>(core(document))->language(); > > + if (!language.isEmpty()) > > + return returnString(language); > > Should this return NULL if empty? I think so. Do you think otherwise? Or am I missing something? - // FIXME: This needs to be implemented. - notImplemented(); + + // TODO: Should we fall back on lang xml:lang when the following comes up empty? + String language = static_cast<AccessibilityRenderObject*>(core(document))->language(); + if (!language.isEmpty()) + return returnString(language); + return 0; ^^^^^^^^^ 159774 3 42281 jmalonzo 2009-11-02 03:44:28 -0800 Comment on attachment 42281 proposed fix > return 0; Yup, I missed it. :) r=me. 159817 4 42281 commit-queue 2009-11-02 09:35:42 -0800 Comment on attachment 42281 proposed fix Clearing flags on attachment: 42281 Committed r50412: <http://trac.webkit.org/changeset/50412> 159818 5 commit-queue 2009-11-02 09:35:48 -0800 All reviewed patches have been landed. Closing bug. 42281 2009-11-01 13:42:59 -0800 2009-11-02 09:35:42 -0800 proposed fix document-iface-3.patch text/plain 2083 jdiggs RnJvbSBmNDAyZjI0MWRmMWQ2ZmUxOWU4MDhjZDg2M2RkNzFiMDU5YWNkNDhiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2FubWFyaWUgRGlnZ3MgPGpvYW5tYXJpZS5kaWdnc0BnbWFp bC5jb20+CkRhdGU6IFNhdCwgMzEgT2N0IDIwMDkgMDg6MDI6MjUgLTA0MDAKU3ViamVjdDogW1BB VENIIDMvM10gUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA5NjQKW0d0a10gSW1wbGVtbWVudCBBdGtEb2N1bWVudAoK UHJvdmlkZXMgYWNjZXNzIHRvIHRoZSByZXBvcnRlZCBjb250ZW50IGxhbmd1YWdlLgoKKiBhY2Nl c3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHA6Cih3ZWJraXRf YWNjZXNzaWJsZV9kb2N1bWVudF9nZXRfbG9jYWxlKToKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTIgKysrKysrKysrKysrCiAuLi4v Z3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcCAgICAgICAgICB8ICAgIDggKysr KysrLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4 IGUxNGM5NGIuLjllOWY3YjYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dl YkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTAtMzEgIEpvYW5tYXJpZSBE aWdncyAgPGpvYW5tYXJpZS5kaWdnc0BnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTMwOTY0CisgICAgICAgIFtHdGtdIEltcGxlbW1lbnQgQXRrRG9jdW1lbnQKKwor ICAgICAgICBQcm92aWRlcyBhY2Nlc3MgdG8gdGhlIHJlcG9ydGVkIGNvbnRlbnQgbGFuZ3VhZ2Uu CisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBl ckF0ay5jcHA6CisgICAgICAgICh3ZWJraXRfYWNjZXNzaWJsZV9kb2N1bWVudF9nZXRfbG9jYWxl KToKKwogMjAwOS0xMC0zMCAgSm9hbm1hcmllIERpZ2dzICA8am9hbm1hcmllLmRpZ2dzQGdtYWls LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBh L1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJBdGsu Y3BwIGIvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBl ckF0ay5jcHAKaW5kZXggOTdkY2QwYi4uODBiNWEzZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9hY2Nl c3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHAKKysrIGIvV2Vi Q29yZS9hY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHAK QEAgLTE0NTIsOCArMTQ1MiwxMiBAQCBzdGF0aWMgQXRrQXR0cmlidXRlU2V0KiB3ZWJraXRfYWNj ZXNzaWJsZV9kb2N1bWVudF9nZXRfYXR0cmlidXRlcyhBdGtEb2N1bWVudCogZAogCiBzdGF0aWMg Y29uc3QgZ2NoYXIqIHdlYmtpdF9hY2Nlc3NpYmxlX2RvY3VtZW50X2dldF9sb2NhbGUoQXRrRG9j dW1lbnQqIGRvY3VtZW50KQogewotICAgIC8vIEZJWE1FOiBUaGlzIG5lZWRzIHRvIGJlIGltcGxl bWVudGVkLgotICAgIG5vdEltcGxlbWVudGVkKCk7CisKKyAgICAvLyBUT0RPOiBTaG91bGQgd2Ug ZmFsbCBiYWNrIG9uIGxhbmcgeG1sOmxhbmcgd2hlbiB0aGUgZm9sbG93aW5nIGNvbWVzIHVwIGVt cHR5PworICAgIFN0cmluZyBsYW5ndWFnZSA9IHN0YXRpY19jYXN0PEFjY2Vzc2liaWxpdHlSZW5k ZXJPYmplY3QqPihjb3JlKGRvY3VtZW50KSktPmxhbmd1YWdlKCk7CisgICAgaWYgKCFsYW5ndWFn ZS5pc0VtcHR5KCkpCisgICAgICAgIHJldHVybiByZXR1cm5TdHJpbmcobGFuZ3VhZ2UpOworCiAg ICAgcmV0dXJuIDA7CiB9CiAKLS0gCjEuNi4zLjMKCg==