30995 2009-11-01 09:37:14 -0800 TimelineAgent should not add events to the timeline if there are no event listeners. 2009-11-01 19:23:30 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 knorton webkit-unassigned commit-queue pfeldman timothy oldest_to_newest 159641 0 knorton 2009-11-01 09:37:14 -0800 TimelineAgent currently sends all DOM event dispatches even if there are no event listeners wired to the Node or its ancestors. (attaching patch) 159642 1 42278 knorton 2009-11-01 09:39:21 -0800 Created attachment 42278 A proposed solution for this. 159644 2 42278 timothy 2009-11-01 11:02:02 -0800 Comment on attachment 42278 A proposed solution for this. > +// static We normally don't add comments like this. > +inline InspectorTimelineAgent* InspectorTimelineAgent::retrieveIfEventHasListeners(InspectorTimelineAgent* timelineAgent, > + const AtomicString& eventType, Node* node, const Vector< RefPtr< ContainerNode > >& ancestors) Will this be used by other callers later? If not it might be best just to put this in Node.cpp so there are less headers included by InspectorTimelineAgent.h. I can see a variation of this being used by XHRs (we don't want to show readystate or load records if there are no listeners.) > + for (size_t i = ancestors.size(); i; --i) { > + ContainerNode* ancestor = ancestors[i - 1].get(); > + if (ancestor->hasEventListeners(eventType)) > + return timelineAgent; > + } This is better written as: for (ssize_t i = (ancestors.size() - 1); i >= 0; --i) { ContainerNode* ancestor = ancestors[i].get(); if (ancestor->hasEventListeners(eventType)) return timelineAgent; } 159694 3 42287 knorton 2009-11-01 17:56:32 -0800 Created attachment 42287 Updated w/ review feedback and went ahead and added the same thing to XHRs. 159696 4 42288 knorton 2009-11-01 18:03:52 -0800 Created attachment 42288 Fixes ChangeLog 159709 5 42288 commit-queue 2009-11-01 19:23:26 -0800 Comment on attachment 42288 Fixes ChangeLog Clearing flags on attachment: 42288 Committed r50400: <http://trac.webkit.org/changeset/50400> 159710 6 commit-queue 2009-11-01 19:23:30 -0800 All reviewed patches have been landed. Closing bug. 42278 2009-11-01 09:39:21 -0800 2009-11-01 17:56:32 -0800 A proposed solution for this. Timeline-NoListeners.diff text/plain 4068 knorton ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDg2OTJiYS4uNmYxNTEzYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0xMS0wMSAgS2VsbHkgTm9ydG9u ICA8a25vcnRvbkBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIERvZXMgbm90IHNlbmQgRE9NIGRpc3BhdGNoZXMgdG8gdGhlIEluc3Bl Y3RvclRpbWVsaW5lQWdlbnQgaWYgdGhlcmUKKyAgICAgICAgYXJlIG5vIGV2ZW50IGxpc3RlbmVy cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwOTk1 CisKKyAgICAgICAgKiBkb20vTm9kZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpOb2RlOjpkaXNw YXRjaEdlbmVyaWNFdmVudCk6CisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvclRpbWVsaW5l QWdlbnQuaDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvclRpbWVsaW5lQWdlbnQ6OnJldHJp ZXZlSWZFdmVudEhhc0xpc3RlbmVycyk6CisKIDIwMDktMTEtMDEgIEtlaXNoaSBIYXR0b3JpICA8 Y2FzZXkuaGF0dG9yaUBnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVGltb3RoeSBI YXRjaGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20vTm9kZS5jcHAgYi9XZWJDb3JlL2RvbS9O b2RlLmNwcAppbmRleCA2MTJiZjE4Li45MDg4NTFmIDEwMDY0NAotLS0gYS9XZWJDb3JlL2RvbS9O b2RlLmNwcAorKysgYi9XZWJDb3JlL2RvbS9Ob2RlLmNwcApAQCAtMjQ1NSwxMiArMjQ1NSw2IEBA IGJvb2wgTm9kZTo6ZGlzcGF0Y2hHZW5lcmljRXZlbnQoUGFzc1JlZlB0cjxFdmVudD4gcHJwRXZl bnQpCiAgICAgQVNTRVJUKGV2ZW50LT50YXJnZXQoKSk7CiAgICAgQVNTRVJUKCFldmVudC0+dHlw ZSgpLmlzTnVsbCgpKTsgLy8gSmF2YVNjcmlwdCBjb2RlIGNhbiBjcmVhdGUgYW4gZXZlbnQgd2l0 aCBhbiBlbXB0eSBuYW1lLCBidXQgbm90IG51bGwuCiAKLSNpZiBFTkFCTEUoSU5TUEVDVE9SKQot ICAgIEluc3BlY3RvclRpbWVsaW5lQWdlbnQqIHRpbWVsaW5lQWdlbnQgPSBkb2N1bWVudCgpLT5p bnNwZWN0b3JUaW1lbGluZUFnZW50KCk7Ci0gICAgaWYgKHRpbWVsaW5lQWdlbnQpCi0gICAgICAg IHRpbWVsaW5lQWdlbnQtPndpbGxEaXNwYXRjaERPTUV2ZW50KCpldmVudCk7Ci0jZW5kaWYKLQog ICAgIC8vIE1ha2UgYSB2ZWN0b3Igb2YgYW5jZXN0b3JzIHRvIHNlbmQgdGhlIGV2ZW50IHRvLgog ICAgIC8vIElmIHRoZSBub2RlIGlzIG5vdCBpbiBhIGRvY3VtZW50IGp1c3Qgc2VuZCB0aGUgZXZl bnQgdG8gaXQuCiAgICAgLy8gQmUgc3VyZSB0byByZWYgYWxsIG9mIG5vZGVzIHNpbmNlIGV2ZW50 IGhhbmRsZXJzIGNvdWxkIHJlc3VsdCBpbiB0aGUgbGFzdCByZWZlcmVuY2UgZ29pbmcgYXdheS4K QEAgLTI0NjgsNiArMjQ2MiwxMyBAQCBib29sIE5vZGU6OmRpc3BhdGNoR2VuZXJpY0V2ZW50KFBh c3NSZWZQdHI8RXZlbnQ+IHBycEV2ZW50KQogICAgIFZlY3RvcjxSZWZQdHI8Q29udGFpbmVyTm9k ZT4gPiBhbmNlc3RvcnM7CiAgICAgZXZlbnRBbmNlc3RvcnMoYW5jZXN0b3JzKTsKIAorI2lmIEVO QUJMRShJTlNQRUNUT1IpCisgICAgSW5zcGVjdG9yVGltZWxpbmVBZ2VudCogdGltZWxpbmVBZ2Vu dCA9IEluc3BlY3RvclRpbWVsaW5lQWdlbnQ6OnJldHJpZXZlSWZFdmVudEhhc0xpc3RlbmVycyhk b2N1bWVudCgpLT5pbnNwZWN0b3JUaW1lbGluZUFnZW50KCksCisgICAgICAgIGV2ZW50LT50eXBl KCksIHRoaXMsIGFuY2VzdG9ycyk7CisgICAgaWYgKHRpbWVsaW5lQWdlbnQpCisgICAgICAgIHRp bWVsaW5lQWdlbnQtPndpbGxEaXNwYXRjaERPTUV2ZW50KCpldmVudCk7CisjZW5kaWYKKwogICAg IC8vIFNldCB1cCBhIHBvaW50ZXIgdG8gaW5kaWNhdGUgd2hldGhlciAvIHdoZXJlIHRvIGRpc3Bh dGNoIHdpbmRvdyBldmVudHMuCiAgICAgLy8gV2UgZG9uJ3QgZGlzcGF0Y2ggbG9hZCBldmVudHMg dG8gdGhlIHdpbmRvdy4gVGhhdCBxdWlyayB3YXMgb3JpZ2luYWxseQogICAgIC8vIGFkZGVkIGJl Y2F1c2UgTW96aWxsYSBkb2Vzbid0IHByb3BhZ2F0ZSBsb2FkIGV2ZW50cyB0byB0aGUgd2luZG93 IG9iamVjdC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclRpbWVsaW5l QWdlbnQuaCBiL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclRpbWVsaW5lQWdlbnQuaAppbmRl eCAwNDAxOTc3Li5mZTRjNWFkIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0 b3JUaW1lbGluZUFnZW50LmgKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yVGltZWxp bmVBZ2VudC5oCkBAIC0zMSwxMCArMzEsMTMgQEAKICNpZm5kZWYgSW5zcGVjdG9yVGltZWxpbmVB Z2VudF9oCiAjZGVmaW5lIEluc3BlY3RvclRpbWVsaW5lQWdlbnRfaAogCisjaW5jbHVkZSAiQ29u dGFpbmVyTm9kZS5oIgogI2luY2x1ZGUgIkRvY3VtZW50LmgiCisjaW5jbHVkZSAiTm9kZS5oIgog I2luY2x1ZGUgIlNjcmlwdEV4ZWN1dGlvbkNvbnRleHQuaCIKICNpbmNsdWRlICJTY3JpcHRPYmpl Y3QuaCIKICNpbmNsdWRlICJTY3JpcHRBcnJheS5oIgorI2luY2x1ZGUgPHd0Zi9SZWZQdHIuaD4K ICNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKQEAgLTk0LDYg Kzk3LDEwIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdm9pZCBkaWRFdmFsdWF0ZVNj cmlwdFRhZygpOwogCiAgICAgICAgIHN0YXRpYyBJbnNwZWN0b3JUaW1lbGluZUFnZW50KiByZXRy aWV2ZShTY3JpcHRFeGVjdXRpb25Db250ZXh0Kik7CisgICAgICAgIAorICAgICAgICBzdGF0aWMg SW5zcGVjdG9yVGltZWxpbmVBZ2VudCogcmV0cmlldmVJZkV2ZW50SGFzTGlzdGVuZXJzKEluc3Bl Y3RvclRpbWVsaW5lQWdlbnQqLCBjb25zdCBBdG9taWNTdHJpbmcmLCBOb2RlKiwKKyAgICAgICAg ICAgIGNvbnN0IFZlY3RvcjwgUmVmUHRyPCBDb250YWluZXJOb2RlID4gPiYpOworICAgICAgICAK ICAgICBwcml2YXRlOgogICAgICAgICBzdHJ1Y3QgVGltZWxpbmVSZWNvcmRFbnRyeSB7CiAgICAg ICAgICAgICBUaW1lbGluZVJlY29yZEVudHJ5KFNjcmlwdE9iamVjdCByZWNvcmQsIFNjcmlwdEFy cmF5IGNoaWxkcmVuLCBUaW1lbGluZVJlY29yZFR5cGUgdHlwZSkgOiByZWNvcmQocmVjb3JkKSwg Y2hpbGRyZW4oY2hpbGRyZW4pLCB0eXBlKHR5cGUpIHsgfQpAQCAtMTIyLDYgKzEyOSwyNSBAQCBp bmxpbmUgSW5zcGVjdG9yVGltZWxpbmVBZ2VudCogSW5zcGVjdG9yVGltZWxpbmVBZ2VudDo6cmV0 cmlldmUoU2NyaXB0RXhlY3V0aW9uQwogICAgIHJldHVybiAwOwogfQogCisvLyBzdGF0aWMKK2lu bGluZSBJbnNwZWN0b3JUaW1lbGluZUFnZW50KiBJbnNwZWN0b3JUaW1lbGluZUFnZW50OjpyZXRy aWV2ZUlmRXZlbnRIYXNMaXN0ZW5lcnMoSW5zcGVjdG9yVGltZWxpbmVBZ2VudCogdGltZWxpbmVB Z2VudCwKKyAgICBjb25zdCBBdG9taWNTdHJpbmcmIGV2ZW50VHlwZSwgTm9kZSogbm9kZSwgY29u c3QgVmVjdG9yPCBSZWZQdHI8IENvbnRhaW5lck5vZGUgPiA+JiBhbmNlc3RvcnMpCit7CisgICAg aWYgKCF0aW1lbGluZUFnZW50KQorICAgICAgICByZXR1cm4gMDsKKworICAgIGlmIChub2RlLT5o YXNFdmVudExpc3RlbmVycyhldmVudFR5cGUpKQorICAgICAgICByZXR1cm4gdGltZWxpbmVBZ2Vu dDsKKworICAgIGZvciAoc2l6ZV90IGkgPSBhbmNlc3RvcnMuc2l6ZSgpOyBpOyAtLWkpIHsKKyAg ICAgICAgQ29udGFpbmVyTm9kZSogYW5jZXN0b3IgPSBhbmNlc3RvcnNbaSAtIDFdLmdldCgpOwor ICAgICAgICBpZiAoYW5jZXN0b3ItPmhhc0V2ZW50TGlzdGVuZXJzKGV2ZW50VHlwZSkpCisgICAg ICAgICAgICByZXR1cm4gdGltZWxpbmVBZ2VudDsKKyAgICB9CisgICAgCisgICAgcmV0dXJuIDA7 Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKIAogI2VuZGlmIC8vICFkZWZpbmVkKEluc3Bl Y3RvclRpbWVsaW5lQWdlbnRfaCkK 42287 2009-11-01 17:56:32 -0800 2009-11-01 18:03:52 -0800 Updated w/ review feedback and went ahead and added the same thing to XHRs. Timeline-NoListeners.diff text/plain 4481 knorton ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDg2OTJiYS4uNmYxNTEzYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0xMS0wMSAgS2VsbHkgTm9ydG9u ICA8a25vcnRvbkBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIERvZXMgbm90IHNlbmQgRE9NIGRpc3BhdGNoZXMgdG8gdGhlIEluc3Bl Y3RvclRpbWVsaW5lQWdlbnQgaWYgdGhlcmUKKyAgICAgICAgYXJlIG5vIGV2ZW50IGxpc3RlbmVy cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwOTk1 CisKKyAgICAgICAgKiBkb20vTm9kZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpOb2RlOjpkaXNw YXRjaEdlbmVyaWNFdmVudCk6CisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvclRpbWVsaW5l QWdlbnQuaDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvclRpbWVsaW5lQWdlbnQ6OnJldHJp ZXZlSWZFdmVudEhhc0xpc3RlbmVycyk6CisKIDIwMDktMTEtMDEgIEtlaXNoaSBIYXR0b3JpICA8 Y2FzZXkuaGF0dG9yaUBnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVGltb3RoeSBI YXRjaGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20vTm9kZS5jcHAgYi9XZWJDb3JlL2RvbS9O b2RlLmNwcAppbmRleCA2MTJiZjE4Li44ZGM1Yjc1IDEwMDY0NAotLS0gYS9XZWJDb3JlL2RvbS9O b2RlLmNwcAorKysgYi9XZWJDb3JlL2RvbS9Ob2RlLmNwcApAQCAtMjQ0Nyw2ICsyNDQ3LDIwIEBA IGJvb2wgTm9kZTo6ZGlzcGF0Y2hFdmVudChQYXNzUmVmUHRyPEV2ZW50PiBwcnBFdmVudCkKICAg ICByZXR1cm4gZGlzcGF0Y2hHZW5lcmljRXZlbnQoZXZlbnQucmVsZWFzZSgpKTsKIH0KIAorc3Rh dGljIGJvb2wgZXZlbnRIYXNMaXN0ZW5lcnMoY29uc3QgQXRvbWljU3RyaW5nJiBldmVudFR5cGUs IE5vZGUqIG5vZGUsIFZlY3RvcjwgUmVmUHRyPCBDb250YWluZXJOb2RlID4gPiYgYW5jZXN0b3Jz KQoreworICAgIGlmIChub2RlLT5oYXNFdmVudExpc3RlbmVycyhldmVudFR5cGUpKQorICAgICAg ICByZXR1cm4gdHJ1ZTsKKworICAgIGZvciAoc3NpemVfdCBpID0gKGFuY2VzdG9ycy5zaXplKCkg LSAxKTsgaSA+PSAwOyAtLWkpIHsKKyAgICAgICAgQ29udGFpbmVyTm9kZSogYW5jZXN0b3IgPSBh bmNlc3RvcnNbaV0uZ2V0KCk7CisgICAgICAgIGlmIChhbmNlc3Rvci0+aGFzRXZlbnRMaXN0ZW5l cnMoZXZlbnRUeXBlKSkKKyAgICAgICAgICAgIHJldHVybiB0cnVlOworICAgIH0KKworICAgcmV0 dXJuIGZhbHNlOyAgICAKK30KKwogYm9vbCBOb2RlOjpkaXNwYXRjaEdlbmVyaWNFdmVudChQYXNz UmVmUHRyPEV2ZW50PiBwcnBFdmVudCkKIHsKICAgICBSZWZQdHI8RXZlbnQ+IGV2ZW50KHBycEV2 ZW50KTsKQEAgLTI0NTUsMTIgKzI0NjksNiBAQCBib29sIE5vZGU6OmRpc3BhdGNoR2VuZXJpY0V2 ZW50KFBhc3NSZWZQdHI8RXZlbnQ+IHBycEV2ZW50KQogICAgIEFTU0VSVChldmVudC0+dGFyZ2V0 KCkpOwogICAgIEFTU0VSVCghZXZlbnQtPnR5cGUoKS5pc051bGwoKSk7IC8vIEphdmFTY3JpcHQg Y29kZSBjYW4gY3JlYXRlIGFuIGV2ZW50IHdpdGggYW4gZW1wdHkgbmFtZSwgYnV0IG5vdCBudWxs LgogCi0jaWYgRU5BQkxFKElOU1BFQ1RPUikKLSAgICBJbnNwZWN0b3JUaW1lbGluZUFnZW50KiB0 aW1lbGluZUFnZW50ID0gZG9jdW1lbnQoKS0+aW5zcGVjdG9yVGltZWxpbmVBZ2VudCgpOwotICAg IGlmICh0aW1lbGluZUFnZW50KQotICAgICAgICB0aW1lbGluZUFnZW50LT53aWxsRGlzcGF0Y2hE T01FdmVudCgqZXZlbnQpOwotI2VuZGlmCi0KICAgICAvLyBNYWtlIGEgdmVjdG9yIG9mIGFuY2Vz dG9ycyB0byBzZW5kIHRoZSBldmVudCB0by4KICAgICAvLyBJZiB0aGUgbm9kZSBpcyBub3QgaW4g YSBkb2N1bWVudCBqdXN0IHNlbmQgdGhlIGV2ZW50IHRvIGl0LgogICAgIC8vIEJlIHN1cmUgdG8g cmVmIGFsbCBvZiBub2RlcyBzaW5jZSBldmVudCBoYW5kbGVycyBjb3VsZCByZXN1bHQgaW4gdGhl IGxhc3QgcmVmZXJlbmNlIGdvaW5nIGF3YXkuCkBAIC0yNDY4LDYgKzI0NzYsMTMgQEAgYm9vbCBO b2RlOjpkaXNwYXRjaEdlbmVyaWNFdmVudChQYXNzUmVmUHRyPEV2ZW50PiBwcnBFdmVudCkKICAg ICBWZWN0b3I8UmVmUHRyPENvbnRhaW5lck5vZGU+ID4gYW5jZXN0b3JzOwogICAgIGV2ZW50QW5j ZXN0b3JzKGFuY2VzdG9ycyk7CiAKKyNpZiBFTkFCTEUoSU5TUEVDVE9SKQorICAgIEluc3BlY3Rv clRpbWVsaW5lQWdlbnQqIHRpbWVsaW5lQWdlbnQgPSBkb2N1bWVudCgpLT5pbnNwZWN0b3JUaW1l bGluZUFnZW50KCk7CisgICAgYm9vbCB0aW1lbGluZUFnZW50SXNBY3RpdmUgPSB0aW1lbGluZUFn ZW50ICYmIGV2ZW50SGFzTGlzdGVuZXJzKGV2ZW50LT50eXBlKCksIHRoaXMsIGFuY2VzdG9ycyk7 ICAgIAorICAgIGlmICh0aW1lbGluZUFnZW50SXNBY3RpdmUpCisgICAgICAgIHRpbWVsaW5lQWdl bnQtPndpbGxEaXNwYXRjaERPTUV2ZW50KCpldmVudCk7CisjZW5kaWYKKwogICAgIC8vIFNldCB1 cCBhIHBvaW50ZXIgdG8gaW5kaWNhdGUgd2hldGhlciAvIHdoZXJlIHRvIGRpc3BhdGNoIHdpbmRv dyBldmVudHMuCiAgICAgLy8gV2UgZG9uJ3QgZGlzcGF0Y2ggbG9hZCBldmVudHMgdG8gdGhlIHdp bmRvdy4gVGhhdCBxdWlyayB3YXMgb3JpZ2luYWxseQogICAgIC8vIGFkZGVkIGJlY2F1c2UgTW96 aWxsYSBkb2Vzbid0IHByb3BhZ2F0ZSBsb2FkIGV2ZW50cyB0byB0aGUgd2luZG93IG9iamVjdC4K QEAgLTI1NTksNyArMjU3NCw3IEBAIGRvbmVEaXNwYXRjaGluZzoKIAogZG9uZVdpdGhEZWZhdWx0 OgogI2lmIEVOQUJMRShJTlNQRUNUT1IpCi0gICAgaWYgKHRpbWVsaW5lQWdlbnQpCisgICAgaWYg KHRpbWVsaW5lQWdlbnRJc0FjdGl2ZSkKICAgICAgICAgdGltZWxpbmVBZ2VudC0+ZGlkRGlzcGF0 Y2hET01FdmVudCgpOwogI2VuZGlmCiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUveG1sL1hNTEh0dHBS ZXF1ZXN0LmNwcCBiL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNwcAppbmRleCA4N2E2NTQw Li5iZjIwMjJmIDEwMDY0NAotLS0gYS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5jcHAKKysr IGIvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuY3BwCkBAIC0yNTMsMjcgKzI1MywyOSBAQCB2 b2lkIFhNTEh0dHBSZXF1ZXN0OjpjYWxsUmVhZHlTdGF0ZUNoYW5nZUxpc3RlbmVyKCkKIAogI2lm IEVOQUJMRShJTlNQRUNUT1IpCiAgICAgSW5zcGVjdG9yVGltZWxpbmVBZ2VudCogdGltZWxpbmVB Z2VudCA9IEluc3BlY3RvclRpbWVsaW5lQWdlbnQ6OnJldHJpZXZlKHNjcmlwdEV4ZWN1dGlvbkNv bnRleHQoKSk7Ci0gICAgaWYgKHRpbWVsaW5lQWdlbnQpCisgICAgYm9vbCBjYWxsVGltZWxpbmVB Z2VudE9uUmVhZHlTdGF0ZUNoYW5nZSA9IHRpbWVsaW5lQWdlbnQgJiYgaGFzRXZlbnRMaXN0ZW5l cnMoZXZlbnROYW1lcygpLnJlYWR5c3RhdGVjaGFuZ2VFdmVudCk7CisgICAgaWYgKGNhbGxUaW1l bGluZUFnZW50T25SZWFkeVN0YXRlQ2hhbmdlKQogICAgICAgICB0aW1lbGluZUFnZW50LT53aWxs Q2hhbmdlWEhSUmVhZHlTdGF0ZShtX3VybC5zdHJpbmcoKSwgbV9zdGF0ZSk7CiAjZW5kaWYKIAog ICAgIGRpc3BhdGNoRXZlbnQoWE1MSHR0cFJlcXVlc3RQcm9ncmVzc0V2ZW50OjpjcmVhdGUoZXZl bnROYW1lcygpLnJlYWR5c3RhdGVjaGFuZ2VFdmVudCkpOwogCiAjaWYgRU5BQkxFKElOU1BFQ1RP UikKLSAgICBpZiAodGltZWxpbmVBZ2VudCkKKyAgICBpZiAoY2FsbFRpbWVsaW5lQWdlbnRPblJl YWR5U3RhdGVDaGFuZ2UpCiAgICAgICAgIHRpbWVsaW5lQWdlbnQtPmRpZENoYW5nZVhIUlJlYWR5 U3RhdGUoKTsKICNlbmRpZgogCiAgICAgaWYgKG1fc3RhdGUgPT0gRE9ORSAmJiAhbV9lcnJvcikg ewogI2lmIEVOQUJMRShJTlNQRUNUT1IpCi0gICAgICAgIGlmICh0aW1lbGluZUFnZW50KQorICAg ICAgICBib29sIGNhbGxUaW1lbGluZUFnZW50T25Mb2FkID0gdGltZWxpbmVBZ2VudCAmJiBoYXNF dmVudExpc3RlbmVycyhldmVudE5hbWVzKCkubG9hZEV2ZW50KTsKKyAgICAgICAgaWYgKGNhbGxU aW1lbGluZUFnZW50T25Mb2FkKQogICAgICAgICAgICAgdGltZWxpbmVBZ2VudC0+d2lsbExvYWRY SFIobV91cmwuc3RyaW5nKCkpOwogI2VuZGlmCiAKICAgICAgICAgZGlzcGF0Y2hFdmVudChYTUxI dHRwUmVxdWVzdFByb2dyZXNzRXZlbnQ6OmNyZWF0ZShldmVudE5hbWVzKCkubG9hZEV2ZW50KSk7 CiAKICNpZiBFTkFCTEUoSU5TUEVDVE9SKQotICAgICAgICBpZiAodGltZWxpbmVBZ2VudCkKKyAg ICAgICAgaWYgKGNhbGxUaW1lbGluZUFnZW50T25Mb2FkKQogICAgICAgICAgICAgdGltZWxpbmVB Z2VudC0+ZGlkTG9hZFhIUigpOwogI2VuZGlmCiAgICAgfQo= 42288 2009-11-01 18:03:52 -0800 2009-11-01 19:23:26 -0800 Fixes ChangeLog Timeline-NoListeners.diff text/plain 4501 knorton ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDg2OTJiYS4uMWRiZmE5YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0xMS0wMSAgS2VsbHkgTm9ydG9u ICA8a25vcnRvbkBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIERvZXMgbm90IHNlbmQgRE9NIGRpc3BhdGNoZXMgdG8gdGhlIEluc3Bl Y3RvclRpbWVsaW5lQWdlbnQgaWYgdGhlcmUKKyAgICAgICAgYXJlIG5vIGV2ZW50IGxpc3RlbmVy cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwOTk1 CisKKyAgICAgICAgKiBkb20vTm9kZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpldmVudEhhc0xp c3RlbmVycyk6CisgICAgICAgIChXZWJDb3JlOjpOb2RlOjpkaXNwYXRjaEdlbmVyaWNFdmVudCk6 CisgICAgICAgICogeG1sL1hNTEh0dHBSZXF1ZXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlhN TEh0dHBSZXF1ZXN0OjpjYWxsUmVhZHlTdGF0ZUNoYW5nZUxpc3RlbmVyKToKKwogMjAwOS0xMS0w MSAgS2Vpc2hpIEhhdHRvcmkgIDxjYXNleS5oYXR0b3JpQGdtYWlsLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2RvbS9Ob2Rl LmNwcCBiL1dlYkNvcmUvZG9tL05vZGUuY3BwCmluZGV4IDYxMmJmMTguLjhkYzViNzUgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvZG9tL05vZGUuY3BwCisrKyBiL1dlYkNvcmUvZG9tL05vZGUuY3BwCkBA IC0yNDQ3LDYgKzI0NDcsMjAgQEAgYm9vbCBOb2RlOjpkaXNwYXRjaEV2ZW50KFBhc3NSZWZQdHI8 RXZlbnQ+IHBycEV2ZW50KQogICAgIHJldHVybiBkaXNwYXRjaEdlbmVyaWNFdmVudChldmVudC5y ZWxlYXNlKCkpOwogfQogCitzdGF0aWMgYm9vbCBldmVudEhhc0xpc3RlbmVycyhjb25zdCBBdG9t aWNTdHJpbmcmIGV2ZW50VHlwZSwgTm9kZSogbm9kZSwgVmVjdG9yPCBSZWZQdHI8IENvbnRhaW5l ck5vZGUgPiA+JiBhbmNlc3RvcnMpCit7CisgICAgaWYgKG5vZGUtPmhhc0V2ZW50TGlzdGVuZXJz KGV2ZW50VHlwZSkpCisgICAgICAgIHJldHVybiB0cnVlOworCisgICAgZm9yIChzc2l6ZV90IGkg PSAoYW5jZXN0b3JzLnNpemUoKSAtIDEpOyBpID49IDA7IC0taSkgeworICAgICAgICBDb250YWlu ZXJOb2RlKiBhbmNlc3RvciA9IGFuY2VzdG9yc1tpXS5nZXQoKTsKKyAgICAgICAgaWYgKGFuY2Vz dG9yLT5oYXNFdmVudExpc3RlbmVycyhldmVudFR5cGUpKQorICAgICAgICAgICAgcmV0dXJuIHRy dWU7CisgICAgfQorCisgICByZXR1cm4gZmFsc2U7ICAgIAorfQorCiBib29sIE5vZGU6OmRpc3Bh dGNoR2VuZXJpY0V2ZW50KFBhc3NSZWZQdHI8RXZlbnQ+IHBycEV2ZW50KQogewogICAgIFJlZlB0 cjxFdmVudD4gZXZlbnQocHJwRXZlbnQpOwpAQCAtMjQ1NSwxMiArMjQ2OSw2IEBAIGJvb2wgTm9k ZTo6ZGlzcGF0Y2hHZW5lcmljRXZlbnQoUGFzc1JlZlB0cjxFdmVudD4gcHJwRXZlbnQpCiAgICAg QVNTRVJUKGV2ZW50LT50YXJnZXQoKSk7CiAgICAgQVNTRVJUKCFldmVudC0+dHlwZSgpLmlzTnVs bCgpKTsgLy8gSmF2YVNjcmlwdCBjb2RlIGNhbiBjcmVhdGUgYW4gZXZlbnQgd2l0aCBhbiBlbXB0 eSBuYW1lLCBidXQgbm90IG51bGwuCiAKLSNpZiBFTkFCTEUoSU5TUEVDVE9SKQotICAgIEluc3Bl Y3RvclRpbWVsaW5lQWdlbnQqIHRpbWVsaW5lQWdlbnQgPSBkb2N1bWVudCgpLT5pbnNwZWN0b3JU aW1lbGluZUFnZW50KCk7Ci0gICAgaWYgKHRpbWVsaW5lQWdlbnQpCi0gICAgICAgIHRpbWVsaW5l QWdlbnQtPndpbGxEaXNwYXRjaERPTUV2ZW50KCpldmVudCk7Ci0jZW5kaWYKLQogICAgIC8vIE1h a2UgYSB2ZWN0b3Igb2YgYW5jZXN0b3JzIHRvIHNlbmQgdGhlIGV2ZW50IHRvLgogICAgIC8vIElm IHRoZSBub2RlIGlzIG5vdCBpbiBhIGRvY3VtZW50IGp1c3Qgc2VuZCB0aGUgZXZlbnQgdG8gaXQu CiAgICAgLy8gQmUgc3VyZSB0byByZWYgYWxsIG9mIG5vZGVzIHNpbmNlIGV2ZW50IGhhbmRsZXJz IGNvdWxkIHJlc3VsdCBpbiB0aGUgbGFzdCByZWZlcmVuY2UgZ29pbmcgYXdheS4KQEAgLTI0Njgs NiArMjQ3NiwxMyBAQCBib29sIE5vZGU6OmRpc3BhdGNoR2VuZXJpY0V2ZW50KFBhc3NSZWZQdHI8 RXZlbnQ+IHBycEV2ZW50KQogICAgIFZlY3RvcjxSZWZQdHI8Q29udGFpbmVyTm9kZT4gPiBhbmNl c3RvcnM7CiAgICAgZXZlbnRBbmNlc3RvcnMoYW5jZXN0b3JzKTsKIAorI2lmIEVOQUJMRShJTlNQ RUNUT1IpCisgICAgSW5zcGVjdG9yVGltZWxpbmVBZ2VudCogdGltZWxpbmVBZ2VudCA9IGRvY3Vt ZW50KCktPmluc3BlY3RvclRpbWVsaW5lQWdlbnQoKTsKKyAgICBib29sIHRpbWVsaW5lQWdlbnRJ c0FjdGl2ZSA9IHRpbWVsaW5lQWdlbnQgJiYgZXZlbnRIYXNMaXN0ZW5lcnMoZXZlbnQtPnR5cGUo KSwgdGhpcywgYW5jZXN0b3JzKTsgICAgCisgICAgaWYgKHRpbWVsaW5lQWdlbnRJc0FjdGl2ZSkK KyAgICAgICAgdGltZWxpbmVBZ2VudC0+d2lsbERpc3BhdGNoRE9NRXZlbnQoKmV2ZW50KTsKKyNl bmRpZgorCiAgICAgLy8gU2V0IHVwIGEgcG9pbnRlciB0byBpbmRpY2F0ZSB3aGV0aGVyIC8gd2hl cmUgdG8gZGlzcGF0Y2ggd2luZG93IGV2ZW50cy4KICAgICAvLyBXZSBkb24ndCBkaXNwYXRjaCBs b2FkIGV2ZW50cyB0byB0aGUgd2luZG93LiBUaGF0IHF1aXJrIHdhcyBvcmlnaW5hbGx5CiAgICAg Ly8gYWRkZWQgYmVjYXVzZSBNb3ppbGxhIGRvZXNuJ3QgcHJvcGFnYXRlIGxvYWQgZXZlbnRzIHRv IHRoZSB3aW5kb3cgb2JqZWN0LgpAQCAtMjU1OSw3ICsyNTc0LDcgQEAgZG9uZURpc3BhdGNoaW5n OgogCiBkb25lV2l0aERlZmF1bHQ6CiAjaWYgRU5BQkxFKElOU1BFQ1RPUikKLSAgICBpZiAodGlt ZWxpbmVBZ2VudCkKKyAgICBpZiAodGltZWxpbmVBZ2VudElzQWN0aXZlKQogICAgICAgICB0aW1l bGluZUFnZW50LT5kaWREaXNwYXRjaERPTUV2ZW50KCk7CiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEv V2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuY3BwIGIvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVl c3QuY3BwCmluZGV4IDg3YTY1NDAuLmJmMjAyMmYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUveG1sL1hN TEh0dHBSZXF1ZXN0LmNwcAorKysgYi9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5jcHAKQEAg LTI1MywyNyArMjUzLDI5IEBAIHZvaWQgWE1MSHR0cFJlcXVlc3Q6OmNhbGxSZWFkeVN0YXRlQ2hh bmdlTGlzdGVuZXIoKQogCiAjaWYgRU5BQkxFKElOU1BFQ1RPUikKICAgICBJbnNwZWN0b3JUaW1l bGluZUFnZW50KiB0aW1lbGluZUFnZW50ID0gSW5zcGVjdG9yVGltZWxpbmVBZ2VudDo6cmV0cmll dmUoc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpKTsKLSAgICBpZiAodGltZWxpbmVBZ2VudCkKKyAg ICBib29sIGNhbGxUaW1lbGluZUFnZW50T25SZWFkeVN0YXRlQ2hhbmdlID0gdGltZWxpbmVBZ2Vu dCAmJiBoYXNFdmVudExpc3RlbmVycyhldmVudE5hbWVzKCkucmVhZHlzdGF0ZWNoYW5nZUV2ZW50 KTsKKyAgICBpZiAoY2FsbFRpbWVsaW5lQWdlbnRPblJlYWR5U3RhdGVDaGFuZ2UpCiAgICAgICAg IHRpbWVsaW5lQWdlbnQtPndpbGxDaGFuZ2VYSFJSZWFkeVN0YXRlKG1fdXJsLnN0cmluZygpLCBt X3N0YXRlKTsKICNlbmRpZgogCiAgICAgZGlzcGF0Y2hFdmVudChYTUxIdHRwUmVxdWVzdFByb2dy ZXNzRXZlbnQ6OmNyZWF0ZShldmVudE5hbWVzKCkucmVhZHlzdGF0ZWNoYW5nZUV2ZW50KSk7CiAK ICNpZiBFTkFCTEUoSU5TUEVDVE9SKQotICAgIGlmICh0aW1lbGluZUFnZW50KQorICAgIGlmIChj YWxsVGltZWxpbmVBZ2VudE9uUmVhZHlTdGF0ZUNoYW5nZSkKICAgICAgICAgdGltZWxpbmVBZ2Vu dC0+ZGlkQ2hhbmdlWEhSUmVhZHlTdGF0ZSgpOwogI2VuZGlmCiAKICAgICBpZiAobV9zdGF0ZSA9 PSBET05FICYmICFtX2Vycm9yKSB7CiAjaWYgRU5BQkxFKElOU1BFQ1RPUikKLSAgICAgICAgaWYg KHRpbWVsaW5lQWdlbnQpCisgICAgICAgIGJvb2wgY2FsbFRpbWVsaW5lQWdlbnRPbkxvYWQgPSB0 aW1lbGluZUFnZW50ICYmIGhhc0V2ZW50TGlzdGVuZXJzKGV2ZW50TmFtZXMoKS5sb2FkRXZlbnQp OworICAgICAgICBpZiAoY2FsbFRpbWVsaW5lQWdlbnRPbkxvYWQpCiAgICAgICAgICAgICB0aW1l bGluZUFnZW50LT53aWxsTG9hZFhIUihtX3VybC5zdHJpbmcoKSk7CiAjZW5kaWYKIAogICAgICAg ICBkaXNwYXRjaEV2ZW50KFhNTEh0dHBSZXF1ZXN0UHJvZ3Jlc3NFdmVudDo6Y3JlYXRlKGV2ZW50 TmFtZXMoKS5sb2FkRXZlbnQpKTsKIAogI2lmIEVOQUJMRShJTlNQRUNUT1IpCi0gICAgICAgIGlm ICh0aW1lbGluZUFnZW50KQorICAgICAgICBpZiAoY2FsbFRpbWVsaW5lQWdlbnRPbkxvYWQpCiAg ICAgICAgICAgICB0aW1lbGluZUFnZW50LT5kaWRMb2FkWEhSKCk7CiAjZW5kaWYKICAgICB9Cg==