30990 2009-11-01 03:48:52 -0800 Web Inspector: Bug with Message Bubble in Syntax Highlighter 2009-11-01 12:33:52 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 keishi webkit-unassigned bweinstein commit-queue joepeck keishi pfeldman pmuellr rik timothy oldest_to_newest 159620 0 keishi 2009-11-01 03:48:52 -0800 Syntax Highlighter copies the content of the message bubble so it shows up twice. 159621 1 42271 keishi 2009-11-01 03:50:07 -0800 Created attachment 42271 proposed patch 159626 2 42271 pfeldman 2009-11-01 04:54:15 -0800 Comment on attachment 42271 proposed patch I think we should be able to test this using inspector layout tests. 159649 3 42271 commit-queue 2009-11-01 12:33:47 -0800 Comment on attachment 42271 proposed patch Clearing flags on attachment: 42271 Committed r50390: <http://trac.webkit.org/changeset/50390> 159650 4 commit-queue 2009-11-01 12:33:52 -0800 All reviewed patches have been landed. Closing bug. 42271 2009-11-01 03:50:07 -0800 2009-11-01 12:33:47 -0800 proposed patch bubble.diff text/plain 2367 keishi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDM4MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDktMTEtMDEgIEtlaXNoaSBIYXR0b3JpICA8Y2FzZXkuaGF0dG9y aUBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRml4IFdlYiBJbnNwZWN0b3I6IEJ1ZyB3aXRoIE1lc3NhZ2UgQnViYmxlIGluIFN5bnRh eCBIaWdobGlnaHRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MzA5OTAKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU291cmNlRnJhbWUu anM6CisKIDIwMDktMTAtMzEgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAg ICAgICBCdWlsZCBmaXgKSW5kZXg6IFdlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VG cmFtZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU291cmNl RnJhbWUuanMJKHJldmlzaW9uIDUwMzgzKQorKysgV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L1NvdXJjZUZyYW1lLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0xMjY4LDE3ICsxMjY4LDExIEBAIFdl Ykluc3BlY3Rvci5KYXZhU2NyaXB0U291cmNlU3ludGF4SGlnaGwKICAgICAgICAgICAgIHZhciBy b3cgPSByb3dzW3RoaXMubGluZUluZGV4XTsKICAgICAgICAgICAgIHZhciBsaW5lID0gcm93ID8g cm93LmNlbGxzWzFdIDogbnVsbDsKICAgICAgICAgICAgIGlmIChsaW5lICYmIHRoaXMubGluZUZy YWdtZW50KSB7Ci0gICAgICAgICAgICAgICAgdmFyIG1lc3NhZ2VCdWJibGUgPSBudWxsOwotICAg ICAgICAgICAgICAgIGlmIChsaW5lLmxhc3RDaGlsZCAmJiBsaW5lLmxhc3RDaGlsZC5ub2RlVHlw ZSA9PT0gTm9kZS5FTEVNRU5UX05PREUgJiYgbGluZS5sYXN0Q2hpbGQuaGFzU3R5bGVDbGFzcygi d2Via2l0LWh0bWwtbWVzc2FnZS1idWJibGUiKSkgewotICAgICAgICAgICAgICAgICAgICBtZXNz YWdlQnViYmxlID0gbGluZS5sYXN0Q2hpbGQ7Ci0gICAgICAgICAgICAgICAgICAgIGxpbmUucmVt b3ZlQ2hpbGQobWVzc2FnZUJ1YmJsZSk7Ci0gICAgICAgICAgICAgICAgfQotICAgICAgICAgICAg ICAgIAogICAgICAgICAgICAgICAgIEVsZW1lbnQucHJvdG90eXBlLnJlbW92ZUNoaWxkcmVuLmNh bGwobGluZSk7CiAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgbGluZS5hcHBlbmRD aGlsZCh0aGlzLmxpbmVGcmFnbWVudCk7Ci0gICAgICAgICAgICAgICAgaWYgKG1lc3NhZ2VCdWJi bGUpCi0gICAgICAgICAgICAgICAgICAgIGxpbmUuYXBwZW5kQ2hpbGQobWVzc2FnZUJ1YmJsZSk7 CisgICAgICAgICAgICAgICAgaWYgKHRoaXMubWVzc2FnZUJ1YmJsZSkKKyAgICAgICAgICAgICAg ICAgICAgbGluZS5hcHBlbmRDaGlsZCh0aGlzLm1lc3NhZ2VCdWJibGUpOwogICAgICAgICAgICAg ICAgIHRoaXMubGluZUZyYWdtZW50ID0gbnVsbDsKICAgICAgICAgICAgIH0KICAgICAgICAgICAg IHRoaXMubGluZUluZGV4Kys7CkBAIC0xMjg5LDYgKzEyODMsMTMgQEAgV2ViSW5zcGVjdG9yLkph dmFTY3JpcHRTb3VyY2VTeW50YXhIaWdobAogICAgICAgICAgICAgfQogICAgICAgICAgICAgcm93 ID0gcm93c1t0aGlzLmxpbmVJbmRleF07CiAgICAgICAgICAgICBsaW5lID0gcm93ID8gcm93LmNl bGxzWzFdIDogbnVsbDsKKyAgICAgICAgICAgIAorICAgICAgICAgICAgdGhpcy5tZXNzYWdlQnVi YmxlID0gbnVsbDsKKyAgICAgICAgICAgIGlmIChsaW5lLmxhc3RDaGlsZCAmJiBsaW5lLmxhc3RD aGlsZC5ub2RlVHlwZSA9PT0gTm9kZS5FTEVNRU5UX05PREUgJiYgbGluZS5sYXN0Q2hpbGQuaGFz U3R5bGVDbGFzcygid2Via2l0LWh0bWwtbWVzc2FnZS1idWJibGUiKSkgeworICAgICAgICAgICAg ICAgIHRoaXMubWVzc2FnZUJ1YmJsZSA9IGxpbmUubGFzdENoaWxkOworICAgICAgICAgICAgICAg IGxpbmUucmVtb3ZlQ2hpbGQodGhpcy5tZXNzYWdlQnViYmxlKTsKKyAgICAgICAgICAgIH0KKwog ICAgICAgICAgICAgdGhpcy5saW5lQ29kZSA9IGxpbmUudGV4dENvbnRlbnQ7CiAgICAgICAgICAg ICB0aGlzLmxpbmVGcmFnbWVudCA9IGRvY3VtZW50LmNyZWF0ZURvY3VtZW50RnJhZ21lbnQoKTsK ICAgICAgICAgICAgIHRoaXMuY3Vyc29yID0gMDsK