30978 2009-10-31 08:25:54 -0700 [Qt] ASSERT failure while running DRT 2009-11-16 14:24:49 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Linux RESOLVED FIXED Qt P2 Normal --- 1 yael webkit-unassigned hausmann kenneth tonikitoo oldest_to_newest 159561 0 yael 2009-10-31 08:25:54 -0700 When running DRT in Debug mode, _many_ tests are crashing due to ASSERT failure in JavaScriptCore. All the crashes I looked at, lead to the same callstack: ASSERTION FAILED: !m_isCheckingForDefaultMarkViolation (../../../JavaScriptCore/runtime/JSCell.h:318 void JSC::MarkStack::append(JSC::JSCell*)) Segmentation fault 0: /home/yael/trunk4/WebKitBuild/Debug/bin/DumpRenderTree [0x805ba69] 1: /home/yael/trunk4/WebKitBuild/Debug/bin/DumpRenderTree [0x805be7c] 2: [0xb80e0400] 3: /home/yael/trunk4/WebKitBuild/Debug/lib/libQtWebKit.so.4(_ZN3JSC9MarkStack6appendEPNS_6JSCellE+0x4c) [0xb6835908] 4: /home/yael/trunk4/WebKitBuild/Debug/lib/libQtWebKit.so.4(_ZN3JSC8Bindings10QtInstance13markAggregateERNS_9MarkStackE+0xc0) [0xb70de9d2] 5: /home/yael/trunk4/WebKitBuild/Debug/lib/libQtWebKit.so.4(_ZN3JSC8Bindings18QtRuntimeObjectImp12markChildrenERNS_9MarkStackE+0x4a) [0xb70dffe2] 6: /home/yael/trunk4/WebKitBuild/Debug/lib/libQtWebKit.so.4(_ZN3JSC9MarkStack12markChildrenEPNS_6JSCellE+0xed) [0xb690be91] 7: /home/yael/trunk4/WebKitBuild/Debug/lib/libQtWebKit.so.4(_ZN3JSC9MarkStack5drainEv+0x2bc) [0xb690c1f8] 8: /home/yael/trunk4/WebKitBuild/Debug/lib/libQtWebKit.so.4(_ZN3JSC4Heap18markConservativelyERNS_9MarkStackEPvS3_+0x215) [0xb690c5bb] 9: /home/yael/trunk4/WebKitBuild/Debug/lib/libQtWebKit.so.4(_ZN3JSC12RegisterFile11markGlobalsERNS_9MarkStackEPNS_4HeapE+0x3e) [0xb68357d2] 10: /home/yael/trunk4/WebKitBuild/Debug/lib/libQtWebKit.so.4(_ZN3JSC14JSGlobalObject12markChildrenERNS_9MarkStackE+0x21f) [0xb6835e63] ... 161581 1 kenneth 2009-11-09 08:18:25 -0800 Is this in the Qt implementation? or shared code? 161585 2 yael 2009-11-09 08:20:42 -0800 (In reply to comment #1) > Is this in the Qt implementation? or shared code? The ASSERT is in shared code. I marked this as Qt bug because I do not get this ASSERT when running DRT on Mac. 163691 3 43235 yael 2009-11-14 17:03:44 -0800 Created attachment 43235 Patch Add needed Structure typeInfo flags to QtRuntimeObjectImpl and QtRuntimeMethod. These flags are needed after r49649, where HasDefaultmark was changed to OverrideMarkChildren. 163695 4 kenneth 2009-11-14 18:29:01 -0800 Good that you are looking into this, but does it really make sense to make those statics? 163698 5 yael 2009-11-14 19:24:06 -0800 (In reply to comment #4) > Good that you are looking into this, but does it really make sense to make > those statics? I followed what Oliver did in r49694 and r49721. StructureFlags is static everywhere else. 163699 6 kenneth 2009-11-14 19:32:04 -0800 OK then :-) 164080 7 yael 2009-11-16 14:24:49 -0800 Committed r51052: <http://trac.webkit.org/changeset/51052> 43235 2009-11-14 17:03:44 -0800 2009-11-14 19:31:44 -0800 Patch 30978.patch text/plain 2395 yael SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDk5OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMTEtMTQgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gQVNTRVJUIGZhaWx1cmUgd2hpbGUgcnVubmluZyBEUlQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwOTc4CisKKyAgICAgICAgQWRkIG5lZWRl ZCBTdHJ1Y3R1cmUgdHlwZUluZm8gZmxhZ3MgdG8gUXRSdW50aW1lT2JqZWN0SW1wbCBhbmQgUXRS dW50aW1lTWV0aG9kLgorICAgICAgICBUaGVzZSBmbGFncyBhcmUgbmVlZGVkIGFmdGVyIHI0OTY0 OSwgd2hlcmUgSGFzRGVmYXVsdG1hcmsgd2FzIGNoYW5nZWQgdG8gT3ZlcnJpZGVNYXJrQ2hpbGRy ZW4uCisKKyAgICAgICAgKiBicmlkZ2UvcXQvcXRfaW5zdGFuY2UuY3BwOgorICAgICAgICAoSlND OjpCaW5kaW5nczo6UXRSdW50aW1lT2JqZWN0SW1wOjpjcmVhdGVTdHJ1Y3R1cmUpOgorICAgICAg ICAqIGJyaWRnZS9xdC9xdF9ydW50aW1lLmg6CisgICAgICAgIChKU0M6OkJpbmRpbmdzOjpRdFJ1 bnRpbWVNZXRob2Q6OmNyZWF0ZVN0cnVjdHVyZSk6CisKIDIwMDktMTEtMTQgIEFkZWxlIFBldGVy c29uICA8YWRlbGVAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3Rl aW4uCkluZGV4OiBXZWJDb3JlL2JyaWRnZS9xdC9xdF9pbnN0YW5jZS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9icmlkZ2UvcXQvcXRfaW5zdGFuY2UuY3BwCShyZXZpc2lvbiA1MDk5OCkKKysr IFdlYkNvcmUvYnJpZGdlL3F0L3F0X2luc3RhbmNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTgs NiArNTgsMTQgQEAKICAgICAgICAgICAgIGluc3RhbmNlLT5tYXJrQWdncmVnYXRlKG1hcmtTdGFj ayk7CiAgICAgfQogCisgICAgc3RhdGljIFBhc3NSZWZQdHI8U3RydWN0dXJlPiBjcmVhdGVTdHJ1 Y3R1cmUoSlNWYWx1ZSBwcm90b3R5cGUpCisgICAgeworICAgICAgICByZXR1cm4gU3RydWN0dXJl OjpjcmVhdGUocHJvdG90eXBlLCBUeXBlSW5mbyhPYmplY3RUeXBlLCAgU3RydWN0dXJlRmxhZ3Mp KTsKKyAgICB9CisKK3Byb3RlY3RlZDoKKyAgICBzdGF0aWMgY29uc3QgdW5zaWduZWQgU3RydWN0 dXJlRmxhZ3MgPSBSdW50aW1lT2JqZWN0SW1wOjpTdHJ1Y3R1cmVGbGFncyB8IE92ZXJyaWRlc01h cmtDaGlsZHJlbjsKKwogcHJpdmF0ZToKICAgICB2aXJ0dWFsIGNvbnN0IENsYXNzSW5mbyogY2xh c3NJbmZvKCkgY29uc3QgeyByZXR1cm4gJnNfaW5mbzsgfQogfTsKSW5kZXg6IFdlYkNvcmUvYnJp ZGdlL3F0L3F0X3J1bnRpbWUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JyaWRnZS9xdC9xdF9y dW50aW1lLmgJKHJldmlzaW9uIDUwOTk4KQorKysgV2ViQ29yZS9icmlkZ2UvcXQvcXRfcnVudGlt ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNTEsMTAgKzE1MSwxMiBAQAogCiAgICAgc3RhdGljIFBh c3NSZWZQdHI8U3RydWN0dXJlPiBjcmVhdGVTdHJ1Y3R1cmUoSlNWYWx1ZSBwcm90b3R5cGUpCiAg ICAgewotICAgICAgICByZXR1cm4gU3RydWN0dXJlOjpjcmVhdGUocHJvdG90eXBlLCBUeXBlSW5m byhPYmplY3RUeXBlLCAgT3ZlcnJpZGVzR2V0T3duUHJvcGVydHlTbG90IHwgT3ZlcnJpZGVzTWFy a0NoaWxkcmVuKSk7CisgICAgICAgIHJldHVybiBTdHJ1Y3R1cmU6OmNyZWF0ZShwcm90b3R5cGUs IFR5cGVJbmZvKE9iamVjdFR5cGUsICBTdHJ1Y3R1cmVGbGFncykpOwogICAgIH0KIAogcHJvdGVj dGVkOgorICAgIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBTdHJ1Y3R1cmVGbGFncyA9IE92ZXJyaWRl c0dldE93blByb3BlcnR5U2xvdCB8IEludGVybmFsRnVuY3Rpb246OlN0cnVjdHVyZUZsYWdzIHwg T3ZlcnJpZGVzTWFya0NoaWxkcmVuOworCiAgICAgUXRSdW50aW1lTWV0aG9kRGF0YSAqZF9mdW5j KCkgY29uc3Qge3JldHVybiBkX3B0cjt9CiAgICAgUXRSdW50aW1lTWV0aG9kKFF0UnVudGltZU1l dGhvZERhdGEgKmRkLCBFeGVjU3RhdGUgKmV4ZWMsIGNvbnN0IElkZW50aWZpZXIgJm4sIFBhc3NS ZWZQdHI8UXRJbnN0YW5jZT4gaW5zdCk7CiAgICAgUXRSdW50aW1lTWV0aG9kRGF0YSAqZF9wdHI7 Cg==