30968 2009-10-30 16:01:49 -0700 Fix windows expected results affected by patch http://trac.webkit.org/changeset/50315 2009-11-03 10:40:47 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 0 victorw webkit-unassigned arv eric oldest_to_newest 159497 0 victorw 2009-10-30 16:01:49 -0700 Patch "http://trac.webkit.org/changeset/50315" makes links mouse focusable only on GTK and QT, so Windows has same behavior as mac. Need to remove win specific expected results for tests related to this patch: fast/events/click-focus-anchor.html fast/inline/dirtyLinesForInline.html 159503 1 42242 victorw 2009-10-30 16:13:51 -0700 Created attachment 42242 Proposed Patch 159701 2 42242 eric 2009-11-01 18:24:15 -0800 Comment on attachment 42242 Proposed Patch OK. I dont' think Victor is a committer yet, so marking cq+ too. 159707 3 42242 commit-queue 2009-11-01 19:12:10 -0800 Comment on attachment 42242 Proposed Patch Rejecting patch 42242 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Eric Seidel', '--force']" exit_code: 2 Last 500 characters of output: eded at 1 with fuzz 3. patching file LayoutTests/platform/win/fast/events/click-focus-anchor-expected.txt rm 'LayoutTests/platform/win/fast/events/click-focus-anchor-expected.txt' patching file LayoutTests/platform/win/fast/inline/dirtyLinesForInline-expected.txt rm 'LayoutTests/platform/win/fast/inline/dirtyLinesForInline-expected.txt' Could not open 'LayoutTests/platform/win/fast/inline' to list files: 0 at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply line 283, <> line 75. 159717 4 eric 2009-11-01 19:41:56 -0800 I'm not sure what's up here. svn-apply does have known issues with git binary deletions, but that shouldn't be the problem here. bug 28456. 160123 5 victorw 2009-11-03 10:40:47 -0800 Patch landed: Changed by: japhet@chromium.org Changed at: Tue 03 Nov 2009 09:49:24 Branch: trunk Revision: 50461 42242 2009-10-30 16:13:51 -0700 2009-11-01 19:12:10 -0800 Proposed Patch click-focus.patch text/plain 3545 victorw SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUwMzYzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDktMTAtMzAgIFZpY3RvciBXYW5nICA8dmlj dG9yd0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgImh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzUwMzE1IiBtYWtl cyBsaW5rcyBtb3VzZQorICAgICAgICBmb2N1c2FibGUgb25seSBvbiBHVEsgYW5kIFFULCBzbyB3 aW4gaGFzIHNhbWUgYmVoYXZpb3IgYXMgbWFjIG5vdworICAgICAgICBSZW1vdmUgdGhlIHdpbiBz cGVjaWZpYyBleHBlY3RlZCByZXN1bHRzIGZvciB0ZXN0cyBmYWlsZWQKKyAgICAgICAgZHVlIHRv IHRoZSBwYXRjaC4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MzA5NjgKKworICAgICAgICAqIHBsYXRmb3JtL3dpbi9mYXN0L2V2ZW50cy9jbGljay1m b2N1cy1hbmNob3ItZXhwZWN0ZWQudHh0OiBSZW1vdmVkLgorICAgICAgICAqIHBsYXRmb3JtL3dp bi9mYXN0L2lubGluZTogUmVtb3ZlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS93aW4vZmFzdC9pbmxp bmUvZGlydHlMaW5lc0ZvcklubGluZS1leHBlY3RlZC50eHQ6IFJlbW92ZWQuCisKIDIwMDktMTAt MzAgIEVucmljYSBDYXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9mYXN0L2V2 ZW50cy9jbGljay1mb2N1cy1hbmNob3ItZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL3BsYXRmb3JtL3dpbi9mYXN0L2V2ZW50cy9jbGljay1mb2N1cy1hbmNob3ItZXhwZWN0 ZWQudHh0CShyZXZpc2lvbiA1MDM1NykKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9mYXN0 L2V2ZW50cy9jbGljay1mb2N1cy1hbmNob3ItZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBA IC0xLDEwICswLDAgQEAKLVRoaXMgdGVzdCBlbnN1cmVzIHRoYXQgd2UgY2FuIGNsaWNrIHRvIGZv Y3VzIGFuIGEgZWxlbWVudC4gQ2xpY2sgb24gdGhlIGVsZW1lbnQgYmVsb3cuCi0KLUZvY3VzYWJs ZSBhbmNob3Igd2l0aCB0YWIgaW5kZXgKLQotRm9jdXNhYmxlIGFuY2hvcgotCi1SZXN1bHQKLQot UEFTUwotUEFTUwpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL2Zhc3QvaW5saW5lL2Rp cnR5TGluZXNGb3JJbmxpbmUtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L3BsYXRmb3JtL3dpbi9mYXN0L2lubGluZS9kaXJ0eUxpbmVzRm9ySW5saW5lLWV4cGVjdGVkLnR4 dAkocmV2aXNpb24gNTAzNTcpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vZmFzdC9pbmxp bmUvZGlydHlMaW5lc0ZvcklubGluZS1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTEs MzIgKzAsMCBAQAotbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCi0gIFJlbmRlclZpZXcgYXQg KDAsMCkgc2l6ZSA4MDB4NjAwCi1sYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKLSAgUmVuZGVy QmxvY2sge0hUTUx9IGF0ICgwLDApIHNpemUgODAweDYwMAotICAgIFJlbmRlckJvZHkge0JPRFl9 IGF0ICg4LDgpIHNpemUgNzg0eDU4NAotICAgICAgUmVuZGVyQmxvY2sge1B9IGF0ICgwLDApIHNp emUgNzg0eDM2Ci0gICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXplIDc3Mngz NgotICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDApIHdpZHRoIDU5ODogIlRvIHJlcHJvZHVjZSB0 aGlzIGJ1ZyBvdXRzaWRlIG9mIER1bXBSZW5kZXJUcmVlLCBtb3VzZSBvdmVyIHRoZSBsaW5rcyBi ZWxvdyBzZXZlcmFsIHRpbWVzLiAiCi0gICAgICAgICAgdGV4dCBydW4gYXQgKDU5OCwwKSB3aWR0 aCAxNzQ6ICJUaGUgYnVnIGlzIGZpeGVkIGlmIHdlIGRvbid0IgotICAgICAgICAgIHRleHQgcnVu IGF0ICgwLDE4KSB3aWR0aCAzNzogImNyYXNoLiIKLSAgICAgIFJlbmRlckJsb2NrIHtESVZ9IGF0 ICgwLDUyKSBzaXplIDc4NHg1NQotICAgICAgICBSZW5kZXJUYWJsZSB7VEFCTEV9IGF0ICgwLDAp IHNpemUgMTMyeDU1Ci0gICAgICAgICAgUmVuZGVyVGFibGVTZWN0aW9uIHtUQk9EWX0gYXQgKDAs MCkgc2l6ZSAxMzJ4NTUKLSAgICAgICAgICAgIFJlbmRlclRhYmxlUm93IHtUUn0gYXQgKDAsMikg c2l6ZSAxMzJ4NTEKLSAgICAgICAgICAgICAgUmVuZGVyVGFibGVDZWxsIHtURH0gYXQgKDIsMikg c2l6ZSAxMjh4NTEgW3I9MCBjPTAgcnM9MSBjcz0xXQotICAgICAgICAgICAgICAgIFJlbmRlckJs b2NrIHtESVZ9IGF0ICgxLDEpIHNpemUgMTI2eDQ5Ci0gICAgICAgICAgICAgICAgICBSZW5kZXJJ bmxpbmUge0F9IGF0ICgwLDApIHNpemUgOTh4MzYgW2NvbG9yPSMwMDAwRUVdCi0gICAgICAgICAg ICAgICAgICAgIFJlbmRlcklubGluZSB7U1BBTn0gYXQgKDAsMCkgc2l6ZSA5OHgzNgotICAgICAg ICAgICAgICAgICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXplIDk4eDM2Ci0g ICAgICAgICAgICAgICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCwwKSB3aWR0aCA5ODogInRoaXMg aXMgdGhlIGhvbWUiCi0gICAgICAgICAgICAgICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCwxOCkg d2lkdGggMzA6ICJwYWdlIgotICAgICAgICAgICAgICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0g YXQgKDMwLDE4KSBzaXplIDM1eDE4Ci0gICAgICAgICAgICAgICAgICAgICAgdGV4dCBydW4gYXQg KDMwLDE4KSB3aWR0aCAzNTogImhvbWUiCi0gICAgICAgICAgICAgICAgICBSZW5kZXJCUiB7QlJ9 IGF0ICg2NSwzMikgc2l6ZSAweDAKLSAgICAgICAgICAgICAgICAgIFJlbmRlcklubGluZSB7QX0g YXQgKDAsMCkgc2l6ZSAzOXgxMyBbY29sb3I9IzAwMDBFRV0KLSAgICAgICAgICAgICAgICAgICAg UmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDM2KSBzaXplIDM5eDEzCi0gICAgICAgICAgICAgICAg ICAgICAgdGV4dCBydW4gYXQgKDAsMzYpIHdpZHRoIDM5OiAiYWJvdXQgdXMiCi0gICAgICAgICAg ICAgICAgICBSZW5kZXJCUiB7QlJ9IGF0ICgzOSw0Nikgc2l6ZSAweDAKLWxheWVyIGF0ICgxMSw5 OSkgc2l6ZSAxMTB4MTMKLSAgUmVuZGVyQmxvY2sgKHBvc2l0aW9uZWQpIHtTUEFOfSBhdCAoMTEs OTkpIHNpemUgMTEweDEzCi0gICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDApIHNpemUgMTEw eDEzCi0gICAgICB0ZXh0IHJ1biBhdCAoMCwwKSB3aWR0aCAxMTA6ICJ0aGlzIGlzIHRoZSBhYm91 dCB1cyBwYWdlIgo=