30965 2009-10-30 14:47:21 -0700 Make MediaPlayer constructor private 2009-10-30 15:04:33 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 eric.carlson eric.carlson ddkilzer oldest_to_newest 159464 0 eric.carlson 2009-10-30 14:47:21 -0700 Every time the media element opens a new movie is creates a new MediaPlayer object, which it stores in an OwnPtr<>. It does this manually, so the code is ugly and confusing: m_player.clear(); m_player.set(new MediaPlayer(this)); MediaPlayer constructor should be made private, and it should have a static create() method that returns a PassOwnPtr<> so that it can be assigned to m_player instead of using OwnPtr<>::set(). 159467 1 42238 eric.carlson 2009-10-30 14:54:52 -0700 Created attachment 42238 proposed patch 159470 2 eric.carlson 2009-10-30 15:04:33 -0700 Sending WebCore/ChangeLog Sending WebCore/html/HTMLMediaElement.cpp Sending WebCore/platform/graphics/MediaPlayer.h Transmitting file data ... Committed revision 50357. trac.webkit.org/changeset/50357 42238 2009-10-30 14:54:52 -0700 2009-10-30 14:56:44 -0700 proposed patch patch.txt text/plain 2645 eric.carlson SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDI4OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMTAtMzAgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBh cHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgTWFrZSBNZWRpYVBsYXllciBjb25zdHJ1Y3RvciBwcml2YXRlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDk2NQorCisgICAgICAgICogaHRtbC9I VE1MTWVkaWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6 OmxvYWRSZXNvdXJjZSk6IAorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6Zmlu aXNoUGFyc2luZ0NoaWxkcmVuKTogCisgICAgICAgICAgICBVc2UgTWVkaWFQbGF5ZXI6OmNyZWF0 ZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmg6CisgICAgICAg IChXZWJDb3JlOjpNZWRpYVBsYXllcjo6Y3JlYXRlKTogTmV3LgorCiAyMDA5LTEwLTI5ICBMYXN6 bG8gR29tYm9zICA8bGFzemxvLjEuZ29tYm9zQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBUb3IgQXJuZSBWZXN0YsO4LgpJbmRleDogV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1l bnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAko cmV2aXNpb24gNTAyODgpCisrKyBXZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTU4MiwxMSArNTgyLDEwIEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6 bG9hZFJlc291cmNlKGNvbnMKICAgICAgICAgc3RhcnRQcm9ncmVzc0V2ZW50VGltZXIoKTsKIAog I2lmICFFTkFCTEUoUExVR0lOX1BST1hZX0ZPUl9WSURFTykKLSAgICBtX3BsYXllci5jbGVhcigp OwotICAgIG1fcGxheWVyLnNldChuZXcgTWVkaWFQbGF5ZXIodGhpcykpOworICAgIG1fcGxheWVy ID0gTWVkaWFQbGF5ZXI6OmNyZWF0ZSh0aGlzKTsKICNlbHNlCiAgICAgaWYgKCFtX3BsYXllcikK LSAgICAgICAgbV9wbGF5ZXIuc2V0KG5ldyBNZWRpYVBsYXllcih0aGlzKSk7CisgICAgICAgIG1f cGxheWVyID0gTWVkaWFQbGF5ZXI6OmNyZWF0ZSh0aGlzKTsKICNlbmRpZgogCiAgICAgbV9wbGF5 ZXItPnNldFByZXNlcnZlc1BpdGNoKG1fd2Via2l0UHJlc2VydmVzUGl0Y2gpOwpAQCAtMTc4NCw3 ICsxNzgzLDcgQEAgdm9pZCBIVE1MTWVkaWFFbGVtZW50OjpmaW5pc2hQYXJzaW5nQ2hpbAogewog ICAgIEhUTUxFbGVtZW50OjpmaW5pc2hQYXJzaW5nQ2hpbGRyZW4oKTsKICAgICBpZiAoIW1fcGxh eWVyKQotICAgICAgICBtX3BsYXllci5zZXQobmV3IE1lZGlhUGxheWVyKHRoaXMpKTsKKyAgICAg ICAgbV9wbGF5ZXIgPSBNZWRpYVBsYXllcjo6Y3JlYXRlKHRoaXMpOwogICAgIAogICAgIGRvY3Vt ZW50KCktPnVwZGF0ZVN0eWxlSWZOZWVkZWQoKTsKICAgICBpZiAobV9uZWVkV2lkZ2V0VXBkYXRl ICYmIHJlbmRlcmVyKCkpCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxh eWVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXll ci5oCShyZXZpc2lvbiA1MDI4OCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQ bGF5ZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMzcsNiArMzcsNyBAQAogI2luY2x1ZGUgPHd0Zi9I YXNoU2V0Lmg+CiAjaW5jbHVkZSA8d3RmL093blB0ci5oPgogI2luY2x1ZGUgPHd0Zi9Ob25jb3B5 YWJsZS5oPgorI2luY2x1ZGUgPHd0Zi9QYXNzT3duUHRyLmg+CiAKICNpZmRlZiBfX09CSkNfXwog QGNsYXNzIFFUTW92aWU7CkBAIC0xMTUsNyArMTE2LDExIEBAIHB1YmxpYzoKIAogY2xhc3MgTWVk aWFQbGF5ZXIgOiBwdWJsaWMgTm9uY29weWFibGUgewogcHVibGljOgotICAgIE1lZGlhUGxheWVy KE1lZGlhUGxheWVyQ2xpZW50Kik7CisKKyAgICBzdGF0aWMgUGFzc093blB0cjxNZWRpYVBsYXll cj4gY3JlYXRlKE1lZGlhUGxheWVyQ2xpZW50KiBjbGllbnQpCisgICAgeworICAgICAgICByZXR1 cm4gbmV3IE1lZGlhUGxheWVyKGNsaWVudCk7CisgICAgfQogICAgIHZpcnR1YWwgfk1lZGlhUGxh eWVyKCk7CiAKICAgICAvLyBtZWRpYSBlbmdpbmUgc3VwcG9ydApAQCAtMjIzLDYgKzIyOCw4IEBA IHB1YmxpYzoKICAgICBib29sIGhhc1NpbmdsZVNlY3VyaXR5T3JpZ2luKCkgY29uc3Q7CiAKIHBy aXZhdGU6CisgICAgTWVkaWFQbGF5ZXIoTWVkaWFQbGF5ZXJDbGllbnQqKTsKKwogICAgIHN0YXRp YyB2b2lkIGluaXRpYWxpemVNZWRpYUVuZ2luZXMoKTsKIAogICAgIE1lZGlhUGxheWVyQ2xpZW50 KiBtX21lZGlhUGxheWVyQ2xpZW50Owo=