30964 2009-10-30 14:30:10 -0700 [Gtk] Implement AtkDocument 2009-11-01 13:57:35 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 25531 25831 1 jdiggs webkit-unassigned apinheiro commit-queue eric jmalonzo walker.willie xan.lopez oldest_to_newest 159446 0 jdiggs 2009-10-30 14:30:10 -0700 We need to implement the AtkDocument interface. http://library.gnome.org/devel/atk/unstable/AtkDocument.html 159551 1 42252 jdiggs 2009-10-31 05:11:24 -0700 Created attachment 42252 Part 1 - bare bones implementation 159552 2 42253 jdiggs 2009-10-31 05:12:29 -0700 Created attachment 42253 Part 2 - Attributes (requires part 1) 159553 3 42254 jdiggs 2009-10-31 05:14:39 -0700 Created attachment 42254 Part 3 - language/locale (requires part 1) 159586 4 42252 jmalonzo 2009-10-31 15:38:25 -0700 Comment on attachment 42252 Part 1 - bare bones implementation Looks fine. r=me. 159588 5 jmalonzo 2009-10-31 15:40:34 -0700 (In reply to comment #2) > Created an attachment (id=42253) [details] > Part 2 - Attributes (requires part 1) I think we should start writing layout tests for these. Would that be possible today or there's a plan to write layout tests for these changes soon? 159592 6 jdiggs 2009-10-31 15:52:29 -0700 (In reply to comment #5) > (In reply to comment #2) > > Created an attachment (id=42253) [details] [details] > > Part 2 - Attributes (requires part 1) > > I think we should start writing layout tests for these. Would that be possible > today or there's a plan to write layout tests for these changes soon? Learning about (and then writing) layout tests was on my to-do list, but not my today-/this-weekend list. :-) However, I will re-adjust my list. Last time I looked at merely running the tests (once they were running) I kept getting failures, so I've got a few things to work on before I can start generating tests. 159597 7 xan.lopez 2009-10-31 16:06:12 -0700 (In reply to comment #5) > (In reply to comment #2) > > Created an attachment (id=42253) [details] [details] > > Part 2 - Attributes (requires part 1) > > I think we should start writing layout tests for these. Would that be possible > today or there's a plan to write layout tests for these changes soon? Mmm, do you mean unit tests here? Or how could we test ATK APIs from layout tests in JavaScript? 159598 8 jmalonzo 2009-10-31 16:20:12 -0700 (In reply to comment #7) > (In reply to comment #5) > > (In reply to comment #2) > > > Created an attachment (id=42253) [details] [details] [details] > > > Part 2 - Attributes (requires part 1) > > > > I think we should start writing layout tests for these. Would that be possible > > today or there's a plan to write layout tests for these changes soon? > > Mmm, do you mean unit tests here? Or how could we test ATK APIs from layout > tests in JavaScript? Layout tests. We're not testing ATK APIs but testing the accessible characteristics of AX objects. AccessibilityController exposes some of this attributes that we can test in JavaScript. It's still missing a few implementations for Gtk though, but shouldn't be difficult to implement those. 159616 9 xan.lopez 2009-11-01 02:13:14 -0800 (In reply to comment #8) > > Mmm, do you mean unit tests here? Or how could we test ATK APIs from layout > > tests in JavaScript? > > Layout tests. We're not testing ATK APIs but testing the accessible > characteristics of AX objects. AccessibilityController exposes some of this > attributes that we can test in JavaScript. It's still missing a few > implementations for Gtk though, but shouldn't be difficult to implement those. OK. Since most of what we are doing here is implementing the ATK APIs I assumed you were referring to that. In any case, testing that all those APIs work as expected is, at least, as important as doing layout tests for any core AX functionality we are using or adding. 159657 10 eric 2009-11-01 13:19:08 -0800 bugzilla-tool is not smart enough to leave bugs open after landing due to bug 28230. So this bug will need to be re-opened after the commit-queue lands patch #1. Either someone (which can be me), needs to fix bug 28230, or better yet, we should follow the one-change-per-bug style that is more common in WebKit. :) 159658 11 42252 commit-queue 2009-11-01 13:22:42 -0800 Comment on attachment 42252 Part 1 - bare bones implementation Clearing flags on attachment: 42252 Committed r50393: <http://trac.webkit.org/changeset/50393> 159659 12 commit-queue 2009-11-01 13:22:50 -0800 All reviewed patches have been landed. Closing bug. 159665 13 42253 jdiggs 2009-11-01 13:41:31 -0800 Comment on attachment 42253 Part 2 - Attributes (requires part 1) Obsoleting this patch and clearing the review flag. Bug 30997 has been spun off so that we only have one change per bug. 159667 14 42254 jdiggs 2009-11-01 13:44:06 -0800 Comment on attachment 42254 Part 3 - language/locale (requires part 1) Obsoleting this patch and clearing the review flag. Bug 30998 has been spun off so that we only have one change per bug. 159669 15 jdiggs 2009-11-01 13:51:36 -0800 (In reply to comment #10) > bugzilla-tool is not smart enough to leave bugs open after landing due to bug > 28230. So this bug will need to be re-opened after the commit-queue lands > patch #1. Either someone (which can be me), needs to fix bug 28230, or better > yet, we should follow the one-change-per-bug style that is more common in > WebKit. :) Sorry. New bugs spun off for each patch. Should I also file new bugs for the tests which I will (hopefully) write for each of those bugs, or do tests associated with a fix constitute part of a single change? 159671 16 eric 2009-11-01 13:57:35 -0800 (In reply to comment #15) > (In reply to comment #10) > > bugzilla-tool is not smart enough to leave bugs open after landing due to bug > > 28230. So this bug will need to be re-opened after the commit-queue lands > > patch #1. Either someone (which can be me), needs to fix bug 28230, or better > > yet, we should follow the one-change-per-bug style that is more common in > > WebKit. :) > > Sorry. New bugs spun off for each patch. > > Should I also file new bugs for the tests which I will (hopefully) write for > each of those bugs, or do tests associated with a fix constitute part of a > single change? Certainly nothing to apologize for! :) I just wanted you to know that our tools don't handle multiple-patches-per-bug very well. Tests should go along with fixes. When I review patches often seeing and understanding what the tests are doing is more important than the code itself. If we have a test, we'll never break the code in the same way again. :) 42252 2009-10-31 05:11:24 -0700 2009-11-01 13:22:42 -0800 Part 1 - bare bones implementation document-iface-1.patch text/plain 4642 jdiggs RnJvbSAyNTZjY2ZlNjE3YWM4ZTliYjM4Yjc2ZmYyMzk0YmJkZjJmOGEyNzBmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2FubWFyaWUgRGlnZ3MgPGpvYW5tYXJpZS5kaWdnc0BnbWFp bC5jb20+CkRhdGU6IEZyaSwgMzAgT2N0IDIwMDkgMTg6MTg6MzUgLTA0MDAKU3ViamVjdDogW1BB VENIIDEvM10gUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA5NjQKW0d0a10gSW1wbGVtbWVudCBBdGtEb2N1bWVudAoK SW1wbGVtZW50cyB3aGF0IGhhcyBiZWVuIGltcGxlbWVudGVkIGluIEFULVNQSQoKKiBhY2Nlc3Np YmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHA6CihHZXRBdGtJbnRl cmZhY2VUeXBlRnJvbVdBSVR5cGUpOgooZ2V0SW50ZXJmYWNlTWFza0Zyb21PYmplY3QpOgooYXRr X2RvY3VtZW50X2ludGVyZmFjZV9pbml0KToKKHdlYmtpdF9hY2Nlc3NpYmxlX2RvY3VtZW50X2dl dF9kb2N1bWVudF9hdHRyaWJ1dGVfdmFsdWUpOgood2Via2l0X2FjY2Vzc2libGVfZG9jdW1lbnRf Z2V0X2RvY3VtZW50X2F0dHJpYnV0ZXMpOgood2Via2l0X2FjY2Vzc2libGVfZG9jdW1lbnRfZ2V0 X2xvY2FsZSk6Ci0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgfCAgIDE3ICsrKysrKysrCiAuLi4vZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFw cGVyQXRrLmNwcCAgICAgICAgICB8ICAgNDQgKysrKysrKysrKysrKysrKysrKy0KIDIgZmlsZXMg Y2hhbmdlZCwgNjAgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9X ZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDlkMWY4YmMuLjczOGU5 MzcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMjAgQEAKKzIwMDktMTAtMzAgIEpvYW5tYXJpZSBEaWdncyAgPGpvYW5tYXJp ZS5kaWdnc0BnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwOTY0 CisgICAgICAgIFtHdGtdIEltcGxlbW1lbnQgQXRrRG9jdW1lbnQKKworICAgICAgICBJbXBsZW1l bnRzIHdoYXQgaGFzIGJlZW4gaW1wbGVtZW50ZWQgaW4gQVQtU1BJLgorCisgICAgICAgICogYWNj ZXNzaWJpbGl0eS9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJBdGsuY3BwOgorICAgICAg ICAoR2V0QXRrSW50ZXJmYWNlVHlwZUZyb21XQUlUeXBlKToKKyAgICAgICAgKGdldEludGVyZmFj ZU1hc2tGcm9tT2JqZWN0KToKKyAgICAgICAgKGF0a19kb2N1bWVudF9pbnRlcmZhY2VfaW5pdCk6 CisgICAgICAgICh3ZWJraXRfYWNjZXNzaWJsZV9kb2N1bWVudF9nZXRfZG9jdW1lbnRfYXR0cmli dXRlX3ZhbHVlKToKKyAgICAgICAgKHdlYmtpdF9hY2Nlc3NpYmxlX2RvY3VtZW50X2dldF9kb2N1 bWVudF9hdHRyaWJ1dGVzKToKKyAgICAgICAgKHdlYmtpdF9hY2Nlc3NpYmxlX2RvY3VtZW50X2dl dF9sb2NhbGUpOgorCiAyMDA5LTEwLTMwICBEbWl0cnkgVGl0b3YgIDxkaW1pY2hAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBh L1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJBdGsu Y3BwIGIvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBl ckF0ay5jcHAKaW5kZXggMmVhODMzNi4uODE5NTkyNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9hY2Nl c3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHAKKysrIGIvV2Vi Q29yZS9hY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHAK QEAgLTEzNyw2ICsxMzcsMTEgQEAgc3RhdGljIEFjY2Vzc2liaWxpdHlPYmplY3QqIGNvcmUoQXRr VGFibGUqIHRhYmxlKQogICAgIHJldHVybiBjb3JlKEFUS19PQkpFQ1QodGFibGUpKTsKIH0KIAor c3RhdGljIEFjY2Vzc2liaWxpdHlPYmplY3QqIGNvcmUoQXRrRG9jdW1lbnQqIGRvY3VtZW50KQor eworICAgIHJldHVybiBjb3JlKEFUS19PQkpFQ1QoZG9jdW1lbnQpKTsKK30KKwogc3RhdGljIGNv bnN0IGdjaGFyKiBuYW1lRnJvbUNoaWxkcmVuKEFjY2Vzc2liaWxpdHlPYmplY3QqIG9iamVjdCkK IHsKICAgICBpZiAoIW9iamVjdCkKQEAgLTE0MDYsNiArMTQxMSwzNCBAQCBzdGF0aWMgdm9pZCBh dGtfdGFibGVfaW50ZXJmYWNlX2luaXQoQXRrVGFibGVJZmFjZSogaWZhY2UpCiAgICAgaWZhY2Ut PmdldF9yb3dfZGVzY3JpcHRpb24gPSB3ZWJraXRfYWNjZXNzaWJsZV90YWJsZV9nZXRfcm93X2Rl c2NyaXB0aW9uOwogfQogCitzdGF0aWMgY29uc3QgZ2NoYXIqIHdlYmtpdF9hY2Nlc3NpYmxlX2Rv Y3VtZW50X2dldF9hdHRyaWJ1dGVfdmFsdWUoQXRrRG9jdW1lbnQqIGRvY3VtZW50LCBjb25zdCBn Y2hhciogYXR0cmlidXRlKQoreworICAgIC8vIEZJWE1FOiBUaGlzIG5lZWRzIHRvIGJlIGltcGxl bWVudGVkLgorICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgcmV0dXJuIDA7Cit9CisKK3N0YXRp YyBBdGtBdHRyaWJ1dGVTZXQqIHdlYmtpdF9hY2Nlc3NpYmxlX2RvY3VtZW50X2dldF9hdHRyaWJ1 dGVzKEF0a0RvY3VtZW50KiBkb2N1bWVudCkKK3sKKyAgICAvLyBGSVhNRTogVGhpcyBuZWVkcyB0 byBiZSBpbXBsZW1lbnRlZC4KKyAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIHJldHVybiAwOwor fQorCitzdGF0aWMgY29uc3QgZ2NoYXIqIHdlYmtpdF9hY2Nlc3NpYmxlX2RvY3VtZW50X2dldF9s b2NhbGUoQXRrRG9jdW1lbnQqIGRvY3VtZW50KQoreworICAgIC8vIEZJWE1FOiBUaGlzIG5lZWRz IHRvIGJlIGltcGxlbWVudGVkLgorICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgcmV0dXJuIDA7 Cit9CisKK3N0YXRpYyB2b2lkIGF0a19kb2N1bWVudF9pbnRlcmZhY2VfaW5pdChBdGtEb2N1bWVu dElmYWNlKiBpZmFjZSkKK3sKKyAgICBpZmFjZS0+Z2V0X2RvY3VtZW50X2F0dHJpYnV0ZV92YWx1 ZSA9IHdlYmtpdF9hY2Nlc3NpYmxlX2RvY3VtZW50X2dldF9hdHRyaWJ1dGVfdmFsdWU7CisgICAg aWZhY2UtPmdldF9kb2N1bWVudF9hdHRyaWJ1dGVzID0gd2Via2l0X2FjY2Vzc2libGVfZG9jdW1l bnRfZ2V0X2F0dHJpYnV0ZXM7CisgICAgaWZhY2UtPmdldF9kb2N1bWVudF9sb2NhbGUgPSB3ZWJr aXRfYWNjZXNzaWJsZV9kb2N1bWVudF9nZXRfbG9jYWxlOworfQorCiBzdGF0aWMgY29uc3QgR0lu dGVyZmFjZUluZm8gQXRrSW50ZXJmYWNlc0luaXRGdW5jdGlvbnNbXSA9IHsKICAgICB7KEdJbnRl cmZhY2VJbml0RnVuYylhdGtfYWN0aW9uX2ludGVyZmFjZV9pbml0LAogICAgICAoR0ludGVyZmFj ZUZpbmFsaXplRnVuYykgTlVMTCwgTlVMTH0sCkBAIC0xNDIwLDYgKzE0NTMsOCBAQCBzdGF0aWMg Y29uc3QgR0ludGVyZmFjZUluZm8gQXRrSW50ZXJmYWNlc0luaXRGdW5jdGlvbnNbXSA9IHsKICAg ICB7KEdJbnRlcmZhY2VJbml0RnVuYylhdGtfaW1hZ2VfaW50ZXJmYWNlX2luaXQsCiAgICAgIChH SW50ZXJmYWNlRmluYWxpemVGdW5jKSBOVUxMLCBOVUxMfSwKICAgICB7KEdJbnRlcmZhY2VJbml0 RnVuYylhdGtfdGFibGVfaW50ZXJmYWNlX2luaXQsCisgICAgIChHSW50ZXJmYWNlRmluYWxpemVG dW5jKSBOVUxMLCBOVUxMfSwKKyAgICB7KEdJbnRlcmZhY2VJbml0RnVuYylhdGtfZG9jdW1lbnRf aW50ZXJmYWNlX2luaXQsCiAgICAgIChHSW50ZXJmYWNlRmluYWxpemVGdW5jKSBOVUxMLCBOVUxM fQogfTsKIApAQCAtMTQzMCw3ICsxNDY1LDggQEAgZW51bSBXQUlUeXBlIHsKICAgICBXQUlfVEVY VCwKICAgICBXQUlfQ09NUE9ORU5ULAogICAgIFdBSV9JTUFHRSwKLSAgICBXQUlfVEFCTEUKKyAg ICBXQUlfVEFCTEUsCisgICAgV0FJX0RPQ1VNRU5UCiB9OwogCiBzdGF0aWMgR1R5cGUgR2V0QXRr SW50ZXJmYWNlVHlwZUZyb21XQUlUeXBlKFdBSVR5cGUgdHlwZSkKQEAgLTE0NTAsNiArMTQ4Niw4 IEBAIHN0YXRpYyBHVHlwZSBHZXRBdGtJbnRlcmZhY2VUeXBlRnJvbVdBSVR5cGUoV0FJVHlwZSB0 eXBlKQogICAgICAgcmV0dXJuIEFUS19UWVBFX0lNQUdFOwogICBjYXNlIFdBSV9UQUJMRToKICAg ICAgIHJldHVybiBBVEtfVFlQRV9UQUJMRTsKKyAgY2FzZSBXQUlfRE9DVU1FTlQ6CisgICAgICBy ZXR1cm4gQVRLX1RZUEVfRE9DVU1FTlQ7CiAgIH0KIAogICByZXR1cm4gR19UWVBFX0lOVkFMSUQ7 CkBAIC0xNDg5LDYgKzE1MjcsMTAgQEAgc3RhdGljIGd1aW50MTYgZ2V0SW50ZXJmYWNlTWFza0Zy b21PYmplY3QoQWNjZXNzaWJpbGl0eU9iamVjdCogY29yZU9iamVjdCkKICAgICBpZiAocm9sZSA9 PSBUYWJsZVJvbGUpCiAgICAgICAgIGludGVyZmFjZU1hc2sgfD0gMSA8PCBXQUlfVEFCTEU7CiAK KyAgICAvLyBEb2N1bWVudAorICAgIGlmIChyb2xlID09IFdlYkFyZWFSb2xlKQorICAgICAgICBp bnRlcmZhY2VNYXNrIHw9IDEgPDwgV0FJX0RPQ1VNRU5UOworCiAgICAgcmV0dXJuIGludGVyZmFj ZU1hc2s7CiB9CiAKLS0gCjEuNi4zLjMKCg== 42253 2009-10-31 05:12:29 -0700 2009-11-01 13:41:31 -0800 Part 2 - Attributes (requires part 1) document-iface-2.patch text/plain 3895 jdiggs RnJvbSBmNzZmNjYwYzkzNjk1N2RlNTMwNzA3OWFiYWUxMDQwMmMxMWJhOWRlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2FubWFyaWUgRGlnZ3MgPGpvYW5tYXJpZS5kaWdnc0BnbWFp bC5jb20+CkRhdGU6IFNhdCwgMzEgT2N0IDIwMDkgMDE6NTI6NTMgLTA0MDAKU3ViamVjdDogW1BB VENIIDIvM10gUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA5NjQKW0d0a10gSW1wbGVtbWVudCBBdGtEb2N1bWVudAoK UHJvdmlkZXMgYWNjZXNzIHRvIGV4cGVjdGVkIGRvY3VtZW50IGF0dHJpYnV0ZXMuCgoqIGFjY2Vz c2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcDoKKGRvY3VtZW50 QXR0cmlidXRlVmFsdWUpOgood2Via2l0X2FjY2Vzc2libGVfZG9jdW1lbnRfZ2V0X2RvY3VtZW50 X2F0dHJpYnV0ZV92YWx1ZSk6Cih3ZWJraXRfYWNjZXNzaWJsZV9kb2N1bWVudF9nZXRfZG9jdW1l bnRfYXR0cmlidXRlcyk6Ci0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDE0ICsrKysrKysKIC4uLi9ndGsvQWNjZXNzaWJpbGl0eU9iamVj dFdyYXBwZXJBdGsuY3BwICAgICAgICAgIHwgICAzNyArKysrKysrKysrKysrKysrLS0tCiAyIGZp bGVzIGNoYW5nZWQsIDQ1IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3MzhlOTM3Li5l MTRjOTRiIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5n ZUxvZwpAQCAtNSw2ICs1LDIwIEBACiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zMDk2NAogICAgICAgICBbR3RrXSBJbXBsZW1tZW50IEF0a0RvY3VtZW50 CiAKKyAgICAgICAgUHJvdmlkZXMgYWNjZXNzIHRvIGV4cGVjdGVkIGRvY3VtZW50IGF0dHJpYnV0 ZXMuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3Jh cHBlckF0ay5jcHA6CisgICAgICAgIChkb2N1bWVudEF0dHJpYnV0ZVZhbHVlKToKKyAgICAgICAg KHdlYmtpdF9hY2Nlc3NpYmxlX2RvY3VtZW50X2dldF9kb2N1bWVudF9hdHRyaWJ1dGVfdmFsdWUp OgorICAgICAgICAod2Via2l0X2FjY2Vzc2libGVfZG9jdW1lbnRfZ2V0X2RvY3VtZW50X2F0dHJp YnV0ZXMpOgorCisyMDA5LTEwLTMwICBKb2FubWFyaWUgRGlnZ3MgIDxqb2FubWFyaWUuZGlnZ3NA Z21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDk2NAorICAgICAg ICBbR3RrXSBJbXBsZW1tZW50IEF0a0RvY3VtZW50CisKICAgICAgICAgSW1wbGVtZW50cyB3aGF0 IGhhcyBiZWVuIGltcGxlbWVudGVkIGluIEFULVNQSS4KIAogICAgICAgICAqIGFjY2Vzc2liaWxp dHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcDoKZGlmZiAtLWdpdCBhL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJBdGsuY3Bw IGIvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0 ay5jcHAKaW5kZXggODE5NTkyNi4uOTdkY2QwYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9hY2Nlc3Np YmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHAKKysrIGIvV2ViQ29y ZS9hY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHAKQEAg LTQ0LDYgKzQ0LDcgQEAKICNpbmNsdWRlICJBdG9taWNTdHJpbmcuaCIKICNpbmNsdWRlICJDU3Ry aW5nLmgiCiAjaW5jbHVkZSAiRG9jdW1lbnQuaCIKKyNpbmNsdWRlICJEb2N1bWVudFR5cGUuaCIK ICNpbmNsdWRlICJFZGl0b3IuaCIKICNpbmNsdWRlICJGcmFtZS5oIgogI2luY2x1ZGUgIkZyYW1l Vmlldy5oIgpAQCAtMTQxMSwxOCArMTQxMiw0MiBAQCBzdGF0aWMgdm9pZCBhdGtfdGFibGVfaW50 ZXJmYWNlX2luaXQoQXRrVGFibGVJZmFjZSogaWZhY2UpCiAgICAgaWZhY2UtPmdldF9yb3dfZGVz Y3JpcHRpb24gPSB3ZWJraXRfYWNjZXNzaWJsZV90YWJsZV9nZXRfcm93X2Rlc2NyaXB0aW9uOwog fQogCi1zdGF0aWMgY29uc3QgZ2NoYXIqIHdlYmtpdF9hY2Nlc3NpYmxlX2RvY3VtZW50X2dldF9h dHRyaWJ1dGVfdmFsdWUoQXRrRG9jdW1lbnQqIGRvY3VtZW50LCBjb25zdCBnY2hhciogYXR0cmli dXRlKQorc3RhdGljIGNvbnN0IGdjaGFyKiBkb2N1bWVudEF0dHJpYnV0ZVZhbHVlKEF0a0RvY3Vt ZW50KiBkb2N1bWVudCwgY29uc3QgZ2NoYXIqIGF0dHJpYnV0ZSkKIHsKLSAgICAvLyBGSVhNRTog VGhpcyBuZWVkcyB0byBiZSBpbXBsZW1lbnRlZC4KLSAgICBub3RJbXBsZW1lbnRlZCgpOworICAg IERvY3VtZW50KiBjb3JlRG9jdW1lbnQgPSBjb3JlKGRvY3VtZW50KS0+ZG9jdW1lbnQoKTsKKyAg ICBpZiAoIWNvcmVEb2N1bWVudCkKKyAgICAgICAgcmV0dXJuIDA7CisKKyAgICBTdHJpbmcgdmFs dWUgPSBTdHJpbmcoKTsKKyAgICBpZiAoIWdfYXNjaWlfc3RyY2FzZWNtcChhdHRyaWJ1dGUsICJE b2NUeXBlIikgJiYgY29yZURvY3VtZW50LT5kb2N0eXBlKCkpCisgICAgICAgIHZhbHVlID0gY29y ZURvY3VtZW50LT5kb2N0eXBlKCktPm5hbWUoKTsKKyAgICBlbHNlIGlmICghZ19hc2NpaV9zdHJj YXNlY21wKGF0dHJpYnV0ZSwgIkVuY29kaW5nIikpCisgICAgICAgIHZhbHVlID0gY29yZURvY3Vt ZW50LT5jaGFyc2V0KCk7CisgICAgZWxzZSBpZiAoIWdfYXNjaWlfc3RyY2FzZWNtcChhdHRyaWJ1 dGUsICJVUkkiKSkKKyAgICAgICAgdmFsdWUgPSBjb3JlRG9jdW1lbnQtPmRvY3VtZW50VVJJKCk7 CisgICAgaWYgKCF2YWx1ZS5pc0VtcHR5KCkpCisgICAgICAgIHJldHVybiByZXR1cm5TdHJpbmco dmFsdWUpOworCiAgICAgcmV0dXJuIDA7CiB9CiAKK3N0YXRpYyBjb25zdCBnY2hhciogd2Via2l0 X2FjY2Vzc2libGVfZG9jdW1lbnRfZ2V0X2F0dHJpYnV0ZV92YWx1ZShBdGtEb2N1bWVudCogZG9j dW1lbnQsIGNvbnN0IGdjaGFyKiBhdHRyaWJ1dGUpCit7CisgICAgcmV0dXJuIGRvY3VtZW50QXR0 cmlidXRlVmFsdWUoZG9jdW1lbnQsIGF0dHJpYnV0ZSk7Cit9CisKIHN0YXRpYyBBdGtBdHRyaWJ1 dGVTZXQqIHdlYmtpdF9hY2Nlc3NpYmxlX2RvY3VtZW50X2dldF9hdHRyaWJ1dGVzKEF0a0RvY3Vt ZW50KiBkb2N1bWVudCkKIHsKLSAgICAvLyBGSVhNRTogVGhpcyBuZWVkcyB0byBiZSBpbXBsZW1l bnRlZC4KLSAgICBub3RJbXBsZW1lbnRlZCgpOwotICAgIHJldHVybiAwOworICAgIEF0a0F0dHJp YnV0ZVNldCogYXR0cmlidXRlU2V0ID0gMDsKKyAgICBjb25zdCBnY2hhciogYXR0cmlidXRlcyBb XSA9IHsiRG9jVHlwZSIsICJFbmNvZGluZyIsICJVUkkifTsKKworICAgIGZvciAodW5zaWduZWQg aSA9IDA7IGkgPCBHX05fRUxFTUVOVFMoYXR0cmlidXRlcyk7IGkrKykgeworICAgICAgICBjb25z dCBnY2hhciogdmFsdWUgPSBkb2N1bWVudEF0dHJpYnV0ZVZhbHVlKGRvY3VtZW50LCBhdHRyaWJ1 dGVzW2ldKTsKKyAgICAgICAgaWYgKHZhbHVlKQorICAgICAgICAgICAgYXR0cmlidXRlU2V0ID0g YWRkQXR0cmlidXRlVG9TZXQoYXR0cmlidXRlU2V0LCBhdHRyaWJ1dGVzW2ldLCB2YWx1ZSk7Cisg ICAgfQorCisgICAgcmV0dXJuIGF0dHJpYnV0ZVNldDsKIH0KIAogc3RhdGljIGNvbnN0IGdjaGFy KiB3ZWJraXRfYWNjZXNzaWJsZV9kb2N1bWVudF9nZXRfbG9jYWxlKEF0a0RvY3VtZW50KiBkb2N1 bWVudCkKLS0gCjEuNi4zLjMKCg== 42254 2009-10-31 05:14:39 -0700 2009-11-01 13:44:17 -0800 Part 3 - language/locale (requires part 1) document-iface-3.patch text/plain 2083 jdiggs RnJvbSBmNDAyZjI0MWRmMWQ2ZmUxOWU4MDhjZDg2M2RkNzFiMDU5YWNkNDhiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2FubWFyaWUgRGlnZ3MgPGpvYW5tYXJpZS5kaWdnc0BnbWFp bC5jb20+CkRhdGU6IFNhdCwgMzEgT2N0IDIwMDkgMDg6MDI6MjUgLTA0MDAKU3ViamVjdDogW1BB VENIIDMvM10gUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA5NjQKW0d0a10gSW1wbGVtbWVudCBBdGtEb2N1bWVudAoK UHJvdmlkZXMgYWNjZXNzIHRvIHRoZSByZXBvcnRlZCBjb250ZW50IGxhbmd1YWdlLgoKKiBhY2Nl c3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHA6Cih3ZWJraXRf YWNjZXNzaWJsZV9kb2N1bWVudF9nZXRfbG9jYWxlKToKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTIgKysrKysrKysrKysrCiAuLi4v Z3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcCAgICAgICAgICB8ICAgIDggKysr KysrLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4 IGUxNGM5NGIuLjllOWY3YjYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dl YkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTAtMzEgIEpvYW5tYXJpZSBE aWdncyAgPGpvYW5tYXJpZS5kaWdnc0BnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTMwOTY0CisgICAgICAgIFtHdGtdIEltcGxlbW1lbnQgQXRrRG9jdW1lbnQKKwor ICAgICAgICBQcm92aWRlcyBhY2Nlc3MgdG8gdGhlIHJlcG9ydGVkIGNvbnRlbnQgbGFuZ3VhZ2Uu CisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBl ckF0ay5jcHA6CisgICAgICAgICh3ZWJraXRfYWNjZXNzaWJsZV9kb2N1bWVudF9nZXRfbG9jYWxl KToKKwogMjAwOS0xMC0zMCAgSm9hbm1hcmllIERpZ2dzICA8am9hbm1hcmllLmRpZ2dzQGdtYWls LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBh L1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJBdGsu Y3BwIGIvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBl ckF0ay5jcHAKaW5kZXggOTdkY2QwYi4uODBiNWEzZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9hY2Nl c3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHAKKysrIGIvV2Vi Q29yZS9hY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHAK QEAgLTE0NTIsOCArMTQ1MiwxMiBAQCBzdGF0aWMgQXRrQXR0cmlidXRlU2V0KiB3ZWJraXRfYWNj ZXNzaWJsZV9kb2N1bWVudF9nZXRfYXR0cmlidXRlcyhBdGtEb2N1bWVudCogZAogCiBzdGF0aWMg Y29uc3QgZ2NoYXIqIHdlYmtpdF9hY2Nlc3NpYmxlX2RvY3VtZW50X2dldF9sb2NhbGUoQXRrRG9j dW1lbnQqIGRvY3VtZW50KQogewotICAgIC8vIEZJWE1FOiBUaGlzIG5lZWRzIHRvIGJlIGltcGxl bWVudGVkLgotICAgIG5vdEltcGxlbWVudGVkKCk7CisKKyAgICAvLyBUT0RPOiBTaG91bGQgd2Ug ZmFsbCBiYWNrIG9uIGxhbmcgeG1sOmxhbmcgd2hlbiB0aGUgZm9sbG93aW5nIGNvbWVzIHVwIGVt cHR5PworICAgIFN0cmluZyBsYW5ndWFnZSA9IHN0YXRpY19jYXN0PEFjY2Vzc2liaWxpdHlSZW5k ZXJPYmplY3QqPihjb3JlKGRvY3VtZW50KSktPmxhbmd1YWdlKCk7CisgICAgaWYgKCFsYW5ndWFn ZS5pc0VtcHR5KCkpCisgICAgICAgIHJldHVybiByZXR1cm5TdHJpbmcobGFuZ3VhZ2UpOworCiAg ICAgcmV0dXJuIDA7CiB9CiAKLS0gCjEuNi4zLjMKCg==