30958 2009-10-30 11:28:39 -0700 Turn on warnings for QtWebKit for gcc 2010-07-29 09:14:11 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Linux RESOLVED FIXED Qt P2 Normal --- 1 laszlo.gombos webkit-unassigned abecsi commit-queue kenneth loki luiz ossy thiago.macieira tonikitoo oldest_to_newest 159378 0 laszlo.gombos 2009-10-30 11:28:39 -0700 As part of some previous work QtWebKit compilation warnings (for gcc) has been greatly reduced. It seems like a good time to turn on -Wall and some other compiler warnings for QtWebKit as well - as it is done for other ports. 159427 1 kenneth 2009-10-30 13:43:27 -0700 I agree! 159430 2 42231 laszlo.gombos 2009-10-30 13:49:12 -0700 Created attachment 42231 proposed patch 159472 3 42231 eric 2009-10-30 15:18:42 -0700 Comment on attachment 42231 proposed patch LGTM. 159653 4 42231 commit-queue 2009-11-01 12:49:14 -0800 Comment on attachment 42231 proposed patch Clearing flags on attachment: 42231 Committed r50392: <http://trac.webkit.org/changeset/50392> 159654 5 commit-queue 2009-11-01 12:49:21 -0800 All reviewed patches have been landed. Closing bug. 220064 6 thiago.macieira 2010-05-03 05:32:14 -0700 -Wcast-align needs to be removed. With GCC 4.4, these two warning crops up all the time on ARM: webkit/JavaScriptCore/wtf/Vector.h:484: warning: cast from 'WTF::AlignedBufferChar*' to '<insert type here>*' increases required alignment of target type webkit/JavaScriptCore/wtf/ListHashSet.h:174: warning: cast from 'char*' to 'WTF::ListHashSetNode<insert type here>*' increases required alignment of target type I know that WTF::Vector aligns by construction, but GCC doesn't know it. And there's no way to tell it. This option also triggers the warning in Qt code: src/corelib/kernel/qobject.h:453: warning: cast from 'QObject*' to 'const WebCore::GraphicsLayerQtImpl*' increases required alignment of target type src/corelib/tools/qmap.h:180: warning: cast from 'char*' to 'QMapNode<float, WebCore::KeyframeValueQt<WebCore::TransformOperations> >*' increases required alignment of target type In both cases the pointers are properly aligned for the type at hand. The one thing in common between these four places is the use of reinterpret_cast. 220079 7 laszlo.gombos 2010-05-03 06:38:55 -0700 (In reply to comment #6) > -Wcast-align needs to be removed. > > With GCC 4.4, these two warning crops up all the time on ARM: Thiago, these issues are being looked at bug 38045. Two good reason why we should continue having these warnings on the _trunk_ a./ Other WebKit ports have them enabled as well; some of the other ports are treat these warnings as errors. If we do not have them enabled building Qt port of WebKit will give no warning about a potential build break on other WebKit ports. b./ I think in long term we really want to fix these - and the best way to get attention is to have the warnings turned on. If these really can not be addresses, we might want to consider turning the warnings off just for ARM platforms. Also, it might make sense to turn the warnings of for production branches, but I think we should keep them on for the trunk. 255817 8 tonikitoo 2010-07-25 08:09:41 -0700 > ... some of the other ports are treat these warnings as errors. Should we consider that, as well? At least on trunk for i386? 257269 9 laszlo.gombos 2010-07-28 11:37:41 -0700 (In reply to comment #8) > > ... some of the other ports are treat these warnings as errors. > > Should we consider that, as well? At least on trunk for i386? My only concern would be the extra pressure to fix these warnings to keep the bot green. CCing Ossy to see what he think. A somewhat relaxed version of this - which I think we should do - is to start treating warnings as errors by default (at least on platforms where this is realistic like i386) but have a provision (e.g. environment variable) not to do this for the build bot. This will force most developers to look into the warning but does not put extra pressure on the bot. 42231 2009-10-30 13:49:12 -0700 2009-11-01 12:49:14 -0800 proposed patch 30958.patch text/plain 5584 laszlo.gombos SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDUwMzQ3 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMTAt MzAgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFR1cm4gb24gd2FybmluZ3Mg Zm9yIFF0V2ViS2l0IGZvciBnY2MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTMwOTU4CisKKyAgICAgICAgKiBXZWJLaXQucHJpOiBUdXJuIG9uIHdhcm5p bmdzIGZvciB0aGUgR0NDIGNvbXBpbGVyCisKIDIwMDktMTAtMzAgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJrIFJvd2UuCkluZGV4OiBX ZWJLaXQucHJpCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC5wcmkJKHJldmlzaW9uIDUwMzQ3KQorKysg V2ViS2l0LnByaQkod29ya2luZyBjb3B5KQpAQCAtNDcsOCArNDcsNyBAQCBCQVNFX0RJUiA9ICQk UFdECiBJTkNMVURFUEFUSCArPSAkJFBXRC9XZWJLaXQvcXQvQXBpCiAKIENPTkZJRyAtPSB3YXJu X29uCi0qLWcrKyo6UU1BS0VfQ1hYRkxBR1MgKz0gLVdyZXR1cm4tdHlwZSAtZm5vLXN0cmljdC1h bGlhc2luZwotI1FNQUtFX0NYWEZMQUdTICs9IC1XYWxsIC1Xbm8tdW5kZWYgLVduby11bnVzZWQt cGFyYW1ldGVyCisqLWcrKyo6UU1BS0VfQ1hYRkxBR1MgKz0gLVdhbGwgLVdyZXR1cm4tdHlwZSAt Zm5vLXN0cmljdC1hbGlhc2luZyAtV2Nhc3QtYWxpZ24gLVdjaGFyLXN1YnNjcmlwdHMgLVdmb3Jt YXQtc2VjdXJpdHkgLVdyZXR1cm4tdHlwZSAtV25vLXVudXNlZC1wYXJhbWV0ZXIgLVduby1zaWdu LWNvbXBhcmUgLVduby1zd2l0Y2ggLVduby1zd2l0Y2gtZW51bSAtV3VuZGVmIC1XbWlzc2luZy1u b3JldHVybiAtV2luaXQtc2VsZgogCiAjIEVuYWJsZSBHTlUgY29tcGlsZXIgZXh0ZW5zaW9ucyB0 byB0aGUgQVJNIGNvbXBpbGVyIGZvciBhbGwgUXQgcG9ydHMgdXNpbmcgUlZDVAogc3ltYmlhbnwq LWFybWNjIHsKSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv Q2hhbmdlTG9nCShyZXZpc2lvbiA1MDM0NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMTAtMzAgIExhc3psbyBHb21ib3MgIDxsYXN6 bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFR1cm4gb24gd2FybmluZ3MgZm9yIFF0V2ViS2l0IGZvciBnY2MKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwOTU4CisKKyAg ICAgICAgTm8gbmV3IHRlc3RzIGFzIHRoZXJlIGlzIG5vIGZ1bmN0aW9uYWwgY2hhbmdlLgorCisg ICAgICAgICogcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvcXQvUkdCQTMyQnVmZmVyUXQuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6UkdCQTMyQnVmZmVyOjpSR0JBMzJCdWZmZXIpOiBSZW9yZGVyIAor ICAgICAgICBpbml0aWFsaXphdGlvbiBsaXN0IHRvIGZpeCBjb21waWxlciB3YXJuaW5ncy4KKwor CiAyMDA5LTEwLTMwICBEbWl0cnkgVGl0b3YgIDxkaW1pY2hAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0v aW1hZ2UtZGVjb2RlcnMvcXQvUkdCQTMyQnVmZmVyUXQuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvcXQvUkdCQTMyQnVmZmVyUXQuY3BwCShyZXZpc2lv biA1MDM0NykKKysrIFdlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvcXQvUkdCQTMyQnVm ZmVyUXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNCw5ICszNCw5IEBACiBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAKIFJHQkEzMkJ1ZmZlcjo6UkdCQTMyQnVmZmVyKCkKLSAgICA6IG1fc3RhdHVzKEZy YW1lRW1wdHkpCi0gICAgLCBtX2hhc0FscGhhKGZhbHNlKQorICAgIDogbV9oYXNBbHBoYShmYWxz ZSkgCiAgICAgLCBtX3NpemUoKQorICAgICwgbV9zdGF0dXMoRnJhbWVFbXB0eSkKICAgICAsIG1f ZHVyYXRpb24oMCkKICAgICAsIG1fZGlzcG9zYWxNZXRob2QoRGlzcG9zZU5vdFNwZWNpZmllZCkK IHsKSW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0No YW5nZUxvZwkocmV2aXNpb24gNTAzNDcpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTAtMzAgIExhc3psbyBHb21ib3MgIDxsYXN6 bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFR1cm4gb24gd2FybmluZ3MgZm9yIFF0V2ViS2l0IGZvciBnY2MKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwOTU4CisKKyAg ICAgICAgKiBBcGkvcXdlYnBhZ2UuY3BwOgorICAgICAgICAoUVdlYlBhZ2VQcml2YXRlOjpRV2Vi UGFnZVByaXZhdGUpOiBSZW9yZGVyIGluaXRpYWxpemF0aW9uIGxpc3QgCisgICAgICAgIHRvIGZp eCBjb21waWxlciB3YXJuaW5ncy4KKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRl ckNsaWVudFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyQ2xpZW50UXQ6OkZy YW1lTG9hZGVyQ2xpZW50UXQpOiBEaXR0by4KKwogMjAwOS0xMC0zMCAgSm9jZWx5biBUdXJjb3R0 ZSAgPGpvY2VseW4udHVyY290dGVAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRv ciBBcm5lIFZlc3Riw7guCkluZGV4OiBXZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNwcAkocmV2aXNpb24gNTAzNDcpCisrKyBX ZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjY2LDExICsyNjYs MTEgQEAgUVdlYlBhZ2VQcml2YXRlOjpRV2ViUGFnZVByaXZhdGUoUVdlYlBhZwogI2lmIFFUX1ZF UlNJT04gPCAweDA0MDYwMAogICAgICwgdmlldygwKQogI2VuZGlmCisgICAgLCBjbGlja0NhdXNl ZEZvY3VzKGZhbHNlKQorICAgICwgdmlld3BvcnRTaXplKFFTaXplKDAsIDApKQogICAgICwgaW5z cGVjdG9yRnJvbnRlbmQoMCkKICAgICAsIGluc3BlY3RvcigwKQogICAgICwgaW5zcGVjdG9ySXNJ bnRlcm5hbE9ubHkoZmFsc2UpCi0gICAgLCB2aWV3cG9ydFNpemUoUVNpemUoMCwgMCkpCi0gICAg LCBjbGlja0NhdXNlZEZvY3VzKGZhbHNlKQogewogICAgIFdlYkNvcmU6OkluaXRpYWxpemVMb2dn aW5nQ2hhbm5lbHNJZk5lY2Vzc2FyeSgpOwogICAgIEpTQzo6aW5pdGlhbGl6ZVRocmVhZGluZygp OwpJbmRleDogV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50UXQuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVu dFF0LmNwcAkocmV2aXNpb24gNTAzNDcpCisrKyBXZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRnJh bWVMb2FkZXJDbGllbnRRdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0NSw5ICsxNDUsOSBAQCBu YW1lc3BhY2UgV2ViQ29yZQogRnJhbWVMb2FkZXJDbGllbnRRdDo6RnJhbWVMb2FkZXJDbGllbnRR dCgpCiAgICAgOiBtX2ZyYW1lKDApCiAgICAgLCBtX3dlYkZyYW1lKDApCisgICAgLCBtX2ZpcnN0 RGF0YShmYWxzZSkKICAgICAsIG1fcGx1Z2luVmlldygwKQogICAgICwgbV9oYXNTZW50UmVzcG9u c2VUb1BsdWdpbihmYWxzZSkKLSAgICAsIG1fZmlyc3REYXRhKGZhbHNlKQogICAgICwgbV9sb2Fk RXJyb3IgKFJlc291cmNlRXJyb3IoKSkKIHsKIH0KSW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxv Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9DaGFuZ2VMb2cJKHJldmlzaW9uIDUwMzQ3KQor KysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAK KzIwMDktMTAtMzAgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFR1cm4gb24g d2FybmluZ3MgZm9yIFF0V2ViS2l0IGZvciBnY2MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTMwOTU4CisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9x dC9tYWluLmNwcDogCisgICAgICAgIChjcmFzaEhhbmRsZXIpOiBNYXJrIGZ1bmN0aW9uIE5PX1JF VFVSTgorCiAyMDA5LTEwLTMwICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJLaXRUb29scy9EdW1wUmVu ZGVyVHJlZS9xdC9tYWluLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9EdW1wUmVuZGVy VHJlZS9xdC9tYWluLmNwcAkocmV2aXNpb24gNTAzNDcpCisrKyBXZWJLaXRUb29scy9EdW1wUmVu ZGVyVHJlZS9xdC9tYWluLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjksNiArMjksOCBAQAogCiAj aW5jbHVkZSAiRHVtcFJlbmRlclRyZWUuaCIKIAorI2luY2x1ZGUgPHd0Zi9BbHdheXNJbmxpbmUu aD4KKwogI2luY2x1ZGUgPHFzdHJpbmdsaXN0Lmg+CiAjaW5jbHVkZSA8cWFwcGxpY2F0aW9uLmg+ CiAjaW5jbHVkZSA8cXVybC5oPgpAQCAtODYsNyArODgsNyBAQCBRU3RyaW5nIGdldF9iYWNrdHJh Y2UoKSB7CiAgICAgcmV0dXJuIHM7CiB9CiAKLXN0YXRpYyB2b2lkIGNyYXNoSGFuZGxlcihpbnQg c2lnKQorc3RhdGljIE5PX1JFVFVSTiB2b2lkIGNyYXNoSGFuZGxlcihpbnQgc2lnKQogewogICAg IGZwcmludGYoc3RkZXJyLCAiJXNcbiIsIHN0cnNpZ25hbChzaWcpKTsKICAgICBmcHJpbnRmKHN0 ZGVyciwgIiVzXG4iLCBnZXRfYmFja3RyYWNlKCkudG9MYXRpbjEoKS5jb25zdERhdGEoKSk7Cg==