30952 2009-10-30 01:38:50 -0700 Patch v1 is a dumb default name for patches 2009-10-30 13:07:10 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned commit-queue ddkilzer eric oldest_to_newest 159257 0 abarth 2009-10-30 01:38:50 -0700 Patch forthcoming. 159259 1 42191 abarth 2009-10-30 01:40:37 -0700 Created attachment 42191 Patch 159283 2 ddkilzer 2009-10-30 03:03:34 -0700 Why is it dumb? The idea was that bugzilla-tool would increment the "v1" to "v2", "v3", etc. as additional patches were attached. This naming also assumes that the first patch isn't always accepted when reviewed and that further patches would be posted. 159370 3 42191 abarth 2009-10-30 11:07:45 -0700 Comment on attachment 42191 Patch It might make sense to add back the v1 part once we get the version incrementing to work. As it stands, it looks silly to have several patches uploaded to a bug all labeled "v1". 159373 4 42191 commit-queue 2009-10-30 11:19:39 -0700 Comment on attachment 42191 Patch Clearing flags on attachment: 42191 Committed r50346: <http://trac.webkit.org/changeset/50346> 159374 5 commit-queue 2009-10-30 11:19:43 -0700 All reviewed patches have been landed. Closing bug. 159414 6 ddkilzer 2009-10-30 13:07:10 -0700 (In reply to comment #3) > (From update of attachment 42191 [details]) > It might make sense to add back the v1 part once we get the version > incrementing to work. As it stands, it looks silly to have several patches > uploaded to a bug all labeled "v1". Having several patches all labeled "Patch" is equally as lame as having them all labeled "Patch v1". I would have rather seen you implement that feature rather than back out this change, but whatever. 42191 2009-10-30 01:40:37 -0700 2009-10-30 11:19:39 -0700 Patch bug-30952-20091030014035.patch text/plain 2916 abarth PyAgICAgICBodWJidWIucGF0Y2gKPyAgICAgICB0dHQKPyAgICAgICBXZWJLaXQvd2luL1dlYlZp ZXcuY3BwLm9yaWcKPyAgICAgICBXZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbS5vcmlnCj8g ICAgICAgV2ViQ29yZS9XZWJDb3JlLmd5cGkub3JpZwo/ICAgICAgIFdlYkNvcmUvR05VbWFrZWZp bGUuYW0ub3JpZwo/ICAgICAgIFdlYkNvcmUvcGFnZS9QYWdlLmNwcC5vcmlnCj8gICAgICAgV2Vi Q29yZS9XZWJDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oub3JpZwpJbmRleDogV2ViS2l0 VG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL0NoYW5nZUxvZwkocmV2 aXNpb24gNTAzMjMpCisrKyBXZWJLaXRUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAg LTEsMyArMSwxNCBAQAorMjAwOS0xMC0zMCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBhdGNo IHYxIGlzIGEgZHVtYiBkZWZhdWx0IG5hbWUgZm9yIHBhdGNoZXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwOTUyCisKKyAgICAgICAgTGV0J3MgdXNl ICJQYXRjaCIgaW5zdGVhZC4KKworICAgICAgICAqIFNjcmlwdHMvYnVnemlsbGEtdG9vbDoKKwog MjAwOS0xMC0zMCAgUm9sYW5kIFN0ZWluZXIgIDxyb2xhbmRzdGVpbmVyQGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IFdlYktpdFRvb2xzL1Nj cmlwdHMvYnVnemlsbGEtdG9vbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL2J1 Z3ppbGxhLXRvb2wJKHJldmlzaW9uIDUwMzIzKQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy9idWd6 aWxsYS10b29sCSh3b3JraW5nIGNvcHkpCkBAIC00NDgsNyArNDQ4LDcgQEAgY2xhc3MgUG9zdERp ZmZBc1BhdGNoVG9CdWcoQ29tbWFuZCk6CiAgICAgICAgIGRpZmYgPSB0b29sLnNjbSgpLmNyZWF0 ZV9wYXRjaCgpCiAgICAgICAgIGRpZmZfZmlsZSA9IFN0cmluZ0lPLlN0cmluZ0lPKGRpZmYpICMg YWRkX3BhdGNoX3RvX2J1ZyBleHBlY3RzIGEgZmlsZS1saWtlIG9iamVjdAogCi0gICAgICAgIGRl c2NyaXB0aW9uID0gb3B0aW9ucy5kZXNjcmlwdGlvbiBvciAiUGF0Y2ggdjEiCisgICAgICAgIGRl c2NyaXB0aW9uID0gb3B0aW9ucy5kZXNjcmlwdGlvbiBvciAiUGF0Y2giCiAgICAgICAgIHRvb2wu YnVncy5hZGRfcGF0Y2hfdG9fYnVnKGJ1Z19pZCwgZGlmZl9maWxlLCBkZXNjcmlwdGlvbiwgbWFy a19mb3JfcmV2aWV3PW9wdGlvbnMucmV2aWV3LCBtYXJrX2Zvcl9jb21taXRfcXVldWU9b3B0aW9u cy5yZXF1ZXN0X2NvbW1pdCkKIAogCkBAIC01OTAsNyArNTkwLDcgQEAgY2xhc3MgQ3JlYXRlQnVn KENvbW1hbmQpOgogCiAgICAgICAgIGRpZmYgPSB0b29sLnNjbSgpLmNyZWF0ZV9wYXRjaF9mcm9t X2xvY2FsX2NvbW1pdChjb21taXRfaWQpCiAgICAgICAgIGRpZmZfZmlsZSA9IFN0cmluZ0lPLlN0 cmluZ0lPKGRpZmYpICMgY3JlYXRlX2J1Z193aXRoX3BhdGNoIGV4cGVjdHMgYSBmaWxlLWxpa2Ug b2JqZWN0Ci0gICAgICAgIGJ1Z19pZCA9IHRvb2wuYnVncy5jcmVhdGVfYnVnX3dpdGhfcGF0Y2go YnVnX3RpdGxlLCBjb21tZW50X3RleHQsIG9wdGlvbnMuY29tcG9uZW50LCBkaWZmX2ZpbGUsICJQ YXRjaCB2MSIsIGNjPW9wdGlvbnMuY2MsIG1hcmtfZm9yX3Jldmlldz1vcHRpb25zLnJldmlldywg bWFya19mb3JfY29tbWl0X3F1ZXVlPW9wdGlvbnMucmVxdWVzdF9jb21taXQpCisgICAgICAgIGJ1 Z19pZCA9IHRvb2wuYnVncy5jcmVhdGVfYnVnX3dpdGhfcGF0Y2goYnVnX3RpdGxlLCBjb21tZW50 X3RleHQsIG9wdGlvbnMuY29tcG9uZW50LCBkaWZmX2ZpbGUsICJQYXRjaCIsIGNjPW9wdGlvbnMu Y2MsIG1hcmtfZm9yX3Jldmlldz1vcHRpb25zLnJldmlldywgbWFya19mb3JfY29tbWl0X3F1ZXVl PW9wdGlvbnMucmVxdWVzdF9jb21taXQpCiAKICAgICAgICAgaWYgYnVnX2lkIGFuZCBsZW4oY29t bWl0X2lkcykgPiAxOgogICAgICAgICAgICAgb3B0aW9ucy5idWdfaWQgPSBidWdfaWQKQEAgLTYx MCw3ICs2MTAsNyBAQCBjbGFzcyBDcmVhdGVCdWcoQ29tbWFuZCk6CiAKICAgICAgICAgZGlmZiA9 IHRvb2wuc2NtKCkuY3JlYXRlX3BhdGNoKCkKICAgICAgICAgZGlmZl9maWxlID0gU3RyaW5nSU8u U3RyaW5nSU8oZGlmZikgIyBjcmVhdGVfYnVnX3dpdGhfcGF0Y2ggZXhwZWN0cyBhIGZpbGUtbGlr ZSBvYmplY3QKLSAgICAgICAgYnVnX2lkID0gdG9vbC5idWdzLmNyZWF0ZV9idWdfd2l0aF9wYXRj aChidWdfdGl0bGUsIGNvbW1lbnRfdGV4dCwgb3B0aW9ucy5jb21wb25lbnQsIGRpZmZfZmlsZSwg IlBhdGNoIHYxIiwgY2M9b3B0aW9ucy5jYywgbWFya19mb3JfcmV2aWV3PW9wdGlvbnMucmV2aWV3 LCBtYXJrX2Zvcl9jb21taXRfcXVldWU9b3B0aW9ucy5yZXF1ZXN0X2NvbW1pdCkKKyAgICAgICAg YnVnX2lkID0gdG9vbC5idWdzLmNyZWF0ZV9idWdfd2l0aF9wYXRjaChidWdfdGl0bGUsIGNvbW1l bnRfdGV4dCwgb3B0aW9ucy5jb21wb25lbnQsIGRpZmZfZmlsZSwgIlBhdGNoIiwgY2M9b3B0aW9u cy5jYywgbWFya19mb3JfcmV2aWV3PW9wdGlvbnMucmV2aWV3LCBtYXJrX2Zvcl9jb21taXRfcXVl dWU9b3B0aW9ucy5yZXF1ZXN0X2NvbW1pdCkKIAogICAgIGRlZiBwcm9tcHRfZm9yX2J1Z190aXRs ZV9hbmRfY29tbWVudChzZWxmKToKICAgICAgICAgYnVnX3RpdGxlID0gcmF3X2lucHV0KCJCdWcg dGl0bGU6ICIp