30948 2009-10-30 00:54:19 -0700 Regression: crash enumerating properties of an object with getters or setters 2009-10-30 02:15:09 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 oliver webkit-unassigned oldest_to_newest 159237 0 oliver 2009-10-30 00:54:19 -0700 Code inspection showed that enumeration caching doesn't account for the existence of getters or setters. 159243 1 42180 oliver 2009-10-30 01:03:35 -0700 Created attachment 42180 Patch v1 159245 2 42180 barraclough 2009-10-30 01:10:36 -0700 Comment on attachment 42180 Patch v1 In the über-big if statement, I have a feeling we usually put the && on the continuing line. Also, might be nicer with one line per clause. Still, r+ with or without that change. 159248 3 oliver 2009-10-30 01:13:54 -0700 Committed r50323 159267 4 oliver 2009-10-30 02:15:09 -0700 Committed r50323 42180 2009-10-30 01:03:35 -0700 2009-10-30 01:10:35 -0700 Patch v1 bug-30948-20091030010334.patch text/plain 3924 oliver ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBhMGU0OTU1Li5jMDA1ZDFkIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMDktMTAtMzAgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZWdyZXNzaW9uOiBjcmFz aCBlbnVtZXJhdGluZyBwcm9wZXJ0aWVzIG9mIGFuIG9iamVjdCB3aXRoIGdldHRlcnMgb3Igc2V0 dGVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA5 NDgKKworICAgICAgICBBZGQgYSBndWFyZCB0byBwcmV2ZW50IHVzIHRyeWluZyB0byBjYWNoZSBw cm9wZXJ0eSBlbnVtZXJhdGlvbiBvbgorICAgICAgICBvYmplY3RzIHdpdGggZ2V0dGVycyBvciBz ZXR0ZXJzLgorCisgICAgICAgICogcnVudGltZS9KU1Byb3BlcnR5TmFtZUl0ZXJhdG9yLmNwcDoK KyAgICAgICAgKEpTQzo6SlNQcm9wZXJ0eU5hbWVJdGVyYXRvcjo6Y3JlYXRlKToKKwogMjAwOS0x MC0yOSAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IE1hY2llaiBTdGFjaG93aWFrLgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9KU1Byb3BlcnR5TmFtZUl0ZXJhdG9yLmNwcCBiL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNQ cm9wZXJ0eU5hbWVJdGVyYXRvci5jcHAKaW5kZXggNmZkMDM0NC4uZTIwMDg3ZiAxMDA2NDQKLS0t IGEvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1Byb3BlcnR5TmFtZUl0ZXJhdG9yLmNwcAorKysg Yi9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTUHJvcGVydHlOYW1lSXRlcmF0b3IuY3BwCkBAIC00 NSw3ICs0NSw4IEBAIEpTUHJvcGVydHlOYW1lSXRlcmF0b3IqIEpTUHJvcGVydHlOYW1lSXRlcmF0 b3I6OmNyZWF0ZShFeGVjU3RhdGUqIGV4ZWMsIEpTT2JqZWN0CiAgICAgby0+Z2V0UHJvcGVydHlO YW1lcyhleGVjLCBwcm9wZXJ0eU5hbWVzKTsKICAgICBzaXplX3QgbnVtQ2FjaGVhYmxlU2xvdHMg PSAwOwogICAgIGlmICghby0+c3RydWN0dXJlKCktPmhhc05vbkVudW1lcmFibGVQcm9wZXJ0aWVz KCkgJiYgIW8tPnN0cnVjdHVyZSgpLT5oYXNBbm9ueW1vdXNTbG90cygpICYmCi0gICAgICAgICFv LT5zdHJ1Y3R1cmUoKS0+aXNVbmNhY2hlYWJsZURpY3Rpb25hcnkoKSAmJiAhby0+c3RydWN0dXJl KCktPnR5cGVJbmZvKCkub3ZlcnJpZGVzR2V0UHJvcGVydHlOYW1lcygpKQorICAgICAgICAhby0+ c3RydWN0dXJlKCktPmhhc0dldHRlclNldHRlclByb3BlcnRpZXMoKSAmJiAhby0+c3RydWN0dXJl KCktPmlzVW5jYWNoZWFibGVEaWN0aW9uYXJ5KCkgJiYKKyAgICAgICAgIW8tPnN0cnVjdHVyZSgp LT50eXBlSW5mbygpLm92ZXJyaWRlc0dldFByb3BlcnR5TmFtZXMoKSkKICAgICAgICAgbnVtQ2Fj aGVhYmxlU2xvdHMgPSBvLT5zdHJ1Y3R1cmUoKS0+cHJvcGVydHlTdG9yYWdlU2l6ZSgpOwogCiAg ICAgSlNQcm9wZXJ0eU5hbWVJdGVyYXRvcioganNQcm9wZXJ0eU5hbWVJdGVyYXRvciA9IG5ldyAo ZXhlYykgSlNQcm9wZXJ0eU5hbWVJdGVyYXRvcihleGVjLCBwcm9wZXJ0eU5hbWVzLmRhdGEoKSwg bnVtQ2FjaGVhYmxlU2xvdHMpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDNhZWMwMjcuLjUzMzY2YzEgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAwOS0xMC0zMCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlZ3Jlc3Np b246IGNyYXNoIGVudW1lcmF0aW5nIHByb3BlcnRpZXMgb2YgYW4gb2JqZWN0IHdpdGggZ2V0dGVy cyBvciBzZXR0ZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zMDk0OAorCisgICAgICAgIEFkZCB0ZXN0IGZvciBlbnVtZXJhdGluZyBnZXR0ZXJzIGFu ZCBzZXR0ZXJzLgorCisgICAgICAgICogZmFzdC9qcy9mb3ItaW4tY2FjaGVkLWV4cGVjdGVkLnR4 dDoKKyAgICAgICAgKiBmYXN0L2pzL3NjcmlwdC10ZXN0cy9mb3ItaW4tY2FjaGVkLmpzOgorICAg ICAgICAoZm9ySW41KToKKwogMjAwOS0xMC0yOSAgRXJpayBBcnZpZHNzb24gIDxhcnZAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvZmFzdC9qcy9mb3ItaW4tY2FjaGVkLWV4cGVjdGVkLnR4dCBiL0xheW91dFRl c3RzL2Zhc3QvanMvZm9yLWluLWNhY2hlZC1leHBlY3RlZC50eHQKaW5kZXggZjcyMjc1MS4uYmFm MGU4MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9qcy9mb3ItaW4tY2FjaGVkLWV4cGVj dGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2pzL2Zvci1pbi1jYWNoZWQtZXhwZWN0ZWQu dHh0CkBAIC0xMCw2ICsxMCw5IEBAIFBBU1MgZm9ySW4zKHsgeTIgOiAyLCBfX3Byb3RvX186IG51 bGwgfSkgaXMgWyd4JywgJ3kyJ10KIFBBU1MgZm9ySW4zKHsgX19wcm90b19fOiB7IF9fcHJvdG9f XzogeyB5MyA6IDIgfSB9IH0pIGlzIFsneCcsICd5MyddCiBQQVNTIGZvckluNChvYmplY3RXaXRo QXJyYXlBc1Byb3RvKSBpcyBbXQogUEFTUyBmb3JJbjQob2JqZWN0V2l0aEFycmF5QXNQcm90bykg aXMgWycwJ10KK1BBU1MgZm9ySW41KHtnZXQgZm9vKCkgeyByZXR1cm4gJ2NhbGxlZCBnZXR0ZXIn fSB9KSBpcyBbJ2ZvbycsICdjYWxsZWQgZ2V0dGVyJ10KK1BBU1MgZm9ySW41KHtzZXQgZm9vKCkg eyB9IH0pIGlzIFsnZm9vJywgdW5kZWZpbmVkXQorUEFTUyBmb3JJbjUoe2dldCBmb28oKSB7IHJl dHVybiAnY2FsbGVkIGdldHRlcid9LCBzZXQgZm9vKCkgeyB9fSkgaXMgWydmb28nLCAnY2FsbGVk IGdldHRlciddCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExF VEUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvanMvc2NyaXB0LXRlc3RzL2Zvci1pbi1j YWNoZWQuanMgYi9MYXlvdXRUZXN0cy9mYXN0L2pzL3NjcmlwdC10ZXN0cy9mb3ItaW4tY2FjaGVk LmpzCmluZGV4IDI1OGIyNGQuLmM4NmQ2MmMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3Qv anMvc2NyaXB0LXRlc3RzL2Zvci1pbi1jYWNoZWQuanMKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9q cy9zY3JpcHQtdGVzdHMvZm9yLWluLWNhY2hlZC5qcwpAQCAtNTUsNCArNTUsMTQgQEAgc2hvdWxk QmUoImZvckluNChvYmplY3RXaXRoQXJyYXlBc1Byb3RvKSIsICJbXSIpOwogb2JqZWN0V2l0aEFy cmF5QXNQcm90by5fX3Byb3RvX19bMF09MTsKIHNob3VsZEJlKCJmb3JJbjQob2JqZWN0V2l0aEFy cmF5QXNQcm90bykiLCAiWycwJ10iKTsKIAorZnVuY3Rpb24gZm9ySW41KG8pIHsKKyAgICBmb3Ig KHZhciBpIGluIG8pCisgICAgICAgIHJldHVybiBbaSwgb1tpXV07Cit9CisKK3Nob3VsZEJlKCJm b3JJbjUoe2dldCBmb28oKSB7IHJldHVybiAnY2FsbGVkIGdldHRlcid9IH0pIiwgIlsnZm9vJywg J2NhbGxlZCBnZXR0ZXInXSIpOworc2hvdWxkQmUoImZvckluNSh7c2V0IGZvbygpIHsgfSB9KSIs ICJbJ2ZvbycsIHVuZGVmaW5lZF0iKTsKK3Nob3VsZEJlKCJmb3JJbjUoe2dldCBmb28oKSB7IHJl dHVybiAnY2FsbGVkIGdldHRlcid9LCBzZXQgZm9vKCkgeyB9fSkiLCAiWydmb28nLCAnY2FsbGVk IGdldHRlciddIik7CisKKwogdmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7