30944 2009-10-29 19:30:50 -0700 [Crash (debug)] Combination of list-item and :after causes assertion failure 2009-11-01 08:03:41 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 yutak webkit-unassigned commit-queue oldest_to_newest 159191 0 yutak 2009-10-29 19:30:50 -0700 Steps to reproduce: 1. Open the attached HTML using debug version of WebKit. 2. Move your mouse pointer to the text. 3. Observe the browser is crashing with the following message: ASSERTION FAILED: genChild->style()->styleType() == FIRST_LETTER (/Users/yutak/WebKit/WebCore/rendering/RenderObjectChildList.cpp:374 void WebCore::RenderObjectChildList::updateBeforeAfterContent(WebCore::RenderObject*, WebCore::PseudoId, WebCore::RenderObject*)) This is derived from a Chromium bug: http://crbug.com/20686 159193 1 42171 yutak 2009-10-29 19:31:31 -0700 Created attachment 42171 Test case 159290 2 42204 yutak 2009-10-30 04:09:16 -0700 Created attachment 42204 Fix assertion falure in RenderObjectChildList::updateBeforeAfterContent(). 159291 3 42205 yutak 2009-10-30 04:12:34 -0700 Created attachment 42205 Fix assertion falure in RenderObjectChildList::updateBeforeAfterContent(). 159357 4 42205 darin 2009-10-30 10:41:25 -0700 Comment on attachment 42205 Fix assertion falure in RenderObjectChildList::updateBeforeAfterContent(). For an assertion-only change, I don't think a test case is required. The test says "passes if it does not crash", but that's misleading. This only ever asserted, it wouldn't crash in a non-debug build. r=me 159479 5 42205 eric 2009-10-30 15:25:34 -0700 Comment on attachment 42205 Fix assertion falure in RenderObjectChildList::updateBeforeAfterContent(). LGTM too. Adding to the commit-queue. 159635 6 42205 commit-queue 2009-11-01 08:03:36 -0800 Comment on attachment 42205 Fix assertion falure in RenderObjectChildList::updateBeforeAfterContent(). Clearing flags on attachment: 42205 Committed r50386: <http://trac.webkit.org/changeset/50386> 159636 7 commit-queue 2009-11-01 08:03:41 -0800 All reviewed patches have been landed. Closing bug. 42171 2009-10-29 19:31:31 -0700 2009-10-29 19:31:31 -0700 Test case 20686.html text/html 374 yutak PCFET0NUWVBFIGh0bWw+DQo8aHRtbD4NCiAgPGhlYWQ+DQogICAgPHRpdGxlPkhpdHRpbmcgQXNz ZXJ0aW9uPC90aXRsZT4NCiAgICA8c3R5bGUgdHlwZT0idGV4dC9jc3MiPg0KYSB7DQogIGRpc3Bs YXk6IGJsb2NrOw0KfQ0KDQphOmhvdmVyIHsNCn0NCg0KYTphZnRlciB7DQogIGNvbnRlbnQ6ICIu IjsNCiAgZGlzcGxheTogYmxvY2s7DQp9DQoNCnNwYW4gew0KICBmbG9hdDogbGVmdDsNCn0NCiAg ICA8L3N0eWxlPg0KICA8L2hlYWQ+DQogIDxib2R5Pg0KICAgIDx1bD4NCiAgICAgIDxsaT4NCiAg ICAgICAgPGEgaHJlZj0iIyI+PHNwYW4+SG92ZXIgbWU8L3NwYW4+PC9hPg0KICAgICAgPC9saT4N CiAgICA8L3VsPg0KICA8L2JvZHk+DQo8L2h0bWw+DQo= 42204 2009-10-30 04:09:16 -0700 2009-10-30 04:12:28 -0700 Fix assertion falure in RenderObjectChildList::updateBeforeAfterContent(). bug-30944-20091030200914.patch text/plain 4607 yutak ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwY2JkNTRjLi5kNTAxZTkyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTAt MzAgIFl1dGEgS2l0YW11cmEgIDx5dXRha0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGFzc2VydGlvbiBmYWx1cmUgaW4g UmVuZGVyT2JqZWN0Q2hpbGRMaXN0Ojp1cGRhdGVCZWZvcmVBZnRlckNvbnRlbnQoKS4KKworICAg ICAgICBbQ3Jhc2ggKGRlYnVnKV0gQ29tYmluYXRpb24gb2YgbGlzdC1pdGVtIGFuZCA6YWZ0ZXIg Y2F1c2VzIGFzc2VydGlvbiBmYWlsdXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zMDk0NAorCisgICAgICAgICogZmFzdC9jc3MvbGlzdC1pdGVtLXBz ZXVkby1ub2NyYXNoLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9jc3MvbGlz dC1pdGVtLXBzZXVkby1ub2NyYXNoLmh0bWw6IEFkZGVkLgorCiAyMDA5LTEwLTI5ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgVXBkYXRlZCBUaWdlci1zcGVjaWZp YyByZXN1bHQgbm93IHRoYXQgVGlnZXIgbWF0Y2hlcyBjdXJyZW50IGJlaGF2aW9yLiBBIFRpZ2Vy LXNwZWNpZmljCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9saXN0LWl0ZW0tcHNl dWRvLW5vY3Jhc2gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvbGlzdC1pdGVt LXBzZXVkby1ub2NyYXNoLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwLi4wMWEzMWMyCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3Mv bGlzdC1pdGVtLXBzZXVkby1ub2NyYXNoLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDMgQEAKK1Ro aXMgaXMgYSB0ZXN0IGZvciBidWcgMzA5NDQuIFBhc3NlcyBpZiBpdCBkb2VzIG5vdCBjcmFzaC4K KworSG92ZXIgbWUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL2xpc3QtaXRlbS1w c2V1ZG8tbm9jcmFzaC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvbGlzdC1pdGVtLXBzZXVk by1ub2NyYXNoLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMDdiNjA1 ZgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2xpc3QtaXRlbS1wc2V1 ZG8tbm9jcmFzaC5odG1sCkBAIC0wLDAgKzEsNTIgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+ CisgICAgPGhlYWQ+CisgICAgICAgIDx0aXRsZT5MaXN0LWl0ZW0gKyA6YWZ0ZXIgcHNldWRvLWNs YXNzPC90aXRsZT4KKyAgICAgICAgPHN0eWxlIHR5cGU9InRleHQvY3NzIj4KKyNhbmNob3Igewor ICAgIGRpc3BsYXk6IGJsb2NrOworfQorI2FuY2hvcjpob3ZlciB7fQorI2FuY2hvcjphZnRlciB7 CisgICAgY29udGVudDogIi4iOworICAgIGRpc3BsYXk6IGJsb2NrOworfQorc3BhbiB7CisgICAg ZmxvYXQ6IGxlZnQ7Cit9CisgICAgICAgIDwvc3R5bGU+CisgICAgICAgIDxzY3JpcHQgdHlwZT0i YXBwbGljYXRpb24vamF2YXNjcmlwdCI+CitmdW5jdGlvbiBydW4oKSB7CisgICAgaWYgKCF3aW5k b3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgIHJldHVybjsKKworICAgIHdpbmRvdy5s YXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgd2luZG93LmxheW91dFRlc3RD b250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKKyAgICB3aW5kb3cuZXZlbnRTZW5kZXIubW91c2VN b3ZlVG8oMCwgMCk7CisgICAgd2luZG93LnNldFRpbWVvdXQoaG92ZXIsIDEwMCk7Cit9CisKK2Z1 bmN0aW9uIGhvdmVyKCkgeworICAgIHZhciBlbGVtZW50ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoJ3RleHQnKTsKKyAgICB2YXIgeCA9IGVsZW1lbnQub2Zmc2V0TGVmdCArIGVsZW1lbnQub2Zm c2V0V2lkdGggLyAyOworICAgIHZhciB5ID0gZWxlbWVudC5vZmZzZXRUb3AgKyBlbGVtZW50Lm9m ZnNldEhlaWdodCAvIDI7CisgICAgd2luZG93LmV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKHgsIHkp OworICAgIHdpbmRvdy5zZXRUaW1lb3V0KGZpbmFsaXplLCAxMDApOworfQorCitmdW5jdGlvbiBm aW5hbGl6ZSgpIHsKKyAgICB3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgp OworfQorCit3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcignbG9hZCcsIHJ1biwgZmFsc2UpOworCTwv c2NyaXB0PgorICAgIDwvaGVhZD4KKyAgICA8Ym9keT4KKyAgICAgICAgPHA+VGhpcyBpcyBhIHRl c3QgZm9yIDxhIGhyZWY9Imh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z MDk0NCI+YnVnIDMwOTQ0PC9hPi4gUGFzc2VzIGlmIGl0IGRvZXMgbm90IGNyYXNoLjwvcD4KKyAg ICAgICAgPHVsPgorICAgICAgICAgICAgPGxpPgorICAgICAgICAgICAgICAgIDxhIGlkPSJhbmNo b3IiIGhyZWY9IiMiPjxzcGFuIGlkPSJ0ZXh0Ij5Ib3ZlciBtZTwvc3Bhbj48L2E+CisgICAgICAg ICAgICA8L2xpPgorICAgICAgICA8L3VsPgorICAgIDwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdp dCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmY5MTBjMy4u OTRiYTIwNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0xMC0zMCAgWXV0YSBLaXRhbXVyYSAgPHl1dGFr QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBGaXggYXNzZXJ0aW9uIGZhbHVyZSBpbiBSZW5kZXJPYmplY3RDaGlsZExpc3Q6OnVw ZGF0ZUJlZm9yZUFmdGVyQ29udGVudCgpLgorCisgICAgICAgIFtDcmFzaCAoZGVidWcpXSBDb21i aW5hdGlvbiBvZiBsaXN0LWl0ZW0gYW5kIDphZnRlciBjYXVzZXMgYXNzZXJ0aW9uIGZhaWx1cmUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwOTQ0CisK KyAgICAgICAgVGVzdDogZmFzdC9jc3MvbGlzdC1pdGVtLXBzZXVkby1ub2NyYXNoLmh0bWwKKwor ICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJPYmplY3RDaGlsZExpc3QuY3BwOgorICAgICAgICAo V2ViQ29yZTo6UmVuZGVyT2JqZWN0Q2hpbGRMaXN0Ojp1cGRhdGVCZWZvcmVBZnRlckNvbnRlbnQp OgorCiAyMDA5LTEwLTI5ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlck9iamVjdENoaWxkTGlzdC5jcHAgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmpl Y3RDaGlsZExpc3QuY3BwCmluZGV4IDIzYWI5OGYuLmZhMTk1NDcgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdENoaWxkTGlzdC5jcHAKKysrIGIvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyT2JqZWN0Q2hpbGRMaXN0LmNwcApAQCAtMzY5LDkgKzM2OSwxMSBAQCB2b2lk IFJlbmRlck9iamVjdENoaWxkTGlzdDo6dXBkYXRlQmVmb3JlQWZ0ZXJDb250ZW50KFJlbmRlck9i amVjdCogb3duZXIsIFBzZXVkbwogICAgICAgICAgICAgICAgICAgICBSZWZQdHI8UmVuZGVyU3R5 bGU+IHN0eWxlID0gUmVuZGVyU3R5bGU6OmNyZWF0ZSgpOwogICAgICAgICAgICAgICAgICAgICBz dHlsZS0+aW5oZXJpdEZyb20ocHNldWRvRWxlbWVudFN0eWxlKTsKICAgICAgICAgICAgICAgICAg ICAgZ2VuQ2hpbGQtPnNldFN0eWxlKHN0eWxlLnJlbGVhc2UoKSk7Ci0gICAgICAgICAgICAgICAg fSBlbHNlCi0gICAgICAgICAgICAgICAgICAgIC8vIE11c3QgYmUgYSBmaXJzdC1sZXR0ZXIgY29u dGFpbmVyLiB1cGRhdGVGaXJzdExldHRlcigpIHdpbGwgdGFrZSBjYXJlIG9mIGl0LgotICAgICAg ICAgICAgICAgICAgICBBU1NFUlQoZ2VuQ2hpbGQtPnN0eWxlKCktPnN0eWxlVHlwZSgpID09IEZJ UlNUX0xFVFRFUik7CisgICAgICAgICAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgICAgICAg ICAgLy8gUmVuZGVyTGlzdEl0ZW0gbWF5IGluc2VydCBhIGxpc3QgbWFya2VyIGhlcmUuIFdlIGRv IG5vdCBuZWVkIHRvIGNhcmUgYWJvdXQgdGhpcyBjYXNlLgorICAgICAgICAgICAgICAgICAgICAv LyBPdGhlcndpc2UsIGdlbkNoaWxkIG11c3QgYmUgYSBmaXJzdC1sZXR0ZXIgY29udGFpbmVyLiB1 cGRhdGVGaXJzdExldHRlcigpIHdpbGwgdGFrZSBjYXJlIG9mIGl0LgorICAgICAgICAgICAgICAg ICAgICBBU1NFUlQoZ2VuQ2hpbGQtPmlzTGlzdE1hcmtlcigpIHx8IGdlbkNoaWxkLT5zdHlsZSgp LT5zdHlsZVR5cGUoKSA9PSBGSVJTVF9MRVRURVIpOworICAgICAgICAgICAgICAgIH0KICAgICAg ICAgICAgIH0KICAgICAgICAgfQogICAgICAgICByZXR1cm47IC8vIFdlJ3ZlIHVwZGF0ZWQgdGhl IGdlbmVyYXRlZCBjb250ZW50LiBUaGF0J3MgYWxsIHdlIG5lZWRlZCB0byBkby4= 42205 2009-10-30 04:12:34 -0700 2009-11-01 08:03:36 -0800 Fix assertion falure in RenderObjectChildList::updateBeforeAfterContent(). bug-30944-20091030201232.patch text/plain 4614 yutak ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwY2JkNTRjLi5kNTAxZTkyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTAt MzAgIFl1dGEgS2l0YW11cmEgIDx5dXRha0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGFzc2VydGlvbiBmYWx1cmUgaW4g UmVuZGVyT2JqZWN0Q2hpbGRMaXN0Ojp1cGRhdGVCZWZvcmVBZnRlckNvbnRlbnQoKS4KKworICAg ICAgICBbQ3Jhc2ggKGRlYnVnKV0gQ29tYmluYXRpb24gb2YgbGlzdC1pdGVtIGFuZCA6YWZ0ZXIg Y2F1c2VzIGFzc2VydGlvbiBmYWlsdXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zMDk0NAorCisgICAgICAgICogZmFzdC9jc3MvbGlzdC1pdGVtLXBz ZXVkby1ub2NyYXNoLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9jc3MvbGlz dC1pdGVtLXBzZXVkby1ub2NyYXNoLmh0bWw6IEFkZGVkLgorCiAyMDA5LTEwLTI5ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgVXBkYXRlZCBUaWdlci1zcGVjaWZp YyByZXN1bHQgbm93IHRoYXQgVGlnZXIgbWF0Y2hlcyBjdXJyZW50IGJlaGF2aW9yLiBBIFRpZ2Vy LXNwZWNpZmljCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9saXN0LWl0ZW0tcHNl dWRvLW5vY3Jhc2gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvbGlzdC1pdGVt LXBzZXVkby1ub2NyYXNoLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwLi4wMWEzMWMyCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3Mv bGlzdC1pdGVtLXBzZXVkby1ub2NyYXNoLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDMgQEAKK1Ro aXMgaXMgYSB0ZXN0IGZvciBidWcgMzA5NDQuIFBhc3NlcyBpZiBpdCBkb2VzIG5vdCBjcmFzaC4K KworSG92ZXIgbWUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL2xpc3QtaXRlbS1w c2V1ZG8tbm9jcmFzaC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvbGlzdC1pdGVtLXBzZXVk by1ub2NyYXNoLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uYmIwMTIz NgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2xpc3QtaXRlbS1wc2V1 ZG8tbm9jcmFzaC5odG1sCkBAIC0wLDAgKzEsNTIgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+ CisgICAgPGhlYWQ+CisgICAgICAgIDx0aXRsZT5MaXN0LWl0ZW0gKyA6YWZ0ZXIgcHNldWRvLWNs YXNzPC90aXRsZT4KKyAgICAgICAgPHN0eWxlIHR5cGU9InRleHQvY3NzIj4KKyNhbmNob3Igewor ICAgIGRpc3BsYXk6IGJsb2NrOworfQorI2FuY2hvcjpob3ZlciB7fQorI2FuY2hvcjphZnRlciB7 CisgICAgY29udGVudDogIi4iOworICAgIGRpc3BsYXk6IGJsb2NrOworfQorc3BhbiB7CisgICAg ZmxvYXQ6IGxlZnQ7Cit9CisgICAgICAgIDwvc3R5bGU+CisgICAgICAgIDxzY3JpcHQgdHlwZT0i YXBwbGljYXRpb24vamF2YXNjcmlwdCI+CitmdW5jdGlvbiBydW4oKSB7CisgICAgaWYgKCF3aW5k b3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgIHJldHVybjsKKworICAgIHdpbmRvdy5s YXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgd2luZG93LmxheW91dFRlc3RD b250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKKyAgICB3aW5kb3cuZXZlbnRTZW5kZXIubW91c2VN b3ZlVG8oMCwgMCk7CisgICAgd2luZG93LnNldFRpbWVvdXQoaG92ZXIsIDEwMCk7Cit9CisKK2Z1 bmN0aW9uIGhvdmVyKCkgeworICAgIHZhciBlbGVtZW50ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoJ3RleHQnKTsKKyAgICB2YXIgeCA9IGVsZW1lbnQub2Zmc2V0TGVmdCArIGVsZW1lbnQub2Zm c2V0V2lkdGggLyAyOworICAgIHZhciB5ID0gZWxlbWVudC5vZmZzZXRUb3AgKyBlbGVtZW50Lm9m ZnNldEhlaWdodCAvIDI7CisgICAgd2luZG93LmV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKHgsIHkp OworICAgIHdpbmRvdy5zZXRUaW1lb3V0KGZpbmFsaXplLCAxMDApOworfQorCitmdW5jdGlvbiBm aW5hbGl6ZSgpIHsKKyAgICB3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgp OworfQorCit3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcignbG9hZCcsIHJ1biwgZmFsc2UpOworICAg ICAgICA8L3NjcmlwdD4KKyAgICA8L2hlYWQ+CisgICAgPGJvZHk+CisgICAgICAgIDxwPlRoaXMg aXMgYSB0ZXN0IGZvciA8YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MzA5NDQiPmJ1ZyAzMDk0NDwvYT4uIFBhc3NlcyBpZiBpdCBkb2VzIG5vdCBjcmFzaC48 L3A+CisgICAgICAgIDx1bD4KKyAgICAgICAgICAgIDxsaT4KKyAgICAgICAgICAgICAgICA8YSBp ZD0iYW5jaG9yIiBocmVmPSIjIj48c3BhbiBpZD0idGV4dCI+SG92ZXIgbWU8L3NwYW4+PC9hPgor ICAgICAgICAgICAgPC9saT4KKyAgICAgICAgPC91bD4KKyAgICA8L2JvZHk+Cis8L2h0bWw+CmRp ZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGZm OTEwYzMuLjk0YmEyMDUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNv cmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMTAtMzAgIFl1dGEgS2l0YW11cmEg IDx5dXRha0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRml4IGFzc2VydGlvbiBmYWx1cmUgaW4gUmVuZGVyT2JqZWN0Q2hpbGRM aXN0Ojp1cGRhdGVCZWZvcmVBZnRlckNvbnRlbnQoKS4KKworICAgICAgICBbQ3Jhc2ggKGRlYnVn KV0gQ29tYmluYXRpb24gb2YgbGlzdC1pdGVtIGFuZCA6YWZ0ZXIgY2F1c2VzIGFzc2VydGlvbiBm YWlsdXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z MDk0NAorCisgICAgICAgIFRlc3Q6IGZhc3QvY3NzL2xpc3QtaXRlbS1wc2V1ZG8tbm9jcmFzaC5o dG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyT2JqZWN0Q2hpbGRMaXN0LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlck9iamVjdENoaWxkTGlzdDo6dXBkYXRlQmVmb3JlQWZ0ZXJD b250ZW50KToKKwogMjAwOS0xMC0yOSAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJPYmplY3RDaGlsZExpc3QuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyT2JqZWN0Q2hpbGRMaXN0LmNwcAppbmRleCAyM2FiOThmLi5mYTE5NTQ3IDEwMDY0NAotLS0g YS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3RDaGlsZExpc3QuY3BwCisrKyBiL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdENoaWxkTGlzdC5jcHAKQEAgLTM2OSw5ICszNjksMTEg QEAgdm9pZCBSZW5kZXJPYmplY3RDaGlsZExpc3Q6OnVwZGF0ZUJlZm9yZUFmdGVyQ29udGVudChS ZW5kZXJPYmplY3QqIG93bmVyLCBQc2V1ZG8KICAgICAgICAgICAgICAgICAgICAgUmVmUHRyPFJl bmRlclN0eWxlPiBzdHlsZSA9IFJlbmRlclN0eWxlOjpjcmVhdGUoKTsKICAgICAgICAgICAgICAg ICAgICAgc3R5bGUtPmluaGVyaXRGcm9tKHBzZXVkb0VsZW1lbnRTdHlsZSk7CiAgICAgICAgICAg ICAgICAgICAgIGdlbkNoaWxkLT5zZXRTdHlsZShzdHlsZS5yZWxlYXNlKCkpOwotICAgICAgICAg ICAgICAgIH0gZWxzZQotICAgICAgICAgICAgICAgICAgICAvLyBNdXN0IGJlIGEgZmlyc3QtbGV0 dGVyIGNvbnRhaW5lci4gdXBkYXRlRmlyc3RMZXR0ZXIoKSB3aWxsIHRha2UgY2FyZSBvZiBpdC4K LSAgICAgICAgICAgICAgICAgICAgQVNTRVJUKGdlbkNoaWxkLT5zdHlsZSgpLT5zdHlsZVR5cGUo KSA9PSBGSVJTVF9MRVRURVIpOworICAgICAgICAgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAg ICAgICAgICAgIC8vIFJlbmRlckxpc3RJdGVtIG1heSBpbnNlcnQgYSBsaXN0IG1hcmtlciBoZXJl LiBXZSBkbyBub3QgbmVlZCB0byBjYXJlIGFib3V0IHRoaXMgY2FzZS4KKyAgICAgICAgICAgICAg ICAgICAgLy8gT3RoZXJ3aXNlLCBnZW5DaGlsZCBtdXN0IGJlIGEgZmlyc3QtbGV0dGVyIGNvbnRh aW5lci4gdXBkYXRlRmlyc3RMZXR0ZXIoKSB3aWxsIHRha2UgY2FyZSBvZiBpdC4KKyAgICAgICAg ICAgICAgICAgICAgQVNTRVJUKGdlbkNoaWxkLT5pc0xpc3RNYXJrZXIoKSB8fCBnZW5DaGlsZC0+ c3R5bGUoKS0+c3R5bGVUeXBlKCkgPT0gRklSU1RfTEVUVEVSKTsKKyAgICAgICAgICAgICAgICB9 CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICAgICAgcmV0dXJuOyAvLyBXZSd2ZSB1cGRh dGVkIHRoZSBnZW5lcmF0ZWQgY29udGVudC4gVGhhdCdzIGFsbCB3ZSBuZWVkZWQgdG8gZG8u