30939 2009-10-29 18:34:10 -0700 counterValueForElementById should return space-separated string for multiple counters 2009-10-30 10:58:19 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 hamaji webkit-unassigned oldest_to_newest 159179 0 hamaji 2009-10-29 18:34:10 -0700 As Darin suggested in Bug 30555, layoutTestController.counterValueForElementById should return space-separated string when there are multiple counters in one element. 159180 1 42165 hamaji 2009-10-29 18:35:57 -0700 Created attachment 42165 Patch v1 159334 2 42165 darin 2009-10-30 10:14:42 -0700 Comment on attachment 42165 Patch v1 > + stream << " "; It's probably more efficient to append a space character instead of a single-character string, but efficiency is not critical here. r=me 159349 3 hamaji 2009-10-30 10:32:45 -0700 > It's probably more efficient to append a space character instead of a > single-character string, but efficiency is not critical here. Yeah, I considered it a bit, but I just used the C string because I couldn't find operator<<(char) in TextStream. I think it's not worth adding an overload function. 159368 4 hamaji 2009-10-30 10:58:19 -0700 Committed r50345: <http://trac.webkit.org/changeset/50345> 42165 2009-10-29 18:35:57 -0700 2009-10-30 10:14:42 -0700 Patch v1 bug-30939-20091030103555.patch text/plain 6722 hamaji ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5YWNmYTM5Li43ZDFlMmI1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTAt MjkgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBjb3VudGVyVmFsdWVGb3JFbGVt ZW50QnlJZCBzaG91bGQgcmV0dXJuIHNwYWNlLXNlcGFyYXRlZCBzdHJpbmcgZm9yIG11bHRpcGxl IGNvdW50ZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zMDkzOQorCisgICAgICAgICogZmFzdC9jc3MvY291bnRlcnMvY291bnRlclZhbHVlRm9yRWxl bWVudEJ5SWQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Nzcy9jb3VudGVy cy9jb3VudGVyVmFsdWVGb3JFbGVtZW50QnlJZC5odG1sOiBBZGRlZC4KKwogMjAwOS0xMC0yOSAg RW5yaWNhIENhc3VjY2kgIDxlbnJpY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04o My4yLjMgLSA0LjAuMik6IE1lc3NhZ2UgY29tcG9zaW5nOiB3aGVuIEkgdW5kbyBhIGNvbG9yIGNo YW5nZSB0byB0ZXh0IGluIE1haWwsIHVuZG8vcmVkbyBiZWhhdmVzIHN0cmFuZ2VseQpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvY291bnRlcnMvY291bnRlclZhbHVlRm9yRWxlbWVu dEJ5SWQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvY291bnRlcnMvY291bnRl clZhbHVlRm9yRWxlbWVudEJ5SWQtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAuLjUxYTIzZWUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0 L2Nzcy9jb3VudGVycy9jb3VudGVyVmFsdWVGb3JFbGVtZW50QnlJZC1leHBlY3RlZC50eHQKQEAg LTAsMCArMSwxMSBAQAorVGhpcyBpcyB0aGUgdGVzdCBmb3IgbGF5b3V0VGVzdENvbnRyb2xsZXIu Y291bnRlclZhbHVlRm9yRWxlbWVudEJ5SWQKKyAgIAorUEFTUyBsYXlvdXRUZXN0Q29udHJvbGxl ci5jb3VudGVyVmFsdWVGb3JFbGVtZW50QnlJZCgnYmVmb3JlJykgaXMgJzAnCitQQVNTIGxheW91 dFRlc3RDb250cm9sbGVyLmNvdW50ZXJWYWx1ZUZvckVsZW1lbnRCeUlkKCdhZnRlcicpIGlzICcw JworUEFTUyBsYXlvdXRUZXN0Q29udHJvbGxlci5jb3VudGVyVmFsdWVGb3JFbGVtZW50QnlJZCgn YmVmb3JlX2FmdGVyJykgaXMgJzAgMCcKK1BBU1MgbGF5b3V0VGVzdENvbnRyb2xsZXIuY291bnRl clZhbHVlRm9yRWxlbWVudEJ5SWQoJ3R3aWNlJykgaXMgJzAgMCcKK1BBU1MgbGF5b3V0VGVzdENv bnRyb2xsZXIuY291bnRlclZhbHVlRm9yRWxlbWVudEJ5SWQoJ3BvaW50JykgaXMgJzAuMScKK1BB U1MgbGF5b3V0VGVzdENvbnRyb2xsZXIuY291bnRlclZhbHVlRm9yRWxlbWVudEJ5SWQoJ3R3by1w b2ludHMnKSBpcyAnMC4xLjInCitQQVNTIGxheW91dFRlc3RDb250cm9sbGVyLmNvdW50ZXJWYWx1 ZUZvckVsZW1lbnRCeUlkKCdncmVlaycpIGlzICcwLs6xLs6yJworUEFTUyBsYXlvdXRUZXN0Q29u dHJvbGxlci5jb3VudGVyVmFsdWVGb3JFbGVtZW50QnlJZCgndGhyZWUtZ3JlZWtzJykgaXMgJzAu zrEuzrIgMC7OsS7OsiAwLs6xLs6yJworCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nz cy9jb3VudGVycy9jb3VudGVyVmFsdWVGb3JFbGVtZW50QnlJZC5odG1sIGIvTGF5b3V0VGVzdHMv ZmFzdC9jc3MvY291bnRlcnMvY291bnRlclZhbHVlRm9yRWxlbWVudEJ5SWQuaHRtbApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi4wMTk3ZDY0Ci0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9jc3MvY291bnRlcnMvY291bnRlclZhbHVlRm9yRWxlbWVudEJ5SWQu aHRtbApAQCAtMCwwICsxLDQ4IEBACis8aGVhZD4KKyAgICA8bWV0YSBjaGFyc2V0PSJ1dGYtOCI+ CisgICAgPHN0eWxlPgorICAgICAgICAucmVzZXQgeyBjb3VudGVyLXJlc2V0OiBjOyB9CisgICAg ICAgIC5pbmNyZW1lbnQgeyBjb3VudGVyLWluY3JlbWVudDogYzsgfQorICAgICAgICAuaW5jcmVt ZW50MiB7IGNvdW50ZXItaW5jcmVtZW50OiBjIDI7IH0KKyAgICAgICAgLnNob3ctYmVmb3JlOmJl Zm9yZSB7IGNvbnRlbnQ6IGNvdW50ZXJzKGMsICIuIik7IH0KKyAgICAgICAgLnNob3ctYWZ0ZXI6 YWZ0ZXIgeyBjb250ZW50OiBjb3VudGVycyhjLCAiLiIpOyB9CisgICAgICAgIC5zaG93LXR3aWNl OmJlZm9yZSB7IGNvbnRlbnQ6IGNvdW50ZXJzKGMsICIuIikgY291bnRlcnMoYywgIi4iKTsgfQor ICAgICAgICAuc2hvdy1ncmVlazpiZWZvcmUgeyBjb250ZW50OiBjb3VudGVycyhjLCAiLiIsIGxv d2VyLWdyZWVrKTsgfQorICAgICAgICAuc2hvdy10aHJlZS1ncmVla3M6YmVmb3JlIHsgY29udGVu dDogY291bnRlcnMoYywgIi4iLCBsb3dlci1ncmVlaykgY291bnRlcnMoYywgIi4iLCBsb3dlci1n cmVlayk7IH0KKyAgICAgICAgLnNob3ctdGhyZWUtZ3JlZWtzOmFmdGVyIHsgY29udGVudDogY291 bnRlcnMoYywgIi4iLCBsb3dlci1ncmVlayk7IH0KKyAgICA8L3N0eWxlPgorICAgIDxzY3JpcHQg c3JjPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFk PgorPGJvZHk+CisgICAgPGRpdj5UaGlzIGlzIHRoZSB0ZXN0IGZvciBsYXlvdXRUZXN0Q29udHJv bGxlci5jb3VudGVyVmFsdWVGb3JFbGVtZW50QnlJZDwvZGl2PgorCisgICAgPGRpdiBjbGFzcz0i cmVzZXQiPjxzcGFuIGlkPSJiZWZvcmUiIGNsYXNzPSJzaG93LWJlZm9yZSI+PC9zcGFuPjwvZGl2 PgorICAgIDxkaXYgY2xhc3M9InJlc2V0Ij48c3BhbiBpZD0iYWZ0ZXIiIGNsYXNzPSJzaG93LWFm dGVyIj48L3NwYW4+PC9kaXY+CisgICAgPGRpdiBjbGFzcz0icmVzZXQiPjxzcGFuIGlkPSJiZWZv cmVfYWZ0ZXIiIGNsYXNzPSJzaG93LWJlZm9yZSBzaG93LWFmdGVyIj48L3NwYW4+PC9kaXY+Cisg ICAgPGRpdiBjbGFzcz0icmVzZXQiPjxzcGFuIGlkPSJ0d2ljZSIgY2xhc3M9InNob3ctdHdpY2Ui Pjwvc3Bhbj48L2Rpdj4KKyAgICA8ZGl2IGNsYXNzPSJyZXNldCI+CisgICAgICAgIDxzcGFuIGlk PSJwb2ludCIgY2xhc3M9InJlc2V0IGluY3JlbWVudCBzaG93LWJlZm9yZSI+CisgICAgICAgICAg ICA8c3BhbiBpZD0idHdvLXBvaW50cyIgY2xhc3M9InJlc2V0IGluY3JlbWVudDIgc2hvdy1iZWZv cmUiPgorICAgICAgICAgICAgICAgIDxzcGFuIGlkPSJncmVlayIgY2xhc3M9InNob3ctZ3JlZWsi Pjwvc3Bhbj4KKyAgICAgICAgICAgICAgICA8c3BhbiBpZD0idGhyZWUtZ3JlZWtzIiBjbGFzcz0i c2hvdy10aHJlZS1ncmVla3MiPjwvc3Bhbj4KKyAgICAgICAgICAgIDwvc3Bhbj4KKyAgICAgICAg PC9zcGFuPgorICAgIDwvZGl2PgorCisgICAgPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CisKKyAg ICA8c2NyaXB0PgorICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7Cisg ICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisKKyAgICAgICAg ICAgIHNob3VsZEJlKCJsYXlvdXRUZXN0Q29udHJvbGxlci5jb3VudGVyVmFsdWVGb3JFbGVtZW50 QnlJZCgnYmVmb3JlJykiLCAiJzAnIik7CisgICAgICAgICAgICBzaG91bGRCZSgibGF5b3V0VGVz dENvbnRyb2xsZXIuY291bnRlclZhbHVlRm9yRWxlbWVudEJ5SWQoJ2FmdGVyJykiLCAiJzAnIik7 CisgICAgICAgICAgICBzaG91bGRCZSgibGF5b3V0VGVzdENvbnRyb2xsZXIuY291bnRlclZhbHVl Rm9yRWxlbWVudEJ5SWQoJ2JlZm9yZV9hZnRlcicpIiwgIicwIDAnIik7CisgICAgICAgICAgICBz aG91bGRCZSgibGF5b3V0VGVzdENvbnRyb2xsZXIuY291bnRlclZhbHVlRm9yRWxlbWVudEJ5SWQo J3R3aWNlJykiLCAiJzAgMCciKTsKKyAgICAgICAgICAgIHNob3VsZEJlKCJsYXlvdXRUZXN0Q29u dHJvbGxlci5jb3VudGVyVmFsdWVGb3JFbGVtZW50QnlJZCgncG9pbnQnKSIsICInMC4xJyIpOwor ICAgICAgICAgICAgc2hvdWxkQmUoImxheW91dFRlc3RDb250cm9sbGVyLmNvdW50ZXJWYWx1ZUZv ckVsZW1lbnRCeUlkKCd0d28tcG9pbnRzJykiLCAiJzAuMS4yJyIpOworICAgICAgICAgICAgc2hv dWxkQmUoImxheW91dFRlc3RDb250cm9sbGVyLmNvdW50ZXJWYWx1ZUZvckVsZW1lbnRCeUlkKCdn cmVlaycpIiwgIicwLlx1MDNiMS5cdTAzYjInIik7CisgICAgICAgICAgICBzaG91bGRCZSgibGF5 b3V0VGVzdENvbnRyb2xsZXIuY291bnRlclZhbHVlRm9yRWxlbWVudEJ5SWQoJ3RocmVlLWdyZWVr cycpIiwgIicwLlx1MDNiMS5cdTAzYjIgMC5cdTAzYjEuXHUwM2IyIDAuXHUwM2IxLlx1MDNiMici KTsKKyAgICAgICAgfQorICAgIDwvc2NyaXB0PgorPC9ib2R5PgpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2YjBlN2IyLi41Y2I4MTMwIDEw MDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE2IEBACisyMDA5LTEwLTI5ICBTaGluaWNoaXJvIEhhbWFqaSAgPGhhbWFqaUBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgY291bnRlclZhbHVlRm9yRWxlbWVudEJ5SWQgc2hvdWxkIHJldHVybiBzcGFjZS1zZXBhcmF0 ZWQgc3RyaW5nIGZvciBtdWx0aXBsZSBjb3VudGVycworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA5MzkKKworICAgICAgICBUZXN0OiBmYXN0L2Nzcy9j b3VudGVycy9jb3VudGVyVmFsdWVGb3JFbGVtZW50QnlJZC5odG1sCisKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyVHJlZUFzVGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjp3cml0ZUNvdW50 ZXJWYWx1ZXNGcm9tQ2hpbGRyZW4pOgorICAgICAgICAoV2ViQ29yZTo6Y291bnRlclZhbHVlRm9y RWxlbWVudCk6CisKIDIwMDktMTAtMjkgIEVucmljYSBDYXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclRyZWVBc1RleHQuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyVHJlZUFzVGV4dC5jcHAKaW5kZXggYjdhYjE5MS4uODU1YjM5OSAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyVHJlZUFzVGV4dC5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyVHJlZUFzVGV4dC5jcHAKQEAgLTU1NCwxMCArNTU0LDEzIEBAIFN0cmluZyBleHRl cm5hbFJlcHJlc2VudGF0aW9uKFJlbmRlck9iamVjdCogbykKICAgICByZXR1cm4gdHMucmVsZWFz ZSgpOwogfQogCi1zdGF0aWMgdm9pZCB3cml0ZUNvdW50ZXJWYWx1ZXNGcm9tQ2hpbGRyZW4oVGV4 dFN0cmVhbSYgc3RyZWFtLCBSZW5kZXJPYmplY3QqIHBhcmVudCkKK3N0YXRpYyB2b2lkIHdyaXRl Q291bnRlclZhbHVlc0Zyb21DaGlsZHJlbihUZXh0U3RyZWFtJiBzdHJlYW0sIFJlbmRlck9iamVj dCogcGFyZW50LCBib29sJiBpc0ZpcnN0Q291bnRlcikKIHsKICAgICBmb3IgKFJlbmRlck9iamVj dCogY2hpbGQgPSBwYXJlbnQtPmZpcnN0Q2hpbGQoKTsgY2hpbGQ7IGNoaWxkID0gY2hpbGQtPm5l eHRTaWJsaW5nKCkpIHsKICAgICAgICAgaWYgKGNoaWxkLT5pc0NvdW50ZXIoKSkgeworICAgICAg ICAgICAgaWYgKCFpc0ZpcnN0Q291bnRlcikKKyAgICAgICAgICAgICAgICBzdHJlYW0gPDwgIiAi OworICAgICAgICAgICAgaXNGaXJzdENvdW50ZXIgPSBmYWxzZTsKICAgICAgICAgICAgIFN0cmlu ZyBzdHIodG9SZW5kZXJUZXh0KGNoaWxkKS0+dGV4dCgpKTsKICAgICAgICAgICAgIHN0cmVhbSA8 PCBzdHI7CiAgICAgICAgIH0KQEAgLTU3MCwxMiArNTczLDEzIEBAIFN0cmluZyBjb3VudGVyVmFs dWVGb3JFbGVtZW50KEVsZW1lbnQqIGVsZW1lbnQpCiAgICAgUmVmUHRyPEVsZW1lbnQ+IGVsZW1l bnRSZWYoZWxlbWVudCk7CiAgICAgZWxlbWVudC0+ZG9jdW1lbnQoKS0+dXBkYXRlTGF5b3V0KCk7 CiAgICAgVGV4dFN0cmVhbSBzdHJlYW07CisgICAgYm9vbCBpc0ZpcnN0Q291bnRlciA9IHRydWU7 CiAgICAgLy8gVGhlIGNvdW50ZXIgcmVuZGVyZXJzIHNob3VsZCBiZSBjaGlsZHJlbiBvZiBhbm9u eW1vdXMgY2hpbGRyZW4KICAgICAvLyAoaS5lLiwgOmJlZm9yZSBvciA6YWZ0ZXIgcHNldWRvLWVs ZW1lbnRzKS4KICAgICBpZiAoUmVuZGVyT2JqZWN0KiByZW5kZXJlciA9IGVsZW1lbnQtPnJlbmRl cmVyKCkpIHsKICAgICAgICAgZm9yIChSZW5kZXJPYmplY3QqIGNoaWxkID0gcmVuZGVyZXItPmZp cnN0Q2hpbGQoKTsgY2hpbGQ7IGNoaWxkID0gY2hpbGQtPm5leHRTaWJsaW5nKCkpIHsKICAgICAg ICAgICAgIGlmIChjaGlsZC0+aXNBbm9ueW1vdXMoKSkKLSAgICAgICAgICAgICAgICB3cml0ZUNv dW50ZXJWYWx1ZXNGcm9tQ2hpbGRyZW4oc3RyZWFtLCBjaGlsZCk7CisgICAgICAgICAgICAgICAg d3JpdGVDb3VudGVyVmFsdWVzRnJvbUNoaWxkcmVuKHN0cmVhbSwgY2hpbGQsIGlzRmlyc3RDb3Vu dGVyKTsKICAgICAgICAgfQogICAgIH0KICAgICByZXR1cm4gc3RyZWFtLnJlbGVhc2UoKTs=