30927 2009-10-29 14:00:08 -0700 [Qt] Remove the QWebInspector::windowTitleChanged signal 2009-10-30 10:50:59 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC Linux RESOLVED FIXED Qt P2 Enhancement --- 1 jturcotte webkit-unassigned commit-queue kenneth oldest_to_newest 159067 0 jturcotte 2009-10-29 14:00:08 -0700 Remove the QWebInspector::windowTitleChanged signal, QEvent::WindowTitleChange can be used to achieve the same. 159068 1 42141 jturcotte 2009-10-29 14:01:03 -0700 Created attachment 42141 Patch 159080 2 kenneth 2009-10-29 14:19:20 -0700 LGTM. Maybe add this hint to the documentation of the class? 159315 3 42141 vestbo 2009-10-30 08:25:15 -0700 Comment on attachment 42141 Patch LGTM 159361 4 42141 commit-queue 2009-10-30 10:50:55 -0700 Comment on attachment 42141 Patch Clearing flags on attachment: 42141 Committed r50344: <http://trac.webkit.org/changeset/50344> 159362 5 commit-queue 2009-10-30 10:50:59 -0700 All reviewed patches have been landed. Closing bug. 42141 2009-10-29 14:01:03 -0700 2009-10-30 10:50:54 -0700 Patch qwebinspector_removeWindowTitleChanged.patch text/plain 2233 jturcotte ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYmluc3BlY3Rvci5jcHAgYi9XZWJLaXQvcXQv QXBpL3F3ZWJpbnNwZWN0b3IuY3BwCmluZGV4IDQ1NzhkYzkuLjQwOWUxYTAgMTAwNjQ0Ci0tLSBh L1dlYktpdC9xdC9BcGkvcXdlYmluc3BlY3Rvci5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2Vi aW5zcGVjdG9yLmNwcApAQCAtMTg4LDkgKzE4OCwzIEBAIHZvaWQgUVdlYkluc3BlY3RvclByaXZh dGU6OmFkanVzdEZyb250ZW5kU2l6ZShjb25zdCBRU2l6ZSYgc2l6ZSkKICAgICAgICAgZnJvbnRl bmQtPnJlc2l6ZShzaXplKTsKIH0KIAotLyohCi0gICAgXGZuIHZvaWQgUVdlYkluc3BlY3Rvcjo6 d2luZG93VGl0bGVDaGFuZ2VkKGNvbnN0IFFTdHJpbmcmIG5ld1RpdGxlKTsKLQotICAgIFRoaXMg aXMgZW1pdHRlZCB0byBzaWduYWwgdGhhdCB0aGlzIHdpZGdldCdzIHRpdGxlIGNoYW5nZWQgdG8g XGEgbmV3VGl0bGUuCi0qLwotCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQXBpL3F3ZWJpbnNwZWN0 b3IuaCBiL1dlYktpdC9xdC9BcGkvcXdlYmluc3BlY3Rvci5oCmluZGV4IGJiNWJkNjQuLmE1YzFl ZDUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9BcGkvcXdlYmluc3BlY3Rvci5oCisrKyBiL1dlYktp dC9xdC9BcGkvcXdlYmluc3BlY3Rvci5oCkBAIC0zOSw5ICszOSw2IEBAIHB1YmxpYzoKICAgICBR U2l6ZSBzaXplSGludCgpIGNvbnN0OwogICAgIGJvb2wgZXZlbnQoUUV2ZW50Kik7CiAKLVFfU0lH TkFMUzoKLSAgICB2b2lkIHdpbmRvd1RpdGxlQ2hhbmdlZChjb25zdCBRU3RyaW5nJiBuZXdUaXRs ZSk7Ci0KIHByb3RlY3RlZDoKICAgICB2b2lkIHJlc2l6ZUV2ZW50KFFSZXNpemVFdmVudCogZXZl bnQpOwogICAgIHZvaWQgc2hvd0V2ZW50KFFTaG93RXZlbnQqIGV2ZW50KTsKZGlmZiAtLWdpdCBh L1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDNmOTNlNmIu LmVjOWEwMTIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L3F0 L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDA5LTEwLTI5ICBKb2NlbHluIFR1cmNvdHRl ICA8am9jZWx5bi50dXJjb3R0ZUBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBSZW1vdmUgdGhlIFFXZWJJbnNwZWN0b3I6Ondp bmRvd1RpdGxlQ2hhbmdlZCBzaWduYWwsCisgICAgICAgIFFFdmVudDo6V2luZG93VGl0bGVDaGFu Z2UgY2FuIGJlIHVzZWQgdG8gYWNoaWV2ZSB0aGUgc2FtZS4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwOTI3CisKKyAgICAgICAgKiBBcGkvcXdlYmlu c3BlY3Rvci5jcHA6CisgICAgICAgICogQXBpL3F3ZWJpbnNwZWN0b3IuaDoKKyAgICAgICAgKiBX ZWJDb3JlU3VwcG9ydC9JbnNwZWN0b3JDbGllbnRRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJ bnNwZWN0b3JDbGllbnRRdDo6dXBkYXRlV2luZG93VGl0bGUpOgorCiAyMDA5LTEwLTI3ICBTaGlu aWNoaXJvIEhhbWFqaSAgPGhhbWFqaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvSW5z cGVjdG9yQ2xpZW50UXQuY3BwIGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0luc3BlY3RvckNs aWVudFF0LmNwcAppbmRleCAxMmY0MDVjLi43YTFiZmQ1IDEwMDY0NAotLS0gYS9XZWJLaXQvcXQv V2ViQ29yZVN1cHBvcnQvSW5zcGVjdG9yQ2xpZW50UXQuY3BwCisrKyBiL1dlYktpdC9xdC9XZWJD b3JlU3VwcG9ydC9JbnNwZWN0b3JDbGllbnRRdC5jcHAKQEAgLTE2Niw3ICsxNjYsNiBAQCB2b2lk IEluc3BlY3RvckNsaWVudFF0Ojp1cGRhdGVXaW5kb3dUaXRsZSgpCiAgICAgaWYgKG1faW5zcGVj dGVkV2ViUGFnZS0+ZC0+aW5zcGVjdG9yKSB7CiAgICAgICAgIFFTdHJpbmcgY2FwdGlvbiA9IFFD b3JlQXBwbGljYXRpb246OnRyYW5zbGF0ZSgiUVdlYlBhZ2UiLCAiV2ViIEluc3BlY3RvciAtICUy IikuYXJnKG1faW5zcGVjdGVkVVJMKTsKICAgICAgICAgbV9pbnNwZWN0ZWRXZWJQYWdlLT5kLT5p bnNwZWN0b3ItPnNldFdpbmRvd1RpdGxlKGNhcHRpb24pOwotICAgICAgICBlbWl0IG1faW5zcGVj dGVkV2ViUGFnZS0+ZC0+aW5zcGVjdG9yLT53aW5kb3dUaXRsZUNoYW5nZWQoY2FwdGlvbik7CiAg ICAgfQogfQogCg==