30919 2009-10-29 11:35:45 -0700 [V8] Remove random crashes by removing retrieval of V8 context during garbage collection. 2009-12-29 08:34:42 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dglazkov dglazkov abarth ager eric sgjesse oldest_to_newest 158985 0 dglazkov 2009-10-29 11:35:45 -0700 These exhibit themselves as random crashes on innocent-looking tests. The timing has to be just right. I wasn't able to write a test for this. The issue occurs when all of the following is true: 1) new V8 context is being created. 2) creating the context (actual allocation of descriptor) triggers garbage collection 3) there's an existing left-over DOM object in map that ask to needs to retrieve current V8 context (MessagePort, for example). Like so: *boom* <-- global_context ain't yet cooked. test_shell!v8::internal::Context::global_context+0x42 test_shell!v8::internal::Context::global_proxy+0x5 test_shell!v8::Context::Global+0x52 test_shell!WebCore::WorkerContextExecutionProxy::retrieve+0x2e test_shell!WebCore::V8DOMWrapper::convertToV8Object+0x31 test_shell!WebCore::GCPrologueVisitor::visitDOMWrapper+0x93 test_shell!WebCore::visitActiveDOMObjectsInCurrentThread+0xa2 test_shell!WebCore::V8GCController::gcPrologue+0x1f test_shell!v8::internal::Heap::PerformGarbageCollection+0x15 test_shell!v8::internal::Heap::CollectGarbage+0x8a test_shell!v8::internal::Factory::NewGlobalObject+0x77 test_shell!v8::internal::Genesis::CreateRoots+0x5aa test_shell!v8::internal::Genesis::Genesis+0x7d test_shell!v8::internal::Bootstrapper::CreateEnvironment+0x1b test_shell!v8::Context::New+0x14a test_shell!WebCore::V8Proxy::createNewContext+0x241 test_shell!WebCore::V8Proxy::initContextIfNeeded+0x79 test_shell!WebCore::V8Proxy::updateDocument+0x21 test_shell!WebCore::Frame::setDocument+0x9e test_shell!WebCore::FrameLoader::begin+0x273 Luckily, we don't need to do V8DOMWrapper::convertToV8Object. We can just reach into the map and grab the object, since we know it's there. I wasn't able to write a layout test that consistently triggers this condition. I can trigger garbage collection and I can trigger navigation, but not at the same time :) 158987 1 42117 dglazkov 2009-10-29 11:40:21 -0700 Created attachment 42117 Fixerate random crashes, v1. 158993 2 42120 dglazkov 2009-10-29 11:46:30 -0700 Created attachment 42120 Fixerate random crashes, v2. 158998 3 42120 abarth 2009-10-29 11:58:18 -0700 Comment on attachment 42120 Fixerate random crashes, v2. + V8DOMWrapper::jsWrapperForDOMObject We should have two of these: one for DOMObjects and one for ActiveDOMObjects, to mirror the setters. 159010 4 42124 dglazkov 2009-10-29 12:25:56 -0700 Created attachment 42124 Fixerate random crashes, v3. 159014 5 42124 abarth 2009-10-29 12:37:52 -0700 Comment on attachment 42124 Fixerate random crashes, v3. Thanks. 159236 6 sgjesse 2009-10-30 00:17:21 -0700 Nit: I Don't think it it's required retrieve port1Wrapper, as it is already in wrapper, that is v8::Handle<v8::Value> port1Wrapper = V8DOMWrapper::jsWrapperForActiveDOMObject(port1); could be v8::Handle<v8::Value> port1Wrapper = wrapper or the variable port1Wrapper could be removed. 163175 7 42124 commit-queue 2009-11-12 19:06:14 -0800 Comment on attachment 42124 Fixerate random crashes, v3. Rejecting patch 42124 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Adam Barth', '--force']" exit_code: 1 Last 500 characters of output: geLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/bindings/v8/V8DOMWrapper.cpp Hunk #1 succeeded at 208 with fuzz 1 (offset 54 lines). patching file WebCore/bindings/v8/V8DOMWrapper.h Hunk #1 FAILED at 279. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/bindings/v8/V8DOMWrapper.h.rej patching file WebCore/bindings/v8/V8GCController.cpp Hunk #1 FAILED at 218. Hunk #2 FAILED at 228. 2 out of 2 hunks FAILED -- saving rejects to file WebCore/bindings/v8/V8GCController.cpp.rej 165299 8 42124 abarth 2009-11-20 07:15:40 -0800 Comment on attachment 42124 Fixerate random crashes, v3. Rejecting patch 42124 from commit-queue. Failed to run "['/Users/abarth/git/webkit-kr/WebKitTools/Scripts/svn-apply', '--reviewer', 'Adam Barth']" exit_code: 1 patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/bindings/v8/V8DOMWrapper.cpp Reversed (or previously applied) patch detected! Assume -R? [n] Apply anyway? [n] Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file WebCore/bindings/v8/V8DOMWrapper.cpp.rej patch -p0 "WebCore/bindings/v8/V8DOMWrapper.cpp" returned 1. Pass --force to ignore patch failures. 170161 9 eric 2009-12-09 14:04:32 -0800 Ping? Looks like we need a new patch here. 175432 10 42124 eric 2009-12-28 23:00:49 -0800 Comment on attachment 42124 Fixerate random crashes, v3. Changing Adam Barth's r+ to an r- since this patch no longer applies. We need a new patch. 175433 11 eric 2009-12-28 23:01:48 -0800 I mean, I guess if Dimitri plans to land this himself, that's totally fine and he should consider it still r+'d by Adam, but not having been touched in nearly 2 months, it's silly to have this still sitting in the pending-commit list. That's assuming this bug should even still be open? 175563 12 dglazkov 2009-12-29 08:34:42 -0800 I stink. Landed as http://trac.webkit.org/changeset/50293. 42117 2009-10-29 11:40:21 -0700 2009-10-29 11:46:24 -0700 Fixerate random crashes, v1. bug-30919-20091029114019.patch text/plain 2527 dglazkov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTcyNzA4OS4uYmM5YTYxYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAwOS0xMC0yOSAgRGltaXRyaSBHbGF6 a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtWOF0gUmVtb3ZlIHJhbmRvbSBjcmFzaGVzIGJ5IHJlbW92 aW5nIHJldHJpZXZhbCBvZiBWOCBjb250ZXh0IGR1cmluZyBnYXJiYWdlIGNvbGxlY3Rpb24uCisK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwOTE5CisK KyAgICAgICAgVW5mb3J0dW5hdGVseSwgSSBoYXZlbid0IGJlZW4gYWJsZSB0byB0cmlnZ2VyIHRo aXMgY3Jhc2ggZXhwbGljaXRseSwgc28gbm8gdGVzdCA6KC4KKworICAgICAgICAqIGJpbmRpbmdz L3Y4L1Y4RE9NV3JhcHBlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOERPTVdyYXBwZXI6Ompz V3JhcHBlckZvckRPTU9iamVjdCk6IEFkZGVkIG5ldyAiYXNzdW1lLWl0J3MtdGhlcmUiIGdldHRl ci4KKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuaDogQWRkZWQgZ2V0dGVyIGRl Y2wuCisgICAgICAgICogYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6R0NQcm9sb2d1ZVZpc2l0b3I6OnZpc2l0RE9NV3JhcHBlcik6IENoYW5nZWQgdG8g dXNlIGV4cGxpY2l0IGdldHRlci4KKwogMjAwOS0xMC0yNyAgQ2hyaXMgRmxlaXphY2ggIDxjZmxl aXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuY3BwIGIvV2ViQ29yZS9i aW5kaW5ncy92OC9WOERPTVdyYXBwZXIuY3BwCmluZGV4IDMyMTE1M2QuLmYzYjUzZjQgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcAorKysgYi9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAKQEAgLTE1NCw2ICsxNTQsMTYgQEAgYm9vbCBW OERPTVdyYXBwZXI6OmRvbU9iamVjdEhhc0pTV3JhcHBlcih2b2lkKiBvYmplY3QpCiAgICAgcmV0 dXJuIGdldERPTU9iamVjdE1hcCgpLmNvbnRhaW5zKG9iamVjdCkgfHwgZ2V0QWN0aXZlRE9NT2Jq ZWN0TWFwKCkuY29udGFpbnMob2JqZWN0KTsKIH0KIAordjg6OlBlcnNpc3RlbnQ8djg6Ok9iamVj dD4gVjhET01XcmFwcGVyOjpqc1dyYXBwZXJGb3JET01PYmplY3Qodm9pZCogb2JqZWN0KQorewor ICAgIHY4OjpQZXJzaXN0ZW50PHY4OjpPYmplY3Q+IHdyYXBwZXIgPSBnZXRET01PYmplY3RNYXAo KS5nZXQob2JqZWN0KTsKKyAgICBpZiAoIXdyYXBwZXIuSXNFbXB0eSgpKQorICAgICAgICByZXR1 cm4gd3JhcHBlcjsKKyAgICB3cmFwcGVyID0gZ2V0QWN0aXZlRE9NT2JqZWN0TWFwKCkuZ2V0KG9i amVjdCk7CisgICAgQVNTRVJUKCF3cmFwcGVyLklzRW1wdHkoKSk7CisgICAgcmV0dXJuIHdyYXBw ZXI7Cit9CisKIC8vIFRoZSBjYWxsZXIgbXVzdCBoYXZlIGluY3JlYXNlZCBvYmoncyByZWYgY291 bnQuCiB2b2lkIFY4RE9NV3JhcHBlcjo6c2V0SlNXcmFwcGVyRm9yRE9NT2JqZWN0KHZvaWQqIG9i amVjdCwgdjg6OlBlcnNpc3RlbnQ8djg6Ok9iamVjdD4gd3JhcHBlcikKIHsKZGlmZiAtLWdpdCBh L1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmggYi9XZWJDb3JlL2JpbmRpbmdzL3Y4 L1Y4RE9NV3JhcHBlci5oCmluZGV4IDIyN2M5ZmYuLmFmMmU2MmUgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmgKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9W OERPTVdyYXBwZXIuaApAQCAtMjc5LDYgKzI3OSw5IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAog ICAgICAgICAvLyBDaGVja3Mgd2hldGhlciBhIERPTSBvYmplY3QgaGFzIGEgSlMgd3JhcHBlci4K ICAgICAgICAgc3RhdGljIGJvb2wgZG9tT2JqZWN0SGFzSlNXcmFwcGVyKHZvaWQqKTsKKyAgICAg ICAgLy8gR2V0IEpTIHdyYXBwZXIgb2YgYW4gZXhpc3RpbmcgRE9NIG9iamVjdCwgYXNzdW1pbmcg dGhhdCB0aGUgd3JhcHBlcgorICAgICAgICAvLyBleGlzdHMuCisgICAgICAgIHN0YXRpYyB2ODo6 UGVyc2lzdGVudDx2ODo6T2JqZWN0PiBqc1dyYXBwZXJGb3JET01PYmplY3Qodm9pZCopOwogICAg ICAgICAvLyBTZXQgSlMgd3JhcHBlciBvZiBhIERPTSBvYmplY3QsIHRoZSBjYWxsZXIgaW4gY2hh cmdlIG9mIGluY3JlYXNlIHJlZi4KICAgICAgICAgc3RhdGljIHZvaWQgc2V0SlNXcmFwcGVyRm9y RE9NT2JqZWN0KHZvaWQqLCB2ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0Pik7CiAgICAgICAgIHN0 YXRpYyB2b2lkIHNldEpTV3JhcHBlckZvckFjdGl2ZURPTU9iamVjdCh2b2lkKiwgdjg6OlBlcnNp c3RlbnQ8djg6Ok9iamVjdD4pOw== 42120 2009-10-29 11:46:30 -0700 2009-10-29 12:25:52 -0700 Fixerate random crashes, v2. bug-30919-20091029114628.patch text/plain 4230 dglazkov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTcyNzA4OS4uYmM5YTYxYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAwOS0xMC0yOSAgRGltaXRyaSBHbGF6 a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtWOF0gUmVtb3ZlIHJhbmRvbSBjcmFzaGVzIGJ5IHJlbW92 aW5nIHJldHJpZXZhbCBvZiBWOCBjb250ZXh0IGR1cmluZyBnYXJiYWdlIGNvbGxlY3Rpb24uCisK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwOTE5CisK KyAgICAgICAgVW5mb3J0dW5hdGVseSwgSSBoYXZlbid0IGJlZW4gYWJsZSB0byB0cmlnZ2VyIHRo aXMgY3Jhc2ggZXhwbGljaXRseSwgc28gbm8gdGVzdCA6KC4KKworICAgICAgICAqIGJpbmRpbmdz L3Y4L1Y4RE9NV3JhcHBlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOERPTVdyYXBwZXI6Ompz V3JhcHBlckZvckRPTU9iamVjdCk6IEFkZGVkIG5ldyAiYXNzdW1lLWl0J3MtdGhlcmUiIGdldHRl ci4KKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuaDogQWRkZWQgZ2V0dGVyIGRl Y2wuCisgICAgICAgICogYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6R0NQcm9sb2d1ZVZpc2l0b3I6OnZpc2l0RE9NV3JhcHBlcik6IENoYW5nZWQgdG8g dXNlIGV4cGxpY2l0IGdldHRlci4KKwogMjAwOS0xMC0yNyAgQ2hyaXMgRmxlaXphY2ggIDxjZmxl aXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuY3BwIGIvV2ViQ29yZS9i aW5kaW5ncy92OC9WOERPTVdyYXBwZXIuY3BwCmluZGV4IDMyMTE1M2QuLmYzYjUzZjQgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcAorKysgYi9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAKQEAgLTE1NCw2ICsxNTQsMTYgQEAgYm9vbCBW OERPTVdyYXBwZXI6OmRvbU9iamVjdEhhc0pTV3JhcHBlcih2b2lkKiBvYmplY3QpCiAgICAgcmV0 dXJuIGdldERPTU9iamVjdE1hcCgpLmNvbnRhaW5zKG9iamVjdCkgfHwgZ2V0QWN0aXZlRE9NT2Jq ZWN0TWFwKCkuY29udGFpbnMob2JqZWN0KTsKIH0KIAordjg6OlBlcnNpc3RlbnQ8djg6Ok9iamVj dD4gVjhET01XcmFwcGVyOjpqc1dyYXBwZXJGb3JET01PYmplY3Qodm9pZCogb2JqZWN0KQorewor ICAgIHY4OjpQZXJzaXN0ZW50PHY4OjpPYmplY3Q+IHdyYXBwZXIgPSBnZXRET01PYmplY3RNYXAo KS5nZXQob2JqZWN0KTsKKyAgICBpZiAoIXdyYXBwZXIuSXNFbXB0eSgpKQorICAgICAgICByZXR1 cm4gd3JhcHBlcjsKKyAgICB3cmFwcGVyID0gZ2V0QWN0aXZlRE9NT2JqZWN0TWFwKCkuZ2V0KG9i amVjdCk7CisgICAgQVNTRVJUKCF3cmFwcGVyLklzRW1wdHkoKSk7CisgICAgcmV0dXJuIHdyYXBw ZXI7Cit9CisKIC8vIFRoZSBjYWxsZXIgbXVzdCBoYXZlIGluY3JlYXNlZCBvYmoncyByZWYgY291 bnQuCiB2b2lkIFY4RE9NV3JhcHBlcjo6c2V0SlNXcmFwcGVyRm9yRE9NT2JqZWN0KHZvaWQqIG9i amVjdCwgdjg6OlBlcnNpc3RlbnQ8djg6Ok9iamVjdD4gd3JhcHBlcikKIHsKZGlmZiAtLWdpdCBh L1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmggYi9XZWJDb3JlL2JpbmRpbmdzL3Y4 L1Y4RE9NV3JhcHBlci5oCmluZGV4IDIyN2M5ZmYuLmFmMmU2MmUgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmgKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9W OERPTVdyYXBwZXIuaApAQCAtMjc5LDYgKzI3OSw5IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAog ICAgICAgICAvLyBDaGVja3Mgd2hldGhlciBhIERPTSBvYmplY3QgaGFzIGEgSlMgd3JhcHBlci4K ICAgICAgICAgc3RhdGljIGJvb2wgZG9tT2JqZWN0SGFzSlNXcmFwcGVyKHZvaWQqKTsKKyAgICAg ICAgLy8gR2V0IEpTIHdyYXBwZXIgb2YgYW4gZXhpc3RpbmcgRE9NIG9iamVjdCwgYXNzdW1pbmcg dGhhdCB0aGUgd3JhcHBlcgorICAgICAgICAvLyBleGlzdHMuCisgICAgICAgIHN0YXRpYyB2ODo6 UGVyc2lzdGVudDx2ODo6T2JqZWN0PiBqc1dyYXBwZXJGb3JET01PYmplY3Qodm9pZCopOwogICAg ICAgICAvLyBTZXQgSlMgd3JhcHBlciBvZiBhIERPTSBvYmplY3QsIHRoZSBjYWxsZXIgaW4gY2hh cmdlIG9mIGluY3JlYXNlIHJlZi4KICAgICAgICAgc3RhdGljIHZvaWQgc2V0SlNXcmFwcGVyRm9y RE9NT2JqZWN0KHZvaWQqLCB2ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0Pik7CiAgICAgICAgIHN0 YXRpYyB2b2lkIHNldEpTV3JhcHBlckZvckFjdGl2ZURPTU9iamVjdCh2b2lkKiwgdjg6OlBlcnNp c3RlbnQ8djg6Ok9iamVjdD4pOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEdD Q29udHJvbGxlci5jcHAgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNwcApp bmRleCA4ZmU0YmUxLi4zY2MxNWQ3IDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4 R0NDb250cm9sbGVyLmNwcAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVy LmNwcApAQCAtMjE4LDggKzIxOCw4IEBAIHB1YmxpYzoKICAgICAgICAgICAgIC8vIEFzIHBvcnRz IGFyZSBhbHdheXMgZW50YW5nbGVkIGluIHBhaXJzIG9ubHkgcGVyZm9ybSB0aGUgZW50YW5nbGVt ZW50CiAgICAgICAgICAgICAvLyBvbmNlIGZvciBlYWNoIHBhaXIgKHNlZSBBU1NFUlQgaW4gTWVz c2FnZVBvcnQ6OnVuZW50YW5nbGUoKSkuCiAgICAgICAgICAgICBpZiAocG9ydDEgPCBwb3J0Mikg ewotICAgICAgICAgICAgICAgIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBwb3J0MVdyYXBwZXIgPSBW OERPTVdyYXBwZXI6OmNvbnZlcnRUb1Y4T2JqZWN0KFY4Q2xhc3NJbmRleDo6TUVTU0FHRVBPUlQs IHBvcnQxKTsKLSAgICAgICAgICAgICAgICB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gcG9ydDJXcmFw cGVyID0gVjhET01XcmFwcGVyOjpjb252ZXJ0VG9WOE9iamVjdChWOENsYXNzSW5kZXg6Ok1FU1NB R0VQT1JULCBwb3J0Mik7CisgICAgICAgICAgICAgICAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IHBv cnQxV3JhcHBlciA9IFY4RE9NV3JhcHBlcjo6anNXcmFwcGVyRm9yRE9NT2JqZWN0KHBvcnQxKTsK KyAgICAgICAgICAgICAgICB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gcG9ydDJXcmFwcGVyID0gVjhE T01XcmFwcGVyOjpqc1dyYXBwZXJGb3JET01PYmplY3QocG9ydDIpOwogICAgICAgICAgICAgICAg IEFTU0VSVChwb3J0MVdyYXBwZXItPklzT2JqZWN0KCkpOwogICAgICAgICAgICAgICAgIHY4OjpI YW5kbGU8djg6Ok9iamVjdD46OkNhc3QocG9ydDFXcmFwcGVyKS0+U2V0SW50ZXJuYWxGaWVsZChW OEN1c3RvbTo6a01lc3NhZ2VQb3J0RW50YW5nbGVkUG9ydEluZGV4LCBwb3J0MldyYXBwZXIpOwog ICAgICAgICAgICAgICAgIEFTU0VSVChwb3J0MldyYXBwZXItPklzT2JqZWN0KCkpOwpAQCAtMjI4 LDcgKzIyOCw3IEBAIHB1YmxpYzoKICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgIC8vIFJl bW92ZSB0aGUgd3JhcHBlciBlbnRhbmdsZW1lbnQgd2hlbiBhIHBvcnQgaXMgbm90IGVudGFuZ2xl ZC4KICAgICAgICAgICAgIGlmIChWOERPTVdyYXBwZXI6OmRvbU9iamVjdEhhc0pTV3JhcHBlcihw b3J0MSkpIHsKLSAgICAgICAgICAgICAgICB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gd3JhcHBlciA9 IFY4RE9NV3JhcHBlcjo6Y29udmVydFRvVjhPYmplY3QoVjhDbGFzc0luZGV4OjpNRVNTQUdFUE9S VCwgcG9ydDEpOworICAgICAgICAgICAgICAgIHY4OjpIYW5kbGU8djg6OlZhbHVlPiB3cmFwcGVy ID0gVjhET01XcmFwcGVyOjpqc1dyYXBwZXJGb3JET01PYmplY3QocG9ydDEpOwogICAgICAgICAg ICAgICAgIEFTU0VSVCh3cmFwcGVyLT5Jc09iamVjdCgpKTsKICAgICAgICAgICAgICAgICB2ODo6 SGFuZGxlPHY4OjpPYmplY3Q+OjpDYXN0KHdyYXBwZXIpLT5TZXRJbnRlcm5hbEZpZWxkKFY4Q3Vz dG9tOjprTWVzc2FnZVBvcnRFbnRhbmdsZWRQb3J0SW5kZXgsIHY4OjpVbmRlZmluZWQoKSk7CiAg ICAgICAgICAgICB9 42124 2009-10-29 12:25:56 -0700 2009-12-28 23:00:48 -0800 Fixerate random crashes, v3. bug-30919-20091029122554.patch text/plain 4447 dglazkov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTcyNzA4OS4uYmM5YTYxYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAwOS0xMC0yOSAgRGltaXRyaSBHbGF6 a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtWOF0gUmVtb3ZlIHJhbmRvbSBjcmFzaGVzIGJ5IHJlbW92 aW5nIHJldHJpZXZhbCBvZiBWOCBjb250ZXh0IGR1cmluZyBnYXJiYWdlIGNvbGxlY3Rpb24uCisK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwOTE5CisK KyAgICAgICAgVW5mb3J0dW5hdGVseSwgSSBoYXZlbid0IGJlZW4gYWJsZSB0byB0cmlnZ2VyIHRo aXMgY3Jhc2ggZXhwbGljaXRseSwgc28gbm8gdGVzdCA6KC4KKworICAgICAgICAqIGJpbmRpbmdz L3Y4L1Y4RE9NV3JhcHBlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOERPTVdyYXBwZXI6Ompz V3JhcHBlckZvckRPTU9iamVjdCk6IEFkZGVkIG5ldyAiYXNzdW1lLWl0J3MtdGhlcmUiIGdldHRl ci4KKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuaDogQWRkZWQgZ2V0dGVyIGRl Y2wuCisgICAgICAgICogYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6R0NQcm9sb2d1ZVZpc2l0b3I6OnZpc2l0RE9NV3JhcHBlcik6IENoYW5nZWQgdG8g dXNlIGV4cGxpY2l0IGdldHRlci4KKwogMjAwOS0xMC0yNyAgQ2hyaXMgRmxlaXphY2ggIDxjZmxl aXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuY3BwIGIvV2ViQ29yZS9i aW5kaW5ncy92OC9WOERPTVdyYXBwZXIuY3BwCmluZGV4IDMyMTE1M2QuLmNmMDVmNTMgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcAorKysgYi9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAKQEAgLTE1NCw2ICsxNTQsMjAgQEAgYm9vbCBW OERPTVdyYXBwZXI6OmRvbU9iamVjdEhhc0pTV3JhcHBlcih2b2lkKiBvYmplY3QpCiAgICAgcmV0 dXJuIGdldERPTU9iamVjdE1hcCgpLmNvbnRhaW5zKG9iamVjdCkgfHwgZ2V0QWN0aXZlRE9NT2Jq ZWN0TWFwKCkuY29udGFpbnMob2JqZWN0KTsKIH0KIAordjg6OlBlcnNpc3RlbnQ8djg6Ok9iamVj dD4gVjhET01XcmFwcGVyOjpqc1dyYXBwZXJGb3JET01PYmplY3Qodm9pZCogb2JqZWN0KQorewor ICAgIHY4OjpQZXJzaXN0ZW50PHY4OjpPYmplY3Q+IHdyYXBwZXIgPSBnZXRET01PYmplY3RNYXAo KS5nZXQob2JqZWN0KTsKKyAgICBBU1NFUlQoIXdyYXBwZXIuSXNFbXB0eSgpKTsKKyAgICByZXR1 cm4gd3JhcHBlcjsKK30KKwordjg6OlBlcnNpc3RlbnQ8djg6Ok9iamVjdD4gVjhET01XcmFwcGVy Ojpqc1dyYXBwZXJGb3JBY3RpdmVET01PYmplY3Qodm9pZCogb2JqZWN0KQoreworICAgIHY4OjpQ ZXJzaXN0ZW50PHY4OjpPYmplY3Q+IHdyYXBwZXIgPSBnZXRBY3RpdmVET01PYmplY3RNYXAoKS5n ZXQob2JqZWN0KTsKKyAgICBBU1NFUlQoIXdyYXBwZXIuSXNFbXB0eSgpKTsKKyAgICByZXR1cm4g d3JhcHBlcjsKK30KKwogLy8gVGhlIGNhbGxlciBtdXN0IGhhdmUgaW5jcmVhc2VkIG9iaidzIHJl ZiBjb3VudC4KIHZvaWQgVjhET01XcmFwcGVyOjpzZXRKU1dyYXBwZXJGb3JET01PYmplY3Qodm9p ZCogb2JqZWN0LCB2ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0PiB3cmFwcGVyKQogewpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuaCBiL1dlYkNvcmUvYmluZGlu Z3MvdjgvVjhET01XcmFwcGVyLmgKaW5kZXggMjI3YzlmZi4uMmI5MzljOCAxMDA2NDQKLS0tIGEv V2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuaAorKysgYi9XZWJDb3JlL2JpbmRpbmdz L3Y4L1Y4RE9NV3JhcHBlci5oCkBAIC0yNzksNiArMjc5LDEwIEBAIG5hbWVzcGFjZSBXZWJDb3Jl IHsKIAogICAgICAgICAvLyBDaGVja3Mgd2hldGhlciBhIERPTSBvYmplY3QgaGFzIGEgSlMgd3Jh cHBlci4KICAgICAgICAgc3RhdGljIGJvb2wgZG9tT2JqZWN0SGFzSlNXcmFwcGVyKHZvaWQqKTsK KyAgICAgICAgLy8gR2V0IEpTIHdyYXBwZXIgb2YgYW4gZXhpc3RpbmcgRE9NIG9iamVjdCwgYXNz dW1pbmcgdGhhdCB0aGUgd3JhcHBlcgorICAgICAgICAvLyBleGlzdHMuCisgICAgICAgIHN0YXRp YyB2ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0PiBqc1dyYXBwZXJGb3JET01PYmplY3Qodm9pZCop OworICAgICAgICBzdGF0aWMgdjg6OlBlcnNpc3RlbnQ8djg6Ok9iamVjdD4ganNXcmFwcGVyRm9y QWN0aXZlRE9NT2JqZWN0KHZvaWQqKTsKICAgICAgICAgLy8gU2V0IEpTIHdyYXBwZXIgb2YgYSBE T00gb2JqZWN0LCB0aGUgY2FsbGVyIGluIGNoYXJnZSBvZiBpbmNyZWFzZSByZWYuCiAgICAgICAg IHN0YXRpYyB2b2lkIHNldEpTV3JhcHBlckZvckRPTU9iamVjdCh2b2lkKiwgdjg6OlBlcnNpc3Rl bnQ8djg6Ok9iamVjdD4pOwogICAgICAgICBzdGF0aWMgdm9pZCBzZXRKU1dyYXBwZXJGb3JBY3Rp dmVET01PYmplY3Qodm9pZCosIHY4OjpQZXJzaXN0ZW50PHY4OjpPYmplY3Q+KTsKZGlmZiAtLWdp dCBhL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3BwIGIvV2ViQ29yZS9iaW5k aW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHAKaW5kZXggOGZlNGJlMS4uYTFkYzgxOSAxMDA2NDQK LS0tIGEvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHAKKysrIGIvV2ViQ29y ZS9iaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHAKQEAgLTIxOCw4ICsyMTgsOCBAQCBwdWJs aWM6CiAgICAgICAgICAgICAvLyBBcyBwb3J0cyBhcmUgYWx3YXlzIGVudGFuZ2xlZCBpbiBwYWly cyBvbmx5IHBlcmZvcm0gdGhlIGVudGFuZ2xlbWVudAogICAgICAgICAgICAgLy8gb25jZSBmb3Ig ZWFjaCBwYWlyIChzZWUgQVNTRVJUIGluIE1lc3NhZ2VQb3J0Ojp1bmVudGFuZ2xlKCkpLgogICAg ICAgICAgICAgaWYgKHBvcnQxIDwgcG9ydDIpIHsKLSAgICAgICAgICAgICAgICB2ODo6SGFuZGxl PHY4OjpWYWx1ZT4gcG9ydDFXcmFwcGVyID0gVjhET01XcmFwcGVyOjpjb252ZXJ0VG9WOE9iamVj dChWOENsYXNzSW5kZXg6Ok1FU1NBR0VQT1JULCBwb3J0MSk7Ci0gICAgICAgICAgICAgICAgdjg6 OkhhbmRsZTx2ODo6VmFsdWU+IHBvcnQyV3JhcHBlciA9IFY4RE9NV3JhcHBlcjo6Y29udmVydFRv VjhPYmplY3QoVjhDbGFzc0luZGV4OjpNRVNTQUdFUE9SVCwgcG9ydDIpOworICAgICAgICAgICAg ICAgIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBwb3J0MVdyYXBwZXIgPSBWOERPTVdyYXBwZXI6Ompz V3JhcHBlckZvckFjdGl2ZURPTU9iamVjdChwb3J0MSk7CisgICAgICAgICAgICAgICAgdjg6Okhh bmRsZTx2ODo6VmFsdWU+IHBvcnQyV3JhcHBlciA9IFY4RE9NV3JhcHBlcjo6anNXcmFwcGVyRm9y QWN0aXZlRE9NT2JqZWN0KHBvcnQyKTsKICAgICAgICAgICAgICAgICBBU1NFUlQocG9ydDFXcmFw cGVyLT5Jc09iamVjdCgpKTsKICAgICAgICAgICAgICAgICB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+ OjpDYXN0KHBvcnQxV3JhcHBlciktPlNldEludGVybmFsRmllbGQoVjhDdXN0b206OmtNZXNzYWdl UG9ydEVudGFuZ2xlZFBvcnRJbmRleCwgcG9ydDJXcmFwcGVyKTsKICAgICAgICAgICAgICAgICBB U1NFUlQocG9ydDJXcmFwcGVyLT5Jc09iamVjdCgpKTsKQEAgLTIyOCw3ICsyMjgsNyBAQCBwdWJs aWM6CiAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICAvLyBSZW1vdmUgdGhlIHdyYXBwZXIg ZW50YW5nbGVtZW50IHdoZW4gYSBwb3J0IGlzIG5vdCBlbnRhbmdsZWQuCiAgICAgICAgICAgICBp ZiAoVjhET01XcmFwcGVyOjpkb21PYmplY3RIYXNKU1dyYXBwZXIocG9ydDEpKSB7Ci0gICAgICAg ICAgICAgICAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IHdyYXBwZXIgPSBWOERPTVdyYXBwZXI6OmNv bnZlcnRUb1Y4T2JqZWN0KFY4Q2xhc3NJbmRleDo6TUVTU0FHRVBPUlQsIHBvcnQxKTsKKyAgICAg ICAgICAgICAgICB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gd3JhcHBlciA9IFY4RE9NV3JhcHBlcjo6 anNXcmFwcGVyRm9yQWN0aXZlRE9NT2JqZWN0KHBvcnQxKTsKICAgICAgICAgICAgICAgICBBU1NF UlQod3JhcHBlci0+SXNPYmplY3QoKSk7CiAgICAgICAgICAgICAgICAgdjg6OkhhbmRsZTx2ODo6 T2JqZWN0Pjo6Q2FzdCh3cmFwcGVyKS0+U2V0SW50ZXJuYWxGaWVsZChWOEN1c3RvbTo6a01lc3Nh Z2VQb3J0RW50YW5nbGVkUG9ydEluZGV4LCB2ODo6VW5kZWZpbmVkKCkpOwogICAgICAgICAgICAg fQ==