30908 2009-10-29 08:43:20 -0700 [GTK] Spell Check Suggestions (Do not work) 2009-12-27 10:20:21 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 pyther webkit-unassigned christian dev eric evan webkit.review.bot oldest_to_newest 158910 0 pyther 2009-10-29 08:43:20 -0700 Currently I am using midori-git with webkit 1.1.15.3. I am also compiling the nightly build, r50235, as I am posting this. However, I doubt this build will solve the issue, as the issue has existed for at least a year now. Currently, misspelled words are underline with a red squiggly line. If you right click on the word a menu shows up with undo, redo, cut, copy paste, select all, spelling + grammar, and input methods. If I highlight/select the word and right click, I get the menu I just described with spelling suggestions at the top. However, any selection I pick will cause the highlighted word to get deleted. Let me know if you need any additional information and if there is anyway I can help resolve the issue. Thank you! 169935 1 dev 2009-12-09 01:09:09 -0800 I confirm this issue. Choosing a suggestion results in the string being removed without the suggestion appearing. I furthermore want to add that I find it very confusing that I have to mark the whole word first. From other browsers, namely the gecko engine, I'm used to just right-clicking a red underlined word to get suggestions immediately. I would prefer this way a lot, right now the spell check suggestions are just not usable at all. 173505 2 45232 christian 2009-12-19 03:52:35 -0800 Created attachment 45232 Implement 'title' in ContextMenuItemGtk 173506 3 webkit.review.bot 2009-12-19 03:55:11 -0800 style-queue ran check-webkit-style on attachment 45232 without any errors. 173522 4 pyther 2009-12-19 08:05:08 -0800 I compiled the patch against the nightly 52242 tarball and it works wonderfully! Thank you so much! 174451 5 eric 2009-12-22 15:54:48 -0800 Looks OK to me. 174568 6 evan 2009-12-23 04:19:59 -0800 (In reply to comment #1) > I confirm this issue. Choosing a suggestion results in the string being removed > without the suggestion appearing. I furthermore want to add that I find it very > confusing that I have to mark the whole word first. From other browsers, namely > the gecko engine, I'm used to just right-clicking a red underlined word to get > suggestions immediately. I would prefer this way a lot, right now the spell > check suggestions are just not usable at all. The right click bug is this one: https://bugs.webkit.org/show_bug.cgi?id=32770 175050 7 christian 2009-12-27 10:20:21 -0800 2009-12-27 Christian Dywan <christian@twotoasts.de> Reviewed by Eric Seidel. [GTK] Spell Check Suggestions (Do not work) https://bugs.webkit.org/show_bug.cgi?id=30908 * platform/gtk/ContextMenuItemGtk.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::setTitle): Implement the 'title' member and set the title from the native menu item. 45232 2009-12-19 03:52:35 -0800 2009-12-22 15:56:02 -0800 Implement 'title' in ContextMenuItemGtk fixspellsuggest.diff text/plain 2074 christian ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzRhY2UwMi4uODgwMmU4YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0xMi0xOSAgQ2hyaXN0aWFuIER5 d2FuICA8Y2hyaXN0aWFuQHR3b3RvYXN0cy5kZT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBTcGVsbCBDaGVjayBTdWdnZXN0aW9ucyAoRG8g bm90IHdvcmspCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zMDkwOAorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL0NvbnRleHRNZW51SXRlbUd0ay5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpDb250ZXh0TWVudUl0ZW06OkNvbnRleHRNZW51SXRlbSk6Cisg ICAgICAgIChXZWJDb3JlOjpDb250ZXh0TWVudUl0ZW06OnRpdGxlKToKKyAgICAgICAgKFdlYkNv cmU6OkNvbnRleHRNZW51SXRlbTo6c2V0VGl0bGUpOiBJbXBsZW1lbnQgdGhlICd0aXRsZScgbWVt YmVyCisgICAgICAgIGFuZCBzZXQgdGhlIHRpdGxlIGZyb20gdGhlIG5hdGl2ZSBtZW51IGl0ZW0u CisKIDIwMDktMTItMTggIFBldGVyIEthc3RpbmcgIDxwa2FzdGluZ0Bnb29nbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxh dGZvcm0vZ3RrL0NvbnRleHRNZW51SXRlbUd0ay5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2d0ay9D b250ZXh0TWVudUl0ZW1HdGsuY3BwCmluZGV4IGFhZWMyMDYuLjJmNzM1MDYgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0NvbnRleHRNZW51SXRlbUd0ay5jcHAKKysrIGIvV2ViQ29y ZS9wbGF0Zm9ybS9ndGsvQ29udGV4dE1lbnVJdGVtR3RrLmNwcApAQCAtMTE3LDYgKzExNywxMiBA QCBDb250ZXh0TWVudUl0ZW06OkNvbnRleHRNZW51SXRlbShHdGtNZW51SXRlbSogaXRlbSkKICAg ICAgICAgbV9wbGF0Zm9ybURlc2NyaXB0aW9uLmNoZWNrZWQgPSBndGtfY2hlY2tfbWVudV9pdGVt X2dldF9hY3RpdmUoR1RLX0NIRUNLX01FTlVfSVRFTShpdGVtKSk7CiAgICAgfSBlbHNlCiAgICAg ICAgIG1fcGxhdGZvcm1EZXNjcmlwdGlvbi50eXBlID0gQWN0aW9uVHlwZTsKKyNpZiBHVEtfQ0hF Q0tfVkVSU0lPTiAoMiwgMTYsIDApCisgICAgbV9wbGF0Zm9ybURlc2NyaXB0aW9uLnRpdGxlID0g U3RyaW5nOjpmcm9tVVRGOChndGtfbWVudV9pdGVtX2dldF9sYWJlbChHVEtfTUVOVV9JVEVNKGl0 ZW0pKSk7CisjZWxzZQorICAgIEd0a1dpZGdldCogbGFiZWwgPSBndGtfYmluX2dldF9jaGlsZChH VEtfQklOKGl0ZW0pKTsKKyAgICBtX3BsYXRmb3JtRGVzY3JpcHRpb24udGl0bGUgPSBTdHJpbmc6 OmZyb21VVEY4KGd0a19sYWJlbF9nZXRfbGFiZWwoR1RLX0xBQkVMKGxhYmVsKSkpOworI2VuZGlm CiAKICAgICBtX3BsYXRmb3JtRGVzY3JpcHRpb24uYWN0aW9uID0gKnN0YXRpY19jYXN0PENvbnRl eHRNZW51QWN0aW9uKj4oZ19vYmplY3RfZ2V0X2RhdGEoR19PQkpFQ1QoaXRlbSksIFdFQktJVF9D T05URVhUX01FTlVfQUNUSU9OKSk7CiAKQEAgLTIwNSwxMyArMjExLDEyIEBAIHZvaWQgQ29udGV4 dE1lbnVJdGVtOjpzZXRBY3Rpb24oQ29udGV4dE1lbnVBY3Rpb24gYWN0aW9uKQogCiBTdHJpbmcg Q29udGV4dE1lbnVJdGVtOjp0aXRsZSgpIGNvbnN0CiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsK LSAgICByZXR1cm4gU3RyaW5nKCk7CisgICAgcmV0dXJuIG1fcGxhdGZvcm1EZXNjcmlwdGlvbi50 aXRsZTsKIH0KIAotdm9pZCBDb250ZXh0TWVudUl0ZW06OnNldFRpdGxlKGNvbnN0IFN0cmluZyYp Cit2b2lkIENvbnRleHRNZW51SXRlbTo6c2V0VGl0bGUoY29uc3QgU3RyaW5nJiB0aXRsZSkKIHsK LSAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIG1fcGxhdGZvcm1EZXNjcmlwdGlvbi50aXRsZSA9 IHRpdGxlOwogfQogCiBQbGF0Zm9ybU1lbnVEZXNjcmlwdGlvbiBDb250ZXh0TWVudUl0ZW06OnBs YXRmb3JtU3ViTWVudSgpIGNvbnN0Cg==