30906 2009-10-29 07:58:21 -0700 [V8] Out-of-memory crash in isolated worlds 2009-10-29 23:53:07 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned commit-queue oldest_to_newest 158894 0 abarth 2009-10-29 07:58:21 -0700 ---------------------------- * Crash Trace * ---------------------------- [api.cc:435] - v8::Context::Enter() [v8isolatedworld.cpp:63] - WebCore::V8IsolatedWorld::V8IsolatedWorld(WebCore::V8Proxy *,int) [v8proxy.cpp:286] - WebCore::V8Proxy::evaluateInIsolatedWorld(int,WTF::Vector const &,int) [webframe_impl.cc:644] - WebFrameImpl::executeScriptInIsolatedWorld(int,WebKit::WebScriptSource const *,unsigned int,int) [user_script_slave.cc:192] - UserScriptSlave::InjectScripts(WebKit::WebFrame *,UserScript::RunLocation) [render_view.cc:2232] - RenderView::didFinishDocumentLoad(WebKit::WebFrame *) [webframeloaderclient_impl.cc:312] - WebFrameLoaderClient::dispatchDidFinishDocumentLoad() [frameloader.cpp:1044] - WebCore::FrameLoader::finishedParsing() [frameloader.cpp:544] - WebCore::FrameLoader::stopLoading(WebCore::UnloadEventPolicy,WebCore::DatabasePolicy) [documentloader.cpp:276] - WebCore::DocumentLoader::stopLoading(WebCore::DatabasePolicy) [frameloader.cpp:2235] - WebCore::FrameLoader::stopAllLoaders(WebCore::DatabasePolicy) [frameloader.cpp:3069] - WebCore::FrameLoader::frameDetached() [htmlframeownerelement.cpp:45] - WebCore::HTMLFrameOwnerElement::willRemove() [containernode.cpp:282] - WebCore::ContainerNode::willRemove() [containernode.cpp:296] - WebCore::willRemoveChild [containernode.cpp:323] - WebCore::ContainerNode::removeChild(WebCore::Node *,int &) [containernode.cpp:192] - WebCore::ContainerNode::replaceChild(WTF::PassRefPtr,WebCore::Node *,int &,bool) [v8htmlelement.cpp:214] - WebCore::HTMLElementInternal::outerHTMLAttrSetter 158896 1 42099 abarth 2009-10-29 08:01:31 -0700 Created attachment 42099 Patch v1 158912 2 42099 abarth 2009-10-29 08:44:25 -0700 Comment on attachment 42099 Patch v1 This patch leaks the isolated world object. 158914 3 42103 abarth 2009-10-29 08:47:17 -0700 Created attachment 42103 Patch v1 158991 4 42103 dglazkov 2009-10-29 11:45:31 -0700 Comment on attachment 42103 Patch v1 r=me. 159001 5 42103 abarth 2009-10-29 12:03:05 -0700 Comment on attachment 42103 Patch v1 Time to break the build! 159003 6 42103 eric 2009-10-29 12:06:37 -0700 Comment on attachment 42103 Patch v1 Can we make world a smart pointer (like OwnPtr) instead of using manual delete? 159008 7 abarth 2009-10-29 12:16:15 -0700 (In reply to comment #6) > (From update of attachment 42103 [details]) > Can we make world a smart pointer (like OwnPtr) instead of using manual delete? The problem is that it's lifetime is managed by the V8 GC. We manually delete it here because if we never create the context, we can't transfer ownership to V8. 159029 8 42103 commit-queue 2009-10-29 13:15:27 -0700 Comment on attachment 42103 Patch v1 Clearing flags on attachment: 42103 Committed r50296: <http://trac.webkit.org/changeset/50296> 159030 9 commit-queue 2009-10-29 13:15:39 -0700 All reviewed patches have been landed. Closing bug. 159041 10 abarth 2009-10-29 13:33:22 -0700 Committed r50299: <http://trac.webkit.org/changeset/50299> 159234 11 abarth 2009-10-29 23:53:07 -0700 http://trac.webkit.org/changeset/50319 42099 2009-10-29 08:01:31 -0700 2009-10-29 08:46:50 -0700 Patch v1 bug-30906-20091029080130.patch text/plain 3125 abarth PyAgICAgICBodWJidWIucGF0Y2gKPyAgICAgICB0dHQKPyAgICAgICBXZWJLaXQvd2luL1dlYlZp ZXcuY3BwLm9yaWcKPyAgICAgICBXZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbS5vcmlnCj8g ICAgICAgV2ViQ29yZS9XZWJDb3JlLmd5cGkub3JpZwo/ICAgICAgIFdlYkNvcmUvR05VbWFrZWZp bGUuYW0ub3JpZwo/ICAgICAgIFdlYkNvcmUvcGFnZS9QYWdlLmNwcC5vcmlnCj8gICAgICAgV2Vi Q29yZS9XZWJDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oub3JpZwpJbmRleDogV2ViQ29y ZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUw MjcwKQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwyMCBA QAorMjAwOS0xMC0yOSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtWOF0gT3V0LW9mLW1lbW9y eSBjcmFzaCBpbiBpc29sYXRlZCB3b3JsZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTMwOTA2CisKKyAgICAgICAgV2UgbmVlZCB0byBoYW5kbGUgdGhl IGZhY3QgdGhhdCBjcmVhdGluZyBhIFY4OkNvbnRleHQgbWlnaHQgZmFpbC4gIEkKKyAgICAgICAg ZG9uJ3Qga25vdyBob3cgdG8gdGVzdCB0aGlzIGNoYW5nZSBiZWNhdXNlIGNyZWF0aW5nIGEgY29u dGV4dCB1c3VhbGx5CisgICAgICAgIG9ubHkgZmFpbHMgd2hlbiBWOCBkZWNpZGVzIGl0J3MgdXNp bmcgdG9vIG11Y2ggbWVtb3J5LgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhJc29sYXRlZFdv cmxkLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4SXNvbGF0ZWRXb3JsZDo6VjhJc29sYXRlZFdv cmxkKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOFByb3h5LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlY4UHJveHk6OmV2YWx1YXRlSW5Jc29sYXRlZFdvcmxkKToKKyAgICAgICAgKFdlYkNvcmU6 OlY4UHJveHk6OmV2YWx1YXRlSW5OZXdDb250ZXh0KToKKwogMjAwOS0xMC0yOSAgR3VzdGF2byBO b3JvbmhhIFNpbHZhICA8Z3VzdGF2by5ub3JvbmhhQGNvbGxhYm9yYS5jby51az4KIAogICAgICAg ICBVbnJldmlld2VkLiBGaXhlcyBzdHlsZSBwcm9ibGVtcyBwb2ludGVkIG91dCBieSBFdmFuIE1h cnRpbi4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvVjhJc29sYXRlZFdvcmxkLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4SXNvbGF0ZWRXb3JsZC5jcHAJKHJldmlz aW9uIDUwMjcwKQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9WOElzb2xhdGVkV29ybGQuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC01OCw2ICs1OCw4IEBAIFY4SXNvbGF0ZWRXb3JsZDo6VjhJc29sYXRl ZFdvcmxkKFY4UHJveHkKIAogICAgIHY4OjpIYW5kbGVTY29wZSBzY29wZTsKICAgICBtX2NvbnRl eHQgPSBTaGFyZWRQZXJzaXN0ZW50PHY4OjpDb250ZXh0Pjo6Y3JlYXRlKHByb3h5LT5jcmVhdGVO ZXdDb250ZXh0KHY4OjpIYW5kbGU8djg6Ok9iamVjdD4oKSwgZXh0ZW5zaW9uR3JvdXApKTsKKyAg ICBpZiAobV9jb250ZXh0LklzRW1wdHkoKSkKKyAgICAgICAgcmV0dXJuOwogCiAgICAgLy8gUnVu IGNvZGUgaW4gdGhlIG5ldyBjb250ZXh0LgogICAgIHY4OjpDb250ZXh0OjpTY29wZSBjb250ZXh0 X3Njb3BlKG1fY29udGV4dC0+Z2V0KCkpOwpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy92OC9WOFBy b3h5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuY3BwCShy ZXZpc2lvbiA1MDI3MCkKKysrIFdlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTI4Miw2ICsyODIsOSBAQCB2b2lkIFY4UHJveHk6OmV2YWx1YXRlSW5Jc29s YXRlZFdvcmxkKGluCiAgICAgICAgICAgICB3b3JsZCA9IGl0ZXItPnNlY29uZDsKICAgICAgICAg fSBlbHNlIHsKICAgICAgICAgICAgIHdvcmxkID0gbmV3IFY4SXNvbGF0ZWRXb3JsZCh0aGlzLCBl eHRlbnNpb25Hcm91cCk7CisgICAgICAgICAgICBpZiAod29ybGQtPmNvbnRleHQoKS0+SXNFbXB0 eSgpKQorICAgICAgICAgICAgICAgIHJldHVybjsKKwogICAgICAgICAgICAgbV9pc29sYXRlZFdv cmxkcy5zZXQod29ybGRJRCwgd29ybGQpOwogCiAgICAgICAgICAgICAvLyBTZXR1cCBjb250ZXh0 IGlkIGZvciBKUyBkZWJ1Z2dlci4KQEAgLTI4OSw2ICsyOTIsOCBAQCB2b2lkIFY4UHJveHk6OmV2 YWx1YXRlSW5Jc29sYXRlZFdvcmxkKGluCiAgICAgICAgIH0KICAgICB9IGVsc2UgewogICAgICAg ICB3b3JsZCA9IG5ldyBWOElzb2xhdGVkV29ybGQodGhpcywgZXh0ZW5zaW9uR3JvdXApOworICAg ICAgICBpZiAod29ybGQtPmNvbnRleHQoKS0+SXNFbXB0eSgpKQorICAgICAgICAgICAgcmV0dXJu OwogICAgIH0KIAogICAgIHY4OjpMb2NhbDx2ODo6Q29udGV4dD4gY29udGV4dCA9IHY4OjpMb2Nh bDx2ODo6Q29udGV4dD46Ok5ldyh3b3JsZC0+Y29udGV4dCgpKTsKQEAgLTMxNCw2ICszMTksOSBA QCB2b2lkIFY4UHJveHk6OmV2YWx1YXRlSW5OZXdDb250ZXh0KGNvbnN0CiAgICAgQVNTRVJUKFY4 RE9NV3JhcHBlcjo6Y29udmVydERPTVdyYXBwZXJUb05hdGl2ZTxET01XaW5kb3c+KHdpbmRvd1dy YXBwZXIpID09IG1fZnJhbWUtPmRvbVdpbmRvdygpKTsKIAogICAgIHY4OjpQZXJzaXN0ZW50PHY4 OjpDb250ZXh0PiBjb250ZXh0ID0gY3JlYXRlTmV3Q29udGV4dCh2ODo6SGFuZGxlPHY4OjpPYmpl Y3Q+KCksIGV4dGVuc2lvbkdyb3VwKTsKKyAgICBpZiAoY29udGV4dC5Jc0VtcHR5KCkpCisgICAg ICAgIHJldHVybjsKKwogICAgIHY4OjpDb250ZXh0OjpTY29wZSBjb250ZXh0U2NvcGUoY29udGV4 dCk7CiAKICAgICAvLyBTZXR1cCBjb250ZXh0IGlkIGZvciBKUyBkZWJ1Z2dlci4= 42103 2009-10-29 08:47:17 -0700 2009-10-29 13:15:26 -0700 Patch v1 bug-30906-20091029084715.patch text/plain 3213 abarth PyAgICAgICBodWJidWIucGF0Y2gKPyAgICAgICB0dHQKPyAgICAgICBXZWJLaXQvd2luL1dlYlZp ZXcuY3BwLm9yaWcKPyAgICAgICBXZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbS5vcmlnCj8g ICAgICAgV2ViQ29yZS9XZWJDb3JlLmd5cGkub3JpZwo/ICAgICAgIFdlYkNvcmUvR05VbWFrZWZp bGUuYW0ub3JpZwo/ICAgICAgIFdlYkNvcmUvcGFnZS9QYWdlLmNwcC5vcmlnCj8gICAgICAgV2Vi Q29yZS9XZWJDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oub3JpZwpJbmRleDogV2ViQ29y ZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUw MjcwKQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwyMCBA QAorMjAwOS0xMC0yOSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtWOF0gT3V0LW9mLW1lbW9y eSBjcmFzaCBpbiBpc29sYXRlZCB3b3JsZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTMwOTA2CisKKyAgICAgICAgV2UgbmVlZCB0byBoYW5kbGUgdGhl IGZhY3QgdGhhdCBjcmVhdGluZyBhIFY4OkNvbnRleHQgbWlnaHQgZmFpbC4gIEkKKyAgICAgICAg ZG9uJ3Qga25vdyBob3cgdG8gdGVzdCB0aGlzIGNoYW5nZSBiZWNhdXNlIGNyZWF0aW5nIGEgY29u dGV4dCB1c3VhbGx5CisgICAgICAgIG9ubHkgZmFpbHMgd2hlbiBWOCBkZWNpZGVzIGl0J3MgdXNp bmcgdG9vIG11Y2ggbWVtb3J5LgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhJc29sYXRlZFdv cmxkLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4SXNvbGF0ZWRXb3JsZDo6VjhJc29sYXRlZFdv cmxkKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOFByb3h5LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlY4UHJveHk6OmV2YWx1YXRlSW5Jc29sYXRlZFdvcmxkKToKKyAgICAgICAgKFdlYkNvcmU6 OlY4UHJveHk6OmV2YWx1YXRlSW5OZXdDb250ZXh0KToKKwogMjAwOS0xMC0yOSAgR3VzdGF2byBO b3JvbmhhIFNpbHZhICA8Z3VzdGF2by5ub3JvbmhhQGNvbGxhYm9yYS5jby51az4KIAogICAgICAg ICBVbnJldmlld2VkLiBGaXhlcyBzdHlsZSBwcm9ibGVtcyBwb2ludGVkIG91dCBieSBFdmFuIE1h cnRpbi4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvVjhJc29sYXRlZFdvcmxkLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4SXNvbGF0ZWRXb3JsZC5jcHAJKHJldmlz aW9uIDUwMjcwKQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9WOElzb2xhdGVkV29ybGQuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC01OCw2ICs1OCw4IEBAIFY4SXNvbGF0ZWRXb3JsZDo6VjhJc29sYXRl ZFdvcmxkKFY4UHJveHkKIAogICAgIHY4OjpIYW5kbGVTY29wZSBzY29wZTsKICAgICBtX2NvbnRl eHQgPSBTaGFyZWRQZXJzaXN0ZW50PHY4OjpDb250ZXh0Pjo6Y3JlYXRlKHByb3h5LT5jcmVhdGVO ZXdDb250ZXh0KHY4OjpIYW5kbGU8djg6Ok9iamVjdD4oKSwgZXh0ZW5zaW9uR3JvdXApKTsKKyAg ICBpZiAobV9jb250ZXh0LklzRW1wdHkoKSkKKyAgICAgICAgcmV0dXJuOwogCiAgICAgLy8gUnVu IGNvZGUgaW4gdGhlIG5ldyBjb250ZXh0LgogICAgIHY4OjpDb250ZXh0OjpTY29wZSBjb250ZXh0 X3Njb3BlKG1fY29udGV4dC0+Z2V0KCkpOwpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy92OC9WOFBy b3h5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuY3BwCShy ZXZpc2lvbiA1MDI3MCkKKysrIFdlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTI4Miw2ICsyODIsMTEgQEAgdm9pZCBWOFByb3h5OjpldmFsdWF0ZUluSXNv bGF0ZWRXb3JsZChpbgogICAgICAgICAgICAgd29ybGQgPSBpdGVyLT5zZWNvbmQ7CiAgICAgICAg IH0gZWxzZSB7CiAgICAgICAgICAgICB3b3JsZCA9IG5ldyBWOElzb2xhdGVkV29ybGQodGhpcywg ZXh0ZW5zaW9uR3JvdXApOworICAgICAgICAgICAgaWYgKHdvcmxkLT5jb250ZXh0KCkuSXNFbXB0 eSgpKSB7CisgICAgICAgICAgICAgICAgZGVsZXRlIHdvcmxkOworICAgICAgICAgICAgICAgIHJl dHVybjsKKyAgICAgICAgICAgIH0KKwogICAgICAgICAgICAgbV9pc29sYXRlZFdvcmxkcy5zZXQo d29ybGRJRCwgd29ybGQpOwogCiAgICAgICAgICAgICAvLyBTZXR1cCBjb250ZXh0IGlkIGZvciBK UyBkZWJ1Z2dlci4KQEAgLTI4OSw2ICsyOTQsMTAgQEAgdm9pZCBWOFByb3h5OjpldmFsdWF0ZUlu SXNvbGF0ZWRXb3JsZChpbgogICAgICAgICB9CiAgICAgfSBlbHNlIHsKICAgICAgICAgd29ybGQg PSBuZXcgVjhJc29sYXRlZFdvcmxkKHRoaXMsIGV4dGVuc2lvbkdyb3VwKTsKKyAgICAgICAgaWYg KHdvcmxkLT5jb250ZXh0KCkuSXNFbXB0eSgpKSB7CisgICAgICAgICAgICBkZWxldGUgd29ybGQ7 CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KICAgICB9CiAKICAgICB2ODo6TG9jYWw8 djg6OkNvbnRleHQ+IGNvbnRleHQgPSB2ODo6TG9jYWw8djg6OkNvbnRleHQ+OjpOZXcod29ybGQt PmNvbnRleHQoKSk7CkBAIC0zMTQsNiArMzIzLDkgQEAgdm9pZCBWOFByb3h5OjpldmFsdWF0ZUlu TmV3Q29udGV4dChjb25zdAogICAgIEFTU0VSVChWOERPTVdyYXBwZXI6OmNvbnZlcnRET01XcmFw cGVyVG9OYXRpdmU8RE9NV2luZG93Pih3aW5kb3dXcmFwcGVyKSA9PSBtX2ZyYW1lLT5kb21XaW5k b3coKSk7CiAKICAgICB2ODo6UGVyc2lzdGVudDx2ODo6Q29udGV4dD4gY29udGV4dCA9IGNyZWF0 ZU5ld0NvbnRleHQodjg6OkhhbmRsZTx2ODo6T2JqZWN0PigpLCBleHRlbnNpb25Hcm91cCk7Cisg ICAgaWYgKGNvbnRleHQuSXNFbXB0eSgpKQorICAgICAgICByZXR1cm47CisKICAgICB2ODo6Q29u dGV4dDo6U2NvcGUgY29udGV4dFNjb3BlKGNvbnRleHQpOwogCiAgICAgLy8gU2V0dXAgY29udGV4 dCBpZCBmb3IgSlMgZGVidWdnZXIu