30902 2009-10-29 03:10:31 -0700 Need a layout test for Bug 28284 2009-11-01 08:18:49 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 hbono webkit-unassigned agl commit-queue evan oldest_to_newest 158851 0 hbono 2009-10-29 03:10:31 -0700 TextInputController.firstRectForCharacterRange() returns the pixel-level rectangle for the specified character range. So, to use this function, we can write a layout test for Bug 28284. Unfortunately, this function is implemented only by Mac WebKit, i.e. the Chromium test_shell doesn't implement this function. So, we need to implement the function for the Chromium test_shell and write a layout test for WebKit Bug 28284. 158856 1 42089 hbono 2009-10-29 03:46:51 -0700 Created attachment 42089 A simple layout test I'm not sure I can send a review request for a change that only includes a layout test. Sorry if it is not allowed. Regards, Hironori Bono 158903 2 42089 darin 2009-10-29 08:23:27 -0700 Comment on attachment 42089 A simple layout test Putting a patch up for review that is just a test is fine. > + // Insert a Thai character U+0E01. > + eventSender.keyDown(String.fromCharCode(0x0E01)); I believe there is a way to make this test work without using eventSender. See, for example, events/option-tab.html and forms/input-text-enter.html which create a keyboard event using the DOM. Please make a version that does not use eventSender, or explain why not. Otherwise, this test looks very good to me. 159292 3 42206 hbono 2009-10-30 04:44:55 -0700 Created attachment 42206 The second layout test (without eventSender) Thank you for your review and comments. > > + // Insert a Thai character U+0E01. > > + eventSender.keyDown(String.fromCharCode(0x0E01)); > > I believe there is a way to make this test work without using eventSender. See, > for example, events/option-tab.html and forms/input-text-enter.html which > create a keyboard event using the DOM. > > Please make a version that does not use eventSender, or explain why not. You are totally right. This test doesn't need eventSender at all. (Sorry, I used eventSender without deep consideration.) Bug #28284 happens when we insert a Thai character into a text node in some way, such as keyboard-typing, copy-and-paste, DOM events, etc. (I should have used "Node.innerText += String.fromCharCode(0x0E01);'.) I have updated this change to use "Node.innerText" instead of 'eventSender.keyDown()'. Would it be possible to review the updated change? Regards, Hironori Bono 159480 4 42206 eric 2009-10-30 15:26:53 -0700 Comment on attachment 42206 The second layout test (without eventSender) LGTM too. Adding to the commit-queue. 159639 5 42206 commit-queue 2009-11-01 08:18:45 -0800 Comment on attachment 42206 The second layout test (without eventSender) Clearing flags on attachment: 42206 Committed r50388: <http://trac.webkit.org/changeset/50388> 159640 6 commit-queue 2009-11-01 08:18:49 -0800 All reviewed patches have been landed. Closing bug. 42089 2009-10-29 03:46:51 -0700 2009-10-30 04:44:55 -0700 A simple layout test issue30902-patch0.txt text/plain 5022 hbono SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUwMjY2KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDktMTAtMjkgIEhpcm9ub3JpIEJvbm8gIDxo Ym9ub0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQnVnIDMwOTAyOiBOZWVkIGEgbGF5b3V0IHRlc3QgZm9yIEJ1ZyAyODI4NAor ICAgICAgICBUaGlzIGNoYW5nZSBqdXN0IGFkZHMgYSBzaW1wbGUgdGVzdCB0aGF0IGNhbGxzIFRl eHRJbnB1dENvbnRyb2xsZXIuZmlyc3RSZWN0Rm9yQ2hhcmFjdGVyUmFuZ2UoKQorICAgICAgICBi ZWZvcmUgYW5kIGFmdGVyIGluc2VydGluZyBhIFRoYWkgY2hhcmFjdGVyIGFuZCBjb21wYXJlIHRo ZWlyIHJlc3VsdHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zMDkwMgorCisgICAgICAgICogZmFzdC90ZXh0L2ludGVybmF0aW9uYWwvdGhhaS1jdXJz b3ItcG9zaXRpb24tZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3RleHQvaW50 ZXJuYXRpb25hbC90aGFpLWN1cnNvci1wb3NpdGlvbi5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBw bGF0Zm9ybS9ndGsvU2tpcHBlZDogU2tpcCB0aGlzIHRlc3QgYmVjYXVzZSBUZXh0SW5wdXRDb250 cm9sbGVyIGlzIG5vdCBpbXBsZW1lbnRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Ta2lwcGVk OiBkaXR0by4KKyAgICAgICAgKiBwbGF0Zm9ybS93aW4vU2tpcHBlZDogZGl0dG8uCisKIDIwMDkt MTAtMjggIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmVk IExlb3BhcmQtc3BlY2lmaWMgcmVzdWx0IGFmdGVyIGNoYW5naW5nIEFUU1VJIG1pc3NpbmctZ2x5 cGggYmVoYXZpb3IgdG8gbWF0Y2ggdGhlCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L3RleHQvaW50 ZXJuYXRpb25hbC90aGFpLWN1cnNvci1wb3NpdGlvbi1leHBlY3RlZC50eHQKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvZmFzdC90ZXh0L2ludGVybmF0aW9uYWwvdGhhaS1jdXJzb3ItcG9zaXRp b24tZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC90ZXh0L2lu dGVybmF0aW9uYWwvdGhhaS1jdXJzb3ItcG9zaXRpb24tZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAw KQpAQCAtMCwwICsxLDQgQEAKK1RoaXMgdGVzdHMgdGhhdCB0aGUgcGl4ZWwtbGV2ZWwgeCBjb29y ZGluYXRlIG9mIGEgY2hhcmFjdGVyIHJhbmdlICgwLDApIGRvZXNuJ3QgY2hhbmdlIGJlZm9yZSBh bmQgYWZ0ZXIgaW5zZXJ0aW5nIGEgVGhhaSBjaGFyYWN0ZXIuIElmIHRoaXMgdGVzdCBmaW5pc2hl cyBzdWNjZXNzZnVsbHksIHRoaXMgdGVzdCBkaXNwbGF5cyAiU1VDQ0VFREVEIi4gT3RoZXJ3aXNl IHRoaXMgdGVzdCBkaXNwbGF5cyAiRkFJTEVEIi4KKwor4LiBCitTVUNDRUVERUQKSW5kZXg6IExh eW91dFRlc3RzL2Zhc3QvdGV4dC9pbnRlcm5hdGlvbmFsL3RoYWktY3Vyc29yLXBvc2l0aW9uLmh0 bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC90ZXh0L2ludGVybmF0aW9uYWwvdGhh aS1jdXJzb3ItcG9zaXRpb24uaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3Qv dGV4dC9pbnRlcm5hdGlvbmFsL3RoYWktY3Vyc29yLXBvc2l0aW9uLmh0bWwJKHJldmlzaW9uIDAp CkBAIC0wLDAgKzEsMzkgQEAKKzxodG1sPgorPGhlYWQ+Cis8dGl0bGU+PC90aXRsZT4KKzwvaGVh ZD4KKzxib2R5PgorPHA+VGhpcyB0ZXN0cyB0aGF0IHRoZSBwaXhlbC1sZXZlbCB4IGNvb3JkaW5h dGUgb2YgYSBjaGFyYWN0ZXIgcmFuZ2UgKDAsMCkgZG9lc24ndCBjaGFuZ2UgYmVmb3JlIGFuZCBh ZnRlciBpbnNlcnRpbmcgYSBUaGFpIGNoYXJhY3Rlci4gSWYgdGhpcyB0ZXN0IGZpbmlzaGVzIHN1 Y2Nlc3NmdWxseSwgdGhpcyB0ZXN0IGRpc3BsYXlzICJTVUNDRUVERUQiLiBPdGhlcndpc2UgdGhp cyB0ZXN0IGRpc3BsYXlzICJGQUlMRUQiLjwvcD4KKzxkaXYgaWQ9InRlc3QiIGNvbnRlbnRlZGl0 YWJsZT48L2Rpdj4KKzx1bCBpZD0iY29uc29sZSI+PC91bD4KKzxzY3JpcHQgdHlwZT0idGV4dC9q YXZhc2NyaXB0Ij4KK2Z1bmN0aW9uIGxvZyhzdHIpIHsKKyAgICB2YXIgbGkgPSBkb2N1bWVudC5j cmVhdGVFbGVtZW50KCJsaSIpOworICAgIGxpLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRl eHROb2RlKHN0cikpOworICAgIHZhciBjb25zb2xlID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo ImNvbnNvbGUiKTsKKyAgICBjb25zb2xlLmFwcGVuZENoaWxkKGxpKTsKK30KKworaWYgKHdpbmRv dy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBB c1RleHQoKTsKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGVzdCIpLmZvY3VzKCk7CisK KyAgICAvLyBSZXRyaWV2ZSB0aGUgcGl4ZWwtbGV2ZWwgeCBjb29yZGluYXRlIG9mIGEgY2hhcmFj dGVyIHJhbmdlICgwLDApIEJFRk9SRSBpbnNlcnRpbmcgYSBUaGFpIGNoYXJhY3Rlci4KKyAgICB2 YXIgcmVjdDAgPSB0ZXh0SW5wdXRDb250cm9sbGVyLmZpcnN0UmVjdEZvckNoYXJhY3RlclJhbmdl KDAsIDApOworICAgIHZhciB4MCA9IHJlY3QwLnRvU3RyaW5nKCkuc3BsaXQoJywnKVswXTsKKwor ICAgIC8vIEluc2VydCBhIFRoYWkgY2hhcmFjdGVyIFUrMEUwMS4KKyAgICBldmVudFNlbmRlci5r ZXlEb3duKFN0cmluZy5mcm9tQ2hhckNvZGUoMHgwRTAxKSk7CisKKyAgICAvLyBSZXRyaWV2ZSB0 aGUgcGl4ZWwtbGV2ZWwgeCBjb29yZGluYXRlIG9mIGEgY2hhcmFjdGVyIHJhbmdlICgwLDApIEFG VEVSIGluc2VydGluZyBhIFRoYWkgY2hhcmFjdGVyLgorICAgIHZhciByZWN0MSA9IHRleHRJbnB1 dENvbnRyb2xsZXIuZmlyc3RSZWN0Rm9yQ2hhcmFjdGVyUmFuZ2UoMCwgMCk7CisgICAgdmFyIHgx ID0gcmVjdDEudG9TdHJpbmcoKS5zcGxpdCgnLCcpWzBdOworCisgICAgLy8gQ29tcGFyZSB0aGUg eCBjb29yZGluYXRlcy4gKFRoZXkgbXVzdCBiZSB0aGUgc2FtZS4pCisgICAgaWYgKHgwID09IHgx KQorICAgICAgICBsb2coJ1NVQ0NFRURFRCcpOworICAgIGVsc2UKKyAgICAgICAgbG9nKCdGQUlM RUQ6IGJlZm9yZT0nICsgeDAgKyAnLCBhZnRlcj0nICsgeDEpOworfQorPC9zY3JpcHQ+Cis8L2Jv ZHk+CkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAkocmV2aXNpb24gNTAyNjUpCisrKyBM YXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAkod29ya2luZyBjb3B5KQpAQCAtNTU3MSw2 ICs1NTcxLDcgQEAgZmFzdC9sb2FkZXIvb3BhcXVlLWJhc2UtdXJsLmh0bWwgCiAjIE5vIFRleHRJ bnB1dENvbnRyb2xsZXIKIGZhc3QvZm9ybXMvaW5wdXQtbWF4bGVuZ3RoLWltZS1jb21wbGV0ZWQu aHRtbAogZmFzdC9mb3Jtcy9pbnB1dC1tYXhsZW5ndGgtaW1lLXByZWVkaXQuaHRtbAorZmFzdC90 ZXh0L2ludGVybmF0aW9uYWwvdGhhaS1jdXJzb3ItcG9zaXRpb24uaHRtbAogCiAjIE5vIFVzZXIg U2NyaXB0cwogdXNlcnNjcmlwdHMKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBw ZWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAkocmV2aXNp b24gNTAyNjUpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCSh3b3JraW5nIGNv cHkpCkBAIC0xMTUsNiArMTE1LDcgQEAgaW5zcGVjdG9yL3VuY2F1Z2h0LWRvbTgtZXhjZXB0aW9u Lmh0bWwKICMgTWlzc2luZyB0ZXh0SW5wdXRDb250cm9sbGVyLnNldE1hcmtlZFRleHQoKQogZmFz dC9mb3Jtcy9pbnB1dC1tYXhsZW5ndGgtaW1lLXByZWVkaXQuaHRtbAogZmFzdC9mb3Jtcy9pbnB1 dC1tYXhsZW5ndGgtaW1lLWNvbXBsZXRlZC5odG1sCitmYXN0L3RleHQvaW50ZXJuYXRpb25hbC90 aGFpLWN1cnNvci1wb3NpdGlvbi5odG1sCiAKICMgTWlzc2luZyBsYXlvdXRUZXN0Q29udHJvbGxl ci5vdmVycmlkZVByZWZlcmVuY2UoKQogZmFzdC9ldmVudHMvcGFnZXNob3ctcGFnZWhpZGUtb24t YmFjay1jYWNoZWQuaHRtbApJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1NraXBwZWQK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1NraXBwZWQJKHJldmlzaW9u IDUwMjY1KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1NraXBwZWQJKHdvcmtpbmcgY29w eSkKQEAgLTYzMCw2ICs2MzAsNyBAQCBodHRwL3Rlc3RzL2xvYWRpbmcvcHJlbG9hZC1pbWctdGVz dC5odG1sCiAjIE5vIFRleHRJbnB1dENvbnRyb2xsZXIKIGZhc3QvZm9ybXMvaW5wdXQtbWF4bGVu Z3RoLWltZS1jb21wbGV0ZWQuaHRtbAogZmFzdC9mb3Jtcy9pbnB1dC1tYXhsZW5ndGgtaW1lLXBy ZWVkaXQuaHRtbAorZmFzdC90ZXh0L2ludGVybmF0aW9uYWwvdGhhaS1jdXJzb3ItcG9zaXRpb24u aHRtbAogCiAjIEZhaWxpbmcgbWVkaWEgdGVzdHMgb24gd2luZG93cyA8aHR0cDovL3dlYmtpdC5v cmcvYi8yOTA0Nz4KIG1lZGlhL2F1ZGlvLWRlbGV0ZS13aGlsZS1zdGVwLWJ1dHRvbi1jbGlja2Vk Lmh0bWwK 42206 2009-10-30 04:44:55 -0700 2009-11-01 08:18:45 -0800 The second layout test (without eventSender) issue30902-patch1.txt text/plain 4983 hbono SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUwMzI3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDktMTAtMzAgIEhpcm9ub3JpIEJvbm8gIDxo Ym9ub0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQnVnIDMwOTAyOiBOZWVkIGEgbGF5b3V0IHRlc3QgZm9yIEJ1ZyAyODI4NAor ICAgICAgICBUaGlzIGNoYW5nZSBqdXN0IGFkZHMgYSBzaW1wbGUgdGVzdCB0aGF0IGNhbGxzIFRl eHRJbnB1dENvbnRyb2xsZXIuZmlyc3RSZWN0Rm9yQ2hhcmFjdGVyUmFuZ2UoKQorICAgICAgICBi ZWZvcmUgYW5kIGFmdGVyIGluc2VydGluZyBhIFRoYWkgY2hhcmFjdGVyIGFuZCBjb21wYXJlIHRo ZWlyIHJlc3VsdHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zMDkwMgorCisgICAgICAgICogZmFzdC90ZXh0L2ludGVybmF0aW9uYWwvdGhhaS1jdXJz b3ItcG9zaXRpb24tZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3RleHQvaW50 ZXJuYXRpb25hbC90aGFpLWN1cnNvci1wb3NpdGlvbi5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBw bGF0Zm9ybS9ndGsvU2tpcHBlZDogU2tpcCB0aGlzIHRlc3QgYmVjYXVzZSBUZXh0SW5wdXRDb250 cm9sbGVyIGlzIG5vdCBpbXBsZW1lbnRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Ta2lwcGVk OiBkaXR0by4KKyAgICAgICAgKiBwbGF0Zm9ybS93aW4vU2tpcHBlZDogZGl0dG8uCisKIDIwMDkt MTAtMzAgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBHYXZpbiBCYXJyYWNsb3VnaC4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvdGV4dC9pbnRl cm5hdGlvbmFsL3RoYWktY3Vyc29yLXBvc2l0aW9uLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9mYXN0L3RleHQvaW50ZXJuYXRpb25hbC90aGFpLWN1cnNvci1wb3NpdGlv bi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3RleHQvaW50 ZXJuYXRpb25hbC90aGFpLWN1cnNvci1wb3NpdGlvbi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDAp CkBAIC0wLDAgKzEsNCBAQAorVGhpcyB0ZXN0cyB0aGF0IHRoZSBwaXhlbC1sZXZlbCB4IGNvb3Jk aW5hdGUgb2YgYSBjaGFyYWN0ZXIgcmFuZ2UgKDAsMCkgZG9lc24ndCBjaGFuZ2UgYmVmb3JlIGFu ZCBhZnRlciBpbnNlcnRpbmcgYSBUaGFpIGNoYXJhY3Rlci4gSWYgdGhpcyB0ZXN0IGZpbmlzaGVz IHN1Y2Nlc3NmdWxseSwgdGhpcyB0ZXN0IGRpc3BsYXlzICJTVUNDRUVERUQiLiBPdGhlcndpc2Ug dGhpcyB0ZXN0IGRpc3BsYXlzICJGQUlMRUQiLgorCivguIEKK1NVQ0NFRURFRApJbmRleDogTGF5 b3V0VGVzdHMvZmFzdC90ZXh0L2ludGVybmF0aW9uYWwvdGhhaS1jdXJzb3ItcG9zaXRpb24uaHRt bAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3RleHQvaW50ZXJuYXRpb25hbC90aGFp LWN1cnNvci1wb3NpdGlvbi5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC90 ZXh0L2ludGVybmF0aW9uYWwvdGhhaS1jdXJzb3ItcG9zaXRpb24uaHRtbAkocmV2aXNpb24gMCkK QEAgLTAsMCArMSw0MCBAQAorPGh0bWw+Cis8aGVhZD4KKzx0aXRsZT48L3RpdGxlPgorPC9oZWFk PgorPGJvZHk+Cis8cD5UaGlzIHRlc3RzIHRoYXQgdGhlIHBpeGVsLWxldmVsIHggY29vcmRpbmF0 ZSBvZiBhIGNoYXJhY3RlciByYW5nZSAoMCwwKSBkb2Vzbid0IGNoYW5nZSBiZWZvcmUgYW5kIGFm dGVyIGluc2VydGluZyBhIFRoYWkgY2hhcmFjdGVyLiBJZiB0aGlzIHRlc3QgZmluaXNoZXMgc3Vj Y2Vzc2Z1bGx5LCB0aGlzIHRlc3QgZGlzcGxheXMgIlNVQ0NFRURFRCIuIE90aGVyd2lzZSB0aGlz IHRlc3QgZGlzcGxheXMgIkZBSUxFRCIuPC9wPgorPGRpdiBpZD0idGVzdCIgY29udGVudGVkaXRh YmxlPjwvZGl2PgorPHVsIGlkPSJjb25zb2xlIj48L3VsPgorPHNjcmlwdCB0eXBlPSJ0ZXh0L2ph dmFzY3JpcHQiPgorZnVuY3Rpb24gbG9nKHN0cikgeworICAgIHZhciBsaSA9IGRvY3VtZW50LmNy ZWF0ZUVsZW1lbnQoImxpIik7CisgICAgbGkuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4 dE5vZGUoc3RyKSk7CisgICAgdmFyIGNvbnNvbGUgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgi Y29uc29sZSIpOworICAgIGNvbnNvbGUuYXBwZW5kQ2hpbGQobGkpOworfQorCitpZiAod2luZG93 LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFz VGV4dCgpOworICAgIHZhciB0ZXN0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3QiKTsK KyAgICB0ZXN0LmZvY3VzKCk7CisKKyAgICAvLyBSZXRyaWV2ZSB0aGUgcGl4ZWwtbGV2ZWwgeCBj b29yZGluYXRlIG9mIGEgY2hhcmFjdGVyIHJhbmdlICgwLDApIEJFRk9SRSBpbnNlcnRpbmcgYSBU aGFpIGNoYXJhY3Rlci4KKyAgICB2YXIgcmVjdDAgPSB0ZXh0SW5wdXRDb250cm9sbGVyLmZpcnN0 UmVjdEZvckNoYXJhY3RlclJhbmdlKDAsIDApOworICAgIHZhciB4MCA9IHJlY3QwLnRvU3RyaW5n KCkuc3BsaXQoJywnKVswXTsKKworICAgIC8vIEluc2VydCBhIFRoYWkgY2hhcmFjdGVyIFUrMEUw MS4KKyAgICB0ZXN0LmlubmVyVGV4dCArPSBTdHJpbmcuZnJvbUNoYXJDb2RlKDB4MEUwMSk7CisK KyAgICAvLyBSZXRyaWV2ZSB0aGUgcGl4ZWwtbGV2ZWwgeCBjb29yZGluYXRlIG9mIGEgY2hhcmFj dGVyIHJhbmdlICgwLDApIEFGVEVSIGluc2VydGluZyBhIFRoYWkgY2hhcmFjdGVyLgorICAgIHZh ciByZWN0MSA9IHRleHRJbnB1dENvbnRyb2xsZXIuZmlyc3RSZWN0Rm9yQ2hhcmFjdGVyUmFuZ2Uo MCwgMCk7CisgICAgdmFyIHgxID0gcmVjdDEudG9TdHJpbmcoKS5zcGxpdCgnLCcpWzBdOworCisg ICAgLy8gQ29tcGFyZSB0aGUgeCBjb29yZGluYXRlcy4gKFRoZXkgbXVzdCBiZSB0aGUgc2FtZS4p CisgICAgaWYgKHgwID09IHgxKQorICAgICAgICBsb2coJ1NVQ0NFRURFRCcpOworICAgIGVsc2UK KyAgICAgICAgbG9nKCdGQUlMRUQ6IGJlZm9yZT0nICsgeDAgKyAnLCBhZnRlcj0nICsgeDEpOwor fQorPC9zY3JpcHQ+Cis8L2JvZHk+CkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tp cHBlZAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAkocmV2 aXNpb24gNTAzMjIpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAkod29ya2lu ZyBjb3B5KQpAQCAtNTU3MSw2ICs1NTcxLDcgQEAgZmFzdC9sb2FkZXIvb3BhcXVlLWJhc2UtdXJs Lmh0bWwgCiAjIE5vIFRleHRJbnB1dENvbnRyb2xsZXIKIGZhc3QvZm9ybXMvaW5wdXQtbWF4bGVu Z3RoLWltZS1jb21wbGV0ZWQuaHRtbAogZmFzdC9mb3Jtcy9pbnB1dC1tYXhsZW5ndGgtaW1lLXBy ZWVkaXQuaHRtbAorZmFzdC90ZXh0L2ludGVybmF0aW9uYWwvdGhhaS1jdXJzb3ItcG9zaXRpb24u aHRtbAogCiAjIE5vIFVzZXIgU2NyaXB0cwogdXNlcnNjcmlwdHMKSW5kZXg6IExheW91dFRlc3Rz L3BsYXRmb3JtL3F0L1NraXBwZWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0v cXQvU2tpcHBlZAkocmV2aXNpb24gNTAzMjIpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9T a2lwcGVkCSh3b3JraW5nIGNvcHkpCkBAIC0xMjIsNiArMTIyLDcgQEAgaW5zcGVjdG9yL3VuY2F1 Z2h0LWRvbTgtZXhjZXB0aW9uLmh0bWwKICMgTWlzc2luZyB0ZXh0SW5wdXRDb250cm9sbGVyLnNl dE1hcmtlZFRleHQoKQogZmFzdC9mb3Jtcy9pbnB1dC1tYXhsZW5ndGgtaW1lLXByZWVkaXQuaHRt bAogZmFzdC9mb3Jtcy9pbnB1dC1tYXhsZW5ndGgtaW1lLWNvbXBsZXRlZC5odG1sCitmYXN0L3Rl eHQvaW50ZXJuYXRpb25hbC90aGFpLWN1cnNvci1wb3NpdGlvbi5odG1sCiAKICMgTWlzc2luZyBs YXlvdXRUZXN0Q29udHJvbGxlci5vdmVycmlkZVByZWZlcmVuY2UoKQogZmFzdC9ldmVudHMvcGFn ZXNob3ctcGFnZWhpZGUtb24tYmFjay1jYWNoZWQuaHRtbApJbmRleDogTGF5b3V0VGVzdHMvcGxh dGZvcm0vd2luL1NraXBwZWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2lu L1NraXBwZWQJKHJldmlzaW9uIDUwMzIyKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1Nr aXBwZWQJKHdvcmtpbmcgY29weSkKQEAgLTYzMCw2ICs2MzAsNyBAQCBodHRwL3Rlc3RzL2xvYWRp bmcvcHJlbG9hZC1pbWctdGVzdC5odG1sCiAjIE5vIFRleHRJbnB1dENvbnRyb2xsZXIKIGZhc3Qv Zm9ybXMvaW5wdXQtbWF4bGVuZ3RoLWltZS1jb21wbGV0ZWQuaHRtbAogZmFzdC9mb3Jtcy9pbnB1 dC1tYXhsZW5ndGgtaW1lLXByZWVkaXQuaHRtbAorZmFzdC90ZXh0L2ludGVybmF0aW9uYWwvdGhh aS1jdXJzb3ItcG9zaXRpb24uaHRtbAogCiAjIEZhaWxpbmcgbWVkaWEgdGVzdHMgb24gd2luZG93 cyA8aHR0cDovL3dlYmtpdC5vcmcvYi8yOTA0Nz4KIG1lZGlhL2F1ZGlvLWRlbGV0ZS13aGlsZS1z dGVwLWJ1dHRvbi1jbGlja2VkLmh0bWwK