<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>30890</bug_id>
          
          <creation_ts>2009-10-28 16:58:32 -0700</creation_ts>
          <short_desc>Windows build: changes in header files do not always trigger correct rebuild.</short_desc>
          <delta_ts>2010-11-10 04:54:10 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Windows Vista</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dmitry Titov">dimich</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>aroben</cc>
    
    <cc>mrowe</cc>
    
    <cc>sfalken</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>158776</commentid>
    <comment_count>0</comment_count>
    <who name="Dmitry Titov">dimich</who>
    <bug_when>2009-10-28 16:58:32 -0700</bug_when>
    <thetext>Example: recent change to JavaScriptCore/wtf/MessageQueue.h broke the Windows build because MessageQueue.h is not included anywhere in JavaScriptCore so the project JavaScriptCore was not build. this project has &quot;post-build step&quot; which make copy of header files to the build directory from where the subsequent WebCore build includes JSC headers. As a result, the stale header of MessageQueue.h was used and build broke.

Changing a cpp file from wtf caused recompile of JavaScriptCore and updated the headers.

I&apos;m not sure what the right fix for this is.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>307297</commentid>
    <comment_count>1</comment_count>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2010-11-10 04:54:10 -0800</bug_when>
    <thetext>The right fix is to move all header copying into a Makefile-based project (like JavaScriptCoreGenerated). Makefile-based projects run on every build regardless of whether any .cpp files changed.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>