30889 2009-10-28 16:14:59 -0700 Fix Windows WebKit flakiness on video-pause-immediately.html 2009-10-28 17:45:47 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 scherkus webkit-unassigned bweinstein commit-queue eric.carlson oldest_to_newest 158762 0 scherkus 2009-10-28 16:14:59 -0700 setTimeout() is evil :( 158763 1 42066 scherkus 2009-10-28 16:16:51 -0700 Created attachment 42066 Round 1 158764 2 42067 scherkus 2009-10-28 16:17:47 -0700 Created attachment 42067 Round 2 Patch included some extra stuff in the diff :\ 158767 3 bweinstein 2009-10-28 16:23:59 -0700 Looks good, hopefully you can ping someone in #webkit to get a review. 158770 4 42067 eric.carlson 2009-10-28 16:26:31 -0700 Comment on attachment 42067 Round 2 r=me 158790 5 42067 commit-queue 2009-10-28 17:45:41 -0700 Comment on attachment 42067 Round 2 Clearing flags on attachment: 42067 Committed r50252: <http://trac.webkit.org/changeset/50252> 158791 6 commit-queue 2009-10-28 17:45:47 -0700 All reviewed patches have been landed. Closing bug. 42066 2009-10-28 16:16:51 -0700 2009-10-28 16:17:47 -0700 Round 1 fix_test.patch text/plain 2547 scherkus ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBjYjRiYWI4Li4wMmZlZDE0IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTEg QEAKKzIwMDktMTAtMjggIEphbi1BcnZlIFPDpnRoZXIgPGphbi1hcnZlLnNhZXRoZXJAbm9raWEu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IFRvciBBcm5lIFZlc3Riw7guCisKKyAgICAgICAg QnVpbGQtZml4IGZvciA2NC1iaXQgV2luZG93cworCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6 IE1ha2Ugc3VyZSB0byB1c2UgV1RGX1VTRV9KU1ZBTFVFNjQKKwogMjAwOS0xMC0yOCAgR2F2aW4g QmFycmFjbG91Z2ggIDxiYXJyYWNsb3VnaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChidWlsZCBmaXghKS4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3d0Zi9Q bGF0Zm9ybS5oIGIvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKaW5kZXggNmJhZTBlYi4u YWE4NWQwZSAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKKysrIGIv SmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKQEAgLTcwMyw3ICs3MDMsNyBAQAogI2VuZGlm CiAKICNpZiAhZGVmaW5lZChXVEZfVVNFX0pTVkFMVUU2NCkgJiYgIWRlZmluZWQoV1RGX1VTRV9K U1ZBTFVFMzIpICYmICFkZWZpbmVkKFdURl9VU0VfSlNWQUxVRTMyXzY0KQotI2lmIFBMQVRGT1JN KFg4Nl82NCkgJiYgKFBMQVRGT1JNKERBUldJTikgfHwgUExBVEZPUk0oTElOVVgpKQorI2lmIFBM QVRGT1JNKFg4Nl82NCkgJiYgKFBMQVRGT1JNKERBUldJTikgfHwgUExBVEZPUk0oTElOVVgpIHx8 IFBMQVRGT1JNKFdJTl9PUykpCiAjZGVmaW5lIFdURl9VU0VfSlNWQUxVRTY0IDEKICNlbGlmIFBM QVRGT1JNKEFSTSkgfHwgUExBVEZPUk0oUFBDNjQpCiAjZGVmaW5lIFdURl9VU0VfSlNWQUxVRTMy IDEKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwppbmRleCBjZWI0YjUyLi5lMDgxMjE3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDkt MTAtMjggIEFuZHJldyBTY2hlcmt1cyAgPHNjaGVya3VzQGNocm9taXVtLm9yZz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggdmlkZW8tcGF1c2Ut aW1tZWRpYXRlbHkuaHRtbCB0byBhdm9pZCB1c2luZyBzZXRUaW1lb3V0KCkuCisKKyAgICAgICAg VGhpcyBhbHNvIGFkZHJlc3NlcyB0aGUgZmxha2luZXNzIG9uIFdpbmRvd3MsIHdoZXJlIDIwMG1z IHdhcyBub3QgZW5vdWdoIHRpbWUgdG8gYWR2YW5jZSB0aGUgY2xvY2sgcGFzdCB6ZXJvLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDg4OQorCisg ICAgICAgICogbWVkaWEvdmlkZW8tcGF1c2UtaW1tZWRpYXRlbHkuaHRtbDogUmVwbGFjZSBzZXRU aW1lb3V0KCkgd2l0aCB0aW1ldXBkYXRlIGV2ZW50cy4KKwogMjAwOS0xMC0yOCAgQ3NhYmEgT3N6 dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5 IEhvbGdlciBGcmV5dGhlci4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLXBh dXNlLWltbWVkaWF0ZWx5Lmh0bWwgYi9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1wYXVzZS1pbW1l ZGlhdGVseS5odG1sCmluZGV4IDA5NDAxOTkuLmFhMzYwMzYgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL21lZGlhL3ZpZGVvLXBhdXNlLWltbWVkaWF0ZWx5Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMv bWVkaWEvdmlkZW8tcGF1c2UtaW1tZWRpYXRlbHkuaHRtbApAQCAtMjIsMTMgKzIyLDE1IEBACiAK ICAgICAgICAgICAgIGZ1bmN0aW9uIHBsYXlpbmcoKQogICAgICAgICAgICAgewotICAgICAgICAg ICAgICAgIHNldFRpbWVvdXQocGF1c2VWaWRlbywgMjAwKTsKKyAgICAgICAgICAgICAgICB2aWRl by5hZGRFdmVudExpc3RlbmVyKCJ0aW1ldXBkYXRlIiwgdGltZXVwZGF0ZSk7CiAgICAgICAgICAg ICB9CiAKLSAgICAgICAgICAgIGZ1bmN0aW9uIHBhdXNlVmlkZW8oKQorICAgICAgICAgICAgZnVu Y3Rpb24gdGltZXVwZGF0ZSgpCiAgICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAgdmlkZW8u cGF1c2UoKTsKLSAgICAgICAgICAgICAgICB0aW1lQWZ0ZXJQYXVzZSA9IHZpZGVvLmN1cnJlbnRU aW1lOworICAgICAgICAgICAgICAgIGlmICh2aWRlby5jdXJyZW50VGltZSA+IDApIHsKKyAgICAg ICAgICAgICAgICAgICAgdmlkZW8ucGF1c2UoKTsKKyAgICAgICAgICAgICAgICAgICAgdGltZUFm dGVyUGF1c2UgPSB2aWRlby5jdXJyZW50VGltZTsKKyAgICAgICAgICAgICAgICB9CiAgICAgICAg ICAgICB9CiAKICAgICAgICAgICAgIGZ1bmN0aW9uIHBhdXNlKCkK 42067 2009-10-28 16:17:47 -0700 2009-10-28 17:45:40 -0700 Round 2 fix_test.patch text/plain 1518 scherkus ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjZWI0YjUyLi5lMDgxMjE3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTAt MjggIEFuZHJldyBTY2hlcmt1cyAgPHNjaGVya3VzQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggdmlkZW8tcGF1c2UtaW1t ZWRpYXRlbHkuaHRtbCB0byBhdm9pZCB1c2luZyBzZXRUaW1lb3V0KCkuCisKKyAgICAgICAgVGhp cyBhbHNvIGFkZHJlc3NlcyB0aGUgZmxha2luZXNzIG9uIFdpbmRvd3MsIHdoZXJlIDIwMG1zIHdh cyBub3QgZW5vdWdoIHRpbWUgdG8gYWR2YW5jZSB0aGUgY2xvY2sgcGFzdCB6ZXJvLgorCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDg4OQorCisgICAg ICAgICogbWVkaWEvdmlkZW8tcGF1c2UtaW1tZWRpYXRlbHkuaHRtbDogUmVwbGFjZSBzZXRUaW1l b3V0KCkgd2l0aCB0aW1ldXBkYXRlIGV2ZW50cy4KKwogMjAwOS0xMC0yOCAgQ3NhYmEgT3N6dHJv Z29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IEhv bGdlciBGcmV5dGhlci4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLXBhdXNl LWltbWVkaWF0ZWx5Lmh0bWwgYi9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1wYXVzZS1pbW1lZGlh dGVseS5odG1sCmluZGV4IDA5NDAxOTkuLmFhMzYwMzYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L21lZGlhL3ZpZGVvLXBhdXNlLWltbWVkaWF0ZWx5Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvbWVk aWEvdmlkZW8tcGF1c2UtaW1tZWRpYXRlbHkuaHRtbApAQCAtMjIsMTMgKzIyLDE1IEBACiAKICAg ICAgICAgICAgIGZ1bmN0aW9uIHBsYXlpbmcoKQogICAgICAgICAgICAgewotICAgICAgICAgICAg ICAgIHNldFRpbWVvdXQocGF1c2VWaWRlbywgMjAwKTsKKyAgICAgICAgICAgICAgICB2aWRlby5h ZGRFdmVudExpc3RlbmVyKCJ0aW1ldXBkYXRlIiwgdGltZXVwZGF0ZSk7CiAgICAgICAgICAgICB9 CiAKLSAgICAgICAgICAgIGZ1bmN0aW9uIHBhdXNlVmlkZW8oKQorICAgICAgICAgICAgZnVuY3Rp b24gdGltZXVwZGF0ZSgpCiAgICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAgdmlkZW8ucGF1 c2UoKTsKLSAgICAgICAgICAgICAgICB0aW1lQWZ0ZXJQYXVzZSA9IHZpZGVvLmN1cnJlbnRUaW1l OworICAgICAgICAgICAgICAgIGlmICh2aWRlby5jdXJyZW50VGltZSA+IDApIHsKKyAgICAgICAg ICAgICAgICAgICAgdmlkZW8ucGF1c2UoKTsKKyAgICAgICAgICAgICAgICAgICAgdGltZUFmdGVy UGF1c2UgPSB2aWRlby5jdXJyZW50VGltZTsKKyAgICAgICAgICAgICAgICB9CiAgICAgICAgICAg ICB9CiAKICAgICAgICAgICAgIGZ1bmN0aW9uIHBhdXNlKCkK