30859 2009-10-28 05:58:21 -0700 Allow custom memory allocation control for WebCore's ShorthandScope 2009-10-29 08:42:02 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 zoltan webkit-unassigned oldest_to_newest 158545 0 zoltan 2009-10-28 05:58:21 -0700 Inherits ShorthandScope class from FastAllocBase because it has been instantiated by 'new' in WebCore/css/CSSParser.cpp:902. 158546 1 42024 zoltan 2009-10-28 05:59:31 -0700 Created attachment 42024 proposed patch 158559 2 42024 darin 2009-10-28 07:47:44 -0700 Comment on attachment 42024 proposed patch For many of these it would be better to inherit from Noncopyable instead of FastAllocBase. 158853 3 42087 zoltan 2009-10-29 03:23:55 -0700 Created attachment 42087 updated to Noncopyable 158909 4 zoltan 2009-10-29 08:42:02 -0700 Landed in 40273. https://trac.webkit.org/changeset/50273 42024 2009-10-28 05:59:31 -0700 2009-10-29 03:23:55 -0700 proposed patch ShorthandScope.patch text/plain 1179 zoltan SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDIxMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMTAtMjggIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtp dC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWxsb3cgY3VzdG9tIG1lbW9yeSBhbGxvY2F0aW9uIGNvbnRyb2wgZm9yIFdlYkNvcmUncyBTaG9y dGhhbmRTY29wZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzA4NTkKKworICAgICAgICBJbmhlcml0cyBTaG9ydGhhbmRTY29wZSBjbGFzcyBmcm9tIEZh c3RBbGxvY0Jhc2UgYmVjYXVzZSBpdCBoYXMgYmVlbgorICAgICAgICBpbnN0YW50aWF0ZWQgYnkg J25ldycgaW4gV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcDo5MDIuCisKKyAgICAgICAgKiBjc3Mv Q1NTUGFyc2VyLmg6CisKIDIwMDktMTAtMjYgIEhvbGdlciBIYW5zIFBldGVyIEZyZXl0aGVyICA8 emVja2VAc2VsZmlzaC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCklu ZGV4OiBXZWJDb3JlL2Nzcy9DU1NQYXJzZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Nzcy9D U1NQYXJzZXIuaAkocmV2aXNpb24gNTAyMTMpCisrKyBXZWJDb3JlL2Nzcy9DU1NQYXJzZXIuaAko d29ya2luZyBjb3B5KQpAQCAtMjg3LDcgKzI4Nyw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAg ICBpbnQgY3NzUHJvcGVydHlJRChjb25zdCBTdHJpbmcmKTsKICAgICBpbnQgY3NzVmFsdWVLZXl3 b3JkSUQoY29uc3QgQ1NTUGFyc2VyU3RyaW5nJik7CiAKLSAgICBjbGFzcyBTaG9ydGhhbmRTY29w ZSB7CisgICAgY2xhc3MgU2hvcnRoYW5kU2NvcGUgOiBwdWJsaWMgRmFzdEFsbG9jQmFzZSB7CiAg ICAgcHVibGljOgogICAgICAgICBTaG9ydGhhbmRTY29wZShDU1NQYXJzZXIqIHBhcnNlciwgaW50 IHByb3BJZCkgOiBtX3BhcnNlcihwYXJzZXIpCiAgICAgICAgIHsK 42087 2009-10-29 03:23:55 -0700 2009-10-29 08:20:08 -0700 updated to Noncopyable ShorthandScope.patch text/plain 1210 zoltan SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDI2NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMTAtMjkgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtp dC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAgQWxs b3cgY3VzdG9tIG1lbW9yeSBhbGxvY2F0aW9uIGNvbnRyb2wgZm9yIFdlYkNvcmUncyBTaG9ydGhh bmRTY29wZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzA4NTkKKworICAgICAgICBJbmhlcml0cyBTaG9ydGhhbmRTY29wZSBjbGFzcyBmcm9tIEZhc3RB bGxvY0Jhc2UgYmVjYXVzZSBpdCBpcyAKKyAgICAgICAgaW5zdGFudGlhdGVkIGJ5ICduZXcnIGlu IFdlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHA6OTAyIGFuZCAKKyAgICAgICAgaXQgaXMgbm8gbmVl ZCB0byBiZSBjb3B5YWJsZS4gICAgICAgIAorCisgICAgICAgICogY3NzL0NTU1BhcnNlci5oOgor CiAyMDA5LTEwLTI5ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAg VGlnZXIgYnVpbGQgZml4IGFmdGVyIHI1MDI1OQpJbmRleDogV2ViQ29yZS9jc3MvQ1NTUGFyc2Vy LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmgJKHJldmlzaW9uIDUwMjY1 KQorKysgV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmgJKHdvcmtpbmcgY29weSkKQEAgLTI4Nyw3ICsy ODcsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgaW50IGNzc1Byb3BlcnR5SUQoY29uc3Qg U3RyaW5nJik7CiAgICAgaW50IGNzc1ZhbHVlS2V5d29yZElEKGNvbnN0IENTU1BhcnNlclN0cmlu ZyYpOwogCi0gICAgY2xhc3MgU2hvcnRoYW5kU2NvcGUgeworICAgIGNsYXNzIFNob3J0aGFuZFNj b3BlIDogcHVibGljIEZhc3RBbGxvY0Jhc2UgewogICAgIHB1YmxpYzoKICAgICAgICAgU2hvcnRo YW5kU2NvcGUoQ1NTUGFyc2VyKiBwYXJzZXIsIGludCBwcm9wSWQpIDogbV9wYXJzZXIocGFyc2Vy KQogICAgICAgICB7Cg==